)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"dd76dfe833252fcdfcac175f32608bf0f913d1ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from the store."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Conflicts:"},{"line_number":42,"context_line":"\tglance/tests/functional/db/test_sqlalchemy.py"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: #1261738"},{"line_number":45,"context_line":"(cherry picked from commit b35728019e0eb89c213eed7bc35a1f062c99dcca)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2FBOU%3D","line":42,"updated":"2014-01-18 20:54:03.000000000","message":"want to get rid of this statement in the commit message?","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"bc1163a21ac8f1f76f6bdfc4b1936a5e4180d4af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from the store."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Conflicts:"},{"line_number":42,"context_line":"\tglance/tests/functional/db/test_sqlalchemy.py"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: #1261738"},{"line_number":45,"context_line":"(cherry picked from commit b35728019e0eb89c213eed7bc35a1f062c99dcca)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2BkOE%3D","line":42,"in_reply_to":"AAAAUH%2F%2B2bU%3D","updated":"2014-01-24 10:40:33.000000000","message":"We do want to keep them, please see https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"47d16f88779e54414475297c0ecaceb6552a92b1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    from the store."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Conflicts:"},{"line_number":42,"context_line":"\tglance/tests/functional/db/test_sqlalchemy.py"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"Closes-Bug: #1261738"},{"line_number":45,"context_line":"(cherry picked from commit b35728019e0eb89c213eed7bc35a1f062c99dcca)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2B2bU%3D","line":42,"in_reply_to":"AAAAUH%2F%2FBOU%3D","updated":"2014-01-21 13:21:42.000000000","message":"mmh, it\u0027s a stable backport. I think we should keep it! It\u0027s useful for reviewing stable patches.","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"}],"glance/db/simple/api.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"ea23c26f8b7cb36cf804b646c7e4870162fe2e26","unresolved":false,"context_lines":[{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BkNE%3D","line":668,"updated":"2014-01-24 10:45:31.000000000","message":"I\u0027m slightly confused by this, is it possible that a image with overall status not in [\u0027killed\u0027, \u0027pending_delete\u0027, \u0027deleted\u0027] would have an individual location that\u0027s deleted?\n\n(... in a sense, a partially deleted image)","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"ea23c26f8b7cb36cf804b646c7e4870162fe2e26","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BkMM%3D","line":669,"updated":"2014-01-24 10:45:31.000000000","message":"I\u0027m wondering why \"external\" locations are counted in the total the same as locations that actually use space within the backend glance store.\n\nIs that actually the case and if so, I wonder does it make sense to do the accounting in this way?","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cdc3c4c8a59f78b9f02d9ba4a8d72d9936bded06","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BMTc%3D","line":669,"in_reply_to":"AAAAUH%2F%2Bcvg%3D","updated":"2014-01-29 08:26:39.000000000","message":"I think I had already opened an issue for this. The issue is basically for having a way to specify which locations should be considered \"internal\" and which shouldn\u0027t.","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"77d8f95e3b67293e06a41bb71b6c5430a7fcd1c7","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Baz0%3D","line":669,"in_reply_to":"AAAAUH%2F%2BcwM%3D","updated":"2014-01-27 04:44:05.000000000","message":"I have opened a bug and a bp to track the improvement of image quota, see https://blueprints.launchpad.net/glance/+spec/improve-image-quota","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"7abad538cce112e8e28993f9f1ad4d5fae1e1bf0","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BcwM%3D","line":669,"in_reply_to":"AAAAUH%2F%2BkMM%3D","updated":"2014-01-26 06:21:15.000000000","message":"Eoghan,\n\nYou\u0027re right. I think this fact makes image size quotas a bit weird. Even two \"internal\" stores muddies the water significantly. But I think that is just a caveat that goes with the existing quota implementation and is the big reason why such quotas are optional.\n\nI think flwang is going to open a bug for this issue just so that we can track it and consider how we might refactor our view of quotas to be less limited in applicability.","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0edc8e18e7a41ed69389e9cc532897729553fc8e","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        if image[\u0027id\u0027] !\u003d image_id:"},{"line_number":667,"context_line":"            locations \u003d [l for l in image[\u0027locations\u0027]"},{"line_number":668,"context_line":"                         if not l.get(\u0027deleted\u0027, False)]"},{"line_number":669,"context_line":"            total +\u003d (image[\u0027size\u0027] * len(locations))"},{"line_number":670,"context_line":"    return total"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bcvg%3D","line":669,"in_reply_to":"AAAAUH%2F%2BkMM%3D","updated":"2014-01-26 06:25:34.000000000","message":"It\u0027s a good question. And just had a short talk with markwash about this. So how about landing this in and fix it in the future?\n\n(02:17:36 PM) markwash: basically, image storage quotas only make sense if you are otherwise constraining your storage system\n(02:17:50 PM) markwash: like enforcing it so that all images are stored in the same way\n(02:18:06 PM) markwash: I think we should open a bug about it, but probably mark it as \"wontfix\" and add a description for why\n(02:18:36 PM) markwash: it\u0027s a temporary wontfix, in the sense that if we did come up with a good way for tracking quotas per store, we could do that","commit_id":"4e26df9c922d96473fdd27782af0fed93f0a79de"}]}