)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"20091129eaf492eb3514f61dbea8a6d29165e20d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     llg8212 \u003clilinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-26 09:12:08 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the redunant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In methods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py,"},{"line_number":10,"context_line":"there are redundant code \u0027sql_connection \u003d CONF.sql_connection\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F9zU%3D","line":7,"updated":"2013-12-26 06:38:28.000000000","message":"typo: redundant","commit_id":"f35a2bd36d4275a36465229094338c0cb06ec2eb"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"20091129eaf492eb3514f61dbea8a6d29165e20d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove the redunant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In methods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py,"},{"line_number":10,"context_line":"there are redundant code \u0027sql_connection \u003d CONF.sql_connection\u0027."},{"line_number":11,"context_line":"They will never be used because the \u0027 _version_control\u0027 has the sentence."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie8a12e6f385f7103463172ed9acde1de0336a6d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2F9zQ%3D","line":10,"updated":"2013-12-26 06:38:28.000000000","message":"dito","commit_id":"f35a2bd36d4275a36465229094338c0cb06ec2eb"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1cd6fa16147030e2630523fccd1ce5146e092d74","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In methods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py,"},{"line_number":10,"context_line":"there are redundant code \u0027sql_connection \u003d CONF.sql_connection\u0027."},{"line_number":11,"context_line":"They will never be used because the \u0027 _version_control\u0027 has the sentence."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie8a12e6f385f7103463172ed9acde1de0336a6d4"},{"line_number":14,"context_line":"Closes-Bug:#1264056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F6so%3D","line":11,"updated":"2013-12-27 06:56:43.000000000","message":"I think the space in \u0027 _version_control\u0027 is unnecessary, but I don\u0027t think it worth to upload a new patch and let the reviewers vote again.\n\nPay attention next time please.","commit_id":"a94b00b9a4b121d28f8134f3db8278a5b1dd1bf6"},{"author":{"_account_id":9520,"name":"David Koo (koofoss)","email":"david.koo@huawei.com","username":"koofoss"},"change_message_id":"558d8518b8d72a5fcc22dd6f8aa16ee13e432762","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In methods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py,"},{"line_number":10,"context_line":"there are redundant code \u0027sql_connection \u003d CONF.sql_connection\u0027."},{"line_number":11,"context_line":"They will never be used because the \u0027 _version_control\u0027 has the sentence."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie8a12e6f385f7103463172ed9acde1de0336a6d4"},{"line_number":14,"context_line":"Closes-Bug:#1264056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F4TM%3D","line":12,"updated":"2013-12-28 08:20:23.000000000","message":"Suggest you reword the commit message - its meaning is not very clear:\n\n--------\n\nRemove redundant code.\n\nMethods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py have a redundant \u0027sql_connection \u003d CONF.sql_connection\u0027 statement. Neither of the two functions use the sql_connection variable.\n\n--------\n\nNote: \u0027sql_connection\u0027 is a local variable. Therefore the \u0027sql_connection\u0027 in these two functions has no effect on _version_control.","commit_id":"a94b00b9a4b121d28f8134f3db8278a5b1dd1bf6"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"57b8e05cf526d39bc3598d57354f66262c342710","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In methods \u0027version_control\u0027 and \u0027db_sync\u0027 in glance/db/sqlalchemy/migration.py,"},{"line_number":10,"context_line":"there are redundant code \u0027sql_connection \u003d CONF.sql_connection\u0027."},{"line_number":11,"context_line":"They will never be used because the \u0027 _version_control\u0027 has the sentence."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie8a12e6f385f7103463172ed9acde1de0336a6d4"},{"line_number":14,"context_line":"Closes-Bug:#1264056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAT3%2F%2F4Sg%3D","line":12,"in_reply_to":"AAAAT3%2F%2F4TM%3D","updated":"2013-12-28 08:29:35.000000000","message":"agree to local var","commit_id":"a94b00b9a4b121d28f8134f3db8278a5b1dd1bf6"}]}