)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"103d9d10e3bd5a6b0fe52bf4fa004b261893215b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All enabled/known store drivers will be initialized and configured by"},{"line_number":10,"context_line":"Glance when API daemon startup, but the driver(s) which could not be"},{"line_number":11,"context_line":"configured correctly will break Glance normal startup progress. This"},{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FzsU%3D","line":11,"updated":"2013-12-31 05:16:59.000000000","message":"I don\u0027t want to be picky. But it would be nice if we can change the words. Since the unconfigurable driver won\u0027t BREAK the glance-api startup. It just prints some noise messages as the following. Please correct me if I missed anything.\n\n2013-12-31 13:14:44.014 6657 ERROR glance.store.sheepdog [-] Error in store configuration: Unexpected error while running command.\nCommand: collie\nExit code: 127\nStdout: \u0027\u0027\nStderr: \u0027/bin/sh: 1: collie: not found\\n\u0027\n2013-12-31 13:14:44.014 6657 WARNING glance.store.base [-] Failed to configure store correctly: Store sheepdog could not be configured correctly. Reason: Error in store configuration: Unexpected error while running command.\nCommand: collie\nExit code: 127\nStdout: \u0027\u0027\nStderr: \u0027/bin/sh: 1: collie: not found\\n\u0027 Disabling add method.","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"6d5dcf8995e9fc1b956c8b68d6304e12121b55ec","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All enabled/known store drivers will be initialized and configured by"},{"line_number":10,"context_line":"Glance when API daemon startup, but the driver(s) which could not be"},{"line_number":11,"context_line":"configured correctly will break Glance normal startup progress. This"},{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FwiY%3D","line":11,"in_reply_to":"AAAAT3%2F%2FybI%3D","updated":"2014-01-02 08:42:28.000000000","message":"\"configured correctly\" is really not enough at here @flwang @iccha?\n\nOr do you think this is ok for your? \"... but the driver(s) which could not be configured correctly for its essential function(s) will break ...\".","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"d05673db2b6b669504a1b46cd6481748e8f3f9a5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"All enabled/known store drivers will be initialized and configured by"},{"line_number":10,"context_line":"Glance when API daemon startup, but the driver(s) which could not be"},{"line_number":11,"context_line":"configured correctly will break Glance normal startup progress. This"},{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FybI%3D","line":11,"in_reply_to":"AAAAT3%2F%2FzsU%3D","updated":"2013-12-31 15:54:07.000000000","message":"+1 I agree with Fei. \nThis patch would help reduce confusion for folks, so thanks for working on it ZHi","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"dd29418e754da4aadf27b4b3b105a7bd56f2feb1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie14b1fb2f554e12cf82512f1d84390619d35a886"},{"line_number":17,"context_line":"Signed-off-by: Zhi Yan Liu \u003czhiyanl@cn.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FvQM%3D","line":15,"updated":"2014-01-02 16:29:21.000000000","message":"All enabled/known store drivers  are currently initialized and configured by\nGlance when API daemon startup, and the driver(s) which could not be\nconfigured correctly are skipped. But the corresponding log messages do not indicate the same. This patch explicitly logs the skipping of the stores with bad configuration.","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"fdd52eb03a92297429d8a428fda759b3f87f626d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie14b1fb2f554e12cf82512f1d84390619d35a886"},{"line_number":17,"context_line":"Signed-off-by: Zhi Yan Liu \u003czhiyanl@cn.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FvNw%3D","line":15,"in_reply_to":"AAAAT3%2F%2FvOo%3D","updated":"2014-01-02 16:38:10.000000000","message":"great, thanks for your suggestion.","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"3bb9a38c765fb35bd7f8bc45d031cdec42830432","unresolved":false,"context_lines":[{"line_number":12,"context_line":"change allow Glance store driver initialization progress skip those"},{"line_number":13,"context_line":"drivers which failed to be configured with BadStoreConfiguration"},{"line_number":14,"context_line":"exception."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie14b1fb2f554e12cf82512f1d84390619d35a886"},{"line_number":17,"context_line":"Signed-off-by: Zhi Yan Liu \u003czhiyanl@cn.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAT3%2F%2FvOo%3D","line":15,"in_reply_to":"AAAAT3%2F%2FvQM%3D","updated":"2014-01-02 16:36:33.000000000","message":"All enabled/known store drivers are currently initialized and configured by Glance when API daemon startup, and the driver(s) which could not be configured correctly fail are not skipped. This patch explicitly skips the stores with bad configuration and logs the same.","commit_id":"ab1472b1aa842e697b59451ba1d4d01f837f27f9"}],"glance/store/__init__.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"063c9b27c6c49ea9063bf323debc158bedbadc25","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            store_instance \u003d store_cls()"},{"line_number":166,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":167,"context_line":"            LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":168,"context_line":"            continue"},{"line_number":169,"context_line":"        schemes \u003d store_instance.get_schemes()"},{"line_number":170,"context_line":"        if not schemes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2FuSE%3D","line":167,"updated":"2014-01-02 21:41:20.000000000","message":"Not sure if we should do LOG.exception(\"Skipping store driver.\") here?","commit_id":"fbf6272ca5ec26b2e87d8f2f6e52f158c5f0ce0a"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7268735b1caccf53f1d401947134bbc44e33eefd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            store_instance \u003d store_cls()"},{"line_number":166,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":167,"context_line":"            LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":168,"context_line":"            continue"},{"line_number":169,"context_line":"        schemes \u003d store_instance.get_schemes()"},{"line_number":170,"context_line":"        if not schemes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2F9nk%3D","line":167,"in_reply_to":"AAAAT3%2F%2FuSE%3D","updated":"2014-01-06 06:17:49.000000000","message":"I think \"warn\" level is enough, since those unconfigurable stores can be skipped normally and glance-api is still could be started in normal, IMO \"exception\" level means glance meet a unprocessible issue generally.","commit_id":"fbf6272ca5ec26b2e87d8f2f6e52f158c5f0ce0a"},{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"5e66801cfdb94ff1e2a553d37df252fc447b59a2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            store_instance \u003d store_cls()"},{"line_number":166,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":167,"context_line":"            LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":168,"context_line":"            continue"},{"line_number":169,"context_line":"        schemes \u003d store_instance.get_schemes()"},{"line_number":170,"context_line":"        if not schemes:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FxDI%3D","line":167,"in_reply_to":"AAAAUH%2F%2F9nk%3D","updated":"2014-01-08 18:06:38.000000000","message":"I agree with zhiyan, I think warning is fine.","commit_id":"fbf6272ca5ec26b2e87d8f2f6e52f158c5f0ce0a"}]}