)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8b73b64f34a023bd4d5c9290616022134c587d1c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-14 06:10:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_a65e7a73","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":15},"updated":"2019-05-14 11:29:27.000000000","message":"NIT: location","commit_id":"5994c5a3c8197c248b831275f798a4837fec9306"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8b73b64f34a023bd4d5c9290616022134c587d1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"},{"line_number":11,"context_line":"corresponding tests as well."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_264a8aab","line":9,"range":{"start_line":9,"start_character":13,"end_line":9,"end_character":23},"updated":"2019-05-14 11:29:27.000000000","message":"Nit: vocabulary","commit_id":"5994c5a3c8197c248b831275f798a4837fec9306"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fd7e31e0d6260dc2e9ede0d08ebcf1cc1170ba9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-22 09:58:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_36ad329b","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":9},"updated":"2019-07-26 11:06:08.000000000","message":"This has been bugging me for months.  Please s/a/o/.","commit_id":"5a3131e5c98106a7102eaaf0da539e57832a445b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0b0ef6fa2f254d784ddaabc7d875d1b31f64f48c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-22 09:58:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_dc287c98","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":9},"in_reply_to":"7faddb67_36ad329b","updated":"2019-07-26 17:04:11.000000000","message":"Done","commit_id":"5a3131e5c98106a7102eaaf0da539e57832a445b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fd7e31e0d6260dc2e9ede0d08ebcf1cc1170ba9f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"},{"line_number":11,"context_line":"corresponding tests as well."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_f68eba30","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":21},"updated":"2019-07-26 11:06:08.000000000","message":"You could s/o/a/ if you like, but this one doesn\u0027t bother me as much.","commit_id":"5a3131e5c98106a7102eaaf0da539e57832a445b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0b0ef6fa2f254d784ddaabc7d875d1b31f64f48c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change lacation metadata key \u0027backend\u0027 to \u0027store\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As a part of vocabulory correction, changed the location"},{"line_number":10,"context_line":"metadata key name from \u0027backend\u0027 to \u0027store\u0027. Modified"},{"line_number":11,"context_line":"corresponding tests as well."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_7c194886","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":21},"in_reply_to":"7faddb67_f68eba30","updated":"2019-07-26 17:04:11.000000000","message":"Done","commit_id":"5a3131e5c98106a7102eaaf0da539e57832a445b"}],"glance/api/v2/images.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"32b708307f230b350f512a5549445e123b231fce","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1239,"context_line":"            \u0027description\u0027: _(\u0027An image file url\u0027),"},{"line_number":1240,"context_line":"        },"},{"line_number":1241,"context_line":"        \u0027backend\u0027: {"},{"line_number":1242,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1243,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1244,"context_line":"            \u0027description\u0027: _(\u0027Backend store to upload image to\u0027),"},{"line_number":1245,"context_line":"        },"},{"line_number":1246,"context_line":"        \u0027schema\u0027: {"},{"line_number":1247,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_0100e066","side":"PARENT","line":1244,"range":{"start_line":1241,"start_character":0,"end_line":1244,"end_character":65},"updated":"2019-07-27 14:15:06.000000000","message":"You are correct that this wasn\u0027t used anywhere, but it\u0027s because it is using the wrong name -- look at line 1053, it should be \u0027stores\u0027.  (The \u0027stores\u0027 property is consumed by commit 5fb14f5ebbea044 to glanceclient, included in 2.15.0).  So this needs to be restored in your patch, but change \u0027backend\u0027 to \u0027stores\u0027 and revise the description to something like \"Store in which this image\u0027s data resides. May be a comma-separated list of store identifiers if multiple image locations are in use.\"","commit_id":"62da67070e5ef8aaf4dd9dcd0ac06a3b62c4f0c6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cdbd4649ef012fa55bd5560362881e9a9279ecda","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1239,"context_line":"            \u0027description\u0027: _(\u0027An image file url\u0027),"},{"line_number":1240,"context_line":"        },"},{"line_number":1241,"context_line":"        \u0027backend\u0027: {"},{"line_number":1242,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1243,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1244,"context_line":"            \u0027description\u0027: _(\u0027Backend store to upload image to\u0027),"},{"line_number":1245,"context_line":"        },"},{"line_number":1246,"context_line":"        \u0027schema\u0027: {"},{"line_number":1247,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_32ec4928","side":"PARENT","line":1244,"range":{"start_line":1241,"start_character":0,"end_line":1244,"end_character":65},"in_reply_to":"7faddb67_0100e066","updated":"2019-07-29 05:22:29.000000000","message":"Done","commit_id":"62da67070e5ef8aaf4dd9dcd0ac06a3b62c4f0c6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"49376bccca647780e208c8ffea42b86859e856aa","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        \u0027stores\u0027: {"},{"line_number":1242,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1243,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1244,"context_line":"            \u0027description\u0027: _(\u0027Store in which image data resides. Comma \u0027"},{"line_number":1245,"context_line":"                             \u0027separated list of store identifiers in case \u0027"},{"line_number":1246,"context_line":"                             \u0027of Multiple stores enabled else empty string.\u0027),"},{"line_number":1247,"context_line":"        },"},{"line_number":1248,"context_line":"        \u0027schema\u0027: {"},{"line_number":1249,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_bfe8ebb2","line":1246,"range":{"start_line":1244,"start_character":29,"end_line":1246,"end_character":76},"updated":"2019-07-30 12:38:12.000000000","message":"I think this could use a revision.  Looking at the code, I don\u0027t think this can be an empty string--it only gets loaded into the view when a \u0027store\u0027 is found in at least one location, and only when multistore is enabled.  Maybe something like:\n\nStore in which image data resides.  Only present when the operator has enabled multiple stores.  May be a comma-separated list of store identifiers.\n\n(I don\u0027t think it\u0027s worth mentioning that the \u0027store\u0027 location metadata must be present also, since your lazy-loading scheme will take care of that before people notice this schema change.)","commit_id":"f06b6fa739a775f84812e9fe04d319972afb6a17"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f9542d327c2bdb5e81ccad4fd87b33912890e18d","unresolved":false,"context_lines":[{"line_number":1241,"context_line":"        \u0027stores\u0027: {"},{"line_number":1242,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":1243,"context_line":"            \u0027readOnly\u0027: True,"},{"line_number":1244,"context_line":"            \u0027description\u0027: _(\u0027Store in which image data resides. Comma \u0027"},{"line_number":1245,"context_line":"                             \u0027separated list of store identifiers in case \u0027"},{"line_number":1246,"context_line":"                             \u0027of Multiple stores enabled else empty string.\u0027),"},{"line_number":1247,"context_line":"        },"},{"line_number":1248,"context_line":"        \u0027schema\u0027: {"},{"line_number":1249,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_2bc27935","line":1246,"range":{"start_line":1244,"start_character":29,"end_line":1246,"end_character":76},"in_reply_to":"7faddb67_bfe8ebb2","updated":"2019-07-30 15:43:06.000000000","message":"Done","commit_id":"f06b6fa739a775f84812e9fe04d319972afb6a17"}]}