)]}'
{"api-ref/source/v2/samples/stores-list-response.json":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"438235dd68acd0853d98fc3280737373853d7cec","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"id\":\"read_only_store\","},{"line_number":18,"context_line":"            \"description\": \"Read only http store\","},{"line_number":19,"context_line":"            \"rad-only\": true"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"    ]"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"bfb3d3c7_2f5edf11","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":16},"updated":"2019-05-28 17:20:06.000000000","message":"read","commit_id":"5f81016d0aa79f27ed6677952e1695d3bfd214cf"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"95c1fd00c4f417180958d85e35b594d6c7ed0f03","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        {"},{"line_number":17,"context_line":"            \"id\":\"read_only_store\","},{"line_number":18,"context_line":"            \"description\": \"Read only http store\","},{"line_number":19,"context_line":"            \"rad-only\": true"},{"line_number":20,"context_line":"        }"},{"line_number":21,"context_line":"    ]"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"bfb3d3c7_81ad579c","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":16},"in_reply_to":"bfb3d3c7_2f5edf11","updated":"2019-05-29 05:13:18.000000000","message":"Done","commit_id":"5f81016d0aa79f27ed6677952e1695d3bfd214cf"}],"doc/source/admin/multistores.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"438235dd68acd0853d98fc3280737373853d7cec","unresolved":false,"context_lines":[{"line_number":57,"context_line":"         [DEFAULT]"},{"line_number":58,"context_line":"         enabled_backends \u003d fast:rbd, cheap:rbd, shared:file, reliable:file"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    .. note:: Due to the special read only nature and characteristics of the"},{"line_number":61,"context_line":"              ``http`` store we do not encourage nor support configuring"},{"line_number":62,"context_line":"              multiple instances of http store even though it\u0027s possible. If"},{"line_number":63,"context_line":"              `http` stored is configured under ``enabled_backends`` config"},{"line_number":64,"context_line":"              option then it will be treated as read-only store. The"},{"line_number":65,"context_line":"              /v2/stores/info call will list this ``http`` store as read-only"},{"line_number":66,"context_line":"              True."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* in the ``[glance_store]`` options group:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bfb3d3c7_4f231357","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":19},"updated":"2019-05-28 17:20:06.000000000","message":"I think this would be more clear if we keep in focus the store identifier vs. store type distinction made in the paragraph at line 49.  Something like this:\n\n  Due to the special read only nature and characteristics of the\n  http store type, we do not encourage nor support configuring\n  multiple instances of the http type store even though it\u0027s possible.\n\n\n  The http store type is always treated by Glance as a read-only\n  store.  This is indicated in the response to the ``/v2/stores/info``\n  call, where an http type store will have the attribute ``read-only: True``\n  in addition to the usual ``id`` and ``description`` fields.","commit_id":"5f81016d0aa79f27ed6677952e1695d3bfd214cf"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"95c1fd00c4f417180958d85e35b594d6c7ed0f03","unresolved":false,"context_lines":[{"line_number":57,"context_line":"         [DEFAULT]"},{"line_number":58,"context_line":"         enabled_backends \u003d fast:rbd, cheap:rbd, shared:file, reliable:file"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    .. note:: Due to the special read only nature and characteristics of the"},{"line_number":61,"context_line":"              ``http`` store we do not encourage nor support configuring"},{"line_number":62,"context_line":"              multiple instances of http store even though it\u0027s possible. If"},{"line_number":63,"context_line":"              `http` stored is configured under ``enabled_backends`` config"},{"line_number":64,"context_line":"              option then it will be treated as read-only store. The"},{"line_number":65,"context_line":"              /v2/stores/info call will list this ``http`` store as read-only"},{"line_number":66,"context_line":"              True."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"* in the ``[glance_store]`` options group:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bfb3d3c7_c1a7cfbc","line":66,"range":{"start_line":60,"start_character":0,"end_line":66,"end_character":19},"in_reply_to":"bfb3d3c7_4f231357","updated":"2019-05-29 05:13:18.000000000","message":"Done","commit_id":"5f81016d0aa79f27ed6677952e1695d3bfd214cf"}],"glance/tests/unit/base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"00f36faadc588ca17f377713e8e1cd036fd5569b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        :returns: the number of how many store drivers been loaded."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.config(enabled_backends\u003d{\u0027file1\u0027: \u0027file\u0027, \u0027ceph1\u0027: \u0027rbd\u0027,"},{"line_number":76,"context_line":"                                      \u0027http1\u0027: \u0027http\u0027})"},{"line_number":77,"context_line":"        store.register_store_opts(CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.config(default_backend\u003d\u0027file1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_c4062b1d","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":53},"updated":"2019-05-24 20:26:27.000000000","message":"This kind of thing always makes me nervous.  We want to name the store so that we know what kind it is in the tests, but we don\u0027t want to have tests pass if the code is checking the \u0027id\u0027 by mistake to find out whether to include the \u0027read-only\u0027 field in the output.  (Up to you whether you want to change it or not, the problem of the protocol being part of the name is already there for the filesystem store.)","commit_id":"295ebed60ba1570bd19e3ecacbc914dd3c103528"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f5b2356d4db3880752e9545aaf81e2ec9c58c174","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        :returns: the number of how many store drivers been loaded."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.config(enabled_backends\u003d{\u0027file1\u0027: \u0027file\u0027, \u0027ceph1\u0027: \u0027rbd\u0027,"},{"line_number":76,"context_line":"                                      \u0027http1\u0027: \u0027http\u0027})"},{"line_number":77,"context_line":"        store.register_store_opts(CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.config(default_backend\u003d\u0027file1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_7135b58e","line":76,"range":{"start_line":76,"start_character":37,"end_line":76,"end_character":53},"in_reply_to":"bfb3d3c7_c4062b1d","updated":"2019-05-27 03:40:34.000000000","message":"Hi Brian,\n\nAgree, I will submit a followup patch to rename these stores as this also need to change in functional tests as well.","commit_id":"295ebed60ba1570bd19e3ecacbc914dd3c103528"}],"glance/tests/unit/v2/test_discovery_stores.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"00f36faadc588ca17f377713e8e1cd036fd5569b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.assertIn(\u0027id\u0027, stores)"},{"line_number":57,"context_line":"            self.assertIn(stores[\u0027id\u0027], available_stores)"},{"line_number":58,"context_line":"            if stores[\u0027id\u0027] \u003d\u003d \u0027http1\u0027:"},{"line_number":59,"context_line":"                self.assertTrue(stores[\u0027read-only\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_497ed6af","line":59,"updated":"2019-05-24 20:26:27.000000000","message":"I think you also want to check that the code is not adding read-only to *all* the stores (which would be one way to pass this test).  Probably add here:\n\n  else:\n      self.assertIsNone(stores.get(\u0027read-only\u0027))","commit_id":"295ebed60ba1570bd19e3ecacbc914dd3c103528"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f5b2356d4db3880752e9545aaf81e2ec9c58c174","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            self.assertIn(\u0027id\u0027, stores)"},{"line_number":57,"context_line":"            self.assertIn(stores[\u0027id\u0027], available_stores)"},{"line_number":58,"context_line":"            if stores[\u0027id\u0027] \u003d\u003d \u0027http1\u0027:"},{"line_number":59,"context_line":"                self.assertTrue(stores[\u0027read-only\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_51d5111b","line":59,"in_reply_to":"bfb3d3c7_497ed6af","updated":"2019-05-27 03:40:34.000000000","message":"Done","commit_id":"295ebed60ba1570bd19e3ecacbc914dd3c103528"}]}