)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ceb7818a2d32b0dcdcd03eb1258d555b68ad35c1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"loading the store, but after merging of recent patch [1] it tries to"},{"line_number":14,"context_line":"connect to rados via configure_add method of rbd driver."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To avoid these kind of failures in near future we should drop using"},{"line_number":17,"context_line":"rbd store in tests as we know it is not supported in gate."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"NOTE:"},{"line_number":20,"context_line":"Also corrected the naming conventions of store identifiers, instead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_807efe16","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":58},"updated":"2019-06-07 11:54:03.000000000","message":"I think the bigger issue here is that unit tests should not have this kind of dependency.  These tests are just making sure that the discovery call is getting correct stuff out of the configuration.  They shouldn\u0027t be actually making calls out to an external library.","commit_id":"0182868be5a3d07755a5039d77ff53ff3d770147"}],"glance/tests/unit/base.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"42b33341132c0fcaf8ce4f815a8fcef5b120a197","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param passing_config: making store driver passes basic configurations."},{"line_number":73,"context_line":"        :returns: the number of how many store drivers been loaded."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.config(enabled_backends\u003d{\u0027fast\u0027: \u0027file\u0027, \u0027cheap\u0027: \u0027file\u0027,"},{"line_number":76,"context_line":"                                      \u0027readonly_store\u0027: \u0027http\u0027})"},{"line_number":77,"context_line":"        store.register_store_opts(CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.config(default_backend\u003d\u0027fast\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_80c6fe99","line":76,"range":{"start_line":75,"start_character":38,"end_line":76,"end_character":62},"updated":"2019-06-07 11:42:02.000000000","message":"Are we actually feeding configs for these somewhere?","commit_id":"0182868be5a3d07755a5039d77ff53ff3d770147"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fcc5952a86d3b4f96b61663cdee7846978d96339","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        :param passing_config: making store driver passes basic configurations."},{"line_number":73,"context_line":"        :returns: the number of how many store drivers been loaded."},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        self.config(enabled_backends\u003d{\u0027fast\u0027: \u0027file\u0027, \u0027cheap\u0027: \u0027file\u0027,"},{"line_number":76,"context_line":"                                      \u0027readonly_store\u0027: \u0027http\u0027})"},{"line_number":77,"context_line":"        store.register_store_opts(CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.config(default_backend\u003d\u0027fast\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_c0ab9686","line":76,"range":{"start_line":75,"start_character":38,"end_line":76,"end_character":62},"in_reply_to":"9fb8cfa7_80c6fe99","updated":"2019-06-07 11:50:15.000000000","message":"No we are not feeding config options anywhere except for \u0027fast\u0027 file store where we are providing the filesytem_store_datadir at line #79","commit_id":"0182868be5a3d07755a5039d77ff53ff3d770147"}]}