)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23915ba99db07b4da7f757b58cebf00986009d5a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            distributed.call_import(task_input,"},{"line_number":151,"context_line":"                                    request_id,"},{"line_number":152,"context_line":"                                    req.context.to_dict())"},{"line_number":153,"context_line":"            until_timeout \u003d time.time() + 60"},{"line_number":154,"context_line":"            while (until_timeout \u003e time.time() and"},{"line_number":155,"context_line":"                   distributed.IMPORTS[request_id] \u003d\u003d False):"},{"line_number":156,"context_line":"                distributed.CONNECTION.process_data_events()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_586358dd","line":153,"range":{"start_line":153,"start_character":42,"end_line":153,"end_character":44},"updated":"2019-07-08 16:08:30.000000000","message":"Is this 60 seconds to complete the import, or just to get a response that it has been started? If the latter, I think it\u0027s probably too short for every case, especially edge ones and should be configurable. Is there another configurable timeout value we could re-use?","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e1aab11365d205cf3d272e347f934cc749b57eaf","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            distributed.call_import(task_input,"},{"line_number":151,"context_line":"                                    request_id,"},{"line_number":152,"context_line":"                                    req.context.to_dict())"},{"line_number":153,"context_line":"            until_timeout \u003d time.time() + 60"},{"line_number":154,"context_line":"            while (until_timeout \u003e time.time() and"},{"line_number":155,"context_line":"                   distributed.IMPORTS[request_id] \u003d\u003d False):"},{"line_number":156,"context_line":"                distributed.CONNECTION.process_data_events()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_84b16592","line":153,"range":{"start_line":153,"start_character":42,"end_line":153,"end_character":44},"in_reply_to":"7faddb67_586358dd","updated":"2019-07-08 20:02:45.000000000","message":"Yes it\u0027s the later, just to get confirmation that a node has found the data and started processing it (or failed initializing the task). Just like the local call returns when it kicks off the async task that does the actual heavy lifting.","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23915ba99db07b4da7f757b58cebf00986009d5a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                    request_id,"},{"line_number":152,"context_line":"                                    req.context.to_dict())"},{"line_number":153,"context_line":"            until_timeout \u003d time.time() + 60"},{"line_number":154,"context_line":"            while (until_timeout \u003e time.time() and"},{"line_number":155,"context_line":"                   distributed.IMPORTS[request_id] \u003d\u003d False):"},{"line_number":156,"context_line":"                distributed.CONNECTION.process_data_events()"},{"line_number":157,"context_line":"            if distributed.IMPORTS[request_id] \u003d\u003d image_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b55cd54b","line":154,"range":{"start_line":154,"start_character":19,"end_line":154,"end_character":46},"updated":"2019-07-08 16:08:30.000000000","message":"I am not sure what is conventional in glance, but...shouldn\u0027t this be something from oslo.timeutils that uses monotonic time? While unlikely, this can roll backwards and confuse your timeout loop :)","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e1aab11365d205cf3d272e347f934cc749b57eaf","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                    request_id,"},{"line_number":152,"context_line":"                                    req.context.to_dict())"},{"line_number":153,"context_line":"            until_timeout \u003d time.time() + 60"},{"line_number":154,"context_line":"            while (until_timeout \u003e time.time() and"},{"line_number":155,"context_line":"                   distributed.IMPORTS[request_id] \u003d\u003d False):"},{"line_number":156,"context_line":"                distributed.CONNECTION.process_data_events()"},{"line_number":157,"context_line":"            if distributed.IMPORTS[request_id] \u003d\u003d image_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_44804d8c","line":154,"range":{"start_line":154,"start_character":19,"end_line":154,"end_character":46},"in_reply_to":"7faddb67_b55cd54b","updated":"2019-07-08 20:02:45.000000000","message":"Probably should. Leftovers from \"I need something to get this moving\". I was counting Brian telling me how it should be done \u0027though but I\u0027ll have a look on oslo.timeutils :P","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a99dfb156106be01211b5ec59942e3ce0a98356","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_serialization import jsonutils as json"},{"line_number":24,"context_line":"from oslo_utils import encodeutils"},{"line_number":25,"context_line":"from oslo_utils import timeutils"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"from six.moves import http_client as http"},{"line_number":28,"context_line":"import six.moves.urllib.parse as urlparse"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_15f91b4c","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":32},"updated":"2019-07-09 10:56:27.000000000","message":"you need to rename it to oslo_timeutils as timeutils is used at line #36","commit_id":"bd2be7c691d5de06b36c467dd6b26ac417586216"}],"glance/common/cluster.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23915ba99db07b4da7f757b58cebf00986009d5a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027cluster_rabbit_connection\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d_(\"\"\""},{"line_number":47,"context_line":"Connection strig to access the rabbitMQ broker"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The connection string can be as following [] indicating optional:"},{"line_number":50,"context_line":"[rabbit://][user:pass@]host[:port]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_98123058","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":16},"updated":"2019-07-08 16:08:30.000000000","message":"string","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e1aab11365d205cf3d272e347f934cc749b57eaf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.StrOpt(\u0027cluster_rabbit_connection\u0027,"},{"line_number":45,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":46,"context_line":"               help\u003d_(\"\"\""},{"line_number":47,"context_line":"Connection strig to access the rabbitMQ broker"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"The connection string can be as following [] indicating optional:"},{"line_number":50,"context_line":"[rabbit://][user:pass@]host[:port]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2e93afa5","line":47,"range":{"start_line":47,"start_character":11,"end_line":47,"end_character":16},"in_reply_to":"7faddb67_98123058","updated":"2019-07-08 20:02:45.000000000","message":"Done","commit_id":"40ab7842a17c404314b532696660deb36f1ff99f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5a58a537cd6aeb0e6f5a6ccde98abcc51a0bed02","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    self.rabbit_pass \u003d transport[0].split(\u0027:\u0027)[1]"},{"line_number":98,"context_line":"                    cred \u003d pika.PlainCredentials(self.rabbit_user,"},{"line_number":99,"context_line":"                                                 self.rabbit_pass)"},{"line_number":100,"context_line":"                    self.CONNECTION \u003d pika.BlockingConnection("},{"line_number":101,"context_line":"                        pika.ConnectionParameters(host\u003dself.rabbit_host,"},{"line_number":102,"context_line":"                                                  port\u003dself.rabbit_port,"},{"line_number":103,"context_line":"                                                  credentials\u003dcred))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_d0cc9b62","line":100,"updated":"2019-09-02 02:58:04.000000000","message":"There is no re-connect logic here. What is meant to happen if the connection is dropped for any reason?","commit_id":"5053386488339e7c9552309361e8b6a14d5777fb"}]}