)]}'
{"glance/db/sqlalchemy/migrate_repo/versions/002_add_image_properties_table.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"b9658464cac3736f008a5d0c1137a86e6de16d84","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from sqlalchemy.schema import ("},{"line_number":17,"context_line":"    Column, ForeignKey, Index, MetaData, Table, UniqueConstraint)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import Boolean"},{"line_number":20,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import create_tables"},{"line_number":21,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import DateTime"},{"line_number":22,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import drop_tables"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BW8k%3D","line":19,"updated":"2014-01-27 18:43:45.000000000","message":"In generally, we don\u0027t change these existing migration scripts/code, but I think this change is straightforward and harmless, so this isn\u0027t a big deal to me.","commit_id":"846690bd18f3f927d187da4d1a9fd73d3b52c590"}],"glance/db/sqlalchemy/migrate_repo/versions/030_add_tasks_table.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"b9658464cac3736f008a5d0c1137a86e6de16d84","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from sqlalchemy.schema import (Column, MetaData, Table, Index)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import Boolean"},{"line_number":20,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import create_tables"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BW68%3D","line":17,"updated":"2014-01-27 18:43:45.000000000","message":"Do you think we also need to separate this to a multi-line importing? thanks.","commit_id":"846690bd18f3f927d187da4d1a9fd73d3b52c590"}],"glance/db/sqlalchemy/migrate_repo/versions/032_add_task_info_table.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"b9658464cac3736f008a5d0c1137a86e6de16d84","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy.schema import (Column, ForeignKey, MetaData, Table)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import create_tables"},{"line_number":19,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import drop_tables"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BW6Q%3D","line":16,"updated":"2014-01-27 18:43:45.000000000","message":"ditto","commit_id":"846690bd18f3f927d187da4d1a9fd73d3b52c590"}],"tox.ini":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"b9658464cac3736f008a5d0c1137a86e6de16d84","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# H304  no relative imports"},{"line_number":38,"context_line":"# H402  one line docstring needs punctuation."},{"line_number":39,"context_line":"# H404  multi line docstring should start with a summary"},{"line_number":40,"context_line":"ignore \u003d E711,E712,F821,F841,H202,H302,H304,H402,H404,H501"},{"line_number":41,"context_line":"builtins \u003d _"},{"line_number":42,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance/locale*,*openstack/common*,*lib/python*,*egg,build"}],"source_content_type":"text/x-properties","patch_set":5,"id":"AAAAUH%2F%2BXDw%3D","line":40,"updated":"2014-01-27 18:43:45.000000000","message":"1. Seems like this change finish 3 things, it not only enabled H301 but also disabled H304 and H501. IMO it will be better if we do those separately\n\n2. If you really like do those H301 enablement and H304 disablement in this patch, you\u0027d better correct the commit message for this change.\n\n3. Why you involve H501 in? Seems it\u0027s not related, isn\u0027t it? Let me know if I miss anything.","commit_id":"846690bd18f3f927d187da4d1a9fd73d3b52c590"}]}