)]}'
{"id":"openstack%2Fglance~677694","triplet_id":"openstack%2Fglance~master~I62c592f0885927b873ed35a1efe4a0f8407e7dee","project":"openstack/glance","branch":"master","topic":"bug/1840898","hashtags":[],"change_id":"I62c592f0885927b873ed35a1efe4a0f8407e7dee","subject":"Fix INSTR not supported for postgresql","status":"MERGED","created":"2019-08-21 10:41:56.000000000","updated":"2019-08-29 18:24:29.000000000","submitted":"2019-08-29 18:22:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677694-1567102949496-6c2ca45c","meta_rev_id":"66eb73446d88e872082a6793405b501b824124f9","_number":677694,"virtual_id_number":677694,"owner":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":2,"date":"2019-08-29 18:22:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2019-08-28 11:47:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2019-08-29 14:50:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2019-08-22 01:29:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2019-08-29 14:50:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2019-08-28 05:24:32.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2019-08-22 03:57:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-22 01:29:36.000000000","updated_by":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"reviewer":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"state":"REVIEWER"},{"updated":"2019-08-28 05:24:32.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2019-08-28 11:47:33.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-08-29 14:50:54.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-08-29 18:22:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"19340bf1e7544ee42daff692bcd0d10861c67a93","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2019-08-21 10:41:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"476d2a93ef3033a6039e61f9682475141a300587","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-21 12:20:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/815d3d93914a4f89bbf86f0bd32d5363 : SUCCESS in 1h 33m 20s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/7e681fe4d3d54614aa5f1cd1cc2478de : SUCCESS in 1h 00m 06s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/def4cba3b2f54df18b137c2ef5d8b6ad : SUCCESS in 58m 29s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/23738d63efa14f059621f24d69a3f610 : SUCCESS in 1h 24m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5b8c586b5553405daf54394778aa266a : SUCCESS in 4m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/57a6fa2b466042f8982b9a06a5114f9d : SUCCESS in 4m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/138efae70080447f85ac99f1a3aa38c8 : SUCCESS in 5m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1890b49cbc3c46aa99b9e841a180d25f : SUCCESS in 5m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4da73534edd44d918961e894e0c4af59 : SUCCESS in 5m 18s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5b8beee19db74102b72ed1206fb7cfb4 : SUCCESS in 5m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e6978f59d36b4ef29a31a7da7bf0e28b : SUCCESS in 6m 50s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/e1557a34bc6440478c40f9f4c97d5efd : SUCCESS in 7m 59s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/804c2721f3c14e91b7b3816527302031 : SUCCESS in 9m 20s\n- glance-eventlet-ssl-handshake-broken-py3 https://zuul.opendev.org/t/openstack/build/2a05179e46b74038816468c987e810c7 : FAILURE in 5m 10s (non-voting)\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/00e3d415b8604283bad4d38e31701760 : SUCCESS in 4m 25s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/249d3d33cfcc4261924b7d04773f0f25 : SUCCESS in 1h 11m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4571fe8035a499d5d5e2ea74f7a37f825b8a3a99","author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"date":"2019-08-22 01:29:36.000000000","message":"Patch Set 1: Code-Review+1\n\nAbhishek, thanks a lot","accounts_in_message":[],"_revision_number":1},{"id":"3c1fe7565839a91105491697d5b947e7607aae36","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2019-08-22 03:57:01.000000000","message":"Patch Set 1: Review-Priority+2","accounts_in_message":[],"_revision_number":1},{"id":"f6bc70cf533eb3780f6155cb8ce6b1c620f8c056","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2019-08-22 03:57:40.000000000","message":"Patch Set 1:\n\nBlocking manila jobs, https://zuul.opendev.org/t/openstack/builds?job_name\u003dmanila-tempest-dsvm-postgres-zfsonlinux","accounts_in_message":[],"_revision_number":1},{"id":"b666ecac29706476634b7582dc41f52dbbb8538b","author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"date":"2019-08-27 09:23:19.000000000","message":"Patch Set 1:\n\nThis also block aodh\u0027s gate, please help review, thanks","accounts_in_message":[],"_revision_number":1},{"id":"89fb4eeed5675fd5d5b9042fd08ad5570a5137ea","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2019-08-28 05:25:53.000000000","message":"Patch Set 1:\n\nThis is blocking neutron tips jobs as well,\nhttp://zuul.openstack.org/builds?project\u003dopenstack%2Fneutron\u0026job_name\u003dneutron-tempest-postgres-full\u0026branch\u003dmaster","accounts_in_message":[],"_revision_number":1},{"id":"882b2a7505b533334a2cffd27216500f19434cc1","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-08-28 11:47:33.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1a35384ada310fb16596eaa4fed1fbee57e0b663","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-08-29 14:50:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThis looks good.  The only weird thing I noticed is that in postgres, POSITION is not case-sensitive, where REPLACE is.  So you could have a situation where has_migrations keeps reporting True, but nothing gets migrated.  But since JSON is case-sensitive, and that\u0027s what\u0027s being stored in the meta_data, I don\u0027t think this is a problem.","accounts_in_message":[],"_revision_number":1},{"id":"0765cd0e1858e028e2bdbcb516856b89ca483fbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 14:52:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6f0fdf7688a763ae3e1063a906168d5b2fd3778a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 18:22:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/b8181a11fcb54befa31829c229b1c4cf : SUCCESS in 1h 44m 20s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/d35113ec22fe40849a188718e15099c8 : SUCCESS in 59m 32s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/dd569465ed3b49cf9eac2f900fcf5223 : SUCCESS in 1h 01m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/71057ad2860d415cb2c1ad1882fec339 : SUCCESS in 1h 30m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b75c86d778794bdc90aad099d2393a57 : SUCCESS in 5m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af385bcae38b400d91ac90ad439cc542 : SUCCESS in 5m 37s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1e75172ea8634d35bf83aadbbdc4ccac : SUCCESS in 5m 37s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/6d71ddacccc14ff7b4cfdd0931906ea8 : SUCCESS in 6m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/97a589723ec04e9daa8065b69a23e838 : SUCCESS in 5m 23s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0d6a6215f9984c0b80108eb217d3be29 : SUCCESS in 6m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c580b51b3a3e46aabba01567a06d8d6b : SUCCESS in 8m 56s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/649899339af64d858e44fb6b6688612a : SUCCESS in 10m 12s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/3558ab57df0044ffbce85dbdb68a4a48 : SUCCESS in 10m 31s","accounts_in_message":[],"_revision_number":1},{"id":"f3755dfd8bdd73e3bf2d36b5b44d31bacb742da6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 18:22:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"a9d00c9ce8645bd9c0fb1befd218862be6f93a73","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 18:24:29.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4d9c36bbf48f45739497d73f593a3c6d : SUCCESS in 1m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6e525647f608839890a8a00a8e03a540a1891471","revisions":{"6e525647f608839890a8a00a8e03a540a1891471":{"kind":"REWORK","_number":1,"created":"2019-08-21 10:41:56.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/94/677694/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/94/677694/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/94/677694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/94/677694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/94/677694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/94/677694/1"}}},"commit":{"parents":[{"commit":"cee9526c98ea2561561baa5de63abb06bb3aa5e7","subject":"Merge \"Lazy update stores information\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/cee9526c98ea2561561baa5de63abb06bb3aa5e7"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2019-08-21 10:38:14.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2019-08-21 10:38:14.000000000","tz":0},"subject":"Fix INSTR not supported for postgresql","message":"Fix INSTR not supported for postgresql\n\nMigration script \u0027train_migrate01_backend_to_store.py\u0027 doesn\u0027t support\nINSTR function for postgresql database. INSTR function does support\nsqlite3 and mysql.\n\nUsed \u0027POSITION\u0027 function instead of \u0027INSTR\u0027 function if database is\npostgresql.\nCloses-Bug: #1840898\n\nChange-Id: I62c592f0885927b873ed35a1efe4a0f8407e7dee\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/6e525647f608839890a8a00a8e03a540a1891471"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/6e525647f608839890a8a00a8e03a540a1891471"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
