)]}'
{"id":"openstack%2Fglance~679895","triplet_id":"openstack%2Fglance~master~Ieecfb11928f74a504b35172a2c96d3a8cba057c0","project":"openstack/glance","branch":"master","hashtags":[],"change_id":"Ieecfb11928f74a504b35172a2c96d3a8cba057c0","subject":"fix properties\u0027 missing underline for VirtCPUTopology","status":"MERGED","created":"2019-09-04 04:04:06.000000000","updated":"2020-01-31 06:20:05.000000000","submitted":"2020-01-28 05:31:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"679895-1580189488081-fa858c1e","meta_rev_id":"78912d0a7ca18fa5150a4d255266f6419c01cc0b","_number":679895,"virtual_id_number":679895,"owner":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-09-04 04:04:28.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"date":"2020-01-15 09:27:14.000000000","_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-01-28 05:31:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},{"value":0,"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2020-01-28 05:19:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2019-09-04 04:31:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},{"value":1,"date":"2019-09-04 04:25:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2020-01-28 05:19:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},{"value":0,"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"date":"2019-09-06 16:04:28.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"date":"2019-09-06 16:04:36.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-09-04 04:10:33.000000000","_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},{"value":0,"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},{"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-04 04:04:28.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-04 04:10:33.000000000","updated_by":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"reviewer":{"_account_id":21757,"name":"Xing Zhang","email":"angeiv.zhang@gmail.com","username":"angeiv"},"state":"REVIEWER"},{"updated":"2019-09-04 04:25:34.000000000","updated_by":{"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"},"reviewer":{"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"},"state":"REVIEWER"},{"updated":"2019-09-04 04:31:56.000000000","updated_by":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"reviewer":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"state":"REVIEWER"},{"updated":"2019-09-06 16:04:28.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2019-09-06 16:04:36.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-01-28 05:19:16.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-01-28 05:31:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cbecd63d2a61ea23910a0d960d01695822461c83","author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"date":"2019-09-04 04:04:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b66a7be6efb5fdc810d6346da7fdf5f37fb84d00","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2019-09-04 04:04:28.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"fb526f036e1c67e03e01684ac7727ef32d4ed3d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-04 04:20:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/72bb9a5322274c6ab43d10abfc49f315 : SUCCESS in 4m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6731c351bf6749dbbadc933a7444dfc6 : SUCCESS in 4m 29s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d0e6c38596af456ab617f28be5b7fed9 : SUCCESS in 4m 33s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/32521702ef154a8b86261c86dd4186a4 : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bdbfd85d9d0649898bf038be1a8102f6 : SUCCESS in 4m 44s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4659df91e65a423fa288e6cd44b95ff5 : SUCCESS in 5m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58ae804de29b4b8fa4fdb4216a1aeb8f : SUCCESS in 6m 34s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/88532ca1d71b4b2fb4bbf9931a166175 : SUCCESS in 8m 24s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/e1fa10bb90bb4901b00c889f6436c38e : SUCCESS in 9m 09s","accounts_in_message":[],"_revision_number":1},{"id":"4fc092f39426888cb6f3157ece89b4d8c53d0e09","author":{"_account_id":28367,"name":"Zijian Guo","email":"guozijn@gmail.com","username":"ZijianGuo"},"date":"2019-09-04 04:25:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ec1075ccbd917c924cd903a7077af4c7704fa0ba","author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"date":"2019-09-04 04:31:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0dc2877cc0459218c08cc37e9004f2d5f92b07fd","author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"date":"2020-01-15 09:27:14.000000000","message":"Patch Set 1:\n\n@Erno Kuvaja","accounts_in_message":[],"_revision_number":1},{"id":"99ec0d0b3df7c24496654766243fa3c5807d1446","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-01-28 05:19:16.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"77e35787ed84a80bd73cac69d252bd38ef4ce3bb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 05:19:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fa4996829a7f6fc52b52c80bc0380cf73288a306","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 05:31:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e65c698f28ce40fca5471e5bf1ab0c00 : SUCCESS in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9d949cbe5a794116ad8a5830b846a87b : SUCCESS in 4m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1b1fd5bba9994698979b8eb9c57378ef : SUCCESS in 4m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/250d9554c8f6446ab252f067e4bd0f0c : SUCCESS in 4m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d0a4c3a2ab94d5eb3d1b91b3070a797 : SUCCESS in 5m 24s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/22690d13d9ae41f7aed8f193ca71b75f : SUCCESS in 8m 09s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/2d4bf97c8ea4468abf6719344f8ca1e0 : SUCCESS in 10m 29s","accounts_in_message":[],"_revision_number":1},{"id":"bd4b1c7b3eb2a4aa693795347f6056c2afb87e30","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 05:31:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"9b0f99527430ede5de70f3591cc0e1984c12f3e9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-01-28 05:32:56.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/81f3507c976544a9b233853c147c7d03 : SUCCESS in 1m 11s","accounts_in_message":[],"_revision_number":1},{"id":"78912d0a7ca18fa5150a4d255266f6419c01cc0b","author":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"date":"2020-01-31 06:20:05.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit faa06f61409656ed7af67ca19c2c9519fd4ab7d8","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"da277c583a2b9a311c4ba66c5856e501944e11d8","revisions":{"da277c583a2b9a311c4ba66c5856e501944e11d8":{"kind":"REWORK","_number":1,"created":"2019-09-04 04:04:06.000000000","uploader":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"ref":"refs/changes/95/679895/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/95/679895/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/95/679895/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/95/679895/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/95/679895/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/95/679895/1"}}},"commit":{"parents":[{"commit":"85a91ba1430e8a7c1593ebf61e360d60ec11a5aa","subject":"Merge \"Fix INSTR not supported for postgresql\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/85a91ba1430e8a7c1593ebf61e360d60ec11a5aa"}]}],"author":{"name":"Ning Yao","email":"yaoning@unitedstack.com","date":"2019-09-04 03:56:35.000000000","tz":480},"committer":{"name":"Ning Yao","email":"yaoning@unitedstack.com","date":"2019-09-04 04:03:52.000000000","tz":480},"subject":"fix properties\u0027 missing underline for VirtCPUTopology","message":"fix properties\u0027 missing underline for VirtCPUTopology\n\nAccording to the docs:\nhttps://opendev.org/openstack/nova-specs/src/branch/master/specs/juno/implemented/virt-driver-vcpu-topology.rst,\ncpu_maxsockets, cpu_maxcores, cpu_maxthreads should be cpu_max_sockets, cpu_max_cores, cpu_max_threads.\n\nChange-Id: Ieecfb11928f74a504b35172a2c96d3a8cba057c0\nSigned-off-by: Ning Yao \u003cyaoning@unitedstack.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/da277c583a2b9a311c4ba66c5856e501944e11d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/da277c583a2b9a311c4ba66c5856e501944e11d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}