)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd8189627662d70d625081e8c33fe5edac38381d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make it list all valid values, and clarify that the default of"},{"line_number":10,"context_line":"virtio-blk is behaviour which happens when hw_scsi_model is not"},{"line_number":11,"context_line":"specified, rather than hw_scsi_model having a default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I99a274af222147fcb5e9969bbeb896312b30aeee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e647fc07_8e6bb9bd","line":11,"updated":"2024-02-26 09:29:35.000000000","message":"virtio-blk is not the default for hw_scsi_model\n\nthe default is virtio-scsi\n\nthe default for hw_disk_bus is virt driver defiend but in practice is virtio-blk for libvirt with qemu/kvm so by default hw_scsi_model is not used as it is only used if hw_disk_bus, hw_cdrom_bus or hw_rescue_bus is set to scsi","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"acba5590a26e3f944cdb17513463a03268ff35e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"18f59e58_f255bf56","updated":"2022-09-16 01:49:28.000000000","message":"I think we should also update the metadef to be consistent with the new text.","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"903d989eaa062833cb03410be662466e60acfce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"663d1b4e_fe0f5c7e","updated":"2022-09-15 19:05:56.000000000","message":"I\u0027m only reformatting this properly so the patch can be reviewed at some point. I\u0027m honestly not sure whether I agree with the new text.","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ccfc7c35e1866feafe4f0899135c3be80abcf3b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7d3e5229_8ca7581f","updated":"2023-06-28 14:38:41.000000000","message":"I think it would be cool if Sean can follow up with a patch for os_distro (which would be good) but we should probably not hold this up, since it\u0027s correct.","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a9d9374ff21e84bfd1f4a0b6e9afaf79fc338147","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f389aae2_94baf4be","updated":"2023-07-12 02:18:06.000000000","message":"The metadef change is missing an enum of the list of values that are being added to the text as legal values for the hw_scsi_model property.","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd8189627662d70d625081e8c33fe5edac38381d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d5a26a3_1fb698c6","in_reply_to":"7d3e5229_8ca7581f","updated":"2024-02-26 09:29:35.000000000","message":"to tell peopple to never use the libosinfo feature and use the image peorty as intened to only have the disto name not the name and version?","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"}],"api-ref/source/v2/samples/metadef-properties-list-response.json":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd8189627662d70d625081e8c33fe5edac38381d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        },"},{"line_number":38,"context_line":"        \"hw_scsi_model\": {"},{"line_number":39,"context_line":"            \"default\": \"virtio-scsi\","},{"line_number":40,"context_line":"            \"description\": \"Specifies the use of a particular model of virtual SCSI controller to provide block device access for compute instances. By default in libvirt, no SCSI controller is provided and another bus will be used, e.g. the default for disks when ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as VirtIO Block or ``virtio-blk``.  ``virtio-scsi`` is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":41,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":42,"context_line":"            \"type\": \"string\""},{"line_number":43,"context_line":"        },"}],"source_content_type":"application/json","patch_set":5,"id":"f7cd744a_c25eb6b0","line":40,"updated":"2024-02-26 09:29:35.000000000","message":"i dont really think this is any clearer.\n\nwhat you should say is hw_scsi_model is used if hw_disk_bus, hw_cdrom_bus or hw_rescue_bus is set to scsi.  by default the device bus is defied by the virt driver in use and no virt driver defaults to using scsi.","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"}],"doc/source/admin/useful-image-properties.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad641e72856d1fc01e947045997fbaaad7da0e4d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"       controller to provide block device access for compute"},{"line_number":433,"context_line":"       instances. By default no SCSI controller is provided, and"},{"line_number":434,"context_line":"       another bus will be used, e.g. the default for disks when"},{"line_number":435,"context_line":"       ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as"},{"line_number":436,"context_line":"       VirtIO Block or ``virtio-blk``. ``virtio-scsi`` is a"},{"line_number":437,"context_line":"       para-virtualized SCSI controller device that provides improved"},{"line_number":438,"context_line":"       scalability and performance, and supports advanced SCSI"},{"line_number":439,"context_line":"       hardware."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_16edfdb5","line":436,"range":{"start_line":435,"start_character":6,"end_line":436,"end_character":35},"updated":"2019-09-30 10:42:29.000000000","message":"this is only true for the libvirt dirver when using qemu/kvm\nother virt dirvers will have different defults.\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L221-L296\n\nso this is not really correct to say.\n\nwhat is correct to say is that as tenant i should only rely on hw_scsi_model if i have already set hw_disk_bus to scsi.\n\nwe also have some broken logic that can alter the default disk bus based on the image used and teh os_disto declared\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L\n114-L147\n\n\nthe vmware driver also support this option\n\nhttps://github.com/openstack/nova/blob/a5e3054e1d6df248fc4c00b9abd7289dde160393/nova/virt/vmwareapi/images.py#L153-L168\n\nbut again it only takes affect if the disk bus is set to scsi.\n\ni woudl try to avoid assuming the use of libvirt/kvm here.\nthe original code makes that assumtion as this image property is technically in the libvirt metadefs section but even for libvirt is not allways the cause the virtio-blk is the defualt since that is ingoring the default is based on the virt driver and the virt type. e.g. lxc vs qemu","commit_id":"238668a0b768794e3a157600a24282216c66c959"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"b66640f4c2f61ed611a660907b6e81620c10f18d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"       controller to provide block device access for compute"},{"line_number":433,"context_line":"       instances. By default no SCSI controller is provided, and"},{"line_number":434,"context_line":"       another bus will be used, e.g. the default for disks when"},{"line_number":435,"context_line":"       ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as"},{"line_number":436,"context_line":"       VirtIO Block or ``virtio-blk``. ``virtio-scsi`` is a"},{"line_number":437,"context_line":"       para-virtualized SCSI controller device that provides improved"},{"line_number":438,"context_line":"       scalability and performance, and supports advanced SCSI"},{"line_number":439,"context_line":"       hardware."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_71cf9b28","line":436,"range":{"start_line":435,"start_character":6,"end_line":436,"end_character":35},"in_reply_to":"3fa7e38b_16edfdb5","updated":"2019-09-30 11:46:52.000000000","message":"\u003e this is only true for the libvirt dirver when using qemu/kvm other virt dirvers will have different defults.\n \u003e \n \u003e https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L221-L296\n\nYes I\u0027m well aware of that code, but it\u0027s not relevant for this doc fragment which is specific to the libvirt driver (look at the first column).\n\n \u003e so this is not really correct to say.\n\nAFAICS it is correct in this libvirt-only context.\n\n \u003e what is correct to say is that as tenant i should only rely on hw_scsi_model if i have already set hw_disk_bus to scsi.\n\nI\u0027m not sure that\u0027s correct, e.g. it could be using virtio for disks but SCSI for CD-ROMs (which is the default for CD-ROMs on non-x86 architectures, but could also be via hw_cdrom_bus\u003dscsi).\n\n \u003e we also have some broken logic that can alter the default disk bus based on the image used and teh os_disto declared\n \u003e \n \u003e https://github.com/openstack/nova/blob/master/nova/virt/osinfo.py#L114-L147\n \u003e \n \u003e the vmware driver also support this option\n \u003e \n \u003e https://github.com/openstack/nova/blob/a5e3054e1d6df248fc4c00b9abd7289dde160393/nova/virt/vmwareapi/images.py#L153-L168\n \u003e \n \u003e but again it only takes affect if the disk bus is set to scsi.\n\nYes I was already aware of this code and even revisited it this morning before submitting the review.\n\n \u003e i woudl try to avoid assuming the use of libvirt/kvm here.\n\nAs per above, this row is *specifically* about libvirt.  vmware is the only other driver which cares about hw_scsi_model, therefore it would be invalid to put \"All\" in the first column of this row.  We could add a separate entry for hw_scsi_model specific to vmware, but that is outside the scope of this review.\n\n \u003e the original code makes that assumtion as this image property is technically in the libvirt metadefs section but even for libvirt is not allways the cause the virtio-blk is the defualt since that is ingoring the default is based on the virt driver and the virt type. e.g. lxc vs qemu\n\nIn libvirt/blockinfo.py, the default is clear:\n\n    elif virt_type in (\"qemu\", \"kvm\"):\n        ...\n        elif device_type \u003d\u003d \"disk\":\n            return \"virtio\"\n\nAgain concerns about lxc are outside the scope of this review which is only for a libvirt-specific doc fragment.","commit_id":"238668a0b768794e3a157600a24282216c66c959"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"37179f439d8466ce4fa20f0dff7f416c05292291","unresolved":false,"context_lines":[{"line_number":432,"context_line":"       controller to provide block device access for compute"},{"line_number":433,"context_line":"       instances. By default no SCSI controller is provided, and"},{"line_number":434,"context_line":"       another bus will be used, e.g. the default for disks when"},{"line_number":435,"context_line":"       ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as"},{"line_number":436,"context_line":"       VirtIO Block or ``virtio-blk``. ``virtio-scsi`` is a"},{"line_number":437,"context_line":"       para-virtualized SCSI controller device that provides improved"},{"line_number":438,"context_line":"       scalability and performance, and supports advanced SCSI"},{"line_number":439,"context_line":"       hardware."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_3b101d4e","line":436,"range":{"start_line":435,"start_character":6,"end_line":436,"end_character":35},"in_reply_to":"3fa7e38b_71cf9b28","updated":"2019-09-30 15:31:26.000000000","message":"I\u0027ve added \"in libvirt\" to this sentence to explicitly qualify the context, in case the first column is not enough.","commit_id":"238668a0b768794e3a157600a24282216c66c959"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"f221b103ba93e1ed513704e39245d1a9e60d3514","unresolved":false,"context_lines":[{"line_number":438,"context_line":"       improved scalability and performance, and supports advanced"},{"line_number":439,"context_line":"       SCSI hardware."},{"line_number":440,"context_line":"     - ``buslogic``, ``ibmvscsi``, ``lsilogic``, ``lsisas1068``,"},{"line_number":441,"context_line":"       ``lsisas1078``, ``virtio-scsi``, ``vmpvscsi``"},{"line_number":442,"context_line":"   * - libvirt API driver"},{"line_number":443,"context_line":"     - ``hw_serial_port_count``"},{"line_number":444,"context_line":"     - Specifies the count of serial ports that should be provided. If"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_197c3771","line":441,"updated":"2019-10-01 15:34:34.000000000","message":"oh wow, i didn\u0027t know about all these options","commit_id":"bbc1e758aebd6c85a469b9fa36c60db036066d5e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63ec0e7b8e0b433b4c7ec66b7fda74464256ea9b","unresolved":true,"context_lines":[{"line_number":552,"context_line":"  ``virtio-scsi`` is a para-virtualized SCSI controller device that"},{"line_number":553,"context_line":"  provides improved scalability and performance, and supports advanced"},{"line_number":554,"context_line":"  SCSI hardware."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"  Only supported by the libvirt driver."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"  One of:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"56a71e95_72e2f62c","line":555,"updated":"2022-09-16 09:59:20.000000000","message":"so all of this is true altough you might want to mention the libosinfo feature.\n\n\nnova has minimal integration with libosinfo which allows the default disk bus to be set based on the os_distro impage property.\n\nhttps://github.com/openstack/nova/blob/50fdbc752a9ca9c31488140ef2997ed59d861a41/nova/virt/osinfo.py#L114-L127\n\nif you set os_distro \u003d fedora17\n\nhttps://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/fedoraproject.org/fedora-17.xml.in#L19\n\nthen we will enable virtio-scsi by default\n\ncentos 9 stream should return virtio-blk\nhttps://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/centos.org/centos-stream-9.xml.in#L19\n\nbut we whould warn people not to use the libosinfo feature if they want to have dependibale behaivor.  libosinfo ocationally change the order of the elements which cna break people so if you care you shoudl set the values excplictly\n\nthe libosinfo feathre also requries you to misuse the image properties as it requires you to be ptu os_version in os_distro\n\nos_distro is ment to just be the name without a verion so ubuntu not ubuntu22.04\n\nim not sure if you want to put any of this in a note or not i just wanted to call out that the default in nova is virtio-blk if and only if you do not use teh libosinfo feature by contatianting the disto name and version into the os_distro filed","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5162637729b7b7a477dc6f108435118175cc4c6e","unresolved":true,"context_lines":[{"line_number":552,"context_line":"  ``virtio-scsi`` is a para-virtualized SCSI controller device that"},{"line_number":553,"context_line":"  provides improved scalability and performance, and supports advanced"},{"line_number":554,"context_line":"  SCSI hardware."},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"  Only supported by the libvirt driver."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"  One of:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d346bb68_181fbb12","line":555,"in_reply_to":"56a71e95_72e2f62c","updated":"2022-09-17 00:27:45.000000000","message":"You seem to know that feature quite well, would you like to amend the patch?","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"}],"etc/metadefs/compute-libvirt-image.json":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"acba5590a26e3f944cdb17513463a03268ff35e5","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"description\": \"Enables booting an ARM system using the specified machine type. By default, if an ARM image is used and its type is not specified, Compute uses vexpress-a15 (for ARMv7) or virt (for AArch64) machine types. Valid types can be viewed by using the virsh capabilities command (machine types are displayed in the machine tag).\","},{"line_number":63,"context_line":"            \"type\": \"string\""},{"line_number":64,"context_line":"        },"},{"line_number":65,"context_line":"        \"hw_scsi_model\": {"},{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Enables the use of VirtIO SCSI (virtio-scsi) to provide block device access for compute instances; by default, instances use VirtIO Block (virtio-blk). VirtIO SCSI is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","}],"source_content_type":"application/json","patch_set":4,"id":"80c4857f_1e5b40b2","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":23},"updated":"2022-09-16 01:49:28.000000000","message":"Should probably also update this metadef.","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5162637729b7b7a477dc6f108435118175cc4c6e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            \"description\": \"Enables booting an ARM system using the specified machine type. By default, if an ARM image is used and its type is not specified, Compute uses vexpress-a15 (for ARMv7) or virt (for AArch64) machine types. Valid types can be viewed by using the virsh capabilities command (machine types are displayed in the machine tag).\","},{"line_number":63,"context_line":"            \"type\": \"string\""},{"line_number":64,"context_line":"        },"},{"line_number":65,"context_line":"        \"hw_scsi_model\": {"},{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Enables the use of VirtIO SCSI (virtio-scsi) to provide block device access for compute instances; by default, instances use VirtIO Block (virtio-blk). VirtIO SCSI is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","}],"source_content_type":"application/json","patch_set":4,"id":"513aba76_b54af020","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":23},"in_reply_to":"60dcafa8_71d0a104","updated":"2022-09-17 00:27:45.000000000","message":"I also updated api-ref/source/v2/samples/metadef-properties-list-response.json","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63ec0e7b8e0b433b4c7ec66b7fda74464256ea9b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"description\": \"Enables booting an ARM system using the specified machine type. By default, if an ARM image is used and its type is not specified, Compute uses vexpress-a15 (for ARMv7) or virt (for AArch64) machine types. Valid types can be viewed by using the virsh capabilities command (machine types are displayed in the machine tag).\","},{"line_number":63,"context_line":"            \"type\": \"string\""},{"line_number":64,"context_line":"        },"},{"line_number":65,"context_line":"        \"hw_scsi_model\": {"},{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Enables the use of VirtIO SCSI (virtio-scsi) to provide block device access for compute instances; by default, instances use VirtIO Block (virtio-blk). VirtIO SCSI is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","}],"source_content_type":"application/json","patch_set":4,"id":"60dcafa8_71d0a104","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":23},"in_reply_to":"80c4857f_1e5b40b2","updated":"2022-09-16 09:59:20.000000000","message":"yes the metadefs are used to generate the text seen in horizon/heat so that should be updated.","commit_id":"e2ddcda10f017d25a48706e4d50a148c048ad945"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a9d9374ff21e84bfd1f4a0b6e9afaf79fc338147","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Specifies the use of a particular model of virtual SCSI controller to provide block device access for compute instances. By default in libvirt, no SCSI controller is provided and another bus will be used, e.g. the default for disks when ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as VirtIO Block or ``virtio-blk``.  ``virtio-scsi`` is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","},{"line_number":69,"context_line":"            \"default\": \"virtio-scsi\""},{"line_number":70,"context_line":"        },"},{"line_number":71,"context_line":"        \"hw_video_model\": {"},{"line_number":72,"context_line":"            \"title\": \"Video Model\","}],"source_content_type":"application/json","patch_set":5,"id":"50d64c30_34d4242a","line":69,"updated":"2023-07-12 02:18:06.000000000","message":"I think you need to add an enum here (like the one at lines 75-85 below) that includes the legal values mentioned on lines 560-566 in the RST file.","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b09e96fc7b23503bba7cd4069eb0ef75014d4fb","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Specifies the use of a particular model of virtual SCSI controller to provide block device access for compute instances. By default in libvirt, no SCSI controller is provided and another bus will be used, e.g. the default for disks when ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as VirtIO Block or ``virtio-blk``.  ``virtio-scsi`` is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","},{"line_number":69,"context_line":"            \"default\": \"virtio-scsi\""},{"line_number":70,"context_line":"        },"},{"line_number":71,"context_line":"        \"hw_video_model\": {"},{"line_number":72,"context_line":"            \"title\": \"Video Model\","}],"source_content_type":"application/json","patch_set":5,"id":"c897ef44_efae0f17","line":69,"in_reply_to":"50d64c30_34d4242a","updated":"2023-07-12 13:21:32.000000000","message":"Need or should have? Looking above some have this and some do not...","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8f3b57f693aeb21a6fea6d997b0c5920037a5ec5","unresolved":true,"context_lines":[{"line_number":66,"context_line":"            \"title\": \"SCSI Model\","},{"line_number":67,"context_line":"            \"description\": \"Specifies the use of a particular model of virtual SCSI controller to provide block device access for compute instances. By default in libvirt, no SCSI controller is provided and another bus will be used, e.g. the default for disks when ``hw_disk_bus`` is not set is the ``virtio`` bus, also known as VirtIO Block or ``virtio-blk``.  ``virtio-scsi`` is a para-virtualized SCSI controller device that provides improved scalability and performance, and supports advanced SCSI hardware.\","},{"line_number":68,"context_line":"            \"type\": \"string\","},{"line_number":69,"context_line":"            \"default\": \"virtio-scsi\""},{"line_number":70,"context_line":"        },"},{"line_number":71,"context_line":"        \"hw_video_model\": {"},{"line_number":72,"context_line":"            \"title\": \"Video Model\","}],"source_content_type":"application/json","patch_set":5,"id":"5b05ecab_4fffa3be","line":69,"in_reply_to":"c897ef44_efae0f17","updated":"2024-02-26 09:42:54.000000000","message":"so the default set is kind of problematic.\n\nthis property is in compute-libvirt-image but i belive its also used by the vmware driver and for vmware we also have some legacy names that have not been supproted in lik 8+ year excpept for the fact nova stilll has the translation code.\n \nso old vms would still work even if the image properties values should not be used.\n\nso if we were to make this an enum would we just list the valid libvirt values.\n\nreally the only thing this should ever be set to for libvirt is virtio-scsi\nall other values are not recommended so listing other values seams counter productive.\n\nhttps://github.com/openstack/nova/blob/065f6e1b51ffc8f15953270c98d225d9f5d15644/nova/objects/fields.py#L563-L585\n\nvmware uses internal mappings to vmware types\n\nhttps://github.com/openstack/nova/blob/065f6e1b51ffc8f15953270c98d225d9f5d15644/nova/virt/vmwareapi/images.py#L154-L168\n\nfixing all of the above feels like more effort then is actully warented.","commit_id":"aad1771864aa7e68edcf60076bb118ce46e4b055"}]}