)]}'
{"glance/tests/functional/test_rbd.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e92d5eed5c32174a63d49d03431a44d3ee1d550f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This test requires that a Ceph cluster is available, and"},{"line_number":22,"context_line":"a config file in a default location is available."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Note that this test "},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If a connection cannot be established, all the test cases are"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BeQ%3D","line":23,"updated":"2011-09-27 18:11:27.000000000","message":"Perhaps add a link to instructions on setting up a Ceph cluster here?","commit_id":"1855c4bdeccac1cdf68f9cad43988a69950455a7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e92d5eed5c32174a63d49d03431a44d3ee1d550f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"a config file in a default location is available."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Note that this test "},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If a connection cannot be established, all the test cases are"},{"line_number":27,"context_line":"skipped."},{"line_number":28,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BeU%3D","line":25,"updated":"2011-09-27 18:11:27.000000000","message":"Missing the end of this sentence? :) Also, whitespace at end of line.","commit_id":"1855c4bdeccac1cdf68f9cad43988a69950455a7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e92d5eed5c32174a63d49d03431a44d3ee1d550f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            self.inited \u003d True"},{"line_number":68,"context_line":"            return"},{"line_number":69,"context_line":"        cluster.shutdown()"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        try:"},{"line_number":72,"context_line":"            self.create_pool()"},{"line_number":73,"context_line":"        except rados.Error, e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BeE%3D","line":70,"updated":"2011-09-27 18:11:27.000000000","message":"I would add a block around all the code above this line with:\n\nif not self.inited:\n    # All the setup code...\n\nSo that each test case does not run the setup code again and again needlessly.","commit_id":"1855c4bdeccac1cdf68f9cad43988a69950455a7"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"d57f50e88dacff7d9fef0d40ecbffb948eb363c9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            self.disabled_message \u003d \"rados python library not found\""},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        cluster \u003d rados.Rados(conffile\u003dself.rbd_store_ceph_conf,"},{"line_number":81,"context_line":"                              rados_id\u003dself.rbd_store_user)"},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            cluster.connect()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAACX%2F%2F984%3D","line":80,"updated":"2011-09-29 20:37:48.000000000","message":"This line doesn\u0027t seem to work for me. Rados.__init__ isn\u0027t accepting \u0027conffile\u0027 as a keyword argument.","commit_id":"4b39088bca24f1832c9ea158a255e4f29631729a"}]}