)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"change_message_id":"132851c7c9d098e84b83da29333d4329a933c6b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable F821 check: undefined name \u0027name\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In glance/common/client.py in BaseClien class image_iterator()"},{"line_number":10,"context_line":"function returns instances of unexisting classes:"},{"line_number":11,"context_line":"- SendFileIterator"},{"line_number":12,"context_line":"- ImageBodyIterator"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2Fma0%3D","line":9,"updated":"2014-02-12 03:53:13.000000000","message":"\u0027BaseClien\u0027 -\u003e \u0027BaseClient\u0027","commit_id":"0d7d0be39f23e887e2ccd10386d9cb063ceed7e9"},{"author":{"_account_id":9533,"name":"Eiichi Aikawa","email":"aikawa@mxk.nes.nec.co.jp","username":"EiichiAikawa"},"change_message_id":"71a07526c4fcb6bb91c467513f659c0895d2f68b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Delete image_iterator() function."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Add changes to test_swift.py"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie1a8c66e5df2836e6e9aadfb1013d69fc6f710e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"AAAAVX%2F%2Fz04%3D","line":18,"updated":"2014-02-28 05:36:34.000000000","message":"This should be deleted.","commit_id":"fae05ed0c4d44b7b4a73d39c2afb21760c087571"}],"glance/db/simple/api.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"e6598925d1e16907e394c0db2836c9ff6046b029","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    if not updated:"},{"line_number":510,"context_line":"        msg \u003d (_(\"No location found with ID %(loc)s from image %(img)s\") %"},{"line_number":511,"context_line":"               dict(loc\u003dlocation_id, img\u003dimage_id))"},{"line_number":512,"context_line":"        LOG.warn(msg)"},{"line_number":513,"context_line":"        raise exception.NotFound(msg)"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_358d602b","side":"PARENT","line":511,"updated":"2014-07-23 13:06:55.000000000","message":"Nice catch! But there is no any information about this change in your commit message. may be It\u0027s better to do this change in separate patch set?","commit_id":"323aba66cf84470c5bf42742c86af4d33d32c57b"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2eed678ffb0a6f4e2946fc84da7d3b840e284c86","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    if not updated:"},{"line_number":510,"context_line":"        msg \u003d (_(\"No location found with ID %(loc)s from image %(img)s\") %"},{"line_number":511,"context_line":"               dict(loc\u003dlocation_id, img\u003dimage_id))"},{"line_number":512,"context_line":"        LOG.warn(msg)"},{"line_number":513,"context_line":"        raise exception.NotFound(msg)"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_d81d3b79","side":"PARENT","line":511,"in_reply_to":"baada198_358d602b","updated":"2014-07-23 13:29:42.000000000","message":"Hi Sergey! All these changes were made to enable F821 and to fix usage of unassigned variables (as written in commit message). That\u0027s why I combined them into one patch set. Please could you tell why it would be better to separate them?","commit_id":"323aba66cf84470c5bf42742c86af4d33d32c57b"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"53370a93b8d27508c9299b548210b308fb95d338","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    if not updated:"},{"line_number":510,"context_line":"        msg \u003d (_(\"No location found with ID %(loc)s from image %(img)s\") %"},{"line_number":511,"context_line":"               dict(loc\u003dlocation_id, img\u003dimage_id))"},{"line_number":512,"context_line":"        LOG.warn(msg)"},{"line_number":513,"context_line":"        raise exception.NotFound(msg)"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_a8abbc73","side":"PARENT","line":511,"in_reply_to":"baada198_d81d3b79","updated":"2014-07-24 05:49:23.000000000","message":"Oh, I\u0027m sorry. In commit message I\u0027m focused on deletion of method image_iterator() and unexisting classes. And I missed why you made this changes :( \nMy bad. Now of course +1. Well done!","commit_id":"323aba66cf84470c5bf42742c86af4d33d32c57b"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"e6598925d1e16907e394c0db2836c9ff6046b029","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        location_ref.save(session\u003dsession)"},{"line_number":797,"context_line":"    except sa_orm.exc.NoResultFound:"},{"line_number":798,"context_line":"        msg \u003d (_(\"No location found with ID %(loc)s from image %(img)s\") %"},{"line_number":799,"context_line":"               dict(loc\u003dlocation_id, img\u003dimage_id))"},{"line_number":800,"context_line":"        LOG.warn(msg)"},{"line_number":801,"context_line":"        raise exception.NotFound(msg)"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_959aac60","side":"PARENT","line":799,"updated":"2014-07-23 13:06:55.000000000","message":"same","commit_id":"323aba66cf84470c5bf42742c86af4d33d32c57b"}],"glance/store/swift.py":[{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"e6598925d1e16907e394c0db2836c9ff6046b029","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from glance.common import auth"},{"line_number":29,"context_line":"from glance.common import exception"},{"line_number":30,"context_line":"from glance.common import swift_store_utils"},{"line_number":31,"context_line":"from glance.common import utils"},{"line_number":32,"context_line":"from glance import i18n"},{"line_number":33,"context_line":"from glance.openstack.common import excutils"},{"line_number":34,"context_line":"import glance.openstack.common.log as logging"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_b53c1032","line":31,"updated":"2014-07-23 13:06:55.000000000","message":"nice catch too! But against, there is no information about this change in commit message. I think you should make separate patch to this change.","commit_id":"0c151d7d7ea00627fad182898958db55b1fef3fd"},{"author":{"_account_id":8127,"name":"Alexander Tivelkov","email":"locher@yandex.ru","username":"ativelkov"},"change_message_id":"c569cf0819cac9648408872125f2731cd6ade05d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from glance.common import auth"},{"line_number":29,"context_line":"from glance.common import exception"},{"line_number":30,"context_line":"from glance.common import swift_store_utils"},{"line_number":31,"context_line":"from glance.common import utils"},{"line_number":32,"context_line":"from glance import i18n"},{"line_number":33,"context_line":"from glance.openstack.common import excutils"},{"line_number":34,"context_line":"import glance.openstack.common.log as logging"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_3e718677","line":31,"in_reply_to":"baada198_b53c1032","updated":"2014-07-24 18:57:00.000000000","message":"This is also related to F821: utils module was not imported, so the utils.exception_to_str calls would cause runtime exceptions. This all falls under \"fix usage of undefined variables\" description. So this change should be part of this commit indeed.","commit_id":"0c151d7d7ea00627fad182898958db55b1fef3fd"}]}