)]}'
{"api-ref/source/v2/images-import.inc":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":263,"context_line":"  associated with the image.)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"- The body of your request must indicate that you are using the"},{"line_number":266,"context_line":"  ``copy-image`` import method, and it must contain the list of stores"},{"line_number":267,"context_line":"  where you want to copy your image."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- If body of your request contains ``all_stores_must_succeed`` (default to"},{"line_number":270,"context_line":"  True) and an error occurs during the copying in at least one store,"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"3fa7e38b_adee571d","line":267,"range":{"start_line":266,"start_character":36,"end_line":267,"end_character":36},"updated":"2020-02-11 14:04:25.000000000","message":"NIT: or \"all_stores\"?","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":263,"context_line":"  associated with the image.)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"- The body of your request must indicate that you are using the"},{"line_number":266,"context_line":"  ``copy-image`` import method, and it must contain the list of stores"},{"line_number":267,"context_line":"  where you want to copy your image."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- If body of your request contains ``all_stores_must_succeed`` (default to"},{"line_number":270,"context_line":"  True) and an error occurs during the copying in at least one store,"}],"source_content_type":"text/x-c++src","patch_set":16,"id":"3fa7e38b_c45a88f3","line":267,"range":{"start_line":266,"start_character":36,"end_line":267,"end_character":36},"in_reply_to":"3fa7e38b_adee571d","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- If body of your request contains ``all_stores_must_succeed`` (default to"},{"line_number":270,"context_line":"  True) and an error occurs during the copying in at least one store,"},{"line_number":271,"context_line":"  the request will be rejected, the data will be deleted from stores"},{"line_number":272,"context_line":"  where copying is done (not staging), and the state of the image"},{"line_number":273,"context_line":"  remains the same."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":16,"id":"3fa7e38b_4dc0037e","line":271,"range":{"start_line":271,"start_character":57,"end_line":271,"end_character":68},"updated":"2020-02-11 14:04:25.000000000","message":"NIT: maybe \"from the new stores\"","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"- If body of your request contains ``all_stores_must_succeed`` (default to"},{"line_number":270,"context_line":"  True) and an error occurs during the copying in at least one store,"},{"line_number":271,"context_line":"  the request will be rejected, the data will be deleted from stores"},{"line_number":272,"context_line":"  where copying is done (not staging), and the state of the image"},{"line_number":273,"context_line":"  remains the same."},{"line_number":274,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":16,"id":"3fa7e38b_646b9485","line":271,"range":{"start_line":271,"start_character":57,"end_line":271,"end_character":68},"in_reply_to":"3fa7e38b_4dc0037e","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"}],"glance/api/v2/images.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                msg \u003d _(\"Image with status active cannot be target for import\")"},{"line_number":114,"context_line":"                raise exception.Conflict(msg)"},{"line_number":115,"context_line":"            if image.status !\u003d \u0027active\u0027 and import_method \u003d\u003d \"copy-image\":"},{"line_number":116,"context_line":"                msg \u003d _(\"Only images with status active will be targeted for \""},{"line_number":117,"context_line":"                        \"copying\")"},{"line_number":118,"context_line":"                raise exception.Conflict(msg)"},{"line_number":119,"context_line":"            if image.status !\u003d \u0027queued\u0027 and import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_4d456315","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":63},"updated":"2020-02-11 14:04:25.000000000","message":"NIT: \"can be\"","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                msg \u003d _(\"Image with status active cannot be target for import\")"},{"line_number":114,"context_line":"                raise exception.Conflict(msg)"},{"line_number":115,"context_line":"            if image.status !\u003d \u0027active\u0027 and import_method \u003d\u003d \"copy-image\":"},{"line_number":116,"context_line":"                msg \u003d _(\"Only images with status active will be targeted for \""},{"line_number":117,"context_line":"                        \"copying\")"},{"line_number":118,"context_line":"                raise exception.Conflict(msg)"},{"line_number":119,"context_line":"            if image.status !\u003d \u0027queued\u0027 and import_method \u003d\u003d \u0027web-download\u0027:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_79e01d94","line":116,"range":{"start_line":116,"start_character":56,"end_line":116,"end_character":63},"in_reply_to":"3fa7e38b_4d456315","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            if not getattr(image, \u0027disk_format\u0027, None):"},{"line_number":132,"context_line":"                msg \u003d _(\"\u0027disk_format\u0027 needs to be set before import\")"},{"line_number":133,"context_line":"                raise exception.Conflict(msg)"},{"line_number":134,"context_line":"            if import_method \u003d\u003d \"copy-image\" and body.get(\u0027all_stores\u0027):"},{"line_number":135,"context_line":"                msg \u003d _(\"\u0027all_stores\u0027 is not accepted for copying the image\")"},{"line_number":136,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            stores \u003d [None]"},{"line_number":139,"context_line":"            if CONF.enabled_backends:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_cd5ab3f3","line":136,"range":{"start_line":134,"start_character":12,"end_line":136,"end_character":63},"updated":"2020-02-11 14:04:25.000000000","message":"Why this?","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            if not getattr(image, \u0027disk_format\u0027, None):"},{"line_number":132,"context_line":"                msg \u003d _(\"\u0027disk_format\u0027 needs to be set before import\")"},{"line_number":133,"context_line":"                raise exception.Conflict(msg)"},{"line_number":134,"context_line":"            if import_method \u003d\u003d \"copy-image\" and body.get(\u0027all_stores\u0027):"},{"line_number":135,"context_line":"                msg \u003d _(\"\u0027all_stores\u0027 is not accepted for copying the image\")"},{"line_number":136,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            stores \u003d [None]"},{"line_number":139,"context_line":"            if CONF.enabled_backends:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_f9240dc6","line":136,"range":{"start_line":134,"start_character":12,"end_line":136,"end_character":63},"in_reply_to":"3fa7e38b_cd5ab3f3","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aa28e77c7543bd1209d7cdb209792749c16a5376","unresolved":false,"context_lines":[{"line_number":40,"context_line":"from glance.common import wsgi"},{"line_number":41,"context_line":"import glance.db"},{"line_number":42,"context_line":"import glance.gateway"},{"line_number":43,"context_line":"from glance.i18n import _, _LI, _LW"},{"line_number":44,"context_line":"import glance.notifier"},{"line_number":45,"context_line":"import glance.schema"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3fa7e38b_11044e12","line":43,"range":{"start_line":43,"start_character":27,"end_line":43,"end_character":30},"updated":"2020-02-12 15:25:48.000000000","message":"I\u0027d really rather we don\u0027t add more use of these noop\u0027s, but not a big deal.\n\nStill think we should just take the time to clean all of these _Lx out of here to clean things up.","commit_id":"1754c9e2b085ba0fc37a4369488c92a40268997a"}],"glance/async_/flows/_internal_plugins/copy_image.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"59d87e878eb95a36f5922c49b458386c7ae107c1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":50,"context_line":"        image_copied \u003d False"},{"line_number":51,"context_line":"        path \u003d \"\""},{"line_number":52,"context_line":"        for loc in image.locations:"},{"line_number":53,"context_line":"            if loc[\u0027url\u0027].startswith(\"file://\"):"},{"line_number":54,"context_line":"                path \u003d self._copy_to_staging_store(loc)"},{"line_number":55,"context_line":"                image_copied \u003d True"},{"line_number":56,"context_line":"                break"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if not image_copied:"},{"line_number":59,"context_line":"            for loc in image.locations:"},{"line_number":60,"context_line":"                path \u003d self._copy_to_staging_store(loc)"},{"line_number":61,"context_line":"                break"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return path"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4cfcf771","line":61,"range":{"start_line":52,"start_character":0,"end_line":61,"end_character":21},"updated":"2019-12-01 12:32:06.000000000","message":"I think we need quite a bit more logic here. I\u0027d prefer us to pick up from the node default store if the image is in there, otherwise we need to compare the locations and storeIDs known to the host, specially as the _copy_to_staging_store has no failure tolerance what so ever and we just break off the loop.","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a522c90587edb6a062c0f61537a90f0f349ea45","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":50,"context_line":"        image_copied \u003d False"},{"line_number":51,"context_line":"        path \u003d \"\""},{"line_number":52,"context_line":"        for loc in image.locations:"},{"line_number":53,"context_line":"            if loc[\u0027url\u0027].startswith(\"file://\"):"},{"line_number":54,"context_line":"                path \u003d self._copy_to_staging_store(loc)"},{"line_number":55,"context_line":"                image_copied \u003d True"},{"line_number":56,"context_line":"                break"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if not image_copied:"},{"line_number":59,"context_line":"            for loc in image.locations:"},{"line_number":60,"context_line":"                path \u003d self._copy_to_staging_store(loc)"},{"line_number":61,"context_line":"                break"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        return path"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f21818ce","line":61,"range":{"start_line":52,"start_character":0,"end_line":61,"end_character":21},"in_reply_to":"3fa7e38b_4cfcf771","updated":"2019-12-02 07:30:37.000000000","message":"Agree!!\n\nI will first check with the default_backend and then will iterated through conf.enabled_backends which will give us access to node specific stores.","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                try:"},{"line_number":69,"context_line":"                    return self._copy_to_staging_store(loc)"},{"line_number":70,"context_line":"                except store_api.exceptions.NotFound:"},{"line_number":71,"context_line":"                    msg \u003d _(\"Image not present in default store, searching \""},{"line_number":72,"context_line":"                            \"in all glance-api specific available backends\")"},{"line_number":73,"context_line":"                    LOG.debug(msg)"},{"line_number":74,"context_line":"                    break"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        available_backends \u003d CONF.enabled_backends"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_adb17702","line":73,"range":{"start_line":71,"start_character":20,"end_line":73,"end_character":34},"updated":"2020-02-11 14:04:25.000000000","message":"This needs to be much higher than debug. After all we have image record that should be in the store, but the data is not found. ERROR or even CRITICAL, we are talking about potential dataloss here. (and debug messages should not be translated)","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                try:"},{"line_number":69,"context_line":"                    return self._copy_to_staging_store(loc)"},{"line_number":70,"context_line":"                except store_api.exceptions.NotFound:"},{"line_number":71,"context_line":"                    msg \u003d _(\"Image not present in default store, searching \""},{"line_number":72,"context_line":"                            \"in all glance-api specific available backends\")"},{"line_number":73,"context_line":"                    LOG.debug(msg)"},{"line_number":74,"context_line":"                    break"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        available_backends \u003d CONF.enabled_backends"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_646154d4","line":73,"range":{"start_line":71,"start_character":20,"end_line":73,"end_character":34},"in_reply_to":"3fa7e38b_adb17702","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    and image_backend !\u003d default_store):"},{"line_number":81,"context_line":"                try:"},{"line_number":82,"context_line":"                    return self._copy_to_staging_store(loc)"},{"line_number":83,"context_line":"                except store_api.exceptions.NotFound:"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        raise exception.NotFound(_(\"Image not found in any configured \""},{"line_number":87,"context_line":"                                   \"backend\"))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_cd9b9376","line":84,"range":{"start_line":83,"start_character":16,"end_line":84,"end_character":28},"updated":"2020-02-11 14:04:25.000000000","message":"Ditto","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    and image_backend !\u003d default_store):"},{"line_number":81,"context_line":"                try:"},{"line_number":82,"context_line":"                    return self._copy_to_staging_store(loc)"},{"line_number":83,"context_line":"                except store_api.exceptions.NotFound:"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        raise exception.NotFound(_(\"Image not found in any configured \""},{"line_number":87,"context_line":"                                   \"backend\"))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_e4830454","line":84,"range":{"start_line":83,"start_character":16,"end_line":84,"end_character":28},"in_reply_to":"3fa7e38b_cd9b9376","updated":"2020-02-11 18:06:35.000000000","message":"Here we are iterating through all existing image locations if image is not present in default store, so if image is not present at any existing locations then I am throwing NotFound exception at line #86\n\nIf I log error here then suppose there are 5 stores and if image is not present in default store then it will log error message for all 4 stores. Do we really want this?","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"288f53518c7cae4304af61a09ca092f5e1aa5a86","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    and image_backend !\u003d default_store):"},{"line_number":81,"context_line":"                try:"},{"line_number":82,"context_line":"                    return self._copy_to_staging_store(loc)"},{"line_number":83,"context_line":"                except store_api.exceptions.NotFound:"},{"line_number":84,"context_line":"                    continue"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        raise exception.NotFound(_(\"Image not found in any configured \""},{"line_number":87,"context_line":"                                   \"backend\"))"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_94091b84","line":84,"range":{"start_line":83,"start_character":16,"end_line":84,"end_character":28},"in_reply_to":"3fa7e38b_e4830454","updated":"2020-02-11 21:42:12.000000000","message":"If the image is not in a store where we have location record, then yes as that indicates that there is data loss in the deployment. We can have this as follow up \u0027though for getting milestone 2 out with this patch","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"945bdc8e5442f00de2cedf1f1bd0dcdb2f08e17e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def _copy_to_staging_store(self, loc):"},{"line_number":90,"context_line":"        store_backend \u003d loc[\u0027metadata\u0027].get(\u0027store\u0027)"},{"line_number":91,"context_line":"        image_data, size \u003d store_api.get(loc[\u0027url\u0027], store_backend)"},{"line_number":92,"context_line":"        msg \u003d (_(\"Found image, copying it in staging area\"))"},{"line_number":93,"context_line":"        LOG.debug(msg)"},{"line_number":94,"context_line":"        return self.staging_store.add(self.image_id, image_data, size)[0]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_8d8fdb1f","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":17},"updated":"2020-02-11 14:04:25.000000000","message":"debug messages should not be translated.","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b94d8d126279cb527b565602a48cc389d741a421","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def _copy_to_staging_store(self, loc):"},{"line_number":90,"context_line":"        store_backend \u003d loc[\u0027metadata\u0027].get(\u0027store\u0027)"},{"line_number":91,"context_line":"        image_data, size \u003d store_api.get(loc[\u0027url\u0027], store_backend)"},{"line_number":92,"context_line":"        msg \u003d (_(\"Found image, copying it in staging area\"))"},{"line_number":93,"context_line":"        LOG.debug(msg)"},{"line_number":94,"context_line":"        return self.staging_store.add(self.image_id, image_data, size)[0]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_449218a2","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":17},"in_reply_to":"3fa7e38b_8d8fdb1f","updated":"2020-02-11 18:06:35.000000000","message":"Done","commit_id":"73b0db773ef7c8b9ddd91558875f1379bdae9f1a"}],"glance/async_/flows/api_image_import.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"59d87e878eb95a36f5922c49b458386c7ae107c1","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    else:"},{"line_number":363,"context_line":"        file_uri \u003d uri"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":366,"context_line":"        copy_to_staging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":367,"context_line":"        flow.add(copy_to_staging)"},{"line_number":368,"context_line":"        separator, staging_dir \u003d _get_dir_separator()"},{"line_number":369,"context_line":"        file_uri \u003d separator.join((staging_dir, str(image_id)))"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    flow.add(_VerifyStaging(task_id, task_type, task_repo, file_uri))"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ec1843ce","line":369,"range":{"start_line":365,"start_character":0,"end_line":369,"end_character":63},"updated":"2019-12-01 12:32:06.000000000","message":"is there a difference on the above or need to duplicate this?","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a522c90587edb6a062c0f61537a90f0f349ea45","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    else:"},{"line_number":363,"context_line":"        file_uri \u003d uri"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    if import_method \u003d\u003d \u0027copy-image\u0027:"},{"line_number":366,"context_line":"        copy_to_staging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":367,"context_line":"        flow.add(copy_to_staging)"},{"line_number":368,"context_line":"        separator, staging_dir \u003d _get_dir_separator()"},{"line_number":369,"context_line":"        file_uri \u003d separator.join((staging_dir, str(image_id)))"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    flow.add(_VerifyStaging(task_id, task_type, task_repo, file_uri))"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b27860f7","line":369,"range":{"start_line":365,"start_character":0,"end_line":369,"end_character":63},"in_reply_to":"3fa7e38b_ec1843ce","updated":"2019-12-02 07:30:37.000000000","message":"Nope, will change the above condition and rename the varaible to more meaningful name.","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"}],"glance/domain/__init__.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"59d87e878eb95a36f5922c49b458386c7ae107c1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \u0027saving\u0027: (\u0027active\u0027, \u0027killed\u0027, \u0027deleted\u0027, \u0027queued\u0027),"},{"line_number":115,"context_line":"        \u0027uploading\u0027: (\u0027importing\u0027, \u0027queued\u0027, \u0027deleted\u0027),"},{"line_number":116,"context_line":"        \u0027importing\u0027: (\u0027active\u0027, \u0027deleted\u0027, \u0027queued\u0027),"},{"line_number":117,"context_line":"        \u0027active\u0027: (\u0027pending_delete\u0027, \u0027deleted\u0027, \u0027deactivated\u0027, \u0027importing\u0027),"},{"line_number":118,"context_line":"        \u0027killed\u0027: (\u0027deleted\u0027,),"},{"line_number":119,"context_line":"        \u0027pending_delete\u0027: (\u0027deleted\u0027, \u0027active\u0027),"},{"line_number":120,"context_line":"        \u0027deleted\u0027: (),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ccd6a7f3","line":117,"updated":"2019-12-01 12:32:06.000000000","message":"I don\u0027t think we should do this. It will block the consumption of the image while it\u0027s being copied with no reason.","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a522c90587edb6a062c0f61537a90f0f349ea45","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        \u0027saving\u0027: (\u0027active\u0027, \u0027killed\u0027, \u0027deleted\u0027, \u0027queued\u0027),"},{"line_number":115,"context_line":"        \u0027uploading\u0027: (\u0027importing\u0027, \u0027queued\u0027, \u0027deleted\u0027),"},{"line_number":116,"context_line":"        \u0027importing\u0027: (\u0027active\u0027, \u0027deleted\u0027, \u0027queued\u0027),"},{"line_number":117,"context_line":"        \u0027active\u0027: (\u0027pending_delete\u0027, \u0027deleted\u0027, \u0027deactivated\u0027, \u0027importing\u0027),"},{"line_number":118,"context_line":"        \u0027killed\u0027: (\u0027deleted\u0027,),"},{"line_number":119,"context_line":"        \u0027pending_delete\u0027: (\u0027deleted\u0027, \u0027active\u0027),"},{"line_number":120,"context_line":"        \u0027deleted\u0027: (),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_527facde","line":117,"in_reply_to":"3fa7e38b_ccd6a7f3","updated":"2019-12-02 07:30:37.000000000","message":"Ok, need to add more conditioning in the code to achieve this.","commit_id":"944538eb6aeebd1367715438e16703f44131f4ca"}],"glance/tests/unit/test_store_image.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"59d87e878eb95a36f5922c49b458386c7ae107c1","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                          \u0027YYYY\u0027, 4, backend\u003d[\u0027ceph1\u0027, \u0027ceph2\u0027])"},{"line_number":234,"context_line":"        call1 \u003d mock.call(\u0027rbd://ceph1\u0027, \u0027ceph1\u0027, context\u003dcontext)"},{"line_number":235,"context_line":"        call2 \u003d mock.call(\u0027rbd://ceph2\u0027, \u0027ceph2\u0027, context\u003dcontext)"},{"line_number":236,"context_line":"        store_api.delete.assert_has_calls([call1, call2])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class TestStoreImage(utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ecd123fa","side":"PARENT","line":236,"updated":"2019-12-01 12:32:06.000000000","message":"Why this test change?","commit_id":"17664ec6d92c5e133c8eed98fb4a80fb350b7d2e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a522c90587edb6a062c0f61537a90f0f349ea45","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                          \u0027YYYY\u0027, 4, backend\u003d[\u0027ceph1\u0027, \u0027ceph2\u0027])"},{"line_number":234,"context_line":"        call1 \u003d mock.call(\u0027rbd://ceph1\u0027, \u0027ceph1\u0027, context\u003dcontext)"},{"line_number":235,"context_line":"        call2 \u003d mock.call(\u0027rbd://ceph2\u0027, \u0027ceph2\u0027, context\u003dcontext)"},{"line_number":236,"context_line":"        store_api.delete.assert_has_calls([call1, call2])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"class TestStoreImage(utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d21ddcbe","side":"PARENT","line":236,"in_reply_to":"3fa7e38b_ecd123fa","updated":"2019-12-02 07:30:37.000000000","message":"Mistake, kindly Ignore :D","commit_id":"17664ec6d92c5e133c8eed98fb4a80fb350b7d2e"}]}