)]}'
{"glance/tests/unit/v2/test_image_data_resource.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b5b817b93f51850ba66f1ec5745fa4fbb07d6e70","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                          request, unit_test_utils.UUID2, \u0027YY\u0027, 2)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @mock.patch(\"glance.common.trust_auth.TokenRefresher\")"},{"line_number":376,"context_line":"    def test_upload_with_trusts(self, mock_refresher):"},{"line_number":377,"context_line":"        \"\"\"Test that uploading with registry correctly uses trusts\"\"\""},{"line_number":378,"context_line":"        # initialize trust environment"},{"line_number":379,"context_line":"        self.config(data_api\u003d\u0027glance.db.registry.api\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2fda29e5","side":"PARENT","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":31},"updated":"2019-12-12 15:32:15.000000000","message":"Do we actually test this somewhere without registry? By quick eyeballing couldn\u0027t find it at least from this file.","commit_id":"3011551dfa70e8bd8c63959b93a6765619f0768b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"67596017bb844ebf2c008754d3d87ade9b17e111","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                          request, unit_test_utils.UUID2, \u0027YY\u0027, 2)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @mock.patch(\"glance.common.trust_auth.TokenRefresher\")"},{"line_number":376,"context_line":"    def test_upload_with_trusts(self, mock_refresher):"},{"line_number":377,"context_line":"        \"\"\"Test that uploading with registry correctly uses trusts\"\"\""},{"line_number":378,"context_line":"        # initialize trust environment"},{"line_number":379,"context_line":"        self.config(data_api\u003d\u0027glance.db.registry.api\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7b0c55ea","side":"PARENT","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":31},"in_reply_to":"3fa7e38b_2fda29e5","updated":"2019-12-13 06:18:56.000000000","message":"Nope we are not testing this without registry.","commit_id":"3011551dfa70e8bd8c63959b93a6765619f0768b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"103242def06da52f337e2cff59e204dee173bcb3","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                          request, unit_test_utils.UUID2, \u0027YY\u0027, 2)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    @mock.patch(\"glance.common.trust_auth.TokenRefresher\")"},{"line_number":376,"context_line":"    def test_upload_with_trusts(self, mock_refresher):"},{"line_number":377,"context_line":"        \"\"\"Test that uploading with registry correctly uses trusts\"\"\""},{"line_number":378,"context_line":"        # initialize trust environment"},{"line_number":379,"context_line":"        self.config(data_api\u003d\u0027glance.db.registry.api\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7b6a15ec","side":"PARENT","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":31},"in_reply_to":"3fa7e38b_7b0c55ea","updated":"2019-12-13 06:40:09.000000000","message":"Trust mechanism is implemented to work with registry only;\nhttps://review.opendev.org/#/c/241986/","commit_id":"3011551dfa70e8bd8c63959b93a6765619f0768b"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b5b817b93f51850ba66f1ec5745fa4fbb07d6e70","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        self.assertEqual(\"fake_token\", request.context.auth_token)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @mock.patch(\"glance.common.trust_auth.TokenRefresher\")"},{"line_number":412,"context_line":"    def test_upload_with_trusts_fails(self, mock_refresher):"},{"line_number":413,"context_line":"        \"\"\"Test upload with registry if trust was not successfully created\"\"\""},{"line_number":414,"context_line":"        # initialize trust environment"},{"line_number":415,"context_line":"        self.config(data_api\u003d\u0027glance.db.registry.api\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8fe47da9","side":"PARENT","line":412,"range":{"start_line":412,"start_character":8,"end_line":412,"end_character":37},"updated":"2019-12-12 15:32:15.000000000","message":"ditto","commit_id":"3011551dfa70e8bd8c63959b93a6765619f0768b"}],"glance/tests/unit/v2/test_tasks_resource.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"67596017bb844ebf2c008754d3d87ade9b17e111","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        }"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        new_task \u003d self.controller.create(request, task\u003dtask)"},{"line_number":356,"context_line":"        executor_factory \u003d self.gateway.get_task_executor_factory("},{"line_number":357,"context_line":"            request.context)"},{"line_number":358,"context_line":"        task_executor \u003d executor_factory.new_task_executor(request.context)"},{"line_number":359,"context_line":"        task_executor.begin_processing(new_task.task_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1b7c411e","line":356,"range":{"start_line":356,"start_character":8,"end_line":356,"end_character":49},"updated":"2019-12-13 06:18:56.000000000","message":"IMO if we mock this method then we will not be able to calculate the live time and this test case will be meaningless.","commit_id":"bdaca77c1f78804f8f795d193b6ac29a3c384fc9"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b5b817b93f51850ba66f1ec5745fa4fbb07d6e70","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        }"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        new_task \u003d self.controller.create(request, task\u003dtask)"},{"line_number":356,"context_line":"        executor_factory \u003d self.gateway.get_task_executor_factory("},{"line_number":357,"context_line":"            request.context)"},{"line_number":358,"context_line":"        task_executor \u003d executor_factory.new_task_executor(request.context)"},{"line_number":359,"context_line":"        task_executor.begin_processing(new_task.task_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_67b045fe","line":356,"range":{"start_line":356,"start_character":40,"end_line":356,"end_character":65},"updated":"2019-12-12 15:32:15.000000000","message":"This is most likely what is causing the errors. Why it surfaces only after removing the registry bits from testing I have no idea, there is probably something that gets mocked in a way that is masks the fact the task executor can\u0027t reach database which is not using the simple db as the gateway initializes the db bits on it\u0027s own instead using the test class defined connectors.","commit_id":"bdaca77c1f78804f8f795d193b6ac29a3c384fc9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ddc69d3acf86f3bfaf36050e4feac93b7701ef5c","unresolved":false,"context_lines":[{"line_number":336,"context_line":"    @mock.patch(\u0027glance.common.scripts.utils.validate_location_uri\u0027)"},{"line_number":337,"context_line":"    def test_create_with_live_time(self, mock_validate_location_uri,"},{"line_number":338,"context_line":"                                   mock_get_image_data_iter):"},{"line_number":339,"context_line":"        self.skipTest(\"Something wrong, this test touches registry\")"},{"line_number":340,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":341,"context_line":"        task \u003d {"},{"line_number":342,"context_line":"            \"type\": \"import\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_23e60fb1","line":339,"updated":"2020-02-10 13:24:40.000000000","message":"This makes me wonder if we should do an audit of all the TODOs and skipTests in the code and see if there is further work needed to clean things up. In general, not just related to registry removal.","commit_id":"b55c0a31c07992469e2cb436d45d92ba92a42de2"}]}