)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"db5b68db6db81ca76c2cf3efa28db4b3a8370e42","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":685,"context_line":"            \u0027description\u0027: _(\u0027Format of the disk\u0027),"},{"line_number":686,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":687,"context_line":"            \u0027enum\u0027: CONF.image_format.disk_formats,"},{"line_number":688,"context_line":"        },"},{"line_number":689,"context_line":"        \u0027created_at\u0027: {"},{"line_number":690,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9xuk%3D","line":687,"updated":"2014-02-04 02:48:53.000000000","message":"I think we need to add \u0027owner\u0027 in these properties somewhere as well.","commit_id":"7a247d55efa4ab0eafc34fc1ca8fc37346b2eee5"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"735e7511020e01eeb7deeb90b8635ce12a3a946d","unresolved":false,"context_lines":[{"line_number":684,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":685,"context_line":"            \u0027description\u0027: _(\u0027Format of the disk\u0027),"},{"line_number":686,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":687,"context_line":"            \u0027enum\u0027: CONF.image_format.disk_formats,"},{"line_number":688,"context_line":"        },"},{"line_number":689,"context_line":"        \u0027created_at\u0027: {"},{"line_number":690,"context_line":"            \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9xro%3D","line":687,"in_reply_to":"AAAAUH%2F9xuk%3D","updated":"2014-02-04 03:02:25.000000000","message":"Oops, yep. Will add it in the next PS. Thanks, Mark.","commit_id":"7a247d55efa4ab0eafc34fc1ca8fc37346b2eee5"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"06b5173027c3b8d6828cc1bcdd7928dba52ce03c","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        },"},{"line_number":669,"context_line":"        \u0027owner\u0027: {"},{"line_number":670,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":671,"context_line":"            \u0027description\u0027: _(\u0027Owner of the image\u0027),"},{"line_number":672,"context_line":"        },"},{"line_number":673,"context_line":"        \u0027size\u0027: {"},{"line_number":674,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9tok%3D","line":671,"updated":"2014-02-04 18:45:21.000000000","message":"Consistency would suggest putting a max length here, though I\u0027m not sure if its completely necessary and I\u0027m not sure exactly what the right limit would be. I suppose we can use the column length in the sqlalchemy db (\u003c\u003d255) or something less that still definitely fits uuids (\u003e\u003d 36).","commit_id":"001f69655ac3956edea5c2be6b63de64659d41b0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5477147ba3d52295dd2427f6fd1c8705573d26af","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        },"},{"line_number":669,"context_line":"        \u0027owner\u0027: {"},{"line_number":670,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":671,"context_line":"            \u0027description\u0027: _(\u0027Owner of the image\u0027),"},{"line_number":672,"context_line":"        },"},{"line_number":673,"context_line":"        \u0027size\u0027: {"},{"line_number":674,"context_line":"            \u0027type\u0027: \u0027integer\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F9sLk%3D","line":671,"in_reply_to":"AAAAUH%2F9tok%3D","updated":"2014-02-04 23:18:05.000000000","message":"I prefer to use the column length in the sqlalchemy db, since for now we\u0027re not checking if the owner is a real tenant/project id or not. And I think we can improve this in the future if it\u0027s necessary.","commit_id":"001f69655ac3956edea5c2be6b63de64659d41b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c940a0239e3d0e34ffc24e93f12df66a349c1cf","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        },"},{"line_number":669,"context_line":"        \u0027owner\u0027: {"},{"line_number":670,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":671,"context_line":"            \u0027description\u0027: _(\u0027Owner of the image\u0027),"},{"line_number":672,"context_line":"            \u0027maxLength\u0027: 255,"},{"line_number":673,"context_line":"        },"},{"line_number":674,"context_line":"        \u0027size\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9n4M%3D","line":671,"updated":"2014-02-05 15:40:56.000000000","message":"I think this should be marked as READ-ONLY in the description (like the checksum field, above).","commit_id":"6ddc991c8376f063f178bb0d5ee2afd7fc920e1b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"39c011cecebf16987f3439385fd2d9423eef10cf","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        },"},{"line_number":669,"context_line":"        \u0027owner\u0027: {"},{"line_number":670,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":671,"context_line":"            \u0027description\u0027: _(\u0027Owner of the image\u0027),"},{"line_number":672,"context_line":"            \u0027maxLength\u0027: 255,"},{"line_number":673,"context_line":"        },"},{"line_number":674,"context_line":"        \u0027size\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9k4o%3D","line":671,"in_reply_to":"AAAAUH%2F9l4o%3D","updated":"2014-02-05 22:40:12.000000000","message":"You\u0027re right, an admin should be able to change this, it\u0027s not \"really\" read-only.  I withdraw my objection.","commit_id":"6ddc991c8376f063f178bb0d5ee2afd7fc920e1b"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"0da997c19634a1a07f81716d78899d52be554c44","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        },"},{"line_number":669,"context_line":"        \u0027owner\u0027: {"},{"line_number":670,"context_line":"            \u0027type\u0027: \u0027string\u0027,"},{"line_number":671,"context_line":"            \u0027description\u0027: _(\u0027Owner of the image\u0027),"},{"line_number":672,"context_line":"            \u0027maxLength\u0027: 255,"},{"line_number":673,"context_line":"        },"},{"line_number":674,"context_line":"        \u0027size\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9l4o%3D","line":671,"in_reply_to":"AAAAUH%2F9n4M%3D","updated":"2014-02-05 19:49:38.000000000","message":"Good point. But can an admin set it? Silly one-size-fits-all schemas :-(","commit_id":"6ddc991c8376f063f178bb0d5ee2afd7fc920e1b"}]}