)]}'
{"glance/registry/db/migrate_repo/versions/015_quote_swift_credentials.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"35acf00f1b36c67c5d22eca514208e4cdfda2a23","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    return location.get_uri()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def legacy__get_credstring(self):"},{"line_number":86,"context_line":"    if self.user:"},{"line_number":87,"context_line":"        return \u0027%s:%s@\u0027 % (self.user, self.key)"},{"line_number":88,"context_line":"    return \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F7do%3D","line":85,"updated":"2012-05-15 21:26:30.000000000","message":"Why the double-underscore?","commit_id":"48da419bf542df17d543132680639c5178202d8a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"19c31908676840f5fd3da0410bf482f1c6b0bb92","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    return location.get_uri()"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def legacy__get_credstring(self):"},{"line_number":86,"context_line":"    if self.user:"},{"line_number":87,"context_line":"        return \u0027%s:%s@\u0027 % (self.user, self.key)"},{"line_number":88,"context_line":"    return \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F7dQ%3D","line":85,"in_reply_to":"AAAAHX%2F%2F7do%3D","updated":"2012-05-15 21:35:22.000000000","message":"The legacy functions are prefixed with legacy_ and the original method name is _get_credstring.","commit_id":"48da419bf542df17d543132680639c5178202d8a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"36f66a9c5f88786e07488d54441750af5092fa06","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def legacy_parse_uri(self, uri):"},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    Parse URLs. This method fixes an issue where credentials specified"},{"line_number":94,"context_line":"    in the URL are interpreted differently in Python 2.6.1+ than prior"},{"line_number":95,"context_line":"    versions of Python. It also deals with the peculiarity that new-style"},{"line_number":96,"context_line":"    Swift URIs have where a username can contain a \u0027:\u0027, like so:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHX%2F%2F7bg%3D","line":93,"updated":"2012-05-15 22:05:35.000000000","message":"it sounds wrong to use URI in the code and URL in the doc string, especially when there are slight differences between the two. I know that you copied and pasted the code, but maybe you could consider to fix this femto nit, both here and in swift.py?","commit_id":"0793eb011e5eff4a217900b7a66a12a79a2871f3"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"04dcdfbf00b9f214e7bddac163541b9cec094921","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def legacy_parse_uri(self, uri):"},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    Parse URLs. This method fixes an issue where credentials specified"},{"line_number":94,"context_line":"    in the URL are interpreted differently in Python 2.6.1+ than prior"},{"line_number":95,"context_line":"    versions of Python. It also deals with the peculiarity that new-style"},{"line_number":96,"context_line":"    Swift URIs have where a username can contain a \u0027:\u0027, like so:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAHX%2F%2F7aQ%3D","line":93,"in_reply_to":"AAAAHX%2F%2F7bg%3D","updated":"2012-05-15 22:46:17.000000000","message":"I\u0027ll fix it, but not as part of this change.","commit_id":"0793eb011e5eff4a217900b7a66a12a79a2871f3"}],"glance/tests/unit/test_store_location.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"35acf00f1b36c67c5d22eca514208e4cdfda2a23","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.assertEqual(\"pass\", loc.key)"},{"line_number":173,"context_line":"        self.assertEqual(uri, loc.get_uri())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        uri \u003d \"\"\""},{"line_number":176,"context_line":"swift+http://a%3Auser%40example.com:p%40ss@authurl.com/v1/container/12345"},{"line_number":177,"context_line":"\"\"\".strip()"},{"line_number":178,"context_line":"        loc.parse_uri(uri)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F78Q%3D","line":175,"updated":"2012-05-15 21:26:30.000000000","message":"I know this is legal, but its pretty ugly. Just do this:\n\n uri \u003d (\u0027swift+http://account:user:pass@authurl.com/\u0027\n        \u0027v1/container/12345\u0027)","commit_id":"48da419bf542df17d543132680639c5178202d8a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"19c31908676840f5fd3da0410bf482f1c6b0bb92","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        self.assertEqual(\"pass\", loc.key)"},{"line_number":173,"context_line":"        self.assertEqual(uri, loc.get_uri())"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        uri \u003d \"\"\""},{"line_number":176,"context_line":"swift+http://a%3Auser%40example.com:p%40ss@authurl.com/v1/container/12345"},{"line_number":177,"context_line":"\"\"\".strip()"},{"line_number":178,"context_line":"        loc.parse_uri(uri)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F7dM%3D","line":175,"in_reply_to":"AAAAHX%2F%2F78Q%3D","updated":"2012-05-15 21:35:22.000000000","message":"Done.","commit_id":"48da419bf542df17d543132680639c5178202d8a"}]}