)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a389ccd99bc8fcbd9494d0172792a24746d3725a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix reloading under PY3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is not direct backport of I361c9d0b53a67b1cc60f0f3012e22accdcc46055"},{"line_number":10,"context_line":"but rather adaptation of it to facilitate SSL/TLS termination under"},{"line_number":11,"context_line":"py27."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_3b92d9f7","line":9,"updated":"2020-03-18 19:32:41.000000000","message":"Generally best to still do the cherry pick, with the included cherry-pick footer information in the commit message, then call out where there were conflicts and modifications to account for stable branch specific changes.","commit_id":"1afeb8cbc1cdf323ef600616d70cd7c3f0a9a1c0"}],"glance/common/utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a389ccd99bc8fcbd9494d0172792a24746d3725a","unresolved":false,"context_lines":[{"line_number":610,"context_line":"    Allows determining if any of these values have changed"},{"line_number":611,"context_line":"    when the config is reloaded."},{"line_number":612,"context_line":"    \"\"\""},{"line_number":613,"context_line":"    if six.PY2:"},{"line_number":614,"context_line":"        conf \u003d {"},{"line_number":615,"context_line":"            \u0027bind_host\u0027: CONF.bind_host,"},{"line_number":616,"context_line":"            \u0027bind_port\u0027: CONF.bind_port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_5bf8f547","line":613,"updated":"2020-03-18 19:32:41.000000000","message":"I think it would be better to keep the original patch removal of the few options, then after the initial definition of conf, add one smaller conditional block that adds them in for py2. So something like:\n\n    conf \u003d {\n        \u0027bind_host\u0027: CONF.bind_host,\n        \u0027bind_port\u0027: CONF.bind_port,\n        \u0027backlog\u0027: CONF.backlog,\n    }\n    if six.PY2:\n        conf[\u0027tcp_keepidle\u0027] \u003d CONF.cert_file\n        conf[\u0027key_file\u0027] \u003d CONF.key_file\n        conf[\u0027cert_file\u0027] \u003d CONF.cert_file","commit_id":"1afeb8cbc1cdf323ef600616d70cd7c3f0a9a1c0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"30b91df1225f2b41b9c0f7fc36f72d0c7a9dce9e","unresolved":false,"context_lines":[{"line_number":614,"context_line":"        \u0027bind_host\u0027: CONF.bind_host,"},{"line_number":615,"context_line":"        \u0027bind_port\u0027: CONF.bind_port,"},{"line_number":616,"context_line":"        \u0027backlog\u0027: CONF.backlog,"},{"line_number":617,"context_line":"        }"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    # Note(jokke): As we can still support termination with PY27 we"},{"line_number":620,"context_line":"    # need to add the possible certs in that specific case. This is"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_7c26bcbc","line":617,"updated":"2020-07-22 18:30:46.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"5d2719f164ba841d391bf66f73a14220478bb5c5"}]}