)]}'
{"id":"openstack%2Fglance~737548","triplet_id":"openstack%2Fglance~master~I385f222c5e3b46978b40bdefdc28fcb20d9c67d3","project":"openstack/glance","branch":"master","topic":"bug/1884587","hashtags":[],"change_id":"I385f222c5e3b46978b40bdefdc28fcb20d9c67d3","subject":"Check authorization before import for image","status":"MERGED","created":"2020-06-23 14:14:26.000000000","updated":"2020-07-01 06:49:27.000000000","submitted":"2020-07-01 06:45:06.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"737548-1593585906537-6d9093bf","meta_rev_id":"059e0d01a69a19e9d7442f9bb6f59a5478222a77","_number":737548,"virtual_id_number":737548,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2020-06-30 21:45:42.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-01 06:45:06.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-30 21:44:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2020-06-30 21:44:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-30 21:50:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":1,"date":"2020-06-30 21:44:47.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-25 16:50:01.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-06-30 21:45:42.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-30 21:50:34.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-07-01 06:45:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f595f3b0342f68792bc93bfa197e3200cc84f4ce","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-23 14:14:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"707191310d797785da4892cdceb0cb75fa20ede4","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-23 14:14:46.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"3a6327f16691e0b4401605577c999b9062f9bb26","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 19:23:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/04e6b778053144b69014a6083e56d4ef : SUCCESS in 59m 12s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/a19427f0baec4828a4ef6c186e8f0328 : SUCCESS in 54m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/03e56d03f77c4fd1a092a1daa6d6a698 : FAILURE in 5m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6cd7667379094288bc3992e66ac98233 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7c3a2d038bd944b292117e08759d6770 : FAILURE in 5m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/01984c73f16943e1b98087105c495886 : FAILURE in 7m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e0fd9938a6c54acdafc0b6c8e05a1709 : SUCCESS in 7m 33s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/56ef54c888c54025a0505b5fc5af33c8 : SUCCESS in 7m 18s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0bb55873317a4ce18c16a8edbfc79ffe : SUCCESS in 8m 52s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/a70303b4b7464dffaccc07f25962c094 : SUCCESS in 5m 08s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/ed710cbab1a74607bd72329cd97d5ab9 : SUCCESS in 44m 35s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/74aede2b723f4e468ddfcbfd4f831ea9 : SUCCESS in 51m 44s","accounts_in_message":[],"_revision_number":1},{"id":"7f0cf4e9ee700eedc9192f61f373373ca8418b2e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-23 21:25:53.000000000","message":"Patch Set 1:\n\nThis gives me a 401 when I try to do this on an image I don\u0027t own:\n\nJun 23 18:52:24.792002 ubuntu-bionic-inap-mtl01-0017345612 nova-compute[23184]: ERROR nova.compute.manager [instance: 93a0de1d-2584-41b4-882a-7d90bdc35c09] glanceclient.exc.HTTPUnauthorized: HTTP 401 Unauthorized: Operation not permitted\n\nAbhi, is my method of checking authorized-ness okay? If so, I will clean this up, add/fix tests and resubmit.","accounts_in_message":[],"_revision_number":1},{"id":"1be8a75ac296138fba9040ee731f85f8abd35c15","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-24 05:58:07.000000000","message":"Patch Set 1:\n\n\u003e This gives me a 401 when I try to do this on an image I don\u0027t own:\n \u003e \n \u003e Jun 23 18:52:24.792002 ubuntu-bionic-inap-mtl01-0017345612\n \u003e nova-compute[23184]: ERROR nova.compute.manager [instance:\n \u003e 93a0de1d-2584-41b4-882a-7d90bdc35c09] glanceclient.exc.HTTPUnauthorized:\n \u003e HTTP 401 Unauthorized: Operation not permitted\n \u003e \n \u003e Abhi, is my method of checking authorized-ness okay? If so, I will\n \u003e clean this up, add/fix tests and resubmit.\n\nYes, this way of checking looks fine to me.","accounts_in_message":[],"_revision_number":1},{"id":"eecf98f100d5897616e02a335697ef8cf4ef7cf3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-24 14:37:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a94e25e6948ff098c434723598c25841520b5983","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-24 14:37:43.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":2},{"id":"d1efce84ba1998db31dbb70896a83d21713bb949","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 20:21:48.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/43b7ad66fbe1441c88a081e5097b20b6 : SUCCESS in 1h 05m 44s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/b81acff43fbd4342b3aa88758fefb1a8 : SUCCESS in 1h 19m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b52cdcd687104b7cb30f296d1164b42f : SUCCESS in 5m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7d99d0258e2346aab542dc2844979f7e : FAILURE in 5m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/308b0b69c90042c2a9f8b9bc6c8fbb46 : SUCCESS in 5m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1de0818a0517492ba08670f794aed503 : SUCCESS in 7m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e67bb6a12bf544a98433cf70cc4f9cbb : SUCCESS in 8m 09s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/029d9f53a1ad48e5a110cbf357955e0b : SUCCESS in 9m 27s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f2a942577397497e9cbad0eb8746fc48 : SUCCESS in 11m 03s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/0b43cad446234a47aa6d60288c41df1c : SUCCESS in 5m 46s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/ccbd1ccba5fb4c1ea2bae539220ca0ff : SUCCESS in 1h 01m 13s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/287e3b54195d4b9cb275fa6837388344 : SUCCESS in 55m 19s","accounts_in_message":[],"_revision_number":2},{"id":"79d131675406d7630366d25724c7107038622b3a","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-25 14:13:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a2ab9342fec8d05cabb7982f6f23f43c219e25e0","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-25 14:13:56.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":3},{"id":"a0a655d0778f693950ceb6c3d05486152982c390","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-25 16:50:01.000000000","message":"Patch Set 3: Review-Priority+1","accounts_in_message":[],"_revision_number":3},{"id":"34c5aa6065a445de9d7d6d502279c2986eb9a102","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 22:04:42.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/4930adbc16514c0880cf439e32c3f118 : SUCCESS in 1h 02m 26s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/982a5d9401a8416e9c25b60a5b9f49a8 : SUCCESS in 1h 15m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/487503e5a0d9492f9d7578e8f9ffe854 : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/329b707fb5fd4bd594ca3e3f88cf2a90 : SUCCESS in 5m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/562883001193428e884566114f0f85e2 : SUCCESS in 6m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c26f65e7741642008e0a9026062458c2 : SUCCESS in 7m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/94dcd8cbc2124c188c2792b1b567b87d : SUCCESS in 11m 41s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/eec8c5b6e1154d22bab8952200d3040e : SUCCESS in 10m 48s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2d82cac4f744442e8170cdd016cf4c97 : SUCCESS in 8m 23s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/88a13293a191465fa24f8a7f76c2c9b4 : SUCCESS in 4m 57s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/8e678813968240908689b0d3b4803dae : FAILURE in 1h 01m 23s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b86a5a5378784565b9233f309b2e04b8 : SUCCESS in 56m 49s","accounts_in_message":[],"_revision_number":3},{"id":"af58fd9990e5e51465707eeefe802bb20851c6c4","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-26 07:53:14.000000000","message":"Patch Set 3: Code-Review+2\n\nThank you Dan!","accounts_in_message":[],"_revision_number":3},{"id":"bb5b9d4c4a94030a18686839b30bd531e3c87a86","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-06-30 14:57:09.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nMakes sense to catch this as early as possible.  Nice test, too.  Thanks, Dan.","accounts_in_message":[],"_revision_number":3},{"id":"a997569d7ff7618efa6a5b5d012705c71d18b4a0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 14:57:30.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"395ab1b35056a47328c36bfb069d5ffbcfe15e2b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 19:41:22.000000000","message":"Patch Set 3: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/170a525c0193416985cf8fa0319d4bf4 : SUCCESS in 1h 00m 59s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/5b69ba3601f640b780e4e2a6c05fc60a : SUCCESS in 1h 31m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dc478c1062124382bd00931cf29ca45f : SUCCESS in 6m 33s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/175d40d878ea4fa380d291e071c68d6c : SUCCESS in 8m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cb436ba37ed549f297389b27fe75454f : SUCCESS in 7m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e48c5802315f44b0bec766c62a026b3a : SUCCESS in 8m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ff4e3c769d7a4541a7febb34957d4246 : SUCCESS in 9m 22s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8053f62f86e94118bc8100b0f3f1cfb5 : SUCCESS in 10m 52s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0436cb3080d74a0082e8cf4c8fa6af80 : SUCCESS in 8m 17s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/312e0ff93bf94c02b2a4047a712dffec : FAILURE in 24m 24s","accounts_in_message":[],"_revision_number":3},{"id":"32ec5a0fced3189ee652874cd55d5891eaa622d6","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 19:56:13.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"8ecdec7dd65a7a1a58487c2390e4385666043065","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-30 19:56:34.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":3},{"id":"cd8ae250d59987da2534831206c76eb18b2b49a2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 21:11:51.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/4f043a8f21ff4dc09eaa94d01d39b685 : SUCCESS in 1h 04m 43s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/1f0252419f9a44c2bb1e41ffcf1558b6 : SUCCESS in 1h 14m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/17fc784c1712474493052c2dbd866a34 : SUCCESS in 5m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6228407917d8447e86239b87a107194e : SUCCESS in 5m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b2201798c6d044d3b0d579fdf11790e6 : SUCCESS in 6m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/722c5189514c49c5acbff5d19857fd23 : SUCCESS in 6m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fb81941f22ca487ba3c3d171b1325958 : SUCCESS in 6m 37s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/adc24c6f98104e9c9bc06e0573a0e4a5 : SUCCESS in 8m 41s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3cb483b7594e4338832f9c33ec80ea33 : SUCCESS in 8m 13s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/8e968f1c78864e409f2a58f2fd48a822 : SUCCESS in 5m 07s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/c532abb2ff014bc991656bf9143f1258 : FAILURE in 25m 59s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6d98477281a943be909facac393a2ddc : SUCCESS in 48m 02s","accounts_in_message":[],"_revision_number":3},{"id":"6bd6d79198bd67710856178ba3c6f71d54c948c5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 21:12:15.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"433746a0a5a1e84e4a978f5ef1c5bd2a28b597bc","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-30 21:44:47.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"ef4ca8d9af76a223b6f332b0c8d405665706ad4c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-30 21:45:42.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"ef415a345eeec97a94b8f04963d2b5955a3fb941","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-06-30 21:50:34.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"35ea94e05b5b26e8ac8135e3aafe34ed6afb4f87","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 23:04:41.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/31a2400a0b0c492f9b0cd65ead9a69e7 : SUCCESS in 58m 05s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/8ff9ce44385e422c8c4f87089fa46af1 : SUCCESS in 1h 18m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ce297ebe816741188c67d25167b850d4 : SUCCESS in 6m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b486d305322e484da1736370b118661e : SUCCESS in 4m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e5d99f86b5b445f9ac2c67ac3158c1ff : SUCCESS in 6m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dcd425de5eab4f8da1af80c013334153 : SUCCESS in 7m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/56d381fc92074d15a6ec8520bdb24fc0 : SUCCESS in 7m 01s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6dc6e92710014d6fb79d4d6c8a2e12e2 : SUCCESS in 8m 27s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b0213fdb6dfc497ba37c6042e0d8b1ef : SUCCESS in 8m 58s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/0eddc2bf0afe4c158b62bc102e2634b2 : SUCCESS in 3m 57s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/e19084827683421491caded9a6fdf0d9 : FAILURE in 24m 53s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f57499a8b7b84a309274c20a0949c77f : SUCCESS in 52m 05s","accounts_in_message":[],"_revision_number":4},{"id":"a934d3bf5eee6b4b43e513ab9d1cc494883eadf4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 23:05:09.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"4633dd466b24a9e66486a12dcd4d130d72b2eea8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 06:45:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"104659ed5f321e473c6ca0ce3ce9ed039bc9f68b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 06:45:06.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/8a364567b48148bf809a32d10ac62a14 : SUCCESS in 1h 22m 20s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/d0819c04f53f41bc8d2f6e3acd5b1aed : SUCCESS in 1h 11m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9bd955bfe34b4df7af7b6e117fea9ed5 : SUCCESS in 5m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fb678081c45a466abf4e4e580b5ba265 : SUCCESS in 4m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/60ebc17537f64c3780fa2d363e76e53a : SUCCESS in 7m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9d387a548d964157b47298fa7aabc831 : SUCCESS in 6m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8c5da6a05944731bff4730d20e12b49 : SUCCESS in 6m 43s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/b65fe3be6faa454e8fec4e413b0946a2 : SUCCESS in 9m 12s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/75a9f991a38d465a9ba61466b8265c9c : SUCCESS in 7m 25s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8bf2789644bd4da2aacac42efdbfdeeb : SUCCESS in 1h 01m 31s","accounts_in_message":[],"_revision_number":4},{"id":"c4c4d6320c9b98ac099251a80a381eb95d3907dd","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-01 06:46:09.000000000","message":"Patch Set 4: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit fcba03989feed85a3301e53b252f766eabeeba3c","accounts_in_message":[],"_revision_number":4},{"id":"dec2a502b35d805697befc84e38eee892411585a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-01 06:49:27.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c503dbdc4f014adfb8454b7a0a61b92e : SUCCESS in 3m 52s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"c930638fcf58b43d53903cfc30e06fd6919bdad6","revisions":{"b45b234e2b62112aa8535b56dd061d0622401d7a":{"kind":"REWORK","_number":1,"created":"2020-06-23 14:14:26.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/48/737548/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/48/737548/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/48/737548/1"}}},"commit":{"parents":[{"commit":"c9c98727690702914784898f999a449f89100aba","subject":"Merge \"Fix hacking min version to 3.0.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c9c98727690702914784898f999a449f89100aba"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-23 14:12:12.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-23 14:14:08.000000000","tz":-420},"subject":"WIP: Check authorization before import for image","message":"WIP: Check authorization before import for image\n\nRight now we only check to see if the user can see the image before\nwe kick off an import operation. However, that will never work unless\nthe user is the *owner* of the image (or an admin) which means we\nreturn a 202 to the API caller and then the task fails immediately.\n\nThis change makes us check that authorization up front and return an\nappropriate code to the user so they know it failed, and avoid starting\na task destined for failure.\n\nNOTE: This needs tests, I\u0027m just pushing it up to see if it signals nova\n\nChange-Id: I385f222c5e3b46978b40bdefdc28fcb20d9c67d3\nCloses-Bug: #1884587\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b45b234e2b62112aa8535b56dd061d0622401d7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b45b234e2b62112aa8535b56dd061d0622401d7a"}]},"branch":"refs/heads/master"},"96804642839b560c3b10e29e9c091a6511315c14":{"kind":"REWORK","_number":2,"created":"2020-06-24 14:37:21.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/48/737548/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/48/737548/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/48/737548/2"}}},"commit":{"parents":[{"commit":"c9c98727690702914784898f999a449f89100aba","subject":"Merge \"Fix hacking min version to 3.0.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c9c98727690702914784898f999a449f89100aba"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-23 14:12:12.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-24 14:37:10.000000000","tz":-420},"subject":"Check authorization before import for image","message":"Check authorization before import for image\n\nRight now we only check to see if the user can see the image before\nwe kick off an import operation. However, that will never work unless\nthe user is the *owner* of the image (or an admin) which means we\nreturn a 202 to the API caller and then the task fails immediately.\n\nThis change makes us check that authorization up front and return an\nappropriate error to the user so they know it failed, and avoid\nstarting a task destined for failure.\n\nNote that there was already a check for a Forbidden result when calling\nthe import API. However, that used a context.owner\u003dNone which could never\nhappen in reality. A more suitable check would have been to use a context\nwith a different real owner, but it turns out that the task creation\nwould have succeeded in that case as well. This test is changed to use\nan alternate owner and ensure that we get the forbidden result from the\nnew check immediately.\n\nChange-Id: I385f222c5e3b46978b40bdefdc28fcb20d9c67d3\nCloses-Bug: #1884587\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/96804642839b560c3b10e29e9c091a6511315c14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/96804642839b560c3b10e29e9c091a6511315c14"}]},"branch":"refs/heads/master"},"165fb38d18c7bca5d9ef9100949a694f51171203":{"kind":"REWORK","_number":3,"created":"2020-06-25 14:13:12.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/48/737548/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/48/737548/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/48/737548/3"}}},"commit":{"parents":[{"commit":"c9c98727690702914784898f999a449f89100aba","subject":"Merge \"Fix hacking min version to 3.0.1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c9c98727690702914784898f999a449f89100aba"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-23 14:12:12.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-25 14:13:16.000000000","tz":-420},"subject":"Check authorization before import for image","message":"Check authorization before import for image\n\nRight now we only check to see if the user can see the image before\nwe kick off an import operation. However, that will never work unless\nthe user is the *owner* of the image (or an admin) which means we\nreturn a 202 to the API caller and then the task fails immediately.\n\nThis change makes us check that authorization up front and return an\nappropriate error to the user so they know it failed, and avoid\nstarting a task destined for failure.\n\nNote that there was already a check for a Forbidden result when calling\nthe import API. However, that used a context.owner\u003dNone which could never\nhappen in reality. A more suitable check would have been to use a context\nwith a different real owner, but it turns out that the task creation\nwould have succeeded in that case as well. This test is changed to use\nan alternate owner and ensure that we get the forbidden result from the\nnew check immediately.\n\nChange-Id: I385f222c5e3b46978b40bdefdc28fcb20d9c67d3\nCloses-Bug: #1884587\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/165fb38d18c7bca5d9ef9100949a694f51171203"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/165fb38d18c7bca5d9ef9100949a694f51171203"}]},"branch":"refs/heads/master"},"c930638fcf58b43d53903cfc30e06fd6919bdad6":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2020-06-30 21:44:47.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/48/737548/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/48/737548/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/48/737548/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/48/737548/4"}}},"commit":{"parents":[{"commit":"e6db0b10a703037f754007bef6f56451086850cd","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e6db0b10a703037f754007bef6f56451086850cd"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-23 14:12:12.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-30 17:24:45.000000000","tz":-420},"subject":"Check authorization before import for image","message":"Check authorization before import for image\n\nRight now we only check to see if the user can see the image before\nwe kick off an import operation. However, that will never work unless\nthe user is the *owner* of the image (or an admin) which means we\nreturn a 202 to the API caller and then the task fails immediately.\n\nThis change makes us check that authorization up front and return an\nappropriate error to the user so they know it failed, and avoid\nstarting a task destined for failure.\n\nNote that there was already a check for a Forbidden result when calling\nthe import API. However, that used a context.owner\u003dNone which could never\nhappen in reality. A more suitable check would have been to use a context\nwith a different real owner, but it turns out that the task creation\nwould have succeeded in that case as well. This test is changed to use\nan alternate owner and ensure that we get the forbidden result from the\nnew check immediately.\n\nChange-Id: I385f222c5e3b46978b40bdefdc28fcb20d9c67d3\nCloses-Bug: #1884587\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c930638fcf58b43d53903cfc30e06fd6919bdad6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c930638fcf58b43d53903cfc30e06fd6919bdad6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
