)]}'
{"id":"openstack%2Fglance~737596","triplet_id":"openstack%2Fglance~master~I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0","project":"openstack/glance","branch":"master","topic":"copy-image_race","hashtags":[],"change_id":"I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0","subject":"WIP: Fix race condition in copy image operation","status":"ABANDONED","created":"2020-06-23 18:28:53.000000000","updated":"2020-08-21 05:49:28.000000000","total_comment_count":94,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3d651e19c77b59e5cb98041339fcfe4bbc424b85","_number":737596,"virtual_id_number":737596,"owner":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-07-17 19:38:39.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"date":"2020-07-17 14:22:54.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2020-07-22 20:54:06.000000000","_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"date":"2020-07-20 15:49:05.000000000","_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":-1,"date":"2020-07-17 20:21:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2020-08-21 05:49:28.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-24 18:24:35.000000000","updated_by":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"reviewer":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"state":"REVIEWER"},{"updated":"2020-07-09 14:29:00.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-07-17 14:22:54.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-17 19:38:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-17 20:21:48.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2020-07-20 15:49:05.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2020-07-22 20:54:06.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"}],"messages":[{"id":"7f2dc37bed2ffbb57f6626ceda70ee77bf859934","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-23 18:28:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"07343e4a90e41c6815b2d5c57b3f290f5cc58bae","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-23 18:47:38.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"9efd4da9093327999b1cdc7f14c89a1ddb0b9b22","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-23 18:51:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(7 comments)\n\nI know this is WIP, so maybe you\u0027ve thought about all of this but I thought I\u0027d comment anyway. Thanks for working on this!","accounts_in_message":[],"_revision_number":1},{"id":"0a94cbdb475da1dc25262351240516fcb5191025","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-23 19:07:11.000000000","message":"Patch Set 1:\n\n(6 comments)\n\nThank you for inputs Dan!","accounts_in_message":[],"_revision_number":1},{"id":"da638f7dba13f5122ef822cf51b9c91ad0a33bec","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-23 19:14:36.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f900a51f4596c8b092e9b87300b2559d090e1757","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-06-23 19:19:30.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6fa088d95be3e56e528a19f522c49085b769c810","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-23 19:58:45.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f8704674e644961f924c3526a2bc270947988466","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 00:20:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/814283dd183349e78c325853320369a5 : SUCCESS in 58m 32s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/67a0599a3b7a4bb5a64e082d880bae25 : SUCCESS in 1h 02m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0308a33899e14d20b1ed0b95b550ce42 : FAILURE in 6m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/58a520b686324804a3a9476d32fd9f1b : SUCCESS in 5m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1457ace6cc344ce49d27eab3b8c47a9c : FAILURE in 5m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0702094875f543df958decc3afcae2f8 : FAILURE in 6m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/979773c58e994963b629b596ec1f1f27 : SUCCESS in 7m 03s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/951261331f11423b81cd71e10ba34b2c : TIMED_OUT in 31m 12s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3e913841fb2e477482d8795792303f3d : SUCCESS in 8m 33s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/5549ff0fc0d144e3b28ebaa4b1e18172 : SUCCESS in 7m 07s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/6c508a6d48c74d009c375522441ac85e : SUCCESS in 45m 57s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f20b346833364537a0110016be8ed659 : SUCCESS in 36m 26s","accounts_in_message":[],"_revision_number":1},{"id":"02d1220cb043fdb2fa5491287dff20927f01c09a","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-24 07:26:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5ab7f9e3f268eec558d32b8b0dbbeb51f0b5a66c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-24 07:26:23.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":2},{"id":"e8941312436c5a62c679b9d99780f3df33eb380b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-24 09:20:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/08a3f4c345894d46a2eed7e12dbc84db : SUCCESS in 41m 45s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/1e4bd5d011e041788df3d410d7b008cd : SUCCESS in 1h 13m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a3e63225fcb342848e0082005ccc8a23 : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/31f11d243a624b3b84aed20f1d517459 : SUCCESS in 5m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9f08eff35e844108b1156968b8457d95 : SUCCESS in 5m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c59f19941cb94311981c8b457c3e0c1d : SUCCESS in 6m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ca229b2a2384e39b8e5dfde75673364 : SUCCESS in 6m 25s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f34e40e534d4457b8f219eed61301b54 : SUCCESS in 7m 57s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b84040612ba14746a15af07427597cfd : SUCCESS in 8m 25s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/85443c1e7e404cf4b78aa0873562087e : SUCCESS in 5m 20s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/708bd706b5804d62b08b315102048c7b : SUCCESS in 57m 39s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/88b5a0f6d05b4f6da62b231cb323b5d0 : SUCCESS in 50m 17s","accounts_in_message":[],"_revision_number":2},{"id":"ddb080b58ab32adfd9ac429f345573f4495e56f8","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-24 15:22:39.000000000","message":"Patch Set 2: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e52622b8eb3af31acf630a0a32a5d846725b2f5b","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-24 17:07:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2d9aee4af5f3e8fa02deec51ce4c9044656d7d32","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-24 17:23:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"64e0e07fcce377c39a6a87abf9cf31993bf53ecb","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-06-24 18:17:41.000000000","message":"Patch Set 2:\n\njust to keep a record here is the IRC convo we had\n\n\u003czzzeek\u003e dansmith: the basic idea is do that UPDATE and then get the rowcount back for numnber of rows affected\n\u003cdansmith\u003e abhishekk: ah sorry\n\u003czzzeek\u003e if it\u0027s zero, you missed\n\u003czzzeek\u003e does that make sense ?\n\u003cdansmith\u003e zzzeek: meaning my example SQL update query you mean right?\n\u003czzzeek\u003e yes\n\u003cabhishekk\u003e dansmith, no problem\n\u003czzzeek\u003e I would skip the ORM and just run result \u003d connection.execute(table.updat()...)\n\u003czzzeek\u003e then result.rowcount\n\u003cdansmith\u003e zzzeek: yeah, okay that\u0027s what I thought.. I don\u0027t really know how to translate that into ORM stuff, but maybe I can work on that a bit and get you to validate that what I\u0027m doing is legit?\n\u003cdansmith\u003e zzzeek: suhweet, that\u0027s what I\u0027d rather do\n\u003czzzeek\u003e dansmith: yeah I would just use a core statement\n\u003cdansmith\u003e zzzeek: a dedicated claim() operation and just do it that way\n\u003czzzeek\u003e dansmith: just for the claim part at least.  then once oyu have it you can do wahever ORM things\n\u003cdansmith\u003e yep\n\u003czzzeek\u003e dansmith: also if you have an ORM session, you can get the connection for the transaciton as conn \u003d session.connection()\n\u003cdansmith\u003e zzzeek: don\u0027t we want to do that update thing outside a transaction where we have already read some of the data we\u0027ll be examining?\n\u003czzzeek\u003e dansmith: hmmmm yes if oyu are on repeatable read then I guess so\n\u003cdansmith\u003e I thought if we did it with other stuff, we\u0027d be operating on repeated read data... yeah that\n\u003czzzeek\u003e might not matter\n\u003czzzeek\u003e the other transacvtions would block\n\u003cdansmith\u003e so I figured we\u0027ll just do the claim as a single shot thing, which is fine because the real work happens later in an async task\n\u003czzzeek\u003e sure I guess commit is safer b.c. then it goes out and gets past the locks but also does the galera writeset thing\n\u003czzzeek\u003e it\u0027s just when you do work subsequent to that, you want to have a new transaction\n\u003czzzeek\u003e so if this is the very fisrt thing you\u0027re doing it should be OK\n\u003cdansmith\u003e ack okay\n\u003czzzeek\u003e assuming this table is also involved in the subseqeunt work\n\u003cdansmith\u003e zzzeek: I need to look at their stuff more to be able to answer that question, but .. probably\n\u003czzzeek\u003e its just cleaner to have two serial transactions rather than one oingoing and another pops out in the middle\n\u003cabhishekk\u003e dansmith, this solution will also solve our race?\n\u003cdansmith\u003e so abhishekk I will try to work on this claim thing, zzzeek can check my work and or make fun of it if it\u0027s wrong and then we can use it to solve your race\n\u003cdansmith\u003e zzzeek: yep, two is what I\u0027m going for\n\u003cabhishekk\u003e dansmith, ack :D\n\u003cabhishekk\u003e dansmith, back to our staging clearing solution\n\u003czzzeek\u003e when transactions overlap that\u0027s how you can get deadlocks so keep them serial is simpler\n* priteau has quit (Remote host closed the connection)\n\u003cdansmith\u003e zzzeek: ++\n\u003czzzeek\u003e ok i will copy gthis to the gerrit as a record","accounts_in_message":[],"_revision_number":2},{"id":"775394391284e32cfaaff0386de0ef4eb1246346","author":{"_account_id":11816,"name":"mike_mp@zzzcomputing.com","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"date":"2020-06-24 18:24:35.000000000","message":"Patch Set 2:\n\none more time, with formatting\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-glance/%23openstack-glance.2020-06-24.log.html#t2020-06-24T18:08:36","accounts_in_message":[],"_revision_number":2},{"id":"5c9ccd7c3ca90f8337d64f5d544f8d87dae16af8","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-26 10:33:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5180ef6aa43620733a73e33a28bca67002c56623","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-26 10:34:04.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":3},{"id":"552932ac3d5930dc11b826241a0f640c7353b791","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-26 10:37:35.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"c22a8eba3b09c90ad0834f2799aa233b5c5b72db","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 13:47:39.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/6311f38e903541969554f48ea9542a5c : SUCCESS in 1h 05m 34s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/a2589a11387349f0a4b537f93bdc61b4 : SUCCESS in 51m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3d3b93d6ca4448ec96bda51a5642944b : SUCCESS in 5m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/770246dd9d554b76bb4ec49541a17cb6 : SUCCESS in 5m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d631e7c8e03d44cd8c8840f5f49d528e : SUCCESS in 5m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/56592541e4bb4ecfb2541223ba83f1f6 : SUCCESS in 5m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a7f6138d145d49feade72ccee5f4d22d : SUCCESS in 7m 39s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/2b7473409a174031aa859f19ba5efe4c : SUCCESS in 9m 00s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a420421cc48f403ba665cfb68351943c : SUCCESS in 8m 27s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/36349492afed45019593fc9147c3fb57 : SUCCESS in 4m 41s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/3df5a389bc2a4cffab0a544be1a264f6 : SUCCESS in 1h 08m 48s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b5a467ee32424342a258a670d6a8ba7b : SUCCESS in 55m 16s","accounts_in_message":[],"_revision_number":3},{"id":"584d49d0a4cd12a215d6e59efd76f7c4d83b15cc","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 14:11:58.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7136269b836380ce94477e41020c692c83096edf","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-26 14:13:56.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"c8d7c7287b2952c8f95f2edbce66148cbee933a4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 14:41:45.000000000","message":"Patch Set 3:\n\n(4 comments)\n\nI will pull the other related changes back into the earlier patch in a bit","accounts_in_message":[],"_revision_number":3},{"id":"715adb7190e491072784b529fbcbf961d2c0e930","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 15:48:19.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"596d66e75b41103418db7c2a891bfaab0ef82e0e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 15:55:23.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"cc4fc6102c0e9ffc6dc496f1a650c541d5e13bc3","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 15:58:58.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1b0ebe998a9683d6e899b7aaddb3c8987e02fa4f","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-26 16:40:13.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"7a353b949f7082004199701ab0584bd98aa62a29","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-26 17:01:23.000000000","message":"Patch Set 5:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":5},{"id":"f65ab6e16e540507de5ec0c62fb5ffba30594c92","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-26 20:42:49.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/fc66a3f4dded476397c62c5e7e00883f : SUCCESS in 1h 00m 13s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/dd36ccfe709644ebb46474ddccfdb878 : SUCCESS in 1h 07m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7b124ad06a0b41bbb8ae522d6dd73258 : SUCCESS in 7m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a06c44d145aa4d22a2f7a87fa6008508 : SUCCESS in 5m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f1ea412f8b5e49cf87534c8b299926ee : SUCCESS in 5m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/650993fefff1431b806caf545a42216c : SUCCESS in 8m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f9d058c80e074a8cb0f437ea79367911 : SUCCESS in 12m 58s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3c7bc6cbc7374731b10a46241e289075 : SUCCESS in 9m 38s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/bfaf1ddc9e62432eb62d70f022c85694 : SUCCESS in 10m 39s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/52e556db706a4c09ae4298a9467df060 : SUCCESS in 9m 56s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/0f9961da0e5548f78ba38c8915ea5920 : SUCCESS in 1h 03m 04s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/61246758d9c446578354c10d29a319ed : SUCCESS in 54m 38s","accounts_in_message":[],"_revision_number":5},{"id":"8892521ac6d3a9dcee27a8c37dd049049a48546c","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-29 06:43:59.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"92ba7c074a3de0333e463052af1d31ad01ea0ce5","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-29 06:44:27.000000000","message":"Patch Set 6:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":6},{"id":"9a6c659db78d14183bcee54bfb1c82928ae60856","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-29 06:44:45.000000000","message":"Patch Set 6: Review-Priority+1\n\n(1 comment)\n\nThank you Dan for inputs.","accounts_in_message":[],"_revision_number":6},{"id":"21ea1473b38e1f50c8ea621fd2ced92add1b1e24","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-29 08:07:54.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/7f073c872d744c5bb9eea5368dd79920 : SUCCESS in 1h 03m 37s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/83e73f6438e24e7f94c61ba930679f08 : SUCCESS in 1h 13m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1eef61c607df45b59b33358dbbfc37ee : SUCCESS in 10m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/89b08f6360094d8a8fe1fad6528a5104 : SUCCESS in 9m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6ec95419c39449fda1174c5c9c9767e5 : SUCCESS in 9m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5cb83e3b0cd2409798bcef71b1ed5b8a : SUCCESS in 10m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/292fe1653e764c099a3c8dc3b8f495f6 : SUCCESS in 10m 12s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/e9852625b81943b3b852a268a89d4f14 : FAILURE in 17m 20s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/d421579bee3a40e0877d9d2dc59208a5 : SUCCESS in 13m 44s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/e72fad74d77b4e4ebd6e289a1a42f085 : SUCCESS in 7m 41s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/b11d3e025f684f6a8ca498a71704c6c3 : SUCCESS in 1h 00m 45s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e2296b9df90a442f86811cd839a79544 : SUCCESS in 1h 02m 37s","accounts_in_message":[],"_revision_number":6},{"id":"7de2e8be10077e96d9d8b6eefe13bb1648080681","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-29 10:02:04.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"90357b13d5811ccd64c284fd84d4d830a98ea4e8","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-29 10:04:47.000000000","message":"Patch Set 6:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":6},{"id":"dae90135cac9ccd2a6f0fbf5013639f9e916d5c1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-29 11:22:47.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/1301669cff4f4542af8065e3febfb8be : SUCCESS in 1h 09m 27s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/4e37ffc8043d4ba0998a36c69acfee4c : SUCCESS in 1h 12m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1e38caf5c9aa4fd7ae7e642d489c7653 : SUCCESS in 5m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/57113590afb747219441d5059b07d7c8 : SUCCESS in 5m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a45c7c940da441d88e73a71d84664e4 : SUCCESS in 5m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/520340159a8340bc8eb4afb802fe770c : SUCCESS in 7m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ad64f24a46b540b49b2dfb7dd12bff36 : SUCCESS in 7m 58s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/7434600e26244fe8990941568f4a1475 : SUCCESS in 7m 00s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2c3f1e5e051f4262b73889f36bcfc04c : SUCCESS in 11m 43s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/37983ab1cb36432cbc1a44abeed436d9 : SUCCESS in 5m 18s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/1c36c612af2348b79542bba9e682c742 : SUCCESS in 1h 10m 28s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/ad1dff6ee024472f8915d7029b53e6c0 : SUCCESS in 54m 49s","accounts_in_message":[],"_revision_number":6},{"id":"d72bf4430204b08348a5c4eeabc441524cdff4af","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-06-29 17:12:52.000000000","message":"Patch Set 6: Code-Review-1\n\n(9 comments)\n\nI think the actual change looks technically right. I think some consideration for the key name might yield a better option. I know this is still WIP, but lots of tests are missing :)","accounts_in_message":[],"_revision_number":6},{"id":"d4df4d9ba5e5a9222b308396f565dc42110ea894","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 10:21:53.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"4a2ba9586546e34f6c50f521e12125f6d6f82844","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-30 10:22:21.000000000","message":"Patch Set 7:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":7},{"id":"5ebb88c5b2e75ae611e44c1da6d55a97c96d04a7","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 10:22:36.000000000","message":"Patch Set 6:\n\n(9 comments)\n\nThank you for review Dan,\n\nAdded unit tests and made changes as per your suggestion.","accounts_in_message":[],"_revision_number":6},{"id":"0be29317efe61ad0d897259be0e7a4eff958ae47","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 10:46:43.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"f99cdecda346b5ec60a0913ca1a2e97a4ca5852b","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-30 10:47:11.000000000","message":"Patch Set 8:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":8},{"id":"43815421910bd2accceeabf7410f3f4ca59fd0e4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 12:03:15.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/ffdbebb08d70488794d10b86f49915ec : SUCCESS in 1h 04m 39s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/f3e47eb9a6504d9ba285d60298f2fc48 : SUCCESS in 1h 10m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/58f008dcd72e45ed80a0d24bcf29a0a9 : SUCCESS in 5m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c4a52c0afed24b65b50d88f274605bf1 : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/695e2403867f4c01b4266e999c96a55c : SUCCESS in 5m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ff011ed519f846e197241b65304617dc : SUCCESS in 5m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3fbd4bb527e4b40bba2d3df1f32d60f : SUCCESS in 6m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/03a2df28ab93499f882ee572257b3189 : SUCCESS in 8m 09s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b30891d05b734fb5afa282a900590ecd : SUCCESS in 7m 56s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/4affc7f0a3064abda8a548645f007dd1 : SUCCESS in 4m 58s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/cfbe670be2964947a0f9b38ec6be6360 : FAILURE in 26m 07s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b138578279df443280af57b809397a25 : SUCCESS in 1h 02m 31s","accounts_in_message":[],"_revision_number":8},{"id":"d478555b4d7508e9b65923acd4ec63ba1149b3dc","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 15:06:53.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"81b93771ef0370c54840bf66236279b7cef2d4f6","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-06-30 15:07:17.000000000","message":"Patch Set 9:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":9},{"id":"64e46076415143d2db1371026fc68016fe49d346","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-06-30 15:07:50.000000000","message":"Patch Set 9: Review-Priority+1","accounts_in_message":[],"_revision_number":9},{"id":"6e4dbaf880fa8e4498ec894deb02a44bba5c6ce3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 18:29:13.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/4ef4916f200d46b48c090237833b81e6 : SUCCESS in 1h 11m 12s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/97fca42f92684aa6af6967c159542600 : SUCCESS in 1h 22m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d85daf7e428649e1b5649fb9815b4cb5 : SUCCESS in 8m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d0ececc63e5347db92b04e3d954b4645 : SUCCESS in 7m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/62b13daab0cd477a802d40ba6b70da7e : SUCCESS in 10m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4e387335688845e3b01431ccef658a4e : SUCCESS in 9m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d1e130cb48ed4f5fbb8ac18247011b95 : SUCCESS in 8m 22s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d404a8fd9d664b4f8618ba30150a5526 : SUCCESS in 7m 38s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/be4acd18e84348c793093cec500cd917 : SUCCESS in 9m 46s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/aaa42cd7eb224b2488df86115a11d487 : SUCCESS in 5m 59s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/2907f1fb260c4714971fdf5fc808e90e : FAILURE in 38m 39s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dde08f68182e489bbe23658b17201f59 : SUCCESS in 1h 05m 22s","accounts_in_message":[],"_revision_number":9},{"id":"d71f0e373bb91df1e93075c5f0cb26720d1d32d9","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-02 05:05:35.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"25c7435f706479086525ea07c70fa0302ca75da9","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-02 05:06:26.000000000","message":"Patch Set 10:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":10},{"id":"f803f9d97b59a940d120e5d77ea09e70fc61ee62","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-02 06:15:00.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/40beeecb6d424994b7e521b1016f1f6f : SUCCESS in 55m 11s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/b2455950383745848689442eb4028011 : SUCCESS in 1h 07m 28s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bcbed021ab1d475c9db47a569a8e4fd0 : SUCCESS in 4m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6132bf2ab4034ac4b1d9d8f294bd2c09 : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cecf012906d340aa955e62ce3f63b760 : SUCCESS in 4m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/16709f9110df48f2a496a8400141b3d7 : SUCCESS in 5m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7227cf108d4b4a07b29f9ded4b7503fb : SUCCESS in 6m 21s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3f1f00fdae534aceb347e7b934ca8c2c : SUCCESS in 8m 08s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/9eae7401f55c4b998b403d380bff966f : SUCCESS in 7m 35s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/e0832b93732e44c5894468f04ef7ee82 : SUCCESS in 5m 16s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/913fb950e17444b9ad385ac6764ca73c : SUCCESS in 1h 04m 08s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/fd7869cc408c4cfea4b32f72faf6db0f : SUCCESS in 54m 39s","accounts_in_message":[],"_revision_number":10},{"id":"6853d46b8bdd2f5a8ebadf1f883bd05b20352724","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-02 13:42:58.000000000","message":"Patch Set 10: Code-Review-1\n\n(7 comments)\n\nTests look a lot better now, thanks. I think you can still leak your lock in some places. Since it\u0027s not user- or admin-resolvable, or even discoverable since the property is hidden, it seems like great care should be taken to make sure we don\u0027t get the image stuck, right?","accounts_in_message":[],"_revision_number":10},{"id":"1e783abbcba60cfe3197ddf8450ab4d8630034dc","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-02 14:49:44.000000000","message":"Patch Set 10:\n\n(6 comments)\n\nThank you Dan!","accounts_in_message":[],"_revision_number":10},{"id":"d27c246d09ffdf7466c59360dc74f47aab06183a","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-02 15:05:01.000000000","message":"Patch Set 10:\n\n(4 comments)","accounts_in_message":[],"_revision_number":10},{"id":"ed4eef52c7b53d5c05cd565b9d40a1ae0d232557","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-03 18:02:47.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"7fdcdf90edac74c381f61083c01590ded3b6341c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-03 18:03:20.000000000","message":"Patch Set 11:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":11},{"id":"f1ddc780019a10c84ab4917f271bde00a695c41d","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-03 18:08:42.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"60e665ee2805aed16dd2ffdb677593a6c07becad","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-03 18:09:07.000000000","message":"Patch Set 12:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":12},{"id":"ac7eb9dcbe6aad02794736f1ab28031b481c0dd7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-03 18:31:47.000000000","message":"Patch Set 12: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/2e319cdea9b849df875db31b739c2567 : FAILURE in 20m 55s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/891b0637179646718aebae0f612f35c7 : FAILURE in 21m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3be0d7bde7d3457ab0326443e57b3ee2 : SUCCESS in 5m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/829db7cb43b14337929102f37d200256 : SUCCESS in 7m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/69f8ccaf89cf42b28de6580178b2df93 : SUCCESS in 5m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5949b5f4d6834ca08e30259aec153ed1 : SUCCESS in 6m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8415436fc1e147509bf452f3ae527681 : SUCCESS in 6m 16s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9d55402d93f24538a23466f124ba1d0c : SUCCESS in 8m 37s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b48c128dfb6642ef83aa06b3026a2ee4 : SUCCESS in 8m 44s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/b4acdda7f0114f63828638537c74f1da : SUCCESS in 5m 16s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/045c5ea931a946d595c991dda1979c45 : FAILURE in 12m 45s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/488d9add39f74eac9f375284dc220964 : FAILURE in 17m 10s","accounts_in_message":[],"_revision_number":12},{"id":"e3766d01c5df129a9cbc09b14d66f5659cfa3901","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-06 16:03:52.000000000","message":"Patch Set 12: Code-Review-1\n\n(2 comments)\n\nJust MHO, but I think it\u0027s much better to have the status code from the POST be consistent. This is *technically* safe I think, it just makes the client have to do a lot of second-guessing of the results.","accounts_in_message":[],"_revision_number":12},{"id":"d61546573135ec029246002ad2e1f1521cd6734e","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-07 14:38:15.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"1aedd898610f35b5edcfdfa2c8e41a0448d9be42","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-07 15:14:33.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"8fc1ff26a4f724a84066e5e0cbed8e0e03ed0ac5","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-09 21:32:19.000000000","message":"Patch Set 12:\n\n(2 comments)\n\nI need to think about this some more.  Two comments inline.","accounts_in_message":[],"_revision_number":12},{"id":"ae995a0159b5f2cea4aabeea81632a9e095b54c0","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-09 22:08:11.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"0943595296c3ed50071f24a611b4e87244c2a1c2","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-10 01:46:09.000000000","message":"Patch Set 12:\n\n(1 comment)\n\nSome more thoughts inline.","accounts_in_message":[],"_revision_number":12},{"id":"e3d8ea2fc8e782242bc26642b128695fdbffa513","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-10 13:34:53.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"8df1199def1d244f3d3e28c7fa6a6b83cde355af","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-17 14:22:17.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"6a04a4ad846109045e8923038806a79560f24ba8","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-17 14:22:54.000000000","message":"Patch Set 13:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":13},{"id":"162a4ca890b6ce39e238904034a852c9831a0469","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-17 19:38:39.000000000","message":"Patch Set 13: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/f31bcb64173b49229087cb55fe7d186c : FAILURE in 51m 34s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/d918b1b20df24e5995e1cce2d6be63a1 : FAILURE in 21m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4eb8eaf634f1447d8e0066fa1e52405b : FAILURE in 6m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/190b6d55565841bb9b1469da06e5e94a : SUCCESS in 5m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/bef78ee19a144e9784e7430cbf9a2144 : FAILURE in 5m 31s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d86f87d258a64cddb66f85cd426cb10a : FAILURE in 6m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c7c4e9285a1143468133bf5854a3202a : FAILURE in 5m 36s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/50334bf31b714c23ad09fd8129eec9c6 : FAILURE in 28m 23s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/16ead0dedb4d46b492c3b4e41d578cb6 : TIMED_OUT in 31m 57s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/0b7c8ab650e14c29ad7421bb67231c04 : SUCCESS in 6m 21s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/a53443d232924279b5c29cdcd9450e38 : FAILURE in 28m 39s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/35092d0f75d94f1eadb23b0dd40035a9 : FAILURE in 30m 12s","accounts_in_message":[],"_revision_number":13},{"id":"9283cee5072e1e9c6758b8c5ac9798f6360e2e9a","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-17 20:21:48.000000000","message":"Patch Set 13: Code-Review-1\n\n(3 comments)\n\nMy -1 is for both breaking the API contract for the other methods and that this has its own race condition.\n\nI don\u0027t really like the time-of-day approach to breaking the lock, but if that\u0027s the desired resolution then that\u0027s fine. I think that 30 minutes of unexplained Conflict is enough time to call the admins, and a day of unexplained Conflict after a system reboot is enough time to file a bug with support. It seems to me like there really needs to be a glance-manage command to bust the lock if you just rebooted after a power outage and don\u0027t want to way 23 hours to touch your image again (which kinda defeats the point of the timer anyway).","accounts_in_message":[],"_revision_number":13},{"id":"2aa71d7f19360180398c32c0bc4d3e678b8a39d8","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-20 01:17:03.000000000","message":"Patch Set 13:\n\n(2 comments)\n\n\u003e (3 comments)\n \u003e \n \u003e My -1 is for both breaking the API contract for the other methods\n \u003e and that this has its own race condition.\n\nWhat other methods this approach is breaking? I think I\u0027m missing something.\n \u003e \n \u003e I don\u0027t really like the time-of-day approach to breaking the lock,\n \u003e but if that\u0027s the desired resolution then that\u0027s fine. I think that\n \u003e 30 minutes of unexplained Conflict is enough time to call the\n \u003e admins, and a day of unexplained Conflict after a system reboot is\n \u003e enough time to file a bug with support. It seems to me like there\n \u003e really needs to be a glance-manage command to bust the lock if you\n\nSo the reason why there is no glance-manage tool for this, nor client patch, nor doc change explaining those timeouts or test changes to even relate to this PS is what you say you have found. Something we missed that this approach would break. I\u0027m looking forward to hear what that is before taking the time to attack those. Thus the \"WIP:\" flag\n\n \u003e just rebooted after a power outage and don\u0027t want to way 23 hours\n \u003e to touch your image again (which kinda defeats the point of the\n \u003e timer anyway).\n\nWhat is your SLA? Yes, if you need and expect it being solved in 2hrs probably it\u0027s good time to nag to the admins to take an action and break it manually after. If the SLA is \"we get to it when we get to it\" and it\u0027s inconvenience that it won\u0027t happen today (or there is 2000 images in same state and it just takes a while to get through them) a way to get around it might be handy. Is it 4, 8, 12, 24 hours Happy to take feedback. 24hours just was pretty much safe bet that something is already seriously wrong if importing to single store takes more than that and easier to test the concept with than 3hrs 27min 18sec. Configurable? Does it need to be? I\u0027d prefer not, but if so we can look into that.","accounts_in_message":[],"_revision_number":13},{"id":"b2b1af762e968bbe6cbf3efb1a7cdcc76180d7e4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 14:07:22.000000000","message":"Patch Set 13:\n\n(2 comments)\n\n\u003e What other methods this approach is breaking? I think I\u0027m missing\n \u003e something.\n\nPerhaps you missed my comment on the old side of api_image_import.py?\n\nhttps://review.opendev.org/#/c/737596/13/glance/async_/flows/api_image_import.py@a630\n\n \u003e So the reason why there is no glance-manage tool for this, nor\n \u003e client patch, nor doc change explaining those timeouts or test\n \u003e changes to even relate to this PS is what you say you have found.\n \u003e Something we missed that this approach would break. I\u0027m looking\n \u003e forward to hear what that is before taking the time to attack\n \u003e those. Thus the \"WIP:\" flag\n\nOkay, so there will be a glance command forthcoming to bust the timed lock? If so, that\u0027s cool, although I would argue that the best plan is to forego the time-based lock and just let an admin bust the lock after a system failure if necessary. The taskflow stuff should ensure that the lock is cleaned up after any failure where we are able to reasonably handle cleanup. But, that\u0027s MHO as I stated.\n\n \u003e What is your SLA? Yes, if you need and expect it being solved in\n \u003e 2hrs probably it\u0027s good time to nag to the admins to take an action\n \u003e and break it manually after. If the SLA is \"we get to it when we\n \u003e get to it\" and it\u0027s inconvenience that it won\u0027t happen today (or\n \u003e there is 2000 images in same state and it just takes a while to get\n \u003e through them) a way to get around it might be handy. Is it 4, 8,\n \u003e 12, 24 hours Happy to take feedback. 24hours just was pretty much\n \u003e safe bet that something is already seriously wrong if importing to\n \u003e single store takes more than that and easier to test the concept\n \u003e with than 3hrs 27min 18sec. Configurable? Does it need to be? I\u0027d\n \u003e prefer not, but if so we can look into that.\n\nI don\u0027t want it to be configurable either, because if people set it to be too low, it will break in ways they will almost surely not understand. That\u0027s why I\u0027d rather it not be time-based at all :)","accounts_in_message":[],"_revision_number":13},{"id":"a6377b1ff8a1a43d1719e4e361052687e7a9b484","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-20 15:49:05.000000000","message":"Patch Set 13:\n\n(2 comments)","accounts_in_message":[],"_revision_number":13},{"id":"c44f1abc8cb37f360197c417e6a69a963955bdf2","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 18:11:52.000000000","message":"Patch Set 13:\n\n(2 comments)\n\nI feel like we\u0027re probably getting to the point where we\u0027re no longer discussing actual technical problems and solutions that address the problem. So let me make a couple of new suggestions:\n\n1. We were originally using the task id as the value for the lock, which eliminates the need to use something else, like time-of-day, and which means we can hold the lock the whole time. You objected to that because it involved the API setting the lock to the task ID before the task was running and thus the revert()s may never get called to clean that up, leaving the cryptic value in the lock key that isn\u0027t validate-able. What if we used the request-id? That would (a) be the API setting a value that is clearly the business of the API, (b) be something the client could look at to know if it was at least selected for the single import task slot, (c) be something we can set and leave to avoid unsetting the lock temporarily and/or worrying about the updated time, and (d) be something that the operator could use with logs to determine if it\u0027s safe to bust the lock after a failure. It would not make automatic clean-up better, but maybe it\u0027s enough of a compromise to be something everyone can get on board with?\n\n2. We could let admins bust the lock via the API, if a couple of conditions are true. First, the copy process could continually touch a status file in the staging directory to indicate liveness. I believe Abhi said that the staging area has to be shared between all the workers because the import is a multi-stage process anyway, so this should work. AFAIK, the staging area is always just a filesystem. If the task stops and the mtime of the status file is more than something like 30 minutes old, then the API will allow the admin to bust it by just deleting the property. That would also give us an option to return \"304: There are 7 minutes left on the lock\" status to the admin, and also provides a concrete way to bust the lock in situations where things have died.","accounts_in_message":[],"_revision_number":13},{"id":"303c506ebc208265826392a6c7b7c7e2ffe9c05f","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-20 18:38:55.000000000","message":"Patch Set 13:\n\n(1 comment)\n\nLeft an idea inline.","accounts_in_message":[],"_revision_number":13},{"id":"8f4d76ca242163615e4ab91a1d6a87b179dd8782","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 18:48:33.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"e76a6b3a8d2a3b56a9a03aeaa4bf5b9b479d5853","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-07-22 20:54:06.000000000","message":"Patch Set 13:\n\n(1 comment)\n\n@Dan: response inline.","accounts_in_message":[],"_revision_number":13},{"id":"d979cd9ae651238b3f494c386f8c4ff54d632963","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-22 21:58:33.000000000","message":"Patch Set 13:\n\n(1 comment)","accounts_in_message":[],"_revision_number":13},{"id":"583cf55bebc7f3ff23b80913a7722f13b7d030d5","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-08-21 05:49:28.000000000","message":"Abandoned\n\nAbandoning against https://review.opendev.org/743597","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"221672a1bf111e50fa00cb69004c00d238c45cc4","revisions":{"8a377ec1d7f20912c08568af96f93633e9b64f3c":{"kind":"REWORK","_number":1,"created":"2020-06-23 18:28:53.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/1"}}},"commit":{"parents":[{"commit":"e6db0b10a703037f754007bef6f56451086850cd","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e6db0b10a703037f754007bef6f56451086850cd"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:28:52.000000000","tz":0},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/8a377ec1d7f20912c08568af96f93633e9b64f3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/8a377ec1d7f20912c08568af96f93633e9b64f3c"}]},"branch":"refs/heads/master"},"25896684d81ac9cd47922fbeb6ae99ad45a16b5a":{"kind":"REWORK","_number":2,"created":"2020-06-24 07:26:02.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/2"}}},"commit":{"parents":[{"commit":"e6db0b10a703037f754007bef6f56451086850cd","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e6db0b10a703037f754007bef6f56451086850cd"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-24 07:25:48.000000000","tz":0},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/25896684d81ac9cd47922fbeb6ae99ad45a16b5a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/25896684d81ac9cd47922fbeb6ae99ad45a16b5a"}]},"branch":"refs/heads/master"},"78cf10223969c77677e5721430a313c22aba7eee":{"kind":"REWORK","_number":3,"created":"2020-06-26 10:33:32.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/3"}}},"commit":{"parents":[{"commit":"e2efdea631d3ba7da1c0e70f3c24dc5a50cc002d","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e2efdea631d3ba7da1c0e70f3c24dc5a50cc002d"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-26 10:32:39.000000000","tz":0},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/78cf10223969c77677e5721430a313c22aba7eee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/78cf10223969c77677e5721430a313c22aba7eee"}]},"branch":"refs/heads/master"},"9e92387393e56ef7f968641ee0c08ca4237b1237":{"kind":"REWORK","_number":4,"created":"2020-06-26 14:11:58.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/96/737596/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/4"}}},"commit":{"parents":[{"commit":"5f99919b844d10bb80d2f84481f5d4c4c938c589","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5f99919b844d10bb80d2f84481f5d4c4c938c589"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-26 14:12:00.000000000","tz":-420},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9e92387393e56ef7f968641ee0c08ca4237b1237"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9e92387393e56ef7f968641ee0c08ca4237b1237"}]},"branch":"refs/heads/master"},"b8d704a32444b4f1bdda176477c5c7cc73019db2":{"kind":"REWORK","_number":5,"created":"2020-06-26 16:40:13.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/96/737596/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/5"}}},"commit":{"parents":[{"commit":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521","subject":"WIP: FakeImage test fixture is not reflective of reality","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d9269c4a7e2597a2db569a7cd86a36ebe08b521"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-06-26 16:40:11.000000000","tz":-420},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b8d704a32444b4f1bdda176477c5c7cc73019db2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b8d704a32444b4f1bdda176477c5c7cc73019db2"}]},"branch":"refs/heads/master"},"03183f87af88fb84bcfc5f5a10b4be4e269752bc":{"kind":"REWORK","_number":6,"created":"2020-06-29 06:43:59.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/6"}}},"commit":{"parents":[{"commit":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521","subject":"WIP: FakeImage test fixture is not reflective of reality","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d9269c4a7e2597a2db569a7cd86a36ebe08b521"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-29 06:43:02.000000000","tz":0},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03183f87af88fb84bcfc5f5a10b4be4e269752bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03183f87af88fb84bcfc5f5a10b4be4e269752bc"}]},"branch":"refs/heads/master"},"d97a515b9d24081c493794b2db02f4c8d4e1745f":{"kind":"REWORK","_number":7,"created":"2020-06-30 10:21:53.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/7"}}},"commit":{"parents":[{"commit":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521","subject":"WIP: FakeImage test fixture is not reflective of reality","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d9269c4a7e2597a2db569a7cd86a36ebe08b521"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-30 10:07:08.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/d97a515b9d24081c493794b2db02f4c8d4e1745f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/d97a515b9d24081c493794b2db02f4c8d4e1745f"}]},"branch":"refs/heads/master"},"71f7ba1d1a4608dfc5826856803b0ec6eb045436":{"kind":"REWORK","_number":8,"created":"2020-06-30 10:46:43.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/8"}}},"commit":{"parents":[{"commit":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521","subject":"WIP: FakeImage test fixture is not reflective of reality","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2d9269c4a7e2597a2db569a7cd86a36ebe08b521"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-30 10:46:27.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/71f7ba1d1a4608dfc5826856803b0ec6eb045436"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/71f7ba1d1a4608dfc5826856803b0ec6eb045436"}]},"branch":"refs/heads/master"},"3185e7578f9a3b4d525618f5644732da4cc56cf0":{"kind":"REWORK","_number":9,"created":"2020-06-30 15:06:53.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/9"}}},"commit":{"parents":[{"commit":"bdebef8aeb347cc008c9830f2ec4ed784ea5a697","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/bdebef8aeb347cc008c9830f2ec4ed784ea5a697"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-30 15:06:38.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3185e7578f9a3b4d525618f5644732da4cc56cf0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3185e7578f9a3b4d525618f5644732da4cc56cf0"}]},"branch":"refs/heads/master"},"77fcb9c8a301f758eddeb0729fb96919408b4c19":{"kind":"REWORK","_number":10,"created":"2020-07-02 05:05:35.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/10"}}},"commit":{"parents":[{"commit":"1a0615a550c3db6ba314b9511c5e02a5815b7f91","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/1a0615a550c3db6ba314b9511c5e02a5815b7f91"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-07-02 05:00:46.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/77fcb9c8a301f758eddeb0729fb96919408b4c19"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/77fcb9c8a301f758eddeb0729fb96919408b4c19"}]},"branch":"refs/heads/master"},"7a106523f962326a6b8272e8b24547ab5462c4ad":{"kind":"REWORK","_number":11,"created":"2020-07-03 18:02:47.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/11"}}},"commit":{"parents":[{"commit":"c243786c7e596a054cc411e70bdef94360350a2d","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c243786c7e596a054cc411e70bdef94360350a2d"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-07-03 18:02:31.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7a106523f962326a6b8272e8b24547ab5462c4ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7a106523f962326a6b8272e8b24547ab5462c4ad"}]},"branch":"refs/heads/master"},"7b2dd00e7efc3e002e37863568f30392ad9f192d":{"kind":"REWORK","_number":12,"created":"2020-07-03 18:08:42.000000000","uploader":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"ref":"refs/changes/96/737596/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/12"}}},"commit":{"parents":[{"commit":"c243786c7e596a054cc411e70bdef94360350a2d","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c243786c7e596a054cc411e70bdef94360350a2d"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-07-03 18:08:27.000000000","tz":0},"subject":"Fix race condition in copy image operation","message":"Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7b2dd00e7efc3e002e37863568f30392ad9f192d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7b2dd00e7efc3e002e37863568f30392ad9f192d"}]},"branch":"refs/heads/master"},"221672a1bf111e50fa00cb69004c00d238c45cc4":{"kind":"REWORK","_number":13,"created":"2020-07-17 14:22:17.000000000","uploader":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"ref":"refs/changes/96/737596/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/96/737596/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/96/737596/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/96/737596/13"}}},"commit":{"parents":[{"commit":"2a51843138e27071bf84269f6b2a601b3ba9978f","subject":"Add image_set_property_atomic() helper","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2a51843138e27071bf84269f6b2a601b3ba9978f"}]}],"author":{"name":"Abhishek Kekane","email":"akekane@redhat.com","date":"2020-06-23 18:25:20.000000000","tz":0},"committer":{"name":"Erno Kuvaja","email":"jokke@usr.fi","date":"2020-07-17 14:16:56.000000000","tz":60},"subject":"WIP: Fix race condition in copy image operation","message":"WIP: Fix race condition in copy image operation\n\nSetting new property \u0027os_glance_import_task\u0027 using new\n\u0027image_set_atomic_property\u0027 DB API which will set only\nonce during active image import operation. If any other\nimport api operation imposed on same image while first\noperation is progress then the same will be rejected\nand HTTP 409 response will be returned to the user.\n\nThe \u0027os_glance_import_task\u0027 can have two value options\n\"Pending\" or UUID. When API receives import request it\nwill set the property to \"Pending\" and once the\nTaskflow is executed it will flip that property to the\ntask_id. The locking is valid for 30min of no updates\non the image while \"Pending\" and 1 day if the execution\nhas started.\n\nCo-authored-by: Erno Kuvaja \u003cjokke@usr.fi\u003e\n\nCloses-Bug: #1884596\nChange-Id: I6bc94b7204a7c52e5fc7cf95f93f2788db7e42d0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/221672a1bf111e50fa00cb69004c00d238c45cc4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/221672a1bf111e50fa00cb69004c00d238c45cc4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}