)]}'
{"glance/tests/unit/v2/test_images_resource.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5387108c009bb73abfbe0955c592a624deb6b3fc","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # NOTE(danms): This object seems to incorrectly mirror what"},{"line_number":144,"context_line":"        # image_repo.get() would return, specifically in the id field"},{"line_number":145,"context_line":"        self.image_id \u003d self.id"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class TestImagesController(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_44042815","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":31},"updated":"2020-06-29 05:40:49.000000000","message":"This is good catch, we didn\u0027t caught this earlier because we were not asserting actual image_id anywhere before. \n\nThe sole purpose of this class was to return the image object by patching which we use to validate on the basis of status and other core properties of image than id.","commit_id":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e08766aabb2c2199615d7a8b1e8ab1156dfe9242","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # NOTE(danms): This object seems to incorrectly mirror what"},{"line_number":144,"context_line":"        # image_repo.get() would return, specifically in the id field"},{"line_number":145,"context_line":"        self.image_id \u003d self.id"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class TestImagesController(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_484ef696","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":31},"in_reply_to":"bf51134e_44042815","updated":"2020-06-29 14:49:20.000000000","message":"Yeah, I know, but it would probably be better to use a single known-to-be-equivalent image fixture instead of defining this each time where these mistakes can be made. On Friday I counted some other places that seem to do the same, although I didn\u0027t survey them for correctness...","commit_id":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c3324e20eb3f27ca9149c2813c898cdffcf4bf24","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        # NOTE(danms): This object seems to incorrectly mirror what"},{"line_number":144,"context_line":"        # image_repo.get() would return, specifically in the id field"},{"line_number":145,"context_line":"        self.image_id \u003d self.id"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class TestImagesController(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3b2aea7d","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":31},"in_reply_to":"bf51134e_484ef696","updated":"2020-06-29 14:57:22.000000000","message":"There are 5 occurrences of FakeImage class in different test files out of which this one only uses id instead of image_id. I will add this in my todo list to correct it and use only one class at all places.\n\nMeanwhile I think we should proceed with fixing this in top level patch (my race condition patch https://review.opendev.org/737596)","commit_id":"2d9269c4a7e2597a2db569a7cd86a36ebe08b521"}]}