)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5cadf89f0e9cc6a3d27fb71756103662c4baacc5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The import plugins were designed to interact with the image data"},{"line_number":10,"context_line":"or metadata before the image becomes active. It does not make sense"},{"line_number":11,"context_line":"to try to run them on \u0027copy-image\u0027 taskflow which is just copying"},{"line_number":12,"context_line":"the data between stores on active image."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Erno Kuvaja \u003cjokke@usr.fi\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_4926c3b9","line":12,"updated":"2020-07-02 15:54:05.000000000","message":"I think this is likely enough justification on its own. However, we initially discussed this in the scope of plugins being a security liability if the import task runs unfettered with admin credentials. My current arrangement of it where all the image things we do as admin are contained to a set of defined actions makes that not a concern. The plugins wouldn\u0027t get access to the admin_repo or the action wrapper and thus wouldn\u0027t be able to do anything as admin (although they\u0027d likely fail).\n\nAnyway, like I say, I think this is probably still something we should do, I just wanted to point out that the security part of the concern is gone I think.","commit_id":"44c849a3f9a61f451e2ca031b49be8cde555e6e5"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"31b9045a8a6daeff519f06c719d27f114687f41b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The import plugins were designed to interact with the image data"},{"line_number":10,"context_line":"or metadata before the image becomes active. It does not make sense"},{"line_number":11,"context_line":"to try to run them on \u0027copy-image\u0027 taskflow which is just copying"},{"line_number":12,"context_line":"the data between stores on active image."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored-By: Erno Kuvaja \u003cjokke@usr.fi\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_690e27e6","line":12,"in_reply_to":"bf51134e_4926c3b9","updated":"2020-07-02 16:07:42.000000000","message":"Probably yes, that\u0027s why I left the security aspects out of this.","commit_id":"44c849a3f9a61f451e2ca031b49be8cde555e6e5"}],"glance/tests/unit/async_/test_async.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a535d37c566f987a19e573bafb7756c3f8a07b5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        flow \u003d self._get_flow()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        flow_comp \u003d self._get_flow_tasks(flow)"},{"line_number":109,"context_line":"        # assert flow has 5 tasks"},{"line_number":110,"context_line":"        self.assertEqual(5, len(flow_comp))"},{"line_number":111,"context_line":"        for c in self.base_flow:"},{"line_number":112,"context_line":"            self.assertIn(c, flow_comp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_e19b0770","line":109,"range":{"start_line":109,"start_character":10,"end_line":109,"end_character":33},"updated":"2020-07-09 18:48:38.000000000","message":"You could do this as a followup, or just reject it as a stupid idea.  What you want to assert here is that the flow contains all and only the base_flow tasks.  So instead of 5 in the next line, you could use len(self.base_flow).  Thus the loop at line 111 shows you that all the base_flow tasks are included in flow_comp, and line 110 tells you that no other tasks are included in flow_comp.  You could make a similar adjustment in the other tests, but like I said, it may not be worth it.","commit_id":"b8332d9b6b5e1e6cadc87927d0c7f115700d49bb"}]}