)]}'
{"id":"openstack%2Fglance~741497","triplet_id":"openstack%2Fglance~master~Id1f761dccb5760a2a56fa78e737440b0588e81e6","project":"openstack/glance","branch":"master","topic":"no-import-methods-for-wsgi","hashtags":[],"change_id":"Id1f761dccb5760a2a56fa78e737440b0588e81e6","subject":"Enforce that import methods are not enabled in pure WSGI mode","status":"ABANDONED","created":"2020-07-16 16:58:07.000000000","updated":"2020-07-30 15:34:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2e7b745ccdd4d5ddf9ee28b8e0d06ccf3af4788e","_number":741497,"virtual_id_number":741497,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-07-20 19:09:03.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2020-07-20 18:42:28.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"date":"2020-07-20 18:12:03.000000000","_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-07-18 00:35:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":-2,"date":"2020-07-17 18:28:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2020-07-20 18:03:01.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2020-07-20 17:19:22.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":-1,"date":"2020-07-21 00:43:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2020-07-30 15:34:24.000000000","permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-17 18:28:56.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2020-07-18 00:35:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-20 17:19:22.000000000","updated_by":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"reviewer":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"state":"REVIEWER"},{"updated":"2020-07-20 18:03:01.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-07-20 18:12:03.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-07-20 18:42:28.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-20 19:09:03.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"0d1340bb1e7ee96900bd9f69941a8f9fc490d771","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-16 16:58:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee2c3fd2801871f42ca6975b0b2b968769902d9f","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-16 16:58:28.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"a9a8a3320363804fe8a6b2afd2d418c17c54b11e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-16 17:33:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2a641945ae137b8395f1685067d7fe82c5718923","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-16 17:45:42.000000000","message":"Patch Set 2: Code-Review+2 Review-Priority+1\n\nThank you Dan!!","accounts_in_message":[],"_revision_number":2},{"id":"c5a3689b40df111fb0bd32f7d3dd57150d05f35e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-16 19:51:06.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/134ccac91ee8469bbb5d9a0d6ee3532a : FAILURE in 55m 30s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/fe73f8a5c5fd444e916c63312075b9c1 : FAILURE in 22m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3066690116e543f2bb1b891afa54ff30 : SUCCESS in 6m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ba4204f576d64f1c93ac033fdf593c3a : SUCCESS in 5m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6b4af86cd398493f966a72f4e8d477f0 : SUCCESS in 5m 34s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fbba753ff628436d8d3dde8cf43075f7 : SUCCESS in 7m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/44aa6a54274d4595998a68ed4db2b786 : SUCCESS in 7m 56s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9e04144854a841fa9fd18e9d99f7ccb8 : SUCCESS in 10m 59s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8dc71e6f5aac4c62b22181cb71c9ba18 : SUCCESS in 11m 02s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/87d4e286c6b547d99d7e145d2bc9e83d : SUCCESS in 6m 20s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/4e73f4477c9d4fd681718f4543263d1e : FAILURE in 32m 21s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3416ed48b02a4dd791ae891bdef2f7a5 : FAILURE in 28m 49s","accounts_in_message":[],"_revision_number":2},{"id":"0bc5357ec0a72dbe24ed43cc1148ab6e3f54bc27","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-16 20:36:50.000000000","message":"Patch Set 2:\n\nConfirmed this works because devstack is currently leaving the default methods enabled:\n\n ERROR glance RuntimeError: enabled_import_methods must be empty when running as a pure WSGI app\n\nNow I will depends-on the devstack patch to configure them off and it should pass.","accounts_in_message":[],"_revision_number":2},{"id":"573b51edd4fdc4ffd309f61c7ea4200311d1c286","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-16 20:37:22.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"5f9f97ffc47e45d567758c47007db8de40e7bfee","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-16 20:56:37.000000000","message":"Patch Set 3:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":3},{"id":"814bd0fed57bed30fc3227d3a8575f72afbf5729","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-16 21:47:39.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/62a28e50cd2a43cab9e668489137790d : FAILURE in 57m 22s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/834e1c4f8ade4c70aa7f1d3ef8602248 : SUCCESS in 1h 06m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8d26598c179543ed9dc4479ad78ff2ae : SUCCESS in 6m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/15b9856870fc4ea1a53154313544015c : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/356ce4b7187f4891a874dae861dbee77 : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ae93b66bc80d4852912d72e46a63e77d : SUCCESS in 5m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38f213efb658433b8243a0c67b86c8e1 : SUCCESS in 7m 16s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6533fc3d502544bfa4672d5226a31304 : SUCCESS in 8m 15s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/bd1c660a5e5549aca293b6a429ce8c43 : SUCCESS in 8m 09s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/70201e30865f4697975ad684fe7f4ab4 : SUCCESS in 4m 44s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/00fa9af963f84560b7f9d052aa274aa7 : FAILURE in 1h 08m 07s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/61d9b98d2871487594721b0a5e6302ec : SUCCESS in 56m 26s","accounts_in_message":[],"_revision_number":3},{"id":"f52f245a74e6f5ac527c162bc33d1c9b496d1d74","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-16 22:00:51.000000000","message":"Patch Set 3:\n\nThis now passes devstack. I *think* the reason this is not passing grenade is because we don\u0027t get a chance to disable the import methods in config during the upgrade because we\u0027re expected to work with the old config. Need to think on that a bit.","accounts_in_message":[],"_revision_number":3},{"id":"e9e7fcc10364786f5f0fd2c3b7c00efd3e2b0331","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-17 16:42:17.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"089681ece54c32169375b6b924ce97b419a7221c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-17 17:14:55.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"daec53292bd3c9cfebc6638b0e012c8621240c35","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-17 18:28:56.000000000","message":"Patch Set 4: Code-Review-2\n\nWe really shouldn\u0027t be doing this. It was discussion when we made the Image Import being enabled by default for actually make it mandatory that at least one of the methods would be enabled but we decided to not do that for easier migration and unforeseen corner cases.\n\nThis will not fix any of the issues running Glance without eventlet and specially be counter intuitive indication when we move towards service tokens and image-upload being reserved to be used for that purpose only (namely for not needing Cinder and Nova to go through import).","accounts_in_message":[],"_revision_number":4},{"id":"33a87fb5494ab093bd87e5ae30780e8b1760da18","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-17 18:43:01.000000000","message":"Patch Set 4:\n\n\u003e We really shouldn\u0027t be doing this. It was discussion when we made\n \u003e the Image Import being enabled by default for actually make it\n \u003e mandatory that at least one of the methods would be enabled but we\n \u003e decided to not do that for easier migration and unforeseen corner\n \u003e cases.\n \u003e \n \u003e This will not fix any of the issues running Glance without eventlet\n \u003e and specially be counter intuitive indication when we move towards\n \u003e service tokens and image-upload being reserved to be used for that\n \u003e purpose only (namely for not needing Cinder and Nova to go through\n \u003e import).\n\nSo, this came out of the need to write a tempest test. Tempest needs to run against any deployment without knowing its config (and without parameterizing everything). From that test, I can poke the info API, asking which methods are enabled, which by default is all of them, even in situations where we _know_ that they cannot be used. Even worse, the API client will be told \"202: I\u0027m working on this\" and then nothing will ever happen, not even failure will be reported. That seems like exceedingly broken API behavior to me.\n\nHow can we write a reliable tempest test against Glance\u0027s API when it tells us things will work that can\u0027t possibly work?","accounts_in_message":[],"_revision_number":4},{"id":"b3baab4e7b2c651dddb81d70bd3160d7d9b3bcc9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-18 00:35:54.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/e20582a6f39c4c1d981c10b99ce932c3 : FAILURE in 51m 18s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/764121f9a26b47c49d77018cdd6ff5fe : SUCCESS in 1h 34m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8295a5eb82e04f8da26c3602731a1eb8 : SUCCESS in 7m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6e2e583bbece42c383e634aebb99b871 : SUCCESS in 5m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/252844722c004e7a8a87f0df9b625a19 : SUCCESS in 7m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6e98456158b34d18a6c6df4e80c9e15e : SUCCESS in 7m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3cf5d3a7060848e2a24343ce7f372f9b : SUCCESS in 7m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d4b1c3e6a7c449f0b69f4f1e01a6e4f1 : SUCCESS in 6m 09s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/2e9ecbeb0eb743f794b497e48fe25b6f : SUCCESS in 10m 45s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1bd9f31571974fcfb404d96efdce48f6 : SUCCESS in 9m 32s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/101cdafe19704e66aad90db8a3fd6a09 : SUCCESS in 6m 44s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/e7a1c8db6e1a4631b4a007afbd43a481 : SUCCESS in 1h 00m 40s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e8fbcc74bf36432796252138e56b9555 : SUCCESS in 1h 04m 34s","accounts_in_message":[],"_revision_number":4},{"id":"410b2c7c16ec664eac181e3ce28baca456148e55","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-20 16:46:56.000000000","message":"Patch Set 4:\n\n\u003e So, this came out of the need to write a tempest test. Tempest\n \u003e needs to run against any deployment without knowing its config (and\n \u003e without parameterizing everything). From that test, I can poke the\n \u003e info API, asking which methods are enabled, which by default is all\n \u003e of them, even in situations where we _know_ that they cannot be\n \u003e used. Even worse, the API client will be told \"202: I\u0027m working on\n \u003e this\" and then nothing will ever happen, not even failure will be\n \u003e reported. That seems like exceedingly broken API behavior to me.\n \u003e \n \u003e How can we write a reliable tempest test against Glance\u0027s API when\n \u003e it tells us things will work that can\u0027t possibly work?\n\nI have to admit that it has came to my mind as well every now and then getting around the issues with devstack/QA by detecting when we\u0027re deployed in the QA environment and making the glance-api behave differently. So far I still have enough integrity and some respect towards QA to not do that. If we take that route we might as well just drop those jobs off the check and gate.","accounts_in_message":[],"_revision_number":4},{"id":"3fc6caae61fa9f491adaf1602ce69de958c15cf9","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-20 17:14:19.000000000","message":"Patch Set 4:\n\n\u003e I have to admit that it has came to my mind as well every now and\n \u003e then getting around the issues with devstack/QA by detecting when\n \u003e we\u0027re deployed in the QA environment and making the glance-api\n \u003e behave differently.\n\nThis isn\u0027t about QA and openstack CI. I can arrange the test skip lists in CI such that all the jobs will run with the proper config or skip the test, that\u0027s not the problem.\n\nTempest is used by lots of people in their own environment for validation. If I am an operator and don\u0027t want (or care) to have the import functionality work, I may very much prefer to run glance-api under uwsgi, like all the other API services. In that case, I would not be able to run tempest against my deployment without a failure, or long timeout unless the test itself can detect that a function is not enabled. You could argue that they should \"just know\" that they need to disable the methods before running the test, or that tempest should have a conf knob to disable that test. I obviously think that if we\u0027re running in pure WSGI mode and *know* that the import methods can\u0027t work, we should refuse to expose that they do.\n\nMaybe you didn\u0027t see this, but devstack now deploys glance in standalone mode by default unless you *ask* for wsgi mode, separate from all the other services. So by default, import is testable in our CI.\n\nhttps://review.opendev.org/#/c/741258/\n\n \u003e So far I still have enough integrity and some\n \u003e respect towards QA to not do that. If we take that route we might\n \u003e as well just drop those jobs off the check and gate.\n\nI\u0027m missing something. Which jobs do you want to drop? Are you suggesting that glance stop supporting pure WSGI mode at all? If so, we should delete wsgi_app.py from the tree (or at least mark it as deprecated/unsupported).","accounts_in_message":[],"_revision_number":4},{"id":"02f972216bde7382f0a36b31098bd3e4015f4ba3","author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"date":"2020-07-20 17:19:22.000000000","message":"Patch Set 4: Code-Review+1\n\nAs an operator with multiple clouds, I think that we should _NOT_ start Glance if it\u0027s operating in a configuration that is not working.\n\nWhile we love a unicorn world where everyone is using glance-api eventlet server and image import, that\u0027s just not the reality of things.  With a lot of deployments using mod_wsgi OR uwsgi (OSA).\n\nAre we really blocking this on actual _user friendly behaviour_?","accounts_in_message":[],"_revision_number":4},{"id":"715edc9f16e04a9d931656a24376b65324aaa783","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-20 18:03:01.000000000","message":"Patch Set 4: Code-Review+1\n\n\u003e \u003e I have to admit that it has came to my mind as well every now and\n \u003e \u003e then getting around the issues with devstack/QA by detecting when\n \u003e \u003e we\u0027re deployed in the QA environment and making the glance-api\n \u003e \u003e behave differently.\n \u003e \n \u003e This isn\u0027t about QA and openstack CI. I can arrange the test skip\n \u003e lists in CI such that all the jobs will run with the proper config\n \u003e or skip the test, that\u0027s not the problem.\n \u003e \n \u003e Tempest is used by lots of people in their own environment for\n \u003e validation. If I am an operator and don\u0027t want (or care) to have\n \u003e the import functionality work, I may very much prefer to run\n \u003e glance-api under uwsgi, like all the other API services. In that\n \u003e case, I would not be able to run tempest against my deployment\n \u003e without a failure, or long timeout unless the test itself can\n \u003e detect that a function is not enabled. You could argue that they\n \u003e should \"just know\" that they need to disable the methods before\n \u003e running the test, or that tempest should have a conf knob to\n \u003e disable that test. I obviously think that if we\u0027re running in pure\n \u003e WSGI mode and *know* that the import methods can\u0027t work, we should\n \u003e refuse to expose that they do.\n \u003e \n \u003e Maybe you didn\u0027t see this, but devstack now deploys glance in\n \u003e standalone mode by default unless you *ask* for wsgi mode, separate\n \u003e from all the other services. So by default, import is testable in\n \u003e our CI.\n \u003e \n \u003e https://review.opendev.org/#/c/741258/\n \u003e \n \u003e \u003e So far I still have enough integrity and some\n \u003e \u003e respect towards QA to not do that. If we take that route we might\n \u003e \u003e as well just drop those jobs off the check and gate.\n \u003e \n \u003e I\u0027m missing something. Which jobs do you want to drop? Are you\n \u003e suggesting that glance stop supporting pure WSGI mode at all? If\n \u003e so, we should delete wsgi_app.py from the tree (or at least mark it\n \u003e as deprecated/unsupported).\n\nYeah, we need to consider Tempest a very valid API user and /v2/info/import API should be reflecting the reality as much as it can. we know none of the import method work when glance in wsgi mode so returning failure makes this API more reliable. Also help operator to miss-configuration if they are in the impression that glance under wsgi with CONF.enabled_import_methods\u003dTrue make import feature available for their users.\n\nFrom Tempest perspective, as dan mentioned, API telling if import is ready to use or not is best way instead of adding feature flag. If glance did not have /v2/info/import API then yes we can add feature flag in tempest side.","accounts_in_message":[],"_revision_number":4},{"id":"bb95837b1b00c333b259c5c5bcff26e82e49a463","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-20 18:09:36.000000000","message":"Patch Set 4:\n\n\u003e \u003e \u003e I have to admit that it has came to my mind as well every now\n \u003e and\n \u003e \u003e \u003e then getting around the issues with devstack/QA by detecting\n \u003e when\n \u003e \u003e \u003e we\u0027re deployed in the QA environment and making the glance-api\n \u003e \u003e \u003e behave differently.\n \u003e \u003e\n \u003e \u003e This isn\u0027t about QA and openstack CI. I can arrange the test skip\n \u003e \u003e lists in CI such that all the jobs will run with the proper\n \u003e config\n \u003e \u003e or skip the test, that\u0027s not the problem.\n \u003e \u003e\n \u003e \u003e Tempest is used by lots of people in their own environment for\n \u003e \u003e validation. If I am an operator and don\u0027t want (or care) to have\n \u003e \u003e the import functionality work, I may very much prefer to run\n \u003e \u003e glance-api under uwsgi, like all the other API services. In that\n \u003e \u003e case, I would not be able to run tempest against my deployment\n \u003e \u003e without a failure, or long timeout unless the test itself can\n \u003e \u003e detect that a function is not enabled. You could argue that they\n \u003e \u003e should \"just know\" that they need to disable the methods before\n \u003e \u003e running the test, or that tempest should have a conf knob to\n \u003e \u003e disable that test. I obviously think that if we\u0027re running in\n \u003e pure\n \u003e \u003e WSGI mode and *know* that the import methods can\u0027t work, we\n \u003e should\n \u003e \u003e refuse to expose that they do.\n \u003e \u003e\n \u003e \u003e Maybe you didn\u0027t see this, but devstack now deploys glance in\n \u003e \u003e standalone mode by default unless you *ask* for wsgi mode,\n \u003e separate\n \u003e \u003e from all the other services. So by default, import is testable in\n \u003e \u003e our CI.\n \u003e \u003e\n \u003e \u003e https://review.opendev.org/#/c/741258/\n \u003e \u003e\n \u003e \u003e \u003e So far I still have enough integrity and some\n \u003e \u003e \u003e respect towards QA to not do that. If we take that route we\n \u003e might\n \u003e \u003e \u003e as well just drop those jobs off the check and gate.\n \u003e \u003e\n \u003e \u003e I\u0027m missing something. Which jobs do you want to drop? Are you\n \u003e \u003e suggesting that glance stop supporting pure WSGI mode at all? If\n \u003e \u003e so, we should delete wsgi_app.py from the tree (or at least mark\n \u003e it\n \u003e \u003e as deprecated/unsupported).\n \u003e \n \u003e Yeah, we need to consider Tempest a very valid API user and\n \u003e /v2/info/import API should be reflecting the reality as much as it\n \u003e can. we know none of the import method work when glance in wsgi\n \u003e mode so returning failure makes this API more reliable. Also help\n \u003e operator to miss-configuration if they are in the impression that\n \u003e glance under wsgi with CONF.enabled_import_methods\u003dTrue make import\n \u003e feature available for their users.\n \u003e \n \u003e From Tempest perspective, as dan mentioned, API telling if import\n \u003e is ready to use or not is best way instead of adding feature flag.\n \u003e If glance did not have /v2/info/import API then yes we can add\n \u003e feature flag in tempest side.\n\ns/CONF.enabled_import_methods\u003dTrue/CONF.enabled_import_methods\u003d[\u0027glance-direct\u0027, \u0027web-download\u0027, \u0027copy-image\u0027]\n\nor default value of CONF.enabled_import","accounts_in_message":[],"_revision_number":4},{"id":"5d406cb545db18e1509f4d02f6ff06463bc36c51","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-07-20 18:12:03.000000000","message":"Patch Set 4:\n\nSomehow I agree with erno\u0027s concern that uwsgi with glance has many issues with uwsgi since its introduction and there were no constructive efforts taken to resolve those issues.\n\nBut as we are making progress by introducing new import workflow, import plugins, multiple stores support we should also make sure that we have enough CI jobs, tempest etc to verify this work.\n\nIMHO, if we are not supporting running under uwsgi then we should remove this support from glance forever unless someone is interested in fixing it.","accounts_in_message":[],"_revision_number":4},{"id":"8500cfb76a71fb0928adecebe11d95135ecaf0f7","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-20 18:14:32.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"01d74dced9a753298d2ce38b4b13a1892eb94456","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-07-20 18:15:02.000000000","message":"Patch Set 4:\n\ngrenade job should be green with latest 741675","accounts_in_message":[],"_revision_number":4},{"id":"407aa3c3aa24fecbf214ba719378e92d63988ad1","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-20 18:23:41.000000000","message":"Patch Set 4:\n\n\u003e I\u0027m missing something. Which jobs do you want to drop? Are you\n \u003e suggesting that glance stop supporting pure WSGI mode at all? If\n \u003e so, we should delete wsgi_app.py from the tree (or at least mark it\n \u003e as deprecated/unsupported).\n\nRemoving it to avoid confusion would be the optimal approach. It\u0027s been unsupported from the very first release it was in due to the fact that it was broken and no-one wanted to fix it.","accounts_in_message":[],"_revision_number":4},{"id":"9279c7b0e6530513ae1026a3368a2557b0c2b409","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2020-07-20 18:31:11.000000000","message":"Patch Set 4:\n\n\u003e As an operator with multiple clouds, I think that we should _NOT_\n \u003e start Glance if it\u0027s operating in a configuration that is not\n \u003e working.\n \u003e \n \u003e While we love a unicorn world where everyone is using glance-api\n \u003e eventlet server and image import, that\u0027s just not the reality of\n \u003e things.  With a lot of deployments using mod_wsgi OR uwsgi (OSA).\n \u003e \n \u003e Are we really blocking this on actual _user friendly behaviour_?\n\nI\u0027m more than happy to follow up on this request as soon as our CI is not relying it anymore. We\u0027ve tried to get there for ~3 years now and as Dan pointed out it looks like we\u0027re finally getting there. Babysteps","accounts_in_message":[],"_revision_number":4},{"id":"1e902bea0f81ebfebc4663167859f00d51df0709","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-20 18:42:28.000000000","message":"Patch Set 4:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":4},{"id":"0f1c868a6c9e7870dd23313cb3aba12df6ddc271","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-07-20 19:09:03.000000000","message":"Patch Set 4:\n\nThis actually seems like a reasonable approach to me.\n\nThe wsgi mode with glance is still a dumpster fire, but at least this helps prevent some badness, while allowing some operation if things are not configured in a way we know it is bad.","accounts_in_message":[],"_revision_number":4},{"id":"b9dc7ccfe8bdc1f2ef5b91f5fb4b888b0d9a8fc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-20 19:51:32.000000000","message":"Patch Set 4:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/f422339625cb4f93b85fc16ea2521dd6 : SUCCESS in 56m 37s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/8cba8c2c36d54ed88402a2e0721d4dfa : SUCCESS in 1h 12m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d5e7f369e5794f8da3f639aeddf241ae : SUCCESS in 6m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9aba80d1f9c84ad19a991da48d217e2c : SUCCESS in 8m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a2f93c5c267408eaf486603df0bca69 : SUCCESS in 5m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1a78f1dba20448229cc38c4b31fad79d : FAILURE in 17m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d1cda22b0df49bcb4a96358268dceaf : SUCCESS in 6m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d44f041b346e48de843285c8f8a27e67 : SUCCESS in 6m 04s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/6351cc2c3ab940d4aaed945472d57943 : TIMED_OUT in 30m 55s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/9fffa7c14ac544a78046fa2d5c850215 : TIMED_OUT in 31m 10s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/a4cdcb63fe464d9a9535db283ad59417 : SUCCESS in 6m 36s\n- devstack-plugin-ceph-tempest-py3 https://zuul.opendev.org/t/openstack/build/2e17e3c271374a578b6027994a368002 : FAILURE in 10m 40s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2067671f3a7c406f85c37444c1d7c041 : SUCCESS in 59m 35s","accounts_in_message":[],"_revision_number":4},{"id":"79c54a718e6eb88d38a7811e44ec6691f83749e9","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-21 00:43:56.000000000","message":"Patch Set 4: Workflow-1","accounts_in_message":[],"_revision_number":4},{"id":"33d73725fa3d88bb39c17d3381df415b32afdd0c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-07-30 15:34:24.000000000","message":"Abandoned\n\nThis is moot now.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"28ed1ab184b569a246d777669b2b1deb0127688c","revisions":{"67e47c644032c24d05ba56e765a32ae63d7bc1e2":{"kind":"REWORK","_number":1,"created":"2020-07-16 16:58:07.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/97/741497/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/741497/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/741497/1"}}},"commit":{"parents":[{"commit":"769d057c6baafd5b42aa0a5c9b3439190b715551","subject":"Merge \"Switch from unittest2 compat methods to Python 3.x methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/769d057c6baafd5b42aa0a5c9b3439190b715551"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 16:56:51.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 16:56:51.000000000","tz":-420},"subject":"RFC: Enforce that import methods are not enabled in pure WSGI mode","message":"RFC: Enforce that import methods are not enabled in pure WSGI mode\n\nWe know that glance cannot run async tasks when running in pure WSGI\nmode. This means import cannot work, and we should not advertise via\nthe API that it can. This patch adds a check to the pure-WSGI init_app()\nmethod to refuse to start if enabled_import_methods is not empty.\n\nChange-Id: Id1f761dccb5760a2a56fa78e737440b0588e81e6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/67e47c644032c24d05ba56e765a32ae63d7bc1e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/67e47c644032c24d05ba56e765a32ae63d7bc1e2"}]},"branch":"refs/heads/master"},"3ec673aacc1d59636cd4128e7b7f10feb3962a9c":{"kind":"REWORK","_number":2,"created":"2020-07-16 17:33:46.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/97/741497/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/741497/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/741497/2"}}},"commit":{"parents":[{"commit":"769d057c6baafd5b42aa0a5c9b3439190b715551","subject":"Merge \"Switch from unittest2 compat methods to Python 3.x methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/769d057c6baafd5b42aa0a5c9b3439190b715551"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 16:56:51.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 17:33:50.000000000","tz":-420},"subject":"Enforce that import methods are not enabled in pure WSGI mode","message":"Enforce that import methods are not enabled in pure WSGI mode\n\nWe know that glance cannot run async tasks when running in pure WSGI\nmode. This means import cannot work, and we should not advertise via\nthe API that it can. This patch adds a check to the pure-WSGI init_app()\nmethod to refuse to start if enabled_import_methods is not empty.\n\nChange-Id: Id1f761dccb5760a2a56fa78e737440b0588e81e6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3ec673aacc1d59636cd4128e7b7f10feb3962a9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/3ec673aacc1d59636cd4128e7b7f10feb3962a9c"}]},"branch":"refs/heads/master"},"c2073b1d51ad6e161b22dada61ec210637999761":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2020-07-16 20:37:22.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/97/741497/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/741497/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/741497/3"}}},"commit":{"parents":[{"commit":"769d057c6baafd5b42aa0a5c9b3439190b715551","subject":"Merge \"Switch from unittest2 compat methods to Python 3.x methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/769d057c6baafd5b42aa0a5c9b3439190b715551"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 16:56:51.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 20:37:15.000000000","tz":-420},"subject":"Enforce that import methods are not enabled in pure WSGI mode","message":"Enforce that import methods are not enabled in pure WSGI mode\n\nWe know that glance cannot run async tasks when running in pure WSGI\nmode. This means import cannot work, and we should not advertise via\nthe API that it can. This patch adds a check to the pure-WSGI init_app()\nmethod to refuse to start if enabled_import_methods is not empty.\n\nDepends-On: https://review.opendev.org/#/c/741507/\nChange-Id: Id1f761dccb5760a2a56fa78e737440b0588e81e6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c2073b1d51ad6e161b22dada61ec210637999761"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c2073b1d51ad6e161b22dada61ec210637999761"}]},"branch":"refs/heads/master"},"28ed1ab184b569a246d777669b2b1deb0127688c":{"kind":"REWORK","_number":4,"created":"2020-07-17 16:42:17.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/97/741497/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/741497/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/741497/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/741497/4"}}},"commit":{"parents":[{"commit":"769d057c6baafd5b42aa0a5c9b3439190b715551","subject":"Merge \"Switch from unittest2 compat methods to Python 3.x methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/769d057c6baafd5b42aa0a5c9b3439190b715551"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-16 16:56:51.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-07-17 16:42:01.000000000","tz":-420},"subject":"Enforce that import methods are not enabled in pure WSGI mode","message":"Enforce that import methods are not enabled in pure WSGI mode\n\nWe know that glance cannot run async tasks when running in pure WSGI\nmode. This means import cannot work, and we should not advertise via\nthe API that it can. This patch adds a check to the pure-WSGI init_app()\nmethod to refuse to start if enabled_import_methods is not empty.\n\nDepends-On: https://review.opendev.org/741507\nDepends-On: https://review.opendev.org/741675\nChange-Id: Id1f761dccb5760a2a56fa78e737440b0588e81e6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/28ed1ab184b569a246d777669b2b1deb0127688c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/28ed1ab184b569a246d777669b2b1deb0127688c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}