)]}'
{"id":"openstack%2Fglance~745708","triplet_id":"openstack%2Fglance~master~Ib57afd6d74d0a39ab1a8b8ca91ef81a9acf31e9c","project":"openstack/glance","branch":"master","topic":"bug/1891190","hashtags":[],"change_id":"Ib57afd6d74d0a39ab1a8b8ca91ef81a9acf31e9c","subject":"Increase aggression in functional base API worker management","status":"ABANDONED","created":"2020-08-11 16:41:23.000000000","updated":"2020-08-11 23:49:38.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"41f28d7dcedf3f7e412786752d0849473d94a3c1","_number":745708,"virtual_id_number":745708,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-08-11 16:41:46.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-08-11 17:01:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-08-11 17:16:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-11 16:41:46.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-11 17:01:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6338a8d14de9694319e0823106df4d1030adbb38","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-11 16:41:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"273ad5968cbf856cfcadbb96dd00a74c046cd049","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-11 16:41:46.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"90cf3ad62f80e8ae44a24afa4ac488f7aa175a5a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-11 17:01:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/61b736b015b345008f467ef1a1d496e6 : SUCCESS in 5m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/faab19306d0840faa7ca86b91fb792b7 : SUCCESS in 5m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8c954624ab0549ed8961981870996f67 : SUCCESS in 5m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/607491bc520c4310b7bd67cfc8ec7935 : SUCCESS in 6m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/275ed59be150412492bcce760bab63a7 : SUCCESS in 6m 21s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8ee19ff744c94b3889a24463f7ef3341 : FAILURE in 16m 37s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/0f272b2ccbfe49d48b68507aa837fd3c : SUCCESS in 8m 17s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/990f0703262b4186a3827aec8b3c0f01 : SUCCESS in 11m 09s","accounts_in_message":[],"_revision_number":1},{"id":"f9e9298a90b2e4cf559121ca3a8bea77a7216030","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-11 17:16:35.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"beef1c79b559966155dd2f0e6cf6e05a2885651d","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-11 23:49:38.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c2b198f26125f4dba4ea733be182ae10318e4429","revisions":{"c2b198f26125f4dba4ea733be182ae10318e4429":{"kind":"REWORK","_number":1,"created":"2020-08-11 16:41:23.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/08/745708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/08/745708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/745708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/745708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/745708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/08/745708/1"}}},"commit":{"parents":[{"commit":"ed3296b23a452391bbe11116e060d4b49235523e","subject":"Merge \"Inspect upload/import stream and set virtual_size\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/ed3296b23a452391bbe11116e060d4b49235523e"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-11 16:36:27.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-11 16:36:27.000000000","tz":-420},"subject":"Increase aggression in functional base API worker management","message":"Increase aggression in functional base API worker management\n\nThe functional test base attempts to send a single SIGINT to the\nAPI master process it starts, and then calls waitpid() for it to\nexit. If the master never exits, this will hang forever, as is the\ncase in the referenced bug, which we see in CI a lot.\n\nThis change makes us specifically always send SIGKILL to our API\nmaster child, and also traverse its entire tree of children making\nsure that they are killed as well. In testing, I definitely see\nsome of the cases where the hang would have manifested where this\nextra child killing takes out some child processes that were lost\nby the master. It seems that the SIGHUPing that happens in test_reload()\ntriggers this behavior.\n\nThis patch does not fix the problem, but does make the test infrastructure\nbe more aggressive about cleaning up.\n\nChange-Id: Ib57afd6d74d0a39ab1a8b8ca91ef81a9acf31e9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c2b198f26125f4dba4ea733be182ae10318e4429"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c2b198f26125f4dba4ea733be182ae10318e4429"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}