)]}'
{"id":"openstack%2Fglance~745937","triplet_id":"openstack%2Fglance~master~I11c7edaefc96236d2757acfb70d9c338c0f51348","project":"openstack/glance","branch":"master","topic":"bug/1891352","hashtags":[],"change_id":"I11c7edaefc96236d2757acfb70d9c338c0f51348","subject":"Poll for final state on test_copy_image_revert_lifecycle()","status":"MERGED","created":"2020-08-12 17:13:27.000000000","updated":"2020-08-26 06:26:57.000000000","submitted":"2020-08-18 22:18:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"745937-1597789125060-39e11680","meta_rev_id":"89127a525f58e042e3fd3d0deedb3ce9e26e4559","_number":745937,"virtual_id_number":745937,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-18 22:18:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"date":"2020-08-18 16:57:54.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-18 16:57:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2020-08-18 16:57:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2020-08-18 16:57:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-08-18 16:57:25.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-13 07:12:44.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-08-18 16:40:46.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-08-18 16:57:54.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-08-18 22:18:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1bf7e0a2b1722633393acc73619b5711f77d3d9e","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-12 17:13:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3f6f2365b3645f49a9f51695eddcfe90ce5c07bb","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-12 17:14:09.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"bcff1718e9dd5e599fe8523d624ca0fa007fd172","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-12 17:48:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/16024ca4044348b78f0d3cf13f2ba6a2 : SUCCESS in 5m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1324077e6c924cb3a2b8c3d2b49f01e8 : SUCCESS in 6m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/365bb2b93ff54a71806ee8b168513659 : SUCCESS in 5m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/06dffe6492da44cc866ea31f355e17d6 : SUCCESS in 6m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eed971168d93458f9b1fcde34380e52d : SUCCESS in 6m 12s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a26f5917ef2146ccb084e3e13b8a91df : SUCCESS in 11m 19s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/eb98f84872824c3e8b8ea32a3d2b40c0 : SUCCESS in 8m 46s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/d8585c2cfe4340cbb75e5488f530c682 : SUCCESS in 4m 14s","accounts_in_message":[],"_revision_number":1},{"id":"ba7b0ffa07e265bd1e86c49c4c86632429bb28c4","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-08-13 07:12:44.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1","accounts_in_message":[],"_revision_number":1},{"id":"5e46e83a27f835a84c15dc58f5cedf478d6f00a8","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-08-18 16:40:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLooks right to me.","accounts_in_message":[],"_revision_number":1},{"id":"a40771e9ffe320222684f984b33dc8978a1dd5dd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 16:41:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a54e9f6be8023f2f9d9400b6f7e2d715abddbdcd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 16:56:46.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"75d99cf91e87d88ca5c936007042f8331b698295","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-08-18 16:57:25.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"4deacb97b13fb802c60629905dd9808d080fb2ad","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-08-18 16:57:54.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- ext-glance-zuul : NOT_REGISTERED","accounts_in_message":[],"_revision_number":2},{"id":"48d2401a9b1091a7a7eae16c3526552fdae70ffb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 17:08:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f4cfd2e0ae9e4551a64215bd14380628 : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f4330eaeaec4b1d8d7b73b4fea1862c : SUCCESS in 4m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9ccdec7053f444809191a7224227bcab : SUCCESS in 4m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/81bad5a54a3b4fa3830268a8cf7fa23f : SUCCESS in 6m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4aff789f8e864b55b6bb92595af26322 : SUCCESS in 6m 26s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8c91154a09114c88b3b6ad703f377bc9 : SUCCESS in 8m 33s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/780bdad70a304516a44b27bc20c135c0 : SUCCESS in 9m 44s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/ba1b4e799a8f471a9bd29ab89dafa2cf : SUCCESS in 5m 33s","accounts_in_message":[],"_revision_number":2},{"id":"48d7a1992ad31e708d2134834f69ed77f7f45404","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 19:49:50.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"dafe95f781f2f60d70766af0464c1db0126a5acc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 22:18:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1e7c0182ad9a4e1f888c243040581e5a : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/612e387589da40b4823d2376e7835470 : SUCCESS in 4m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c76c701a4e724903b29c03c508a96cc8 : SUCCESS in 4m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2f484c384713453f8f254972b2d4352b : SUCCESS in 6m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa857a4bf91a4e01a4001a6f23450630 : SUCCESS in 6m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8275f2d4b91a435da0ebc64ec061b953 : SUCCESS in 7m 48s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/33c9d5762acd49709ac61a38bf656059 : SUCCESS in 9m 01s","accounts_in_message":[],"_revision_number":2},{"id":"36a20de1eecaa3cc10720a2d79262c0813a261f5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 22:18:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"f5605dabc75018d565187de4bba2a3fa91b70daa","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-18 22:21:20.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/312fe7ca99d5494b965e4b4cd48dda09 : SUCCESS in 1m 00s","accounts_in_message":[],"_revision_number":2},{"id":"3988e531e0a56d0579578b912aec3498f3b8eca2","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-08-26 06:26:57.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6c96319eeb36274bed31466941dd83e7d9713cfd","revisions":{"28f3d80d3e681f28b29847e58a31717893bd7434":{"kind":"REWORK","_number":1,"created":"2020-08-12 17:13:27.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/37/745937/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/37/745937/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/37/745937/1"}}},"commit":{"parents":[{"commit":"4da88018bc2eb700952dbeac70bd9557ff963e2e","subject":"Fix import failure status reporting when all_stores_must_succeed\u003dTrue","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/4da88018bc2eb700952dbeac70bd9557ff963e2e"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-12 16:22:30.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-12 17:13:24.000000000","tz":-420},"subject":"Poll for final state on test_copy_image_revert_lifecycle()","message":"Poll for final state on test_copy_image_revert_lifecycle()\n\nThis test currently simulates failure by pre-deleting the store\ndirectory for \u0027file3\u0027 which is the second of a two-store import\noperation. The goal is to assert that the later failure reverts\nthe import of the earlier \u0027file2\u0027 store. However, the way the\npolling loop works is that we break out once \u0027file2\u0027 has completed,\nand then assume that \u0027file3\u0027 has already failed and reverted.\nThis is a race, and one we\u0027re losing consistently in CI.\n\nThis patch waits for the failure of \u0027file3\u0027 to be reported, as\nwell as the revert of \u0027file2\u0027 to occur before exiting the polling\nloop and checking the final state of things to ensure that the\nrevert has actually happened. This addresses the non-determinism\ninherent in the original test.\n\nChange-Id: I11c7edaefc96236d2757acfb70d9c338c0f51348\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/28f3d80d3e681f28b29847e58a31717893bd7434"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/28f3d80d3e681f28b29847e58a31717893bd7434"}]},"branch":"refs/heads/master"},"6c96319eeb36274bed31466941dd83e7d9713cfd":{"kind":"NO_CHANGE","_number":2,"created":"2020-08-18 16:57:25.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/37/745937/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/37/745937/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/37/745937/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/37/745937/2"}}},"commit":{"parents":[{"commit":"737dfca83c8d347ef22eab7afca4057ce5f03f20","subject":"Fix import failure status reporting when all_stores_must_succeed\u003dTrue","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/737dfca83c8d347ef22eab7afca4057ce5f03f20"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-12 16:22:30.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dms@danplanet.com","date":"2020-08-18 16:57:25.000000000","tz":0},"subject":"Poll for final state on test_copy_image_revert_lifecycle()","message":"Poll for final state on test_copy_image_revert_lifecycle()\n\nThis test currently simulates failure by pre-deleting the store\ndirectory for \u0027file3\u0027 which is the second of a two-store import\noperation. The goal is to assert that the later failure reverts\nthe import of the earlier \u0027file2\u0027 store. However, the way the\npolling loop works is that we break out once \u0027file2\u0027 has completed,\nand then assume that \u0027file3\u0027 has already failed and reverted.\nThis is a race, and one we\u0027re losing consistently in CI.\n\nThis patch waits for the failure of \u0027file3\u0027 to be reported, as\nwell as the revert of \u0027file2\u0027 to occur before exiting the polling\nloop and checking the final state of things to ensure that the\nrevert has actually happened. This addresses the non-determinism\ninherent in the original test.\n\nChange-Id: I11c7edaefc96236d2757acfb70d9c338c0f51348\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/6c96319eeb36274bed31466941dd83e7d9713cfd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/6c96319eeb36274bed31466941dd83e7d9713cfd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}