)]}'
{"id":"openstack%2Fglance~749508","triplet_id":"openstack%2Fglance~stable%2Fussuri~Ibd0c802efa2723e11ece1097c9bf1ad68b1a820c","project":"openstack/glance","branch":"stable/ussuri","topic":"bug/1884596","hashtags":[],"change_id":"Ibd0c802efa2723e11ece1097c9bf1ad68b1a820c","subject":"Add functional test for task status updating","status":"MERGED","created":"2020-09-02 14:15:19.000000000","updated":"2020-09-14 17:13:29.000000000","submitted":"2020-09-14 17:07:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"749508-1600103236192-9fd2f9ed","meta_rev_id":"00c2040ba75554d2e2e9818512be002a92d5d1ab","_number":749508,"virtual_id_number":749508,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-14 17:07:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-03 15:02:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2020-09-14 15:23:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2020-09-14 15:23:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-09-03 15:02:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-02 14:46:00.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-09-14 15:23:30.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-09-14 17:07:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"20d8c2d9cbf9048de8b188977a8f5b4276f2ddbc","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-09-02 14:15:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ab05064facc946ae89c0032597a939aa6ccaef63","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-09-02 14:46:00.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1","accounts_in_message":[],"_revision_number":1},{"id":"f05c5663eada5e9cdb87b508d9b2f69235c8347f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 15:32:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dce03386bc944314bfa8fa39e0968098 : SUCCESS in 6m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/59cf0a2695694da69086d1cf1c585157 : FAILURE in 5m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ff2044015fd54472ba48187af8d97956 : SUCCESS in 5m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7e13dc6d31fc4e2887e362fffc512985 : SUCCESS in 5m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/534a94d4faf94139a4e14c9d245ac387 : SUCCESS in 5m 59s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/7a5b33fc221a4e4ea118222da976ce69 : FAILURE in 8m 47s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/9a399e63c3c043beac78b8716dc8153e : SUCCESS in 10m 08s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/2f9e26d2bf63433a9fe0e3f5d4c759cb : SUCCESS in 5m 26s\n\nWarning:\n  Comments left for invalid file glance/tests/utils.py","accounts_in_message":[],"_revision_number":1},{"id":"600213891d530c0e93246f5ab3a67539e1cddf4c","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-09-03 15:02:03.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"008855bdb512636f84a06f19e6030527048a256c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 17:09:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7cfa89e5af3e496588867b9cac313446 : SUCCESS in 5m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/592022cc85f74abe9aded8b342eb82d6 : SUCCESS in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e75f4e737f2e45a5898917b7080bd334 : SUCCESS in 5m 05s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9fd6baf589c84a1b93cac97bc012df64 : SUCCESS in 5m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/67f2bfd982c84403a50865f975ddd95c : SUCCESS in 6m 28s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/63460edc093043a494b0938e694ab56c : SUCCESS in 7m 31s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/8e5db2085a1747d996d23595acccf1be : SUCCESS in 7m 42s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/a7fcc7f0711b4e32a5f02a5ee6fc39da : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":2},{"id":"999f900a57c8261b35b8aacb3d06d8d37ceaa9ca","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-09-14 15:23:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nMerged to master, good to backport.","accounts_in_message":[],"_revision_number":2},{"id":"a7ae7ce8f47b35096392e8956c27bfe7a06220a3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 15:24:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"12bed6951cc45c4ff5d898e248b41a1319703b28","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 17:07:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/15d0b60c29224b0884a5fc7aed3c12da : SUCCESS in 4m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35c6175b1bdc45919d2a1e442e61e15e : SUCCESS in 5m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/96d18899c68e4eadb2baa837cde9a19b : SUCCESS in 4m 40s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fb5726e28b644f29aba5b1d113bc82a9 : SUCCESS in 5m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7a05a671b20f46aeb49bd266a0098595 : SUCCESS in 5m 49s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/7cae64ca287e48ebb9e116b3110e711f : SUCCESS in 7m 08s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/9d1d5717db674e48998042babb06a90f : SUCCESS in 7m 14s","accounts_in_message":[],"_revision_number":2},{"id":"10d7a13481a1acb25641f338eb444394aedd9dd9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 17:07:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2d67a21815206133200924961fc612184cf5789f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-14 17:13:29.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/335e6536ad644c7fb0fbfa74aa8fcd76 : SUCCESS in 1m 12s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7ba0762dd80fd35ae97523b15493be76c79e31bb","revisions":{"f86038d1edc70bd0d777b74aacfcc96de6869231":{"kind":"REWORK","_number":1,"created":"2020-09-02 14:15:19.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/08/749508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/08/749508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/08/749508/1"}}},"commit":{"parents":[{"commit":"337a5b340eea919d0a7c72287ddc9e7d28cdd06e","subject":"Add FakeData generator test utility","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/337a5b340eea919d0a7c72287ddc9e7d28cdd06e"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-07 18:56:28.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-09-02 14:14:21.000000000","tz":-420},"subject":"Add functional test for task status updating","message":"Add functional test for task status updating\n\nThis was really hard to test before the introduction of the\nSynchronousAPIBase test class, so this is added after that patch for\nconvenience.\n\nThis tests uses two mocks, but it\u0027s otherwise quite \"functional\" in its\nrealness. It mocks out the timer so it always fires, and it mocks out\nthe effective call to glance_store and uses that as a hook to grab the\ntask state in lockstep (and avoid making another copy of the fake data\non disk, since we need to generate a couple MiB of data to test this).\n\nChange-Id: Ibd0c802efa2723e11ece1097c9bf1ad68b1a820c\n(cherry picked from commit 1b006c4f44e56d08d5ca1fb9090dc83990395d87)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/f86038d1edc70bd0d777b74aacfcc96de6869231"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/f86038d1edc70bd0d777b74aacfcc96de6869231"}]},"branch":"refs/heads/stable/ussuri"},"7ba0762dd80fd35ae97523b15493be76c79e31bb":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-09-03 15:02:03.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/08/749508/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/08/749508/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/08/749508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/08/749508/2"}}},"commit":{"parents":[{"commit":"173fdb1968f7bc106040bd6beb3a02663a6138cd","subject":"Add FakeData generator test utility","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/173fdb1968f7bc106040bd6beb3a02663a6138cd"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-07 18:56:28.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-09-03 15:00:35.000000000","tz":-420},"subject":"Add functional test for task status updating","message":"Add functional test for task status updating\n\nThis was really hard to test before the introduction of the\nSynchronousAPIBase test class, so this is added after that patch for\nconvenience.\n\nThis tests uses two mocks, but it\u0027s otherwise quite \"functional\" in its\nrealness. It mocks out the timer so it always fires, and it mocks out\nthe effective call to glance_store and uses that as a hook to grab the\ntask state in lockstep (and avoid making another copy of the fake data\non disk, since we need to generate a couple MiB of data to test this).\n\nChange-Id: Ibd0c802efa2723e11ece1097c9bf1ad68b1a820c\n(cherry picked from commit 1b006c4f44e56d08d5ca1fb9090dc83990395d87)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7ba0762dd80fd35ae97523b15493be76c79e31bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7ba0762dd80fd35ae97523b15493be76c79e31bb"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}