)]}'
{"id":"openstack%2Fglance~749509","triplet_id":"openstack%2Fglance~stable%2Fussuri~I59e3b5d5d4b69f076092b9950c0d34467a6636ad","project":"openstack/glance","branch":"stable/ussuri","topic":"bug/1884596","hashtags":[],"change_id":"I59e3b5d5d4b69f076092b9950c0d34467a6636ad","subject":"Move SynchronousAPIBase to a generalized location","status":"MERGED","created":"2020-09-02 14:15:19.000000000","updated":"2020-09-18 00:16:13.000000000","submitted":"2020-09-18 00:14:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"749509-1600388087230-72df3f54","meta_rev_id":"7b662a2317616e8db772d6df669a11eb6a083c6f","_number":749509,"virtual_id_number":749509,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-18 00:14:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-09-03 15:02:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":2,"date":"2020-09-17 21:07:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":1,"date":"2020-09-17 21:07:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-09-03 15:02:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-02 14:50:50.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2020-09-17 21:07:32.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-09-18 00:14:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"30e6373bfd9d5a25d8bdbcd468a6e9d74dbac3ca","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-09-02 14:15:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40dbc6a4ebf40f6f07dcd02e666234b3defa642d","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-09-02 14:50:50.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1","accounts_in_message":[],"_revision_number":1},{"id":"32e1bcda50f1b9a3698be3991feb7598c0bd90ca","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-02 15:30:42.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/065c1859941f4c72a1ddfce0b8b92551 : SUCCESS in 5m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a3d6114e2f9940cbbf98d2113a3c127e : FAILURE in 5m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/25aca9393fd94b5483a0b4274677ff9b : SUCCESS in 4m 37s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/8a25775c5de549cbb13b1a8515b5b2a2 : SUCCESS in 6m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/69c7ef4b5d204f31b657f2500420f4a7 : SUCCESS in 6m 43s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/02b7139845604145ba63eee3001a8064 : SUCCESS in 7m 52s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/a78e74175f334f808c434006a362157f : SUCCESS in 7m 09s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/26834754ae9e4df680b7540376024bb3 : SUCCESS in 5m 19s\n\nWarning:\n  Comments left for invalid file glance/tests/utils.py","accounts_in_message":[],"_revision_number":1},{"id":"a93fc4333b7ecb090ecbd6349d334599aa490bf0","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2020-09-03 15:02:03.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a14213f8e97923ee0bd2f3636c8a0ea5c0a9df8e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-03 17:20:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/efaec6f8e4f946a7b38f015179bc4142 : SUCCESS in 10m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e8ab99f97e624083a473032211e15e66 : SUCCESS in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2a6b4fe5190d4a9ab28ddeb90d785d0f : SUCCESS in 9m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5ae41b68d53a4ac6a81fc453e16a25c9 : SUCCESS in 6m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e687509a9702486e851dae3befcf9772 : SUCCESS in 7m 34s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/9be8cd0b5e6e4d03b2b9829ffd6eff37 : SUCCESS in 9m 18s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/a932a5b8a14448a190403209b2fcedbc : SUCCESS in 11m 03s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/a799317bd49e4ce89ff5380faed807d1 : SUCCESS in 4m 09s","accounts_in_message":[],"_revision_number":2},{"id":"8cd83ef68ae812bd00fb591474037d97b25473c4","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-09-17 21:07:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLooks good. Merged to master.","accounts_in_message":[],"_revision_number":2},{"id":"330088a853ab04ca9c6be3bdbc6674aac9abbdc5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-17 21:07:58.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"cdc7264a3a47d058f77a3cac69ba12d93f98c37c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 00:14:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c98a3a7fefd84959906e6dae6153e846 : SUCCESS in 4m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7426f47421784f3cb0d69c5d6fe31892 : SUCCESS in 4m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/41ca1bfdbaba4f9fb1271766712fa5c4 : SUCCESS in 4m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f44a9b13c7ef44c58fbad64ee06dbee5 : SUCCESS in 5m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f958c15d784d4b9499df0236485ede08 : SUCCESS in 6m 10s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c3e4837620c04693a0880cbdba4c78fd : SUCCESS in 7m 45s\n- openstack-tox-functional-py37 https://zuul.opendev.org/t/openstack/build/55bf68a4d3034cafb272c377be7cf823 : SUCCESS in 6m 57s","accounts_in_message":[],"_revision_number":2},{"id":"a635fcae3b5ade60f93fb775ec1e836300147847","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 00:14:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1efcd98f107b6d9d38732de6355dc5219025e383","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-18 00:16:13.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a38c1e89014742f582f753bdc555685b : SUCCESS in 1m 02s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"beece27e0b2a7009e84e8888d4b6b395567b9458","revisions":{"b272ffe8a29012d3929706d34c60400ba502d0de":{"kind":"REWORK","_number":1,"created":"2020-09-02 14:15:19.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/749509/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/09/749509/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/09/749509/1"}}},"commit":{"parents":[{"commit":"f86038d1edc70bd0d777b74aacfcc96de6869231","subject":"Add functional test for task status updating","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/f86038d1edc70bd0d777b74aacfcc96de6869231"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-10 16:09:43.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-09-02 14:14:21.000000000","tz":-420},"subject":"Move SynchronousAPIBase to a generalized location","message":"Move SynchronousAPIBase to a generalized location\n\nThe base class for the tests added in test_images_import_locking provides\na mechanism to make API cals directly against the WSGI stack, without\nstarting a separate server and using the local networking. This is useful\nfor cases where fault injection of global state needs to be altered, where\nthis is very difficult in the existing fork-and-exec functional test\nmodel.\n\nThis moves that test base class out to the functional module, expands the\ndocumentation a little, and also generalizes the request methods for\nwider applicability.\n\nChange-Id: I59e3b5d5d4b69f076092b9950c0d34467a6636ad\n(cherry picked from commit 36cbc50e7d70699d6ca5dd4fa81844567e39ddf0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b272ffe8a29012d3929706d34c60400ba502d0de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b272ffe8a29012d3929706d34c60400ba502d0de"}]},"branch":"refs/heads/stable/ussuri"},"beece27e0b2a7009e84e8888d4b6b395567b9458":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-09-03 15:02:03.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/09/749509/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/09/749509/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/749509/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/09/749509/2"}}},"commit":{"parents":[{"commit":"7ba0762dd80fd35ae97523b15493be76c79e31bb","subject":"Add functional test for task status updating","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7ba0762dd80fd35ae97523b15493be76c79e31bb"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-08-10 16:09:43.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2020-09-03 15:00:35.000000000","tz":-420},"subject":"Move SynchronousAPIBase to a generalized location","message":"Move SynchronousAPIBase to a generalized location\n\nThe base class for the tests added in test_images_import_locking provides\na mechanism to make API cals directly against the WSGI stack, without\nstarting a separate server and using the local networking. This is useful\nfor cases where fault injection of global state needs to be altered, where\nthis is very difficult in the existing fork-and-exec functional test\nmodel.\n\nThis moves that test base class out to the functional module, expands the\ndocumentation a little, and also generalizes the request methods for\nwider applicability.\n\nChange-Id: I59e3b5d5d4b69f076092b9950c0d34467a6636ad\n(cherry picked from commit 36cbc50e7d70699d6ca5dd4fa81844567e39ddf0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/beece27e0b2a7009e84e8888d4b6b395567b9458"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/beece27e0b2a7009e84e8888d4b6b395567b9458"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}