)]}'
{"bin/glance":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"b405eab95628a14c0cf69af2fba692e0e7c10dd7","unresolved":false,"context_lines":[{"line_number":214,"context_line":"EXAMPLES"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"%(prog)s add name\u003d\"My Image\" disk_format\u003draw container_format\u003dovf \\\\"},{"line_number":218,"context_line":"    location\u003dhttp://images.ubuntu.org/images/lucid-10.04-i686.iso \\\\"},{"line_number":219,"context_line":"    distro\u003d\"Ubuntu 10.04 LTS\""},{"line_number":220,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAHX%2F%2F6tg%3D","side":"PARENT","line":217,"updated":"2012-05-17 13:40:46.000000000","message":"Are the backslashes deliberate here, i.e to indicate that the example command line extends over several lines.\n\nIn that case, I would replace the double backslash with a single one, so that the example command line can be copied\u0027n\u0027pasted to a shell prompt.","commit_id":"77552aaac77b3e25b57a865b0643443d68a145ee"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"2cfbb563004672319f49c44d002c836543dee0a1","unresolved":false,"context_lines":[{"line_number":214,"context_line":"EXAMPLES"},{"line_number":215,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"%(prog)s add name\u003d\"My Image\" disk_format\u003draw container_format\u003dovf \\\\"},{"line_number":218,"context_line":"    location\u003dhttp://images.ubuntu.org/images/lucid-10.04-i686.iso \\\\"},{"line_number":219,"context_line":"    distro\u003d\"Ubuntu 10.04 LTS\""},{"line_number":220,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAHX%2F%2F6tI%3D","side":"PARENT","line":217,"in_reply_to":"AAAAHX%2F%2F6tg%3D","updated":"2012-05-17 13:51:22.000000000","message":"I was also wondering why there were two slashes. I\u0027ll replace this into single backslashes","commit_id":"77552aaac77b3e25b57a865b0643443d68a145ee"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"b405eab95628a14c0cf69af2fba692e0e7c10dd7","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        print \"\u003d\" * 80"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    if (not options.force and len(images) \u003d\u003d limit and"},{"line_number":597,"context_line":"        not user_confirm(\"Fetch next page?\", True)):"},{"line_number":598,"context_line":"        return SUCCESS"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    parameters[\"marker\"] \u003d images[-1][\u0027id\u0027]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAHX%2F%2F6tc%3D","line":597,"updated":"2012-05-17 13:40:46.000000000","message":"Also an opportunity to simplify via de Morgan\u0027s:\n\n  -   if (not options.force and len(images) \u003d\u003d limit and\n  -       not user_confirm(\"Fetch next page?\", True)):\n  +   if not (options.force and len(images) \u003d\u003d limit or\n  +            user_confirm(\"Fetch next page?\", True)):\n\nSimilar comments could be applied in several other places in this patch.","commit_id":"a0cf355260577cbae19f40259725e317f277128d"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"2cfbb563004672319f49c44d002c836543dee0a1","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        print \"\u003d\" * 80"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    if (not options.force and len(images) \u003d\u003d limit and"},{"line_number":597,"context_line":"        not user_confirm(\"Fetch next page?\", True)):"},{"line_number":598,"context_line":"        return SUCCESS"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    parameters[\"marker\"] \u003d images[-1][\u0027id\u0027]"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAHX%2F%2F6tA%3D","line":597,"in_reply_to":"AAAAHX%2F%2F6tc%3D","updated":"2012-05-17 13:51:22.000000000","message":"will do","commit_id":"a0cf355260577cbae19f40259725e317f277128d"}],"glance/registry/db/api.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"b405eab95628a14c0cf69af2fba692e0e7c10dd7","unresolved":false,"context_lines":[{"line_number":784,"context_line":"    query \u003d session.query(models.ImageTag).\\"},{"line_number":785,"context_line":"                    filter_by(image_id\u003dimage_id).\\"},{"line_number":786,"context_line":"                    filter_by(value\u003dvalue).\\"},{"line_number":787,"context_line":"                    filter_by(deleted\u003dFalse)"},{"line_number":788,"context_line":"    try:"},{"line_number":789,"context_line":"        tag_ref \u003d query.one()"},{"line_number":790,"context_line":"    except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F6tk%3D","line":787,"updated":"2012-05-17 13:40:46.000000000","message":"Why leave the black-slashes in place here but not elsewhere?\n\nWould the following change make sense for consistency:\n\n\n  -    query \u003d session.query(models.ImageTag).\\\n  -                    filter_by(image_id\u003dimage_id).\\\n  -                    filter_by(value\u003dvalue).\\\n  -                    filter_by(deleted\u003dFalse)\n  +    query \u003d (session.query(models.ImageTag).\n  +                     filter_by(image_id\u003dimage_id).\n  +                     filter_by(value\u003dvalue).\n  +                     filter_by(deleted\u003dFalse))","commit_id":"a0cf355260577cbae19f40259725e317f277128d"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"2cfbb563004672319f49c44d002c836543dee0a1","unresolved":false,"context_lines":[{"line_number":784,"context_line":"    query \u003d session.query(models.ImageTag).\\"},{"line_number":785,"context_line":"                    filter_by(image_id\u003dimage_id).\\"},{"line_number":786,"context_line":"                    filter_by(value\u003dvalue).\\"},{"line_number":787,"context_line":"                    filter_by(deleted\u003dFalse)"},{"line_number":788,"context_line":"    try:"},{"line_number":789,"context_line":"        tag_ref \u003d query.one()"},{"line_number":790,"context_line":"    except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F6s4%3D","line":787,"in_reply_to":"AAAAHX%2F%2F6tk%3D","updated":"2012-05-17 13:51:22.000000000","message":"In Nova, there are too many lines of sqlalchemy related backslashes that they were kept as it was. Your method should work but doesn\u0027t it seem a bit unorthodox?","commit_id":"a0cf355260577cbae19f40259725e317f277128d"}],"glance/tests/functional/test_bin_glance.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"b405eab95628a14c0cf69af2fba692e0e7c10dd7","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        line \u003d lines[0]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        _img_info \u003d [c.strip() for c in line.split()]"},{"line_number":157,"context_line":"        image_id, name, disk_format, container_format, size \u003d _img_info"},{"line_number":158,"context_line":"        self.assertEqual(\u0027MyImage\u0027, name)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F6to%3D","line":156,"updated":"2012-05-17 13:40:46.000000000","message":"We don\u0027t usually use leading underscores in temporary variable names (unlike pseudo-private method names).\n\nCan you replace this and else-where with img_info?","commit_id":"a0cf355260577cbae19f40259725e317f277128d"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"2cfbb563004672319f49c44d002c836543dee0a1","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        line \u003d lines[0]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        _img_info \u003d [c.strip() for c in line.split()]"},{"line_number":157,"context_line":"        image_id, name, disk_format, container_format, size \u003d _img_info"},{"line_number":158,"context_line":"        self.assertEqual(\u0027MyImage\u0027, name)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAHX%2F%2F6s0%3D","line":156,"in_reply_to":"AAAAHX%2F%2F6to%3D","updated":"2012-05-17 13:51:22.000000000","message":"will do","commit_id":"a0cf355260577cbae19f40259725e317f277128d"}]}