)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7d43e53334567f82508d8e46e8d14f0d7c69d7cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e58f4a40_b0b53806","updated":"2023-02-08 20:32:37.000000000","message":"Rebasing \u0026 reformatting so we can make a decision about this patch in the next review party.","commit_id":"438758db2feeb59d75d6432b84e449df52ba84d6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"43ecac7a88835c57eb53b4434f5ff6c866a62ba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c6d89339_c8868ea7","updated":"2023-02-09 14:35:21.000000000","message":"Thanks for adding this, I didn\u0027t realize it was undocumented.\n\nAs a followup, the admin page could possibly explain what the legal values for \u0027hashing_algorithm\u0027 are ... although that is very clearly explained in the help text for the config option, so it\u0027s probably not necessary.","commit_id":"438758db2feeb59d75d6432b84e449df52ba84d6"}],"doc/source/admin/os_hash_algo.rst":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"aa7b08355f1753f37fe80e5ebf44621659f37fda","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Secure Hash Algorithm Support(Multihash, providing secure hashing for image data)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_664817b3","line":7,"updated":"2020-09-30 20:37:05.000000000","message":"docs: Title overline too short.","commit_id":"a07f77d8eba8407de6b05d4127e846af674550d9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Secure Hash Algorithm Support(Multihash)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This release implements the Glance spec Secure Hash Algorithm Support."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_4fe7b1e4","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":30},"updated":"2020-10-05 16:19:59.000000000","message":"Missing space before the opening (. That will also align the title bar length with the title length.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Secure Hash Algorithm Support(Multihash)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This release implements the Glance spec Secure Hash Algorithm Support."},{"line_number":12,"context_line":"This feature supplements the current ‘checksum’ image property with a"},{"line_number":13,"context_line":"self-describing secure hash."},{"line_number":14,"context_line":"The self-description consists of two new image properties:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_0f065986","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":12},"updated":"2020-10-05 16:19:59.000000000","message":"Documentation shouldn\u0027t state things like \"this release\". The docs are for multiple releases, so inferring a specific release may be slightly confusing.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This release implements the Glance spec Secure Hash Algorithm Support."},{"line_number":12,"context_line":"This feature supplements the current ‘checksum’ image property with a"},{"line_number":13,"context_line":"self-describing secure hash."},{"line_number":14,"context_line":"The self-description consists of two new image properties:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_af3bed36","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":12},"updated":"2020-10-05 16:19:59.000000000","message":"Instead of \"this feature\", I think it would be better to state \"The Secure Hash Algorithm feature\"","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":13,"context_line":"self-describing secure hash."},{"line_number":14,"context_line":"The self-description consists of two new image properties:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":" - os_hash_algo - this contains the name of the secure hash algorithm"},{"line_number":17,"context_line":"   used to generate the value on this image"},{"line_number":18,"context_line":" - os_hash_value - this is the hexdigest computed by applying the"},{"line_number":19,"context_line":"   secure hash algorithm named in the os_hash_algo property to"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_af000d37","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":1},"updated":"2020-10-05 16:19:59.000000000","message":"These should not be indented. This causes the rendered HTML output to also blockquote the bullet list.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":19,"context_line":"   secure hash algorithm named in the os_hash_algo property to"},{"line_number":20,"context_line":"   the image data"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"os_hash_algo is operator-configurable:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Secure hashing algorithm used for computing the \u0027os_hash_value\u0027 property."},{"line_number":25,"context_line":"This option configures the Glance \"multihash\", which consists of two"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_6f59d58c","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":38},"updated":"2020-10-05 16:19:59.000000000","message":"This doesn\u0027t really explain well how the operator configures this. It should point out where the configuration option is set so an admin reading this documentation understands what they need to do.\n\nIt should also go into some detail on what the possible values are for os_hash_algo so they know what their options are when configuring it.\n\nAlso, remove the ending \":\" and make this into a title so it\u0027s clearly called out as a separate section. Maybe then also change the title to be something like \"Hash Algorithm Configuration\".","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"os_hash_algo is operator-configurable:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Secure hashing algorithm used for computing the \u0027os_hash_value\u0027 property."},{"line_number":25,"context_line":"This option configures the Glance \"multihash\", which consists of two"},{"line_number":26,"context_line":"image properties: the \u0027os_hash_algo\u0027 and the \u0027os_hash_value\u0027."},{"line_number":27,"context_line":"The \u0027os_hash_algo\u0027 will be populated by the value of this configuration"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_af248d0f","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":73},"updated":"2020-10-05 16:19:59.000000000","message":"This is an incomplete sentence. Should that be \"algorithm *is* used\"?\n\nChange the single quotes around os_hash_value to double backticks (``os_hash_algorith``) so it gets formatted in the output to make it stand out as a config option.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Secure hashing algorithm used for computing the \u0027os_hash_value\u0027 property."},{"line_number":25,"context_line":"This option configures the Glance \"multihash\", which consists of two"},{"line_number":26,"context_line":"image properties: the \u0027os_hash_algo\u0027 and the \u0027os_hash_value\u0027."},{"line_number":27,"context_line":"The \u0027os_hash_algo\u0027 will be populated by the value of this configuration"},{"line_number":28,"context_line":"option, and the \u0027os_hash_value\u0027 will be populated by the hexdigest"},{"line_number":29,"context_line":"computed when the algorithm is applied to the uploaded or imported"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_0f7939fa","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":60},"updated":"2020-10-05 16:19:59.000000000","message":"Same here.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eb93023975dff6cdab11b153635d8b36732e0f5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Secure Hash Algorithm Support (Multihash)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_1014ac4c","line":7,"updated":"2020-10-06 11:33:40.000000000","message":"Now you\u0027ve added an extra character for the title bar lines. Remove that.","commit_id":"af3d094b0cfde753eafd0a0b0411c453f3e79a7d"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eb93023975dff6cdab11b153635d8b36732e0f5e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"secure hash algorithm named in the os_hash_algo property to"},{"line_number":21,"context_line":"the image data"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":24,"context_line":"Hash Algorithm Configuration"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_700a4827","line":23,"updated":"2020-10-06 11:33:40.000000000","message":"This shouldn\u0027t be at the top title level. Remove the line over the top of the title and just have the bottom line.","commit_id":"af3d094b0cfde753eafd0a0b0411c453f3e79a7d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"078d70367e6271c76a6bee4c8160173f49550270","unresolved":true,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"``os_hash_algo`` will be populated by the value of the configuration"},{"line_number":29,"context_line":"option ``hashing_algorith`` in the ``glance.conf`` file. The ``os_hash_value``"},{"line_number":30,"context_line":"value will be populated by the hexdigest computed when the algorithm is applied"},{"line_number":31,"context_line":"to the uploaded or imported image data."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"1b8ddf9e_e57e0e34","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":25},"updated":"2021-03-29 14:31:30.000000000","message":"hashing_algorithm ???","commit_id":"19166b92474473c231abba75f34b52e4266ac66f"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"7d43e53334567f82508d8e46e8d14f0d7c69d7cd","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"``os_hash_algo`` will be populated by the value of the configuration"},{"line_number":29,"context_line":"option ``hashing_algorith`` in the ``glance.conf`` file. The ``os_hash_value``"},{"line_number":30,"context_line":"value will be populated by the hexdigest computed when the algorithm is applied"},{"line_number":31,"context_line":"to the uploaded or imported image data."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"37f1913b_38047d63","line":29,"range":{"start_line":29,"start_character":9,"end_line":29,"end_character":25},"in_reply_to":"1b8ddf9e_e57e0e34","updated":"2023-02-08 20:32:37.000000000","message":"Done","commit_id":"19166b92474473c231abba75f34b52e4266ac66f"}],"doc/source/user/os_hash_algo.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Secure Hash Algorithm Support(Multihash)"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This release implements the Glance spec Secure Hash Algorithm Support."}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_afcdad5f","line":8,"range":{"start_line":8,"start_character":28,"end_line":8,"end_character":30},"updated":"2020-10-05 16:19:59.000000000","message":"Same here.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This release implements the Glance spec Secure Hash Algorithm Support."},{"line_number":12,"context_line":"This feature supplements the current ‘checksum’ image propertywith a"},{"line_number":13,"context_line":"self-describing secure hash."},{"line_number":14,"context_line":"The self-description consists of two new image properties:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_8f4d49c7","line":12,"range":{"start_line":12,"start_character":54,"end_line":12,"end_character":66},"updated":"2020-10-05 16:19:59.000000000","message":"property with","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbc364ae446ab200461ee507c503daccf1513775","unresolved":false,"context_lines":[{"line_number":19,"context_line":"   secure hash algorithm named in the os_hash_algo property to"},{"line_number":20,"context_line":"   the image data"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"os_hash_algo is operator-configurable:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Secure hashing algorithm used for computing the \u0027os_hash_value\u0027 property."},{"line_number":25,"context_line":"This option configures the Glance \"multihash\", which consists of two"}],"source_content_type":"text/x-rst","patch_set":8,"id":"9f560f44_4fd171cc","line":22,"updated":"2020-10-05 16:19:59.000000000","message":"Since this page is under the user docs, it shouldn\u0027t go into details about the configuration of this setting. This page should explain how the user can view the set values to do any kind of checking on their end about the hash.\n\nIt might make more sense to leave user docs out completely, unless there is a specific action the user can take based on these properties.","commit_id":"04c0a8c528a0c029049276d170ca52829a74b059"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"64f8e701dd9eac2d8846a1d8e41d2021508832a4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"option, and the ``os_hash_value`` will be populated by the hexdigest"},{"line_number":29,"context_line":"computed when the algorithm is applied to the uploaded or imported"},{"line_number":30,"context_line":"image data."},{"line_number":31,"context_line":"These are read-only image properties and are not user-modifiable."},{"line_number":32,"context_line":"The multihash implemented in Secure Hash Algorithm Support"},{"line_number":33,"context_line":"is images computed only for new images. There is no provision for"},{"line_number":34,"context_line":"computing the multihash for existing images."}],"source_content_type":"text/x-rst","patch_set":9,"id":"9f560f44_f3fb0212","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":65},"updated":"2020-10-06 11:34:18.000000000","message":"Then what does the user need to know here if they can\u0027t do anything with this information?","commit_id":"af3d094b0cfde753eafd0a0b0411c453f3e79a7d"}]}