)]}'
{"id":"openstack%2Fglance~757774","triplet_id":"openstack%2Fglance~master~I6f6592ecd78c1611880a27112ef54fdd586874d2","project":"openstack/glance","branch":"master","topic":"image-query-optimize","hashtags":[],"change_id":"I6f6592ecd78c1611880a27112ef54fdd586874d2","subject":"Optimize image query code execution order","status":"NEW","created":"2020-10-13 08:54:46.000000000","updated":"2020-10-16 11:43:18.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e661cb148e1ed82d146125f1ed1ede67cc7d3831","_number":757774,"virtual_id_number":757774,"owner":{"_account_id":32538,"name":"fangwenjiang","email":"jiangfw@inspur.com","username":"fangwenjiang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-10-16 11:43:18.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"date":"2020-10-16 10:30:53.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-13 08:54:57.000000000","updated_by":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"reviewer":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"state":"REVIEWER"},{"updated":"2020-10-13 11:01:27.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-10-13 13:07:52.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-10-16 10:30:53.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-16 11:43:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"94361986d1a1bc66357f6db8b13ea39ecd509d22","author":{"_account_id":32538,"name":"fangwenjiang","email":"jiangfw@inspur.com","username":"fangwenjiang"},"date":"2020-10-13 08:54:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3d037c3b3cd17d712d8944b124c88548e0b683e5","author":{"_account_id":10068,"name":"Welcome, new contributor!","username":"welcome-message"},"date":"2020-10-13 08:54:57.000000000","message":"Patch Set 1:\n\nCongratulations, you\u0027ve proposed your first change in OpenDev.\n\nYour submission will now be tested automatically by Zuul, our gatekeeper,\nand reviewed by other friendly developers. They will give you feedback and\nmay require you to refine it.\n\nPeople seldom get their patch approved on the first try, so don\u0027t be\nconcerned if requested to make corrections. Feel free to modify your patch\nand resubmit a new change-set.\n\nPatches often take days (and sometimes weeks) to get reviewed, so be\npatient. Don\u0027t hesitate to ask for help, and answer questions about your\nwork promptly if you can. The more you get to know reviewers and get to be\nknown by them, the smoother the review and approval process will become. The\nfastest way to accomplish this is by reviewing other proposed changes\nyourself: anybody can do it, and it\u0027s a great way to learn the code base.\n\nThanks again for participating in OpenDev, we look forward to seeing you\naround.\n\nWorkflow Guide: https://docs.openstack.org/infra/manual/developers.html","accounts_in_message":[],"_revision_number":1},{"id":"516635c11ea26e62e085edefbaa029dc46434d0d","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-10-13 11:01:27.000000000","message":"Patch Set 1: Code-Review-1\n\nPlease point out the unit test coverage that shows that this change does not cause a regression, or add tests if there aren\u0027t any.","accounts_in_message":[],"_revision_number":1},{"id":"d98f00c39637ad86e35ff8a535980f54f4859e29","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-10-13 13:07:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8c655ef5357cc80599ae6ad4fe36dfb45021d2b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-13 13:49:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/39f3b45b80614ad1ae0fc07f2542eb69 : SUCCESS in 1h 01m 15s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/a74d00b4e1144a518d112ec2f4587371 : SUCCESS in 1h 13m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4bff95b1fbf74862afa92275a711c07c : SUCCESS in 6m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5365c88dc2cb48218f2168a823def4cb : SUCCESS in 4m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d2d03df2bad745a3806ea3c0b54dcb06 : SUCCESS in 5m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bb4fc79c88d54e12afa3592e6f940964 : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a3fdf4226d2b4a1986d2ab5f26267a14 : SUCCESS in 6m 59s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a3a52d8988b440e3a285384aa167c4ce : SUCCESS in 6m 52s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/adb0996d218a4ebab644a64d20a9f205 : SUCCESS in 8m 10s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/b8ad1596f1a3439bbaec60853da302b5 : SUCCESS in 3m 55s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/9c5cf6729ac4416ea3ee0076b3d449d5 : SUCCESS in 1h 11m 02s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/52cf50df8bd34ca589fd2a14067a07e5 : SUCCESS in 1h 13m 03s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/aa11451a953b4b708ed8a5b1c319b79b : SUCCESS in 1h 08m 52s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/b053a7d684e94fa1a8beebb1450f04d6 : FAILURE in 1h 13m 25s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a779de0aba73472fbb82bdfa5e727a74 : SUCCESS in 1h 02m 52s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f9e4c47da1914bc1b4e2f47fbe1faff5 : SUCCESS in 1h 46m 45s","accounts_in_message":[],"_revision_number":1},{"id":"f3a27361f29deda4826cbf00309b609b5176fa93","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-10-14 17:24:34.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-glance http://207.189.188.190/logs/74/757774/1/check-not-vote/ext-glance-zuul/d7e57fc : FAILURE in 17m 37s","accounts_in_message":[],"_revision_number":1},{"id":"e181e9635ea07aaa3154ffe713763f54ecd882e4","author":{"_account_id":32538,"name":"fangwenjiang","email":"jiangfw@inspur.com","username":"fangwenjiang"},"date":"2020-10-16 10:14:49.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"164a765c0134092024776d9317e598db1202eaab","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-10-16 10:30:53.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- dsvm-glance http://207.189.188.190/logs/74/757774/2/check-not-vote/ext-glance-zuul/950296c : FAILURE in 15m 42s","accounts_in_message":[],"_revision_number":2},{"id":"62cbcd87c45065f81aeae486402d71fc8bbc2122","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-16 11:43:18.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/e6796d95dc4040dba2e893a8a8dd6162 : SUCCESS in 1h 03m 07s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/3ef62f522dd84f29985a8a8e1aa7d6b4 : FAILURE in 1h 10m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d8471aba00f04ed095a3e8d3b28387c8 : SUCCESS in 7m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/88d99159342c43cb9f5a79fe041de1c2 : SUCCESS in 5m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f82a6012e63047c59dcd4d01eb0d36b1 : SUCCESS in 6m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d9a1bf8b26ff494ba7d88703a068f298 : SUCCESS in 6m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9663abdae6b249e4a0147ece135171d5 : SUCCESS in 7m 13s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/314527a5c47f449f9001a926536d79d4 : SUCCESS in 9m 14s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/38f56277e69b4cb5a398eccb0653e76b : SUCCESS in 7m 59s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/c09e1780588440918bf01b3ce719f1c3 : SUCCESS in 5m 25s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/8c49424cce204e92853b425dac4c0b6b : SUCCESS in 1h 22m 00s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/085857c4969f42c9ac52c1608a0f0e84 : SUCCESS in 1h 11m 50s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/7d9de3704f7a4ea69bab96358987afa4 : SUCCESS in 1h 16m 52s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/c9673cf4cef342e2b268ed03da3bff9c : SUCCESS in 1h 12m 14s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f7d5eca945764b71a310bff1d9a5669c : SUCCESS in 1h 06m 27s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/042e987402624ca7b63ea56f0b8d408a : SUCCESS in 1h 06m 59s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"29306a6da0e0a6e018a73162c116858ba370fbfa","revisions":{"5c896f5f779478ed242f93b784c6077c5a744ebc":{"kind":"REWORK","_number":1,"created":"2020-10-13 08:54:46.000000000","uploader":{"_account_id":32538,"name":"fangwenjiang","email":"jiangfw@inspur.com","username":"fangwenjiang"},"ref":"refs/changes/74/757774/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/757774/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/757774/1"}}},"commit":{"parents":[{"commit":"1344c45772c1a77107f621632642cf1488e431db","subject":"Adding gate job for glance cinder store","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/1344c45772c1a77107f621632642cf1488e431db"}]}],"author":{"name":"fangwenjiang","email":"jiangfw@inspur.com","date":"2020-10-13 08:39:47.000000000","tz":480},"committer":{"name":"fangwenjiang","email":"jiangfw@inspur.com","date":"2020-10-13 08:39:47.000000000","tz":480},"subject":"Optimize code logic Adjust code execution order to reduce code redundancy and branch.","message":"Optimize code logic\nAdjust code execution order to reduce code redundancy and branch.\n\nChange-Id: I6f6592ecd78c1611880a27112ef54fdd586874d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5c896f5f779478ed242f93b784c6077c5a744ebc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5c896f5f779478ed242f93b784c6077c5a744ebc"}]},"branch":"refs/heads/master"},"29306a6da0e0a6e018a73162c116858ba370fbfa":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-10-16 10:14:49.000000000","uploader":{"_account_id":32538,"name":"fangwenjiang","email":"jiangfw@inspur.com","username":"fangwenjiang"},"ref":"refs/changes/74/757774/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/757774/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/757774/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/757774/2"}}},"commit":{"parents":[{"commit":"1344c45772c1a77107f621632642cf1488e431db","subject":"Adding gate job for glance cinder store","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/1344c45772c1a77107f621632642cf1488e431db"}]}],"author":{"name":"fangwenjiang","email":"jiangfw@inspur.com","date":"2020-10-13 08:39:47.000000000","tz":480},"committer":{"name":"fangwenjiang","email":"jiangfw@inspur.com","date":"2020-10-16 10:14:25.000000000","tz":0},"subject":"Optimize image query code execution order","message":"Optimize image query code execution order\n\nModify code execution order to reduce code redundancy and branch, \nbut do not change the execution logic.The original unit test cases have \nbeen covered, so it is not necessary to add unit test cases.\n\nChange-Id: I6f6592ecd78c1611880a27112ef54fdd586874d2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/29306a6da0e0a6e018a73162c116858ba370fbfa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/29306a6da0e0a6e018a73162c116858ba370fbfa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}