)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b9fc78a7797bd0e85750e695e7093cdd15b8c13","unresolved":true,"context_lines":[{"line_number":10,"context_line":"\u0027alter\u0027 on a table column, something that is only possible once you\u0027ve"},{"line_number":11,"context_line":"monkey patched sqlalchemy by importing the \u0027migrate\u0027 module. Resolve"},{"line_number":12,"context_line":"this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic71710aebafa38dceeead104b3e97fafa4bb4362"},{"line_number":15,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a0fade4b_94c5ce34","line":13,"updated":"2021-07-19 18:55:55.000000000","message":"Implements: blueprint remove-sqlalchemy-migrate ?","commit_id":"77676e833f861373e07de7ab04c6a56c8d37fc78"}],"glance/db/sqlalchemy/alembic_migrations/versions/ocata_expand01_add_visibility.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b9fc78a7797bd0e85750e695e7093cdd15b8c13","unresolved":true,"context_lines":[{"line_number":143,"context_line":"    with op.batch_alter_table(\u0027images\u0027) as batch_op:"},{"line_number":144,"context_line":"        batch_op.alter_column("},{"line_number":145,"context_line":"            \u0027is_public\u0027, nullable\u003dTrue, server_default\u003dNone,"},{"line_number":146,"context_line":"            existing_type\u003dBoolean())"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":4,"id":"401f565c_57a2bb4c","line":146,"range":{"start_line":146,"start_character":12,"end_line":146,"end_character":35},"updated":"2021-07-19 18:55:55.000000000","message":"what happens if this is not provided?","commit_id":"77676e833f861373e07de7ab04c6a56c8d37fc78"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"51b94712d16c14513619e07bb8496438382bea13","unresolved":true,"context_lines":[{"line_number":143,"context_line":"    with op.batch_alter_table(\u0027images\u0027) as batch_op:"},{"line_number":144,"context_line":"        batch_op.alter_column("},{"line_number":145,"context_line":"            \u0027is_public\u0027, nullable\u003dTrue, server_default\u003dNone,"},{"line_number":146,"context_line":"            existing_type\u003dBoolean())"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":4,"id":"71126496_0c76dd05","line":146,"range":{"start_line":146,"start_character":12,"end_line":146,"end_character":35},"in_reply_to":"401f565c_57a2bb4c","updated":"2021-07-20 09:03:58.000000000","message":"alembic refuses to run on MySQL. You have to specify this, unfortunately. From the docs [1]:\n\n\u003e MySQL has special requirements here, since MySQL cannot ALTER a column without a full specification. When producing MySQL-compatible migration files, it is recommended that the existing_type, existing_server_default, and existing_nullable parameters be present, if not being altered.\n\n[1] https://alembic.sqlalchemy.org/en/latest/ops.html#alembic.operations.Operations.alter_column","commit_id":"77676e833f861373e07de7ab04c6a56c8d37fc78"}]}