)]}'
{"id":"openstack%2Fglance~762793","triplet_id":"openstack%2Fglance~stable%2Fqueens~Ieecfb11928f74a504b35172a2c96d3a8cba057c0","project":"openstack/glance","branch":"stable/queens","hashtags":[],"change_id":"Ieecfb11928f74a504b35172a2c96d3a8cba057c0","subject":"fix properties\u0027 missing underline for VirtCPUTopology","status":"ABANDONED","created":"2020-11-16 08:08:35.000000000","updated":"2022-05-11 14:30:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2139b0e25b7bee81c9aca128571095a800fb5470","_number":762793,"virtual_id_number":762793,"owner":{"_account_id":31804,"name":"Ryo Hayakawa","email":"ryo@redhat.com","username":"ryohayakawa"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-11-16 10:12:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":-1,"date":"2020-12-11 03:52:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-16 08:08:35.000000000","updated_by":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"reviewer":{"_account_id":24849,"name":"yao ning","email":"zay11022@163.com","username":"mslovy"},"state":"REVIEWER"},{"updated":"2020-11-16 10:12:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-11 03:52:48.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"state":"REVIEWER"},{"updated":"2020-12-11 03:53:00.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2020-12-11 03:53:00.000000000","updated_by":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"}],"messages":[{"id":"a167796e9422f22ec072dd233f631da07b7690b0","author":{"_account_id":31804,"name":"Ryo Hayakawa","email":"ryo@redhat.com","username":"ryohayakawa"},"date":"2020-11-16 08:08:35.000000000","message":"Patch Set 1: Cherry Picked from branch stable/rocky.","accounts_in_message":[],"_revision_number":1},{"id":"7bf4f824439ed7303d55e075ecfc9c0563367623","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-11-16 08:13:48.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"451a7f222c7ea65f43b0cd5986d8078c626e7517","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-16 10:12:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/ab79974954634a9da360a04bd350e943 : SUCCESS in 6m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b036ea64fd14ce78274f2263b5eb039 : SUCCESS in 5m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fd97d9bdeb5748b1bb5c8bb1e21d4425 : SUCCESS in 5m 49s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f6a643ce1d82441aa3ddc017ddbfd245 : SUCCESS in 7m 25s\n- tempest-full https://zuul.opendev.org/t/openstack/build/e3705bcaff4743bda4904282ee8ecda4 : SUCCESS in 1h 25m 03s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/6f305e9e681b4bf8b52e297b85a90857 : SUCCESS in 1h 00m 51s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5865649b55114303bfa9749bb762454e : SUCCESS in 1h 18m 55s\n- openstack-tox-functional https://zuul.opendev.org/t/openstack/build/5e20713b7a0f48ecb1ec43f51efd2a65 : SUCCESS in 8m 07s\n- openstack-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/9ded0f0906c24770a93b2697f8f4f2aa : SUCCESS in 10m 57s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/ecb47cd2258e498db9790c6527db780d : FAILURE in 1h 03m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5480dca0c1152aa8a355059f3845920acb87b3d2","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2020-12-11 03:52:48.000000000","message":"Patch Set 2: Code-Review-1\n\nHello,\n\nThanks for taking the time to create this backport. Unfortunately, I do not think we will be able to merge it upstream because of the Glance rules regarding backports.\n\n@Abhishek: can you confirm this?","accounts_in_message":[],"_revision_number":2},{"id":"fb0229df39e65db37dadc1ebd5579d2d196d36c1","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2020-12-15 14:08:27.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e Hello,\n\u003e \n\u003e Thanks for taking the time to create this backport. Unfortunately, I do not think we will be able to merge it upstream because of the Glance rules regarding backports.\n\u003e \n\u003e @Abhishek: can you confirm this?\n\nYou are right cyril, upstream backports can be allowed maximum upto two previous stable branches unless its security or very important fix.","accounts_in_message":[],"_revision_number":2},{"id":"2139b0e25b7bee81c9aca128571095a800fb5470","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2022-05-11 14:30:36.000000000","message":"Abandoned\n\nThis does not fit with our backport criteria [0]\n\n[0] https://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"eb22a53e63d4aef9ed9ce160eb25c845fdd4404a","revisions":{"2fd72067e04db9638b0d81ee02bf35d666af39ec":{"kind":"REWORK","_number":1,"created":"2020-11-16 08:08:35.000000000","uploader":{"_account_id":31804,"name":"Ryo Hayakawa","email":"ryo@redhat.com","username":"ryohayakawa"},"ref":"refs/changes/93/762793/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/93/762793/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/93/762793/1"}}},"commit":{"parents":[{"commit":"cc4f74d112bb93cec0e51a37eea1d509b5ad1776","subject":"Merge \"Mitigate OSSN-0075\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/cc4f74d112bb93cec0e51a37eea1d509b5ad1776"}]}],"author":{"name":"Ning Yao","email":"yaoning@unitedstack.com","date":"2019-09-04 03:56:35.000000000","tz":480},"committer":{"name":"Ryo Hayakawa","email":"ryo@redhat.com","date":"2020-11-16 08:08:35.000000000","tz":0},"subject":"fix properties\u0027 missing underline for VirtCPUTopology","message":"fix properties\u0027 missing underline for VirtCPUTopology\n\nAccording to the docs:\nhttps://opendev.org/openstack/nova-specs/src/branch/master/specs/juno/implemented/virt-driver-vcpu-topology.rst,\ncpu_maxsockets, cpu_maxcores, cpu_maxthreads should be cpu_max_sockets, cpu_max_cores, cpu_max_threads.\n\nChange-Id: Ieecfb11928f74a504b35172a2c96d3a8cba057c0\nSigned-off-by: Ning Yao \u003cyaoning@unitedstack.com\u003e\n(cherry picked from commit da277c583a2b9a311c4ba66c5856e501944e11d8)\n(cherry picked from commit faa06f61409656ed7af67ca19c2c9519fd4ab7d8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2fd72067e04db9638b0d81ee02bf35d666af39ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2fd72067e04db9638b0d81ee02bf35d666af39ec"}]},"branch":"refs/heads/stable/queens"},"eb22a53e63d4aef9ed9ce160eb25c845fdd4404a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-16 08:13:48.000000000","uploader":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"ref":"refs/changes/93/762793/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/93/762793/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/93/762793/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/93/762793/2"}}},"commit":{"parents":[{"commit":"cc4f74d112bb93cec0e51a37eea1d509b5ad1776","subject":"Merge \"Mitigate OSSN-0075\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/cc4f74d112bb93cec0e51a37eea1d509b5ad1776"}]}],"author":{"name":"Ning Yao","email":"yaoning@unitedstack.com","date":"2019-09-04 03:56:35.000000000","tz":480},"committer":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2020-11-16 08:13:43.000000000","tz":0},"subject":"fix properties\u0027 missing underline for VirtCPUTopology","message":"fix properties\u0027 missing underline for VirtCPUTopology\n\nAccording to the docs:\nhttps://opendev.org/openstack/nova-specs/src/branch/master/specs/juno/implemented/virt-driver-vcpu-topology.rst,\ncpu_maxsockets, cpu_maxcores, cpu_maxthreads should be cpu_max_sockets, cpu_max_cores, cpu_max_threads.\n\nChange-Id: Ieecfb11928f74a504b35172a2c96d3a8cba057c0\nSigned-off-by: Ning Yao \u003cyaoning@unitedstack.com\u003e\n(cherry picked from commit da277c583a2b9a311c4ba66c5856e501944e11d8)\n(cherry picked from commit faa06f61409656ed7af67ca19c2c9519fd4ab7d8)\n(cherry picked from commit 3464b0cccd0ca34afc32faccf14ce17a35982040)\n(cherry picked from commit 9402601272d7aa0a9a35b8d57d13cb1fb099dc4e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/eb22a53e63d4aef9ed9ce160eb25c845fdd4404a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/eb22a53e63d4aef9ed9ce160eb25c845fdd4404a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}