)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b2f7583144402cb7a3c02904dc29da904b2e3916","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Additionally, future patches will introduce check string for"},{"line_number":16,"context_line":"system-personas when glance is a better position to adopt system-scope"},{"line_number":17,"context_line":"for administrative APIs."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id09ad3d3a6e96d9d77a9f8a43c755b1b6b9c9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a6cd2bb8_3d578b37","line":18,"updated":"2021-02-23 10:23:50.000000000","message":"We should add here tag\nRelated: blueprint secure-rbac","commit_id":"1b2ca9e5bcfff60ed0e1b2185c96dac4114432ee"}],"glance/policies/base.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7199acfa6db9477cf1764f1549b3cfaaf19cca88","unresolved":true,"context_lines":[{"line_number":13,"context_line":"from oslo_policy import policy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Generic check string used to protect APIs meant for system administrators."},{"line_number":16,"context_line":"SYSTEM_ADMIN \u003d \u0027role:all and system_scope:all\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Generic check string used to protect APIs means for system users with"},{"line_number":19,"context_line":"# read-only access to the API."}],"source_content_type":"text/x-python","patch_set":2,"id":"83b68a61_cdcd95d8","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":24},"updated":"2020-11-26 05:23:29.000000000","message":"this should be admin?","commit_id":"de48694d4f25bca28816fea958ace12156d83417"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e17fdc530ff5dfc1bca89b401f135ca5e7ef7052","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from oslo_policy import policy"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Generic check string used to protect APIs meant for system administrators."},{"line_number":16,"context_line":"SYSTEM_ADMIN \u003d \u0027role:all and system_scope:all\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Generic check string used to protect APIs means for system users with"},{"line_number":19,"context_line":"# read-only access to the API."}],"source_content_type":"text/x-python","patch_set":2,"id":"d655237b_e2704d68","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":24},"in_reply_to":"83b68a61_cdcd95d8","updated":"2020-11-30 21:41:15.000000000","message":"Done","commit_id":"de48694d4f25bca28816fea958ace12156d83417"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"7199acfa6db9477cf1764f1549b3cfaaf19cca88","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Generic check string used to protect APIs means for system users with"},{"line_number":19,"context_line":"# read-only access to the API."},{"line_number":20,"context_line":"SYSTEM_READER \u003d \u0027role:all and system_scope:all\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Generic check string for checking if a user is authorized on a paritcular"},{"line_number":23,"context_line":"# project, specifically with the member role."}],"source_content_type":"text/x-python","patch_set":2,"id":"f3eecaaa_d665bd82","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":25},"updated":"2020-11-26 05:23:29.000000000","message":"reader??","commit_id":"de48694d4f25bca28816fea958ace12156d83417"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e17fdc530ff5dfc1bca89b401f135ca5e7ef7052","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Generic check string used to protect APIs means for system users with"},{"line_number":19,"context_line":"# read-only access to the API."},{"line_number":20,"context_line":"SYSTEM_READER \u003d \u0027role:all and system_scope:all\u0027"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Generic check string for checking if a user is authorized on a paritcular"},{"line_number":23,"context_line":"# project, specifically with the member role."}],"source_content_type":"text/x-python","patch_set":2,"id":"d08af7c3_3c505aaa","line":20,"range":{"start_line":20,"start_character":22,"end_line":20,"end_character":25},"in_reply_to":"f3eecaaa_d665bd82","updated":"2020-11-30 21:41:15.000000000","message":"Done","commit_id":"de48694d4f25bca28816fea958ace12156d83417"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8c323ec1178d54fe03bd4ee50fb427178b42f993","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Composite check strings useful for APIs and resources that operate across"},{"line_number":33,"context_line":"# more than one scope."},{"line_number":34,"context_line":"SYSTEM_ADMIN_OR_PROJECT_MEMBER \u003d f\u0027({SYSTEM_ADMIN}) or ({PROJECT_MEMBER})\u0027"},{"line_number":35,"context_line":"SYSTEM_OR_PROJECT_READER \u003d f\u0027({SYSTEM_READER}) or ({PROJECT_READER})\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d4d10a4a_7a06a15d","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":34},"updated":"2021-02-19 14:48:55.000000000","message":"We can\u0027t be friends anymore.","commit_id":"d093dd7ffbe872fd3b752295325a087ac502a8ed"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"01028464cfda34e6af6e2f4450f96ee444b77b11","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Composite check strings useful for APIs and resources that operate across"},{"line_number":33,"context_line":"# more than one scope."},{"line_number":34,"context_line":"SYSTEM_ADMIN_OR_PROJECT_MEMBER \u003d f\u0027({SYSTEM_ADMIN}) or ({PROJECT_MEMBER})\u0027"},{"line_number":35,"context_line":"SYSTEM_OR_PROJECT_READER \u003d f\u0027({SYSTEM_READER}) or ({PROJECT_READER})\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"794feba5_23b615d4","line":34,"range":{"start_line":34,"start_character":33,"end_line":34,"end_character":34},"in_reply_to":"d4d10a4a_7a06a15d","updated":"2021-02-22 17:42:12.000000000","message":"Done :)","commit_id":"d093dd7ffbe872fd3b752295325a087ac502a8ed"}]}