)]}'
{"id":"openstack%2Fglance~770825","triplet_id":"openstack%2Fglance~master~I670f6db96998c8a2cec5d16fbca9f01857b866da","project":"openstack/glance","branch":"master","topic":"test-upgrade-checks","hashtags":[],"change_id":"I670f6db96998c8a2cec5d16fbca9f01857b866da","subject":"Fix upgrade checks for sheepdog","status":"MERGED","created":"2021-01-14 15:48:16.000000000","updated":"2021-01-19 15:44:12.000000000","submitted":"2021-01-19 15:41:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"770825-test-upgrade-checks","meta_rev_id":"8160799d24d904c7233c768caeb989cffa7ea1db","_number":770825,"virtual_id_number":770825,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-19 15:41:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2021-01-19 12:47:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2021-01-15 20:35:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":1,"date":"2021-01-19 12:47:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-15 12:20:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-15 15:08:08.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-01-15 20:35:34.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2021-01-19 12:47:19.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"}],"messages":[{"id":"484b63627b271fe64c063241897b0f229c995a08","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2021-01-14 15:48:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f992505886cb3dbe63da670b821a88287fb6893","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 12:20:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/bfb957f7c0b54206889af16a8e761a74 : SUCCESS in 1h 04m 00s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/ed75b4b5fd4749fc8e9e2f160f7efb87 : SUCCESS in 1h 12m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/93f5f4ccd78d470a99c456b517947940 : SUCCESS in 5m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e662a4b01ea942b2a4d75b4798a9691b : SUCCESS in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d4b4388a77ee4b2bbb28ee755787afd0 : SUCCESS in 5m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/552baf91c39943c9a5bcbdb618dfd0af : SUCCESS in 6m 43s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8187bda07acc4c3583b8c142361a2a46 : SUCCESS in 6m 04s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0c46ab18e86b4cbd8f6ae87deed85906 : SUCCESS in 8m 09s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8a7d88403e4c4956b96cce1eb2cf6371 : SUCCESS in 9m 45s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c2a46ab9fa3d4723b4c62afed0e775ad : SUCCESS in 7m 17s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/08b896217b8e492187f97677b8466d86 : SUCCESS in 4m 09s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/19ec9d7f9d964f8dbc99b8b896765c8d : SUCCESS in 1h 03m 09s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/12795f1d371a47b287ec9215ca7879f1 : SUCCESS in 1h 09m 44s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/53eb5f09db3d4076a89fa50075bf0cee : SUCCESS in 1h 29m 58s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/997fb6f4a3e642a8bc029f19168978ea : SUCCESS in 1h 20m 22s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3c32c387516f4b7a9c1a83853ff55685 : SUCCESS in 1h 06m 55s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2169f3b5566942e6aa511e28b7fb01d9 : SUCCESS in 1h 12m 08s","accounts_in_message":[],"_revision_number":1},{"id":"5bc7efa6667cb6c27633ac7deb7943ee790709ad","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-01-15 15:08:08.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-glance http://207.189.188.190/logs/770825/770825/1/check-not-vote/ext-glance-zuul/5999732 : FAILURE in 6m 28s","accounts_in_message":[],"_revision_number":1},{"id":"da5dd4d502783ac94793089e2cf5ca307788f497","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-01-15 20:35:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"900a53a16a9808bd7bd862e68e4a6aa7448be63b","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2021-01-19 12:47:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM, thanks Cyril!","accounts_in_message":[],"_revision_number":1},{"id":"307c65efa8f6dd399ecaa2954cff13840a5548a6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-19 12:48:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"50f9dd843ea210ae4acaed4333a377cf8ba1d7c2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-19 15:41:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/5f8ff964866e42c890581e7f5114b600 : SUCCESS in 1h 01m 07s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/1d3fd0e5091a49d6978ebe23147a96e9 : SUCCESS in 1h 12m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3cd0992df88c49269f2da55e72142d94 : SUCCESS in 6m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cb10a6b4a01e41a79b0aa0d35eee6970 : SUCCESS in 5m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7709b89bf8124eb0af2137e38f866e11 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6e5ece949fba4dbca7861614eb6908de : SUCCESS in 6m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d489de442754484887f86c8956a6e24c : SUCCESS in 6m 16s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/ac5356eda3454b9cbc16410d195614ff : SUCCESS in 7m 47s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1b4eb3703ef04975880c2c16f1bdd760 : SUCCESS in 6m 52s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/155974ce4d2249d78857cd6cc11a9eac : SUCCESS in 1h 11m 17s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/8605b024038745afb57328649ca2dd11 : SUCCESS in 1h 16m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/61983d747b3e46b4a1563c713dfd4c21 : SUCCESS in 58m 25s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/f6eee982eb5f425ba62420e98972751a : SUCCESS in 1h 05m 43s","accounts_in_message":[],"_revision_number":1},{"id":"c5cedc3acf89e2e562a0757cc5b48943829c8fe0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-19 15:41:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"8160799d24d904c7233c768caeb989cffa7ea1db","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-19 15:44:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6a7a4575bdc84c36a858974ded65e747 : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c7236a0897b87c0a0ee21655139e527d66ed7105","revisions":{"c7236a0897b87c0a0ee21655139e527d66ed7105":{"kind":"REWORK","_number":1,"created":"2021-01-14 15:48:16.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/25/770825/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/25/770825/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/770825/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/770825/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/770825/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/25/770825/1"}}},"commit":{"parents":[{"commit":"73742be99944d923031aa5f90e06051126b17007","subject":"Imported Translations from Zanata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/73742be99944d923031aa5f90e06051126b17007"}]}],"author":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2021-01-14 01:52:23.000000000","tz":60},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2021-01-14 15:47:50.000000000","tz":60},"subject":"Fix upgrade checks for sheepdog","message":"Fix upgrade checks for sheepdog\n\nWhen either CONF.enabled_backends or CONF.glance_store.stores is set to\nNone (which may happen if they are not actually specified in the config\nfile), a TypeError is raised. Fix this and add tests.\n\nChange-Id: I670f6db96998c8a2cec5d16fbca9f01857b866da\nCloses-Bug: #1911700\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c7236a0897b87c0a0ee21655139e527d66ed7105"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/c7236a0897b87c0a0ee21655139e527d66ed7105"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
