)]}'
{"id":"openstack%2Fglance~773357","triplet_id":"openstack%2Fglance~master~I9a39f57ab4ab29d62105812f82b3eb4c7548eb5c","project":"openstack/glance","branch":"master","topic":"collections.abc","hashtags":[],"change_id":"I9a39f57ab4ab29d62105812f82b3eb4c7548eb5c","subject":"Replace collections.Iterable","status":"MERGED","created":"2021-02-01 10:59:12.000000000","updated":"2021-06-23 20:41:39.000000000","submitted":"2021-06-23 20:38:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"773357-collections.abc","meta_rev_id":"2511343894c634f0905f2ffbb79e5749eeab5fb2","_number":773357,"virtual_id_number":773357,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-23 20:38:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"all":[{"value":2,"date":"2021-06-15 13:50:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":2,"date":"2021-06-23 16:30:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":1,"date":"2021-06-23 16:30:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-01 11:04:36.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-02-01 12:46:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-14 14:44:16.000000000","updated_by":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"reviewer":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"state":"REVIEWER"},{"updated":"2021-06-23 16:30:45.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"}],"messages":[{"id":"009ea41bd68593d8c0455d719483dadc9f4a3e73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-02-01 10:59:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c416874c25fa4282a6d9f30265d08c0f85a82dd6","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-02-01 11:04:36.000000000","message":"Patch Set 1:\n\nBuild failed\n\n- dsvm-glance http://207.189.188.190/logs/773357/773357/1/check-not-vote/ext-glance-zuul/995b081 : FAILURE in 4m 57s","accounts_in_message":[],"_revision_number":1},{"id":"1c02c8a42e904ac78074f842bdf5ed0093c3051d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 12:46:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/1deb2a26739d457a8f0c6527f06cc722 : SUCCESS in 57m 18s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/3a4a3fa2ad7540708ccecb17bd8a3f5c : SUCCESS in 1h 12m 01s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/de7ef2bbc3914a26976315666d86c3c9 : SUCCESS in 5m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d13d1e24530d434a864c202f8c008b2c : SUCCESS in 5m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b6afa0c29e6e460f8f66ea20a657f3e6 : SUCCESS in 4m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/54aec4cc7b4a410394b326c3052a5c1a : SUCCESS in 4m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3229909ba24840d4891c43d6d48a6b5f : SUCCESS in 4m 41s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f3d2c1ccb9df4ca4bd70586b8c759162 : SUCCESS in 8m 28s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/c93f5ae6485c4fa1bc1e6ec62a993501 : SUCCESS in 9m 12s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/c7415ea61d61462b873f64510521cbd9 : SUCCESS in 9m 13s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/6a6fbffc43404f548db5388824936245 : SUCCESS in 4m 50s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/49f8710dece349a78bab4334daf7e22d : SUCCESS in 1h 10m 00s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/6d1473a9a33440a7b916f92c263902c9 : SUCCESS in 1h 26m 22s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/d6078b1a381d47feae94b64d9c18b7c5 : SUCCESS in 1h 13m 45s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/2301a4f3e9cd4d2ca16caf101a10edc3 : SUCCESS in 1h 39m 21s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/4daca44b4bf246dfbd5f5c52dfd5af10 : SUCCESS in 1h 23m 00s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2194c228cab643dab761099221c4dcd7 : SUCCESS in 1h 02m 48s","accounts_in_message":[],"_revision_number":1},{"id":"bf5bf9b72e93a83fe09329fae73c896e132766e9","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2021-06-14 14:44:16.000000000","message":"Patch Set 1: Code-Review-1\n\nWe probably should just smash this together with all collections deprecation violations. There is only couple of them left in the codebase: glance/cmd/cache_manage.py and glance/tests/functional/db/test_migrations.py","accounts_in_message":[],"_revision_number":1},{"id":"2a793015dee5ecd3798572adfa5a02f7e8eaa1c0","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-06-15 13:17:51.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e We probably should just smash this together with all collections deprecation violations. There is only couple of them left in the codebase: glance/cmd/cache_manage.py\n\nI assume you\u0027re referring to the use of \u0027OrderedDict\u0027? That\u0027s still in \u0027collections\u0027, not \u0027collections.abc\u0027 [1]\n\n\u003e and glance/tests/functional/db/test_migrations.py\n\nI don\u0027t see any collections here (on master anyway)\n\n[1] https://docs.python.org/3/library/collections.html","accounts_in_message":[],"_revision_number":1},{"id":"cb5032745e9998365a830061317354cd1ccc19c4","author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"date":"2021-06-15 13:50:23.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e We probably should just smash this together with all collections deprecation violations. There is only couple of them left in the codebase: glance/cmd/cache_manage.py\n\u003e \n\u003e I assume you\u0027re referring to the use of \u0027OrderedDict\u0027? That\u0027s still in \u0027collections\u0027, not \u0027collections.abc\u0027 [1]\n\u003e \n\u003e \u003e and glance/tests/functional/db/test_migrations.py\n\u003e \n\u003e I don\u0027t see any collections here (on master anyway)\n\u003e \n\u003e [1] https://docs.python.org/3/library/collections.html\n\nOops, correct ... there\u0027s collections.defaultdict which is staying as well, so this is indeed the last one that is hanging behind. Thanks Stephen!","accounts_in_message":[],"_revision_number":1},{"id":"b44aa1c65da60939ac4ae2eaa87b9c02c0e65682","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-06-23 16:30:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLooks good to me!!","accounts_in_message":[],"_revision_number":1},{"id":"7ab0b3134a97898e858797afadd9cd1d0bf2e255","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-23 16:31:26.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"aadf5823f3d6c8dd69f16ed23481cc47aa276340","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-23 20:38:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/468ecf09c1ce42879f0fd583fec9e378 : SUCCESS in 1h 07m 38s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/bf008141272242fdade89419211c5fa6 : SUCCESS in 1h 14m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fa23a26c51244880854249861935adfe : SUCCESS in 7m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bd633957d27f490b8de489685d31a87f : SUCCESS in 7m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4a9e1d7254244f458d11d79f8f75dd4a : SUCCESS in 7m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b678374664eb4b7f8d95ebabc228b8ec : SUCCESS in 9m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/db73b41d41a1413bb8c7e52d8dbb52bc : SUCCESS in 7m 30s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/d003bd74d5564ed4b14dabacfab89ddb : SUCCESS in 9m 07s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/7c989b0b0a864356b78939ac6760e720 : SUCCESS in 10m 08s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/0ec411efbf0e442f8745e3d8f824f3ef : SUCCESS in 1h 11m 32s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/179957648058465dac5fe904514c6dc0 : SUCCESS in 56m 30s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7461c0b0a17e4e8a8aedb7047cc4ea5f : SUCCESS in 52m 36s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c182313c055844fa9249f172808f0595 : SUCCESS in 1h 12m 06s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/5a98c00c92654a79ba0fb58228ab1214 : SUCCESS in 35m 06s","accounts_in_message":[],"_revision_number":1},{"id":"2c3f4c5ef1cc12147143e26280d48ee3808f0b1a","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-23 20:38:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"2511343894c634f0905f2ffbb79e5749eeab5fb2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-23 20:41:39.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/55a614a70c7f4dc8955ea0896ac7fdf3 : SUCCESS in 1m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9b67bd19763bf77d0b002ccc447de5b786b6a165","revisions":{"9b67bd19763bf77d0b002ccc447de5b786b6a165":{"kind":"REWORK","_number":1,"created":"2021-02-01 10:59:12.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/57/773357/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/57/773357/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/57/773357/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/57/773357/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/57/773357/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/57/773357/1"}}},"commit":{"parents":[{"commit":"03bf00ee3b4c95713795f6bb7fcb4f37e98b5866","subject":"Change database migration version to wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03bf00ee3b4c95713795f6bb7fcb4f37e98b5866"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-02-01 10:58:33.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-02-01 10:58:47.000000000","tz":0},"subject":"Replace collections.Iterable","message":"Replace collections.Iterable\n\nThis has been moved to the \u0027abc\u0027 submodule in Python 3.3 and the alias\nwill be removed in 3.10.\n\nChange-Id: I9a39f57ab4ab29d62105812f82b3eb4c7548eb5c\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9b67bd19763bf77d0b002ccc447de5b786b6a165"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9b67bd19763bf77d0b002ccc447de5b786b6a165"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}