)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":329,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        try:"},{"line_number":332,"context_line":"            ctxt \u003d req.context"},{"line_number":333,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"},{"line_number":334,"context_line":"                                                owner\u003dctxt.owner,"},{"line_number":335,"context_line":"                                                task_input\u003dtask_input,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5e628324_30444df2","line":332,"updated":"2021-02-09 15:25:38.000000000","message":"Might be good to put this at the top, since we use req.context a few other places already.","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        try:"},{"line_number":332,"context_line":"            ctxt \u003d req.context"},{"line_number":333,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"},{"line_number":334,"context_line":"                                                owner\u003dctxt.owner,"},{"line_number":335,"context_line":"                                                task_input\u003dtask_input,"}],"source_content_type":"text/x-python","patch_set":1,"id":"139fa31d_989326a4","line":332,"in_reply_to":"5e628324_30444df2","updated":"2021-02-10 07:47:56.000000000","message":"Done","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e3ecffda6e221df86c7a2a0506722101e8626c7","unresolved":true,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @utils.mutating"},{"line_number":214,"context_line":"    def import_image(self, req, image_id, body):"},{"line_number":215,"context_line":"        ctxt \u003d req.context"},{"line_number":216,"context_line":"        image_repo \u003d self.gateway.get_repo(ctxt)"},{"line_number":217,"context_line":"        task_factory \u003d self.gateway.get_task_factory(ctxt)"},{"line_number":218,"context_line":"        task_repo \u003d self.gateway.get_task_repo(ctxt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"971206d4_0476053d","line":215,"updated":"2021-02-12 15:25:00.000000000","message":"Well, that was even more places than I had spotted, so maybe that was a bad suggestion on my part and should have been a separate cleanup. But it\u0027s definitely better.","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"244334c65a9af85da3870e06f7656c1943799477","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @utils.mutating"},{"line_number":214,"context_line":"    def import_image(self, req, image_id, body):"},{"line_number":215,"context_line":"        ctxt \u003d req.context"},{"line_number":216,"context_line":"        image_repo \u003d self.gateway.get_repo(ctxt)"},{"line_number":217,"context_line":"        task_factory \u003d self.gateway.get_task_factory(ctxt)"},{"line_number":218,"context_line":"        task_repo \u003d self.gateway.get_task_repo(ctxt)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b76452d8_0422bdb2","line":215,"in_reply_to":"971206d4_0476053d","updated":"2021-02-15 06:41:57.000000000","message":"Done","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"}],"glance/db/__init__.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":345,"context_line":"            message\u003ddb_task[\u0027message\u0027],"},{"line_number":346,"context_line":"            image_id\u003ddb_task[\u0027image_id\u0027],"},{"line_number":347,"context_line":"            user\u003ddb_task[\u0027user\u0027],"},{"line_number":348,"context_line":"            request_id\u003ddb_task[\u0027request_id\u0027]"},{"line_number":349,"context_line":"        )"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def _format_task_stub_from_db(self, db_task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d8404f8_3f726aa5","line":348,"range":{"start_line":348,"start_character":43,"end_line":348,"end_character":44},"updated":"2021-02-09 15:25:38.000000000","message":"I\u0027m a huge fan of keeping trailing commas in places like this so we don\u0027t have to modify this line the next time we add stuff (like L345 above).","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            message\u003ddb_task[\u0027message\u0027],"},{"line_number":346,"context_line":"            image_id\u003ddb_task[\u0027image_id\u0027],"},{"line_number":347,"context_line":"            user\u003ddb_task[\u0027user\u0027],"},{"line_number":348,"context_line":"            request_id\u003ddb_task[\u0027request_id\u0027]"},{"line_number":349,"context_line":"        )"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def _format_task_stub_from_db(self, db_task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a5614fb_f4b1a037","line":348,"range":{"start_line":348,"start_character":43,"end_line":348,"end_character":44},"in_reply_to":"0d8404f8_3f726aa5","updated":"2021-02-10 07:47:56.000000000","message":"Done","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":372,"context_line":"                \u0027updated_at\u0027: task.updated_at,"},{"line_number":373,"context_line":"                \u0027image_id\u0027: task.image_id,"},{"line_number":374,"context_line":"                \u0027request_id\u0027: task.request_id,"},{"line_number":375,"context_line":"                \u0027user\u0027: task.user"},{"line_number":376,"context_line":"                }"},{"line_number":377,"context_line":"        return task"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c1b4c6d3_41b28c2d","line":375,"range":{"start_line":375,"start_character":32,"end_line":375,"end_character":33},"updated":"2021-02-09 15:25:38.000000000","message":"Here too.","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                \u0027updated_at\u0027: task.updated_at,"},{"line_number":373,"context_line":"                \u0027image_id\u0027: task.image_id,"},{"line_number":374,"context_line":"                \u0027request_id\u0027: task.request_id,"},{"line_number":375,"context_line":"                \u0027user\u0027: task.user"},{"line_number":376,"context_line":"                }"},{"line_number":377,"context_line":"        return task"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0997ecb6_790a09de","line":375,"range":{"start_line":375,"start_character":32,"end_line":375,"end_character":33},"in_reply_to":"c1b4c6d3_41b28c2d","updated":"2021-02-10 07:47:56.000000000","message":"Done","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"}],"glance/db/simple/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":179,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":180,"context_line":"        \u0027image_id\u0027: None,"},{"line_number":181,"context_line":"        \u0027request_id\u0027: None,"},{"line_number":182,"context_line":"        \u0027user\u0027: None"},{"line_number":183,"context_line":"    }"},{"line_number":184,"context_line":"    task.update(values)"},{"line_number":185,"context_line":"    return task"}],"source_content_type":"text/x-python","patch_set":1,"id":"d8109d70_acbf6edd","line":182,"range":{"start_line":182,"start_character":19,"end_line":182,"end_character":20},"updated":"2021-02-09 15:25:38.000000000","message":"Trailing comma","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \u0027deleted\u0027: False,"},{"line_number":180,"context_line":"        \u0027image_id\u0027: None,"},{"line_number":181,"context_line":"        \u0027request_id\u0027: None,"},{"line_number":182,"context_line":"        \u0027user\u0027: None"},{"line_number":183,"context_line":"    }"},{"line_number":184,"context_line":"    task.update(values)"},{"line_number":185,"context_line":"    return task"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7caae09_1c9fc725","line":182,"range":{"start_line":182,"start_character":19,"end_line":182,"end_character":20},"in_reply_to":"d8109d70_acbf6edd","updated":"2021-02-10 07:47:56.000000000","message":"Done","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"}],"glance/domain/__init__.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            kwargs.get(\u0027message\u0027),"},{"line_number":496,"context_line":"            image_id\u003dkwargs.get(\u0027image_id\u0027),"},{"line_number":497,"context_line":"            user\u003dkwargs.get(\u0027user\u0027),"},{"line_number":498,"context_line":"            request_id\u003dkwargs.get(\u0027request_id\u0027),"},{"line_number":499,"context_line":"        )"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"89a8760a_efb58275","line":498,"updated":"2021-02-09 15:25:38.000000000","message":"These are optional because why? Can we ever call this from code that won\u0027t pass them? It\u0027s one thing if the actual value is None (like if we create a task internally, unrelated to a request), but shouldn\u0027t they all be in the kwargs all the time?","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            kwargs.get(\u0027message\u0027),"},{"line_number":496,"context_line":"            image_id\u003dkwargs.get(\u0027image_id\u0027),"},{"line_number":497,"context_line":"            user\u003dkwargs.get(\u0027user\u0027),"},{"line_number":498,"context_line":"            request_id\u003dkwargs.get(\u0027request_id\u0027),"},{"line_number":499,"context_line":"        )"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a1e75706_255cbd24","line":498,"in_reply_to":"89a8760a_efb58275","updated":"2021-02-10 07:47:56.000000000","message":"I do not recollect whether we call this from code without passing these.\nWill change it to be a positional arguments.","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c58683567cbd89e49550438ee916c962afa2db32","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            kwargs.get(\u0027message\u0027),"},{"line_number":496,"context_line":"            image_id\u003dkwargs.get(\u0027image_id\u0027),"},{"line_number":497,"context_line":"            user\u003dkwargs.get(\u0027user\u0027),"},{"line_number":498,"context_line":"            request_id\u003dkwargs.get(\u0027request_id\u0027),"},{"line_number":499,"context_line":"        )"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"27a2411e_ed9aedb1","line":498,"in_reply_to":"a1e75706_255cbd24","updated":"2021-02-10 14:42:08.000000000","message":"There is a lot of this across glance, so maybe it\u0027s just \"convention\". In nova, sometimes we have to do this because we\u0027re dispatched over RPC and may be called with fewer arguments if one side of the conversation hasn\u0027t upgraded or something. However, for glance, AFAIK, that will never be the case. Unless the code really needs to be callable in both ways, making everything optional all the time leads to fragility and is difficult to debug.\n\nI know you were just copying what was here, and convention is convention, I was just genuinely asking :)","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"}],"glance/tests/functional/v2/test_tasks.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":104,"context_line":"                            u\u0027result\u0027,"},{"line_number":105,"context_line":"                            u\u0027updated_at\u0027,"},{"line_number":106,"context_line":"                            u\u0027request_id\u0027,"},{"line_number":107,"context_line":"                            u\u0027user\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(checked_keys, set(task.keys()))"},{"line_number":109,"context_line":"        expected_task \u003d {"},{"line_number":110,"context_line":"            \u0027status\u0027: \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"db586f42_0274cca2","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":37},"updated":"2021-02-09 15:25:38.000000000","message":"There was no trailing comma here, so maybe not a big deal, but... you could leave it so the next guy can cleanly add to this list :)","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                            u\u0027result\u0027,"},{"line_number":105,"context_line":"                            u\u0027updated_at\u0027,"},{"line_number":106,"context_line":"                            u\u0027request_id\u0027,"},{"line_number":107,"context_line":"                            u\u0027user\u0027])"},{"line_number":108,"context_line":"        self.assertEqual(checked_keys, set(task.keys()))"},{"line_number":109,"context_line":"        expected_task \u003d {"},{"line_number":110,"context_line":"            \u0027status\u0027: \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a50c18ef_7c8b13cd","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":37},"in_reply_to":"db586f42_0274cca2","updated":"2021-02-10 07:47:56.000000000","message":"Done","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"}],"glance/tests/unit/test_db.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e3ecffda6e221df86c7a2a0506722101e8626c7","unresolved":true,"context_lines":[{"line_number":810,"context_line":"        self.task_repo.add(task)"},{"line_number":811,"context_line":"        retrieved_task \u003d self.task_repo.get(task.task_id)"},{"line_number":812,"context_line":"        self.assertEqual(task.updated_at, retrieved_task.updated_at)"},{"line_number":813,"context_line":"        self.assertEqual(self.fake_task_input, retrieved_task.task_input)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    def test_save_task(self):"},{"line_number":816,"context_line":"        task \u003d self.task_repo.get(UUID1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"822ee0a8_fcc3ffda","line":813,"updated":"2021-02-12 15:25:00.000000000","message":"I think we need some asserts here to make sure that the expected values are pulled back out right?","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"244334c65a9af85da3870e06f7656c1943799477","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        self.task_repo.add(task)"},{"line_number":811,"context_line":"        retrieved_task \u003d self.task_repo.get(task.task_id)"},{"line_number":812,"context_line":"        self.assertEqual(task.updated_at, retrieved_task.updated_at)"},{"line_number":813,"context_line":"        self.assertEqual(self.fake_task_input, retrieved_task.task_input)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"    def test_save_task(self):"},{"line_number":816,"context_line":"        task \u003d self.task_repo.get(UUID1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"040889ad_f3ccfa91","line":813,"in_reply_to":"822ee0a8_fcc3ffda","updated":"2021-02-15 06:41:57.000000000","message":"Done","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"}],"glance/tests/unit/test_domain.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e3ecffda6e221df86c7a2a0506722101e8626c7","unresolved":true,"context_lines":[{"line_number":342,"context_line":"        self.assertEqual(owner, task.owner)"},{"line_number":343,"context_line":"        self.assertEqual(task_input, task.task_input)"},{"line_number":344,"context_line":"        self.assertEqual(\u0027test_message\u0027, task.message)"},{"line_number":345,"context_line":"        self.assertEqual(\u0027test_result\u0027, task.result)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def test_new_task_invalid_type(self):"},{"line_number":348,"context_line":"        task_type \u003d \u0027blah\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"dadb5e15_0a467281","line":345,"updated":"2021-02-12 15:25:00.000000000","message":"Need asserts here on the task.","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"244334c65a9af85da3870e06f7656c1943799477","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        self.assertEqual(owner, task.owner)"},{"line_number":343,"context_line":"        self.assertEqual(task_input, task.task_input)"},{"line_number":344,"context_line":"        self.assertEqual(\u0027test_message\u0027, task.message)"},{"line_number":345,"context_line":"        self.assertEqual(\u0027test_result\u0027, task.result)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"    def test_new_task_invalid_type(self):"},{"line_number":348,"context_line":"        task_type \u003d \u0027blah\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"25e8d80a_674b0c0f","line":345,"in_reply_to":"dadb5e15_0a467281","updated":"2021-02-15 06:41:57.000000000","message":"Done","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e3ecffda6e221df86c7a2a0506722101e8626c7","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        self.assertEqual(\u0027status\u0027, task.status)"},{"line_number":524,"context_line":"        self.assertEqual(\u0027expires_at\u0027, task.expires_at)"},{"line_number":525,"context_line":"        self.assertEqual(\u0027created_at\u0027, task.created_at)"},{"line_number":526,"context_line":"        self.assertEqual(\u0027updated_at\u0027, task.updated_at)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def test_task_stub_get_status(self):"},{"line_number":529,"context_line":"        status \u003d \u0027pending\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"0e45078e_09bc43c6","line":526,"updated":"2021-02-12 15:25:00.000000000","message":"...and here","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"244334c65a9af85da3870e06f7656c1943799477","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.assertEqual(\u0027status\u0027, task.status)"},{"line_number":524,"context_line":"        self.assertEqual(\u0027expires_at\u0027, task.expires_at)"},{"line_number":525,"context_line":"        self.assertEqual(\u0027created_at\u0027, task.created_at)"},{"line_number":526,"context_line":"        self.assertEqual(\u0027updated_at\u0027, task.updated_at)"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def test_task_stub_get_status(self):"},{"line_number":529,"context_line":"        status \u003d \u0027pending\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffd813a_f5f537d0","line":526,"in_reply_to":"0e45078e_09bc43c6","updated":"2021-02-15 06:41:57.000000000","message":"Done","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"}],"glance/tests/unit/test_notifier.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8e3ecffda6e221df86c7a2a0506722101e8626c7","unresolved":true,"context_lines":[{"line_number":652,"context_line":"            image_id\u003d\u0027fake_image_id\u0027,"},{"line_number":653,"context_line":"            user_id\u003d\u0027fake_user\u0027,"},{"line_number":654,"context_line":"            request_id\u003d\u0027fake_request_id\u0027,"},{"line_number":655,"context_line":"        )"},{"line_number":656,"context_line":"        self.context \u003d glance.context.RequestContext("},{"line_number":657,"context_line":"            tenant\u003dTENANT2,"},{"line_number":658,"context_line":"            user\u003dUSER1"}],"source_content_type":"text/x-python","patch_set":3,"id":"b410a357_c471440e","line":655,"updated":"2021-02-12 15:25:00.000000000","message":"Presumably at some point we may want to add these fields to the notification, unless the notification will just dump everything from the task in it? If the latter, then we should probably have some asserts below to make sure it does that.","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"244334c65a9af85da3870e06f7656c1943799477","unresolved":false,"context_lines":[{"line_number":652,"context_line":"            image_id\u003d\u0027fake_image_id\u0027,"},{"line_number":653,"context_line":"            user_id\u003d\u0027fake_user\u0027,"},{"line_number":654,"context_line":"            request_id\u003d\u0027fake_request_id\u0027,"},{"line_number":655,"context_line":"        )"},{"line_number":656,"context_line":"        self.context \u003d glance.context.RequestContext("},{"line_number":657,"context_line":"            tenant\u003dTENANT2,"},{"line_number":658,"context_line":"            user\u003dUSER1"}],"source_content_type":"text/x-python","patch_set":3,"id":"1969e441_4682147c","line":655,"in_reply_to":"b410a357_c471440e","updated":"2021-02-15 06:41:57.000000000","message":"Done","commit_id":"8bba37dc19f99c22b0028fba01b6a9141092149b"}],"glance/tests/unit/v2/test_images_resource.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f29a4a5a978eda83586e2079466e7e4f6387a758","unresolved":true,"context_lines":[{"line_number":3056,"context_line":"                                         task_input\u003dexpected_input,"},{"line_number":3057,"context_line":"                                         image_id\u003dUUID4,"},{"line_number":3058,"context_line":"                                         user\u003drequest.context.user_id,"},{"line_number":3059,"context_line":"                                         request_id\u003drequest.context.request_id)"},{"line_number":3060,"context_line":""},{"line_number":3061,"context_line":"    def test_image_import_copy_not_allowed_by_policy(self):"},{"line_number":3062,"context_line":"        # Make sure that if the policy check fails, we fail a copy-image with"}],"source_content_type":"text/x-python","patch_set":1,"id":"55f719ff_19b24895","line":3059,"updated":"2021-02-09 15:25:38.000000000","message":"Technically this checks that we are sending all these things through, but I think it would be good to also make a more generic test that specifically sets these to reasonable values and makes sure they get set all the way through to a task in the DB and not just that we called the task factory with them.","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a8244495818161037a494f99a3024c40d00aeeb9","unresolved":true,"context_lines":[{"line_number":3056,"context_line":"                                         task_input\u003dexpected_input,"},{"line_number":3057,"context_line":"                                         image_id\u003dUUID4,"},{"line_number":3058,"context_line":"                                         user\u003drequest.context.user_id,"},{"line_number":3059,"context_line":"                                         request_id\u003drequest.context.request_id)"},{"line_number":3060,"context_line":""},{"line_number":3061,"context_line":"    def test_image_import_copy_not_allowed_by_policy(self):"},{"line_number":3062,"context_line":"        # Make sure that if the policy check fails, we fail a copy-image with"}],"source_content_type":"text/x-python","patch_set":1,"id":"7eef71e8_92a42568","line":3059,"in_reply_to":"55f719ff_19b24895","updated":"2021-02-10 07:47:56.000000000","message":"Will work on this test","commit_id":"b43bd2bb98febf9087b1724477165f1e22b7f123"}]}