)]}'
{"id":"openstack%2Fglance~774722","triplet_id":"openstack%2Fglance~master~I8f1d03275e6ec51a802cc4b4107f3ab648f535a1","project":"openstack/glance","branch":"master","topic":"bug/1914826","hashtags":[],"change_id":"I8f1d03275e6ec51a802cc4b4107f3ab648f535a1","subject":"Add missing fail case tests for image_conversion","status":"MERGED","created":"2021-02-09 20:14:25.000000000","updated":"2021-03-06 17:37:26.000000000","submitted":"2021-03-06 17:35:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"774722-bug/1914826","meta_rev_id":"997f8dd930ca0f4741a7202a5913cf365c392a15","_number":774722,"virtual_id_number":774722,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-06 17:34:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2021-02-10 05:55:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2021-03-05 18:26:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2021-02-10 05:55:15.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-10 00:43:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-10 05:55:15.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"}],"messages":[{"id":"85dc97c876180ceb3a1051b8cc67b4f8987e8d2f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-09 20:14:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6510f09a72a914000642d6a2259af81a7f5489e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 00:43:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/db1efda82c3e4cc1b1275027819fcdba : SUCCESS in 59m 56s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/fac36da05f3c415f845b3c1fbf102779 : SUCCESS in 1h 47m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7edba465e3f74a8cbb6ed401afcdc4bb : SUCCESS in 6m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/794463d3470f4c379c5be59d427d3f44 : SUCCESS in 4m 52s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/79b69c5c5edf4506b48f6ab9e0f2936c : SUCCESS in 5m 05s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7d890f5c3332474a92c14a6621f96bc0 : SUCCESS in 5m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/028ce794ab4f4d36be8e2ce1a20aba81 : SUCCESS in 5m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c8072b30451d4577ab5eb1c4ba137518 : SUCCESS in 9m 30s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/445c4034c839451ebc3493986a70f0b8 : SUCCESS in 7m 52s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/77b7a998d00d4be5ab0ba016f7a9a9fc : SUCCESS in 8m 28s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/d0b6186d1e544d5aa4c86840c7cc2767 : SUCCESS in 4m 27s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/7b36ab5bcb2943c68b45ddb9564a7ee7 : SUCCESS in 1h 18m 34s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/a2285ad06f054972963369a68da4377f : SUCCESS in 1h 17m 12s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/db8a714fd6ad421481ecf6cccd160e70 : SUCCESS in 1h 13m 10s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/b0d56e3448ac4614b736b0442d83bee7 : FAILURE in 1h 06m 56s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8f531bf4f06540fd85677fffa81cb8e6 : SUCCESS in 1h 07m 33s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/cf0b59f4dc34414eb55b40e712923432 : SUCCESS in 1h 12m 53s","accounts_in_message":[],"_revision_number":1},{"id":"813908d7dc26a59b619c2a2269909781ad33e308","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-02-10 05:55:15.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1\n\n(1 comment)\n\nThank you for more tests!","accounts_in_message":[],"_revision_number":1},{"id":"b9a563a62237a3398896b3bbc28be3ead06f9798","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-10 14:22:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a585d8c46fc6a93d89b365a4feeea9acb5488f6","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-03-05 18:26:20.000000000","message":"Patch Set 1: Workflow+1\n\nNinja approving, sitting open for long, Improvement in negative testing.\nThank you!","accounts_in_message":[],"_revision_number":1},{"id":"ed8f141e29856c0cf01034af4d6c9369b5280e27","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 01:55:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f93d6f2fd68fff84d32beaad448b6fa6be7e4e9f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 11:41:41.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"9bdef9760d06ff34a393d54417ec08d1ab1c9f2f","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-03-06 11:48:10.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"90724ec4cc6a23671a3a915e5ef593f3d5866784","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 13:54:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/807c2819cb394aa58f7b4957d850d628 : SUCCESS in 1h 07m 43s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/177a19c0fa004eaeba8ca411a97e3870 : SUCCESS in 1h 17m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/66f9e6c032d349abbc532b78853848e8 : SUCCESS in 6m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/47fcf1b3dabc40d0a8f16e030c9e36bc : SUCCESS in 5m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2fea7db5a1564bd2a69d820af7359290 : SUCCESS in 5m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/88950415c2c24b9db16fe05fe7b1a3b0 : SUCCESS in 5m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0bebd318c8ec42f8bc595125a84d60d8 : SUCCESS in 5m 34s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7dab7f0d138e419182ef9a0bb39259c9 : SUCCESS in 6m 38s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/cda483465ca44a0eb0c46b4dc0a4f97f : SUCCESS in 8m 05s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b86fd8ffa05f4582b23b8efb439c5be1 : SUCCESS in 8m 27s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/0c35de2fd08c4842a6f5ce3448c188fa : SUCCESS in 4m 54s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/c81b8dbefeed4f58a84054e4a41ef628 : SUCCESS in 1h 21m 40s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/a7828dbc4ef444f695769257fee5524b : SUCCESS in 1h 19m 56s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/1f0bb75d2bb04ad2adda8ccf64567ca8 : SUCCESS in 1h 33m 09s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/fb714b5e3c4e43dbbabe4e4029290c58 : SUCCESS in 1h 32m 05s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b8b4d5ac2f2b4518a556a3699f87c8de : SUCCESS in 53m 28s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/521541ead1e04caf80e38c76df381cf9 : SUCCESS in 1h 21m 58s","accounts_in_message":[],"_revision_number":1},{"id":"b0db7501df0a81158144724e4905e92b31f43e7c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 13:59:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5d5d4add66d222d3bba9e4b44ef35bbc58768903","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 17:34:51.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/9953f3a02dfb4f6383e20e05451d8a49 : SUCCESS in 58m 11s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/67de82a43db14358ae14278162127358 : SUCCESS in 1h 24m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d6d2f88f284440c8919212b0c982313e : SUCCESS in 6m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/71a4042be2a2428d8dbb976a16f29aa4 : SUCCESS in 7m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8cf02c62a4594351ac40993346f01350 : SUCCESS in 5m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/230a906acf224f23bf699abec93360f2 : SUCCESS in 5m 52s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2dbaea4efa9a46ccb8572095be3e5724 : SUCCESS in 6m 52s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/763ced521dc4439096bc242ca0d4227c : SUCCESS in 10m 04s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/65bda64f00924926978118e3034c0d8c : SUCCESS in 8m 54s\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/067f3a1b989d4adfb854e920020bb374 : SUCCESS in 1h 39m 42s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/25691a51954d4900a18c1cbc2d46e4af : SUCCESS in 1h 34m 36s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/862ca02288a24d0ba923634860b8c0b7 : SUCCESS in 1h 03m 20s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/df47948e14e6445d91fe2c9eb0281014 : SUCCESS in 1h 08m 32s","accounts_in_message":[],"_revision_number":1},{"id":"2cc47960cc3577fc073b0099fa76c405dd13de83","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 17:35:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"997f8dd930ca0f4741a7202a5913cf365c392a15","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 17:37:26.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f23ac1d6d36b430f8598f22071242c2d : SUCCESS in 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"050802dd67b9135e04a65d340531157c94248c51","revisions":{"050802dd67b9135e04a65d340531157c94248c51":{"kind":"REWORK","_number":1,"created":"2021-02-09 20:14:25.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/22/774722/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/22/774722/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/22/774722/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/22/774722/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/22/774722/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/22/774722/1"}}},"commit":{"parents":[{"commit":"5331f1e0badf0820a93264e6d7063927b2afe51b","subject":"Make action wrapper support arbitrary properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5331f1e0badf0820a93264e6d7063927b2afe51b"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-09 18:40:56.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-09 20:33:05.000000000","tz":-480},"subject":"Add missing fail case tests for image_conversion","message":"Add missing fail case tests for image_conversion\n\nThe tests for the image_conversion plugin were missing basically all\nof the places where the task can fail (or NOP). This adds tests for\nthose things to validate behavior before moving the task to use the\nimport wrapper.\n\nNote that in the process, I found a potential bug in the handling of\nthe metadata response from qemu-img when probing for the format. We\ntolerate \"format\" being missing from the result, but will end up\npassing None as an argument to \u0027qemu-img convert\u0027, which will fail.\nThis fixes that to raise RuntimeError in line with the existing\nbehavior of \"raise RuntimeError if any error is reported\".\n\nChange-Id: I8f1d03275e6ec51a802cc4b4107f3ab648f535a1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/050802dd67b9135e04a65d340531157c94248c51"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/050802dd67b9135e04a65d340531157c94248c51"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}