)]}'
{"id":"openstack%2Fglance~774725","triplet_id":"openstack%2Fglance~master~Ifc2f49d49ff62c49c7dd1d2174a78bb1451b7bf3","project":"openstack/glance","branch":"master","topic":"bug/1914826","hashtags":[],"change_id":"Ifc2f49d49ff62c49c7dd1d2174a78bb1451b7bf3","subject":"Fix nonsensical test mocks and assertions","status":"MERGED","created":"2021-02-09 20:14:25.000000000","updated":"2021-03-07 10:33:24.000000000","submitted":"2021-03-07 10:32:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"774725-bug/1914826","meta_rev_id":"24e0c535dc5ccf29a0527a03712e8c62390a6cf9","_number":774725,"virtual_id_number":774725,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-07 10:32:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":2,"date":"2021-03-07 10:33:24.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2021-03-05 18:30:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"all":[{"value":1,"date":"2021-03-07 10:33:24.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":2},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-09 20:30:17.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2021-02-09 20:30:17.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2021-02-09 23:21:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4bb3680347356bd693e4defaa2bfea3fe9701bb7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-09 20:14:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d65546b85a24e855a02866c56b2ba94b3ae88225","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-09 20:30:17.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nYou both originally approved these tests, so just a heads up in case I\u0027m missing something major.","accounts_in_message":[],"_revision_number":1},{"id":"c4d25bc14fff40795a2b2bcdd6a0db49415c2438","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 23:21:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f2824c05951e4d1d86c778037a1ac257 : SUCCESS in 8m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fc8b0fec32664578aa6da41d93e18aa5 : SUCCESS in 5m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/669bf4047b7240ef9b90767e0391a92b : SUCCESS in 6m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/db0c55a2c3d54c06a101152302ce2a34 : SUCCESS in 5m 14s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/fcb4ba042d7b4506bf9ec66424823128 : SUCCESS in 8m 29s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bb0a9b6d67904440aca6dbab58783b76 : SUCCESS in 5m 42s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/da9f3c70ebac43049cb2f8574b3052b5 : SUCCESS in 10m 08s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/634f46fd8aee492aa8f2e0b355b58b75 : SUCCESS in 9m 25s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/bb14fde3bc644433b1667fa8f7c69d03 : SUCCESS in 5m 06s","accounts_in_message":[],"_revision_number":1},{"id":"a9a5b9241bb3f3a2f4a8fc5a4a630bbebd9bf6a5","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-02-10 06:17:39.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1\n\nThank you for correcting the tests","accounts_in_message":[],"_revision_number":1},{"id":"40e8d03e1c1440814e63b4dbb31866870efe8b9e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2021-02-10 14:42:45.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"95eb6d57668f031dc4dbca3c2f3025880f9dea35","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-10 14:58:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a05a70c035864e50ada71fdb6ec28bd2 : SUCCESS in 6m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0aef4f19da71438984aedb211dcaa3f4 : SUCCESS in 5m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2bed446010fd40ceb6a25830ee4653f1 : SUCCESS in 5m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/26548024bd4a4172ab46a58d493f772a : SUCCESS in 5m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f1499a8f743642ca9249157e90977268 : SUCCESS in 5m 25s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3463c99847a4e308f2bbfc9f3802812 : SUCCESS in 6m 27s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/a59198b8cde1444993c4055c91b9e79a : SUCCESS in 10m 12s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a7df489d1bdf4388a782cfcdc15aa1d2 : SUCCESS in 10m 09s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/97cf3e6c9c3a434c8247d63d6055942e : SUCCESS in 6m 43s","accounts_in_message":[],"_revision_number":2},{"id":"f4f2fca0586b458eae1ceebe9aa0a1c03973d636","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-03-05 18:30:55.000000000","message":"Patch Set 2: Workflow+1\n\nNinja approving, sitting open for long, Definitely fixing our tests which were giving wrong impression.\nThank you!","accounts_in_message":[],"_revision_number":2},{"id":"6e313f9c382235610ddf1156124c291d7bc5d786","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 02:09:30.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e8f2fe41264b1879ce0eda51c6bd8714d57b4878","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 11:41:45.000000000","message":"Patch Set 2: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":2},{"id":"cc5d8d9c5fd1540480d6f32f812806d973a97d15","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-03-06 11:49:12.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"abf11aae196540cf1cb6f981a8a557775a46e52e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 12:03:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/527aae2d46ca475e8b082fd09a750612 : SUCCESS in 7m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/224c1bd115c4489caa9e8284a2512975 : SUCCESS in 7m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/24fe5e72c9d6422d93f14cbc9d9af15b : SUCCESS in 5m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f107738a6dc943a49ef9cc4e6ccaafc4 : SUCCESS in 6m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7c771fa733cf444d832be04754cbf7f2 : SUCCESS in 6m 08s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f050fe0be82440219e787d2ffdc3a526 : SUCCESS in 5m 49s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/48ee3046776b48ae8f40200bd1fa5fbc : SUCCESS in 9m 20s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/f3f0e77323a74f5baeb1f35fec5dcdab : SUCCESS in 9m 17s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/b7ab510cf8764d709d888ccbb4450ccc : SUCCESS in 5m 17s","accounts_in_message":[],"_revision_number":2},{"id":"cc1e19fa6520087d3616bd77c3ea988690813fc1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 01:56:22.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"79068a5cb9fd18791b5a871dec7dbbcc0b32946a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 03:26:12.000000000","message":"Patch Set 2: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":2},{"id":"52bcde2e5cb0600dc1b02555594abc5920fb4067","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2021-03-07 09:06:36.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"b856732319498a17207845d7701124cb778f6823","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 09:40:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/44b0fd4f9b9b4bdca453f73cbd7e5b2a : SUCCESS in 5m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1f0b9f400037419d81ff3d3b1edc938d : SUCCESS in 5m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e69d3d7364274955bfb5c91f9b4cc484 : SUCCESS in 5m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6c50dbb335b848f2996e2d1b1e3a4f49 : SUCCESS in 5m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e6e3158158114853a5e5a4b60f98dc3a : SUCCESS in 5m 34s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3552c86eb9614705a93957bc82dc78bc : SUCCESS in 6m 03s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/0b35a3677dde4ceb80419990e4978807 : SUCCESS in 8m 28s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a341ddce73fc43eb97714749d22675ad : SUCCESS in 7m 50s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/d43eb78673fe45539136e7d4f9aa3f0c : SUCCESS in 4m 33s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/6bbbf131e4184421832a0ae3b51544dd : FAILURE in 32m 08s (non-voting)\n- glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/153f07795daa4cc19739f77f4e88ee19 : SUCCESS in 30m 38s","accounts_in_message":[],"_revision_number":2},{"id":"98d2db3f31256b15f84f80b47c4ea1ccf53417c8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 09:40:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"486004c0d38984239ca89e616f9c2c85df24e6bb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 10:32:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bc32a5efea624b48ba5c1e1c1e9a9f4b : SUCCESS in 6m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a5f94288ff554c008759a680a4a32ed0 : SUCCESS in 4m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5ff11991d96a401980781536f2e868d4 : SUCCESS in 5m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c2fe3c5389fc4c95aa77c2f46b3b1f19 : SUCCESS in 5m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39f82594e2de428792fba92a25d79695 : SUCCESS in 6m 18s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/1ee24bbf02464dcc8e10ebd31ee9a718 : SUCCESS in 8m 11s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/4d4b9059af2741d9b03eb8086fb17dd0 : SUCCESS in 8m 39s\n- glance-legacy-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/1fb8488a1aa94196bbb7e01cdf886b39 : SUCCESS in 42m 52s","accounts_in_message":[],"_revision_number":2},{"id":"94b5ae772088423d5afe270a4d69f8ce7c9ddc65","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 10:32:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2fa4d01962f227dd9ff4a3a93e594ce68eb8b739","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-07 10:33:24.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b35f94891b634224bae9d2ba4e4f8cf2 : SUCCESS in 50s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b1e757884aa1a10c939337ba83caf9bf8d615305","revisions":{"fb328ba07ba60791684382c8f9c79d8d56fc59aa":{"kind":"REWORK","_number":1,"created":"2021-02-09 20:14:25.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/25/774725/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/25/774725/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/25/774725/1"}}},"commit":{"parents":[{"commit":"9cf5c1769cd05212d58211ee254fa9c95a65a605","subject":"Allow plugins to mutate image extra_properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9cf5c1769cd05212d58211ee254fa9c95a65a605"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-09 20:15:42.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-09 20:33:05.000000000","tz":-480},"subject":"Fix nonsensical test mocks and assertions","message":"Fix nonsensical test mocks and assertions\n\nThe test_inject_image_metadata test was doing some completely\nnonsensical mock behavior, like mocking something after we have\nrun the method under test, and re-mocking the image repo with the\nthing that was supposed to change so that the assertions were not\neven checking the actual behavior. None of the three tests were\nactually testing the desired behavior.\n\nIn the case of the admin_user test, it was also asserting that things\nwere not run that *should* be, probably because the mocks were done\nafter the execution and asserting that they *were* run would never\nwork.\n\nThis also wires up the image and image_repo mocks that were in\nsetUp(), but unused (and incorrect) so that we can assert the calls\nare actually as we expect.\n\nChange-Id: Ifc2f49d49ff62c49c7dd1d2174a78bb1451b7bf3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/fb328ba07ba60791684382c8f9c79d8d56fc59aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/fb328ba07ba60791684382c8f9c79d8d56fc59aa"}]},"branch":"refs/heads/master"},"b1e757884aa1a10c939337ba83caf9bf8d615305":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-02-10 14:42:45.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/25/774725/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/25/774725/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/25/774725/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/25/774725/2"}}},"commit":{"parents":[{"commit":"e54a1a52ec246e199d2a9731a390111ae3ba61da","subject":"Allow plugins to mutate image extra_properties","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e54a1a52ec246e199d2a9731a390111ae3ba61da"}]}],"author":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-09 20:15:42.000000000","tz":-480},"committer":{"name":"Dan Smith","email":"dansmith@redhat.com","date":"2021-02-10 15:36:24.000000000","tz":-480},"subject":"Fix nonsensical test mocks and assertions","message":"Fix nonsensical test mocks and assertions\n\nThe test_inject_image_metadata test was doing some completely\nnonsensical mock behavior, like mocking something after we have\nrun the method under test, and re-mocking the image repo with the\nthing that was supposed to change so that the assertions were not\neven checking the actual behavior. None of the three tests were\nactually testing the desired behavior.\n\nIn the case of the admin_user test, it was also asserting that things\nwere not run that *should* be, probably because the mocks were done\nafter the execution and asserting that they *were* run would never\nwork.\n\nThis also wires up the image and image_repo mocks that were in\nsetUp(), but unused (and incorrect) so that we can assert the calls\nare actually as we expect.\n\nChange-Id: Ifc2f49d49ff62c49c7dd1d2174a78bb1451b7bf3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b1e757884aa1a10c939337ba83caf9bf8d615305"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b1e757884aa1a10c939337ba83caf9bf8d615305"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}