)]}'
{"glance/tests/functional/v2/test_legacy_update_cinder_store.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a695c7a5b9ec271ceb7a164607880c81e6150518","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        self.assertEqual(\u0027cinder://store1/%s\u0027 % self.vol_id,"},{"line_number":206,"context_line":"                         image[\u0027locations\u0027][0][\u0027url\u0027])"},{"line_number":207,"context_line":"        self.assertEqual(\u0027store1\u0027, image[\u0027locations\u0027][0][\u0027metadata\u0027][\u0027store\u0027])"},{"line_number":208,"context_line":"        mocked_cc.assert_called()"},{"line_number":209,"context_line":"        mock_open.assert_called()"},{"line_number":210,"context_line":"        mock_chown.assert_called()"},{"line_number":211,"context_line":"        mock_connector.get_connector_properties.assert_called()"}],"source_content_type":"text/x-python","patch_set":2,"id":"de25959d_43736fac","line":208,"updated":"2021-02-18 14:36:18.000000000","message":"Could you put a comment above these that says something like:\n\n # NOTE(): These are internals called by glance_store, so we want\n # to make sure they got hit, but not be too strict about how.\n\nThat will help make it clear to later readers that these are loose for a reason. Normally this is not very good in terms of validation, but there\u0027s a specific reason here and a note would help avoid people \"optimizing\" these in the future. Same for the block below.","commit_id":"1c961a3bf64518c7743353c805b6b894dc10f636"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"759b12fa257e5d22690f9c5a2b17002107c60d3f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        self.assertEqual(\u0027cinder://store1/%s\u0027 % self.vol_id,"},{"line_number":206,"context_line":"                         image[\u0027locations\u0027][0][\u0027url\u0027])"},{"line_number":207,"context_line":"        self.assertEqual(\u0027store1\u0027, image[\u0027locations\u0027][0][\u0027metadata\u0027][\u0027store\u0027])"},{"line_number":208,"context_line":"        mocked_cc.assert_called()"},{"line_number":209,"context_line":"        mock_open.assert_called()"},{"line_number":210,"context_line":"        mock_chown.assert_called()"},{"line_number":211,"context_line":"        mock_connector.get_connector_properties.assert_called()"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa593298_4b693847","line":208,"in_reply_to":"de25959d_43736fac","updated":"2021-02-18 14:46:16.000000000","message":"Done\nI\u0027m also not very happy about loosening this up since the mocked_cc told us a lot about the code path followed but with regular updates in glance cinder store, it\u0027s an overhead to fix glance every time so this feels like the best approach.","commit_id":"1c961a3bf64518c7743353c805b6b894dc10f636"}]}