)]}'
{"id":"openstack%2Fglance~778609","triplet_id":"openstack%2Fglance~master~I1d7f2e09d21fad44e8d9dc8e212bc61219144b86","project":"openstack/glance","branch":"master","topic":"secure-rbac","hashtags":[],"change_id":"I1d7f2e09d21fad44e8d9dc8e212bc61219144b86","subject":"DNM: Make sure protection tests protect against policy regressions","status":"ABANDONED","created":"2021-03-04 04:22:18.000000000","updated":"2021-03-04 18:15:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b932b7db1aa10e91775ba4073653cdd8e8461764","_number":778609,"virtual_id_number":778609,"owner":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-03-04 05:56:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-04 05:56:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5618f9cb8f65a2c26c40f33e663c1bff4eea41ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-04 04:22:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d4b1f18b37fbaee6d8828938e5d07028afebcdac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 05:56:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- grenade https://zuul.opendev.org/t/openstack/build/2137b37236db427b8bfb692d01ecf896 : SUCCESS in 47m 05s\n- tempest-integrated-storage https://zuul.opendev.org/t/openstack/build/57b6bb0aafb54086bbaf96d9ed7b6c33 : SUCCESS in 54m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/32e90ebb8b244074a871426cd423e4c5 : SUCCESS in 5m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0365ca0ed65849a3ad7c3c46f099ec9b : SUCCESS in 4m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/afb2e76388ac4f30b4f09cf6f2e75a4c : SUCCESS in 5m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b9fb7381c572419395877ef10e9ff98f : SUCCESS in 5m 03s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b33267ca33574385b8e2a1318eac5196 : SUCCESS in 5m 00s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95a2dd3a1af34cf4a518921442fcbf49 : SUCCESS in 6m 55s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/fd4da2d5304d498c942dfd3c7ecffdd8 : SUCCESS in 7m 50s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/58c2d0e8efd74db99eda20649ed26d86 : SUCCESS in 8m 40s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/41d6ebc6135c4e32b5a7d560bca5d76d : SUCCESS in 5m 00s\n- glance-ceph-thin-provisioning https://zuul.opendev.org/t/openstack/build/d68423fb17f74deaacc5f4bc3b3c5fd7 : POST_FAILURE in 58m 45s (non-voting)\n- tempest-integrated-storage-import https://zuul.opendev.org/t/openstack/build/093c795521144007a951a576f39f5abc : SUCCESS in 1h 28m 24s\n- tempest-integrated-storage-import-standalone https://zuul.opendev.org/t/openstack/build/068d9acf303f472fbabf574777536a8c : SUCCESS in 1h 17m 05s\n- glance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/277359e6521b4891aa5d60e2150dc5fd : SUCCESS in 1h 01m 07s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/55b9217526354c53a93e795c74938b68 : SUCCESS in 1h 02m 07s\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/606104f113584e848832b46a7e4fff89 : SUCCESS in 59m 31s\n- glance-secure-rbac-protection-functional https://zuul.opendev.org/t/openstack/build/946d5e9bb9e4436baf239ee669c145b6 : FAILURE in 35m 37s","accounts_in_message":[],"_revision_number":1},{"id":"6b9d3450a0f1b487a740ce6a2b4a2f24a540bf22","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-04 13:35:12.000000000","message":"Patch Set 1:\n\nFailed test are here - https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_946/778609/1/check/glance-secure-rbac-protection-functional/946d5e9/testr_results.html\n\nProving the new tests offer some level of protection against authorization regressions.\n\nI can propose another DNM that modifies the authorization code in the database to make sure these tests also protect against that, if it\u0027s helpful. But I also want to be conscious of gate resources.","accounts_in_message":[],"_revision_number":1},{"id":"b932b7db1aa10e91775ba4073653cdd8e8461764","tag":"autogenerated:gerrit:abandon","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-04 18:15:14.000000000","message":"Abandoned\n\nI never intended this to merge, just proving that the new protection jobs are useful in protecting against authorization regressions.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"366b79b99287815f4d2dc1a3631900fca4dd173b","revisions":{"366b79b99287815f4d2dc1a3631900fca4dd173b":{"kind":"REWORK","_number":1,"created":"2021-03-04 04:22:18.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/09/778609/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/09/778609/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/778609/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/778609/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/09/778609/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/09/778609/1"}}},"commit":{"parents":[{"commit":"8c6e0d7d28d9d3808b6f26934e6582643704fde1","subject":"Make secure RBAC protection job voting","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/8c6e0d7d28d9d3808b6f26934e6582643704fde1"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-04 04:19:38.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-04 04:19:38.000000000","tz":0},"subject":"DNM: Make sure protection tests protect against policy regressions","message":"DNM: Make sure protection tests protect against policy regressions\n\nChange-Id: I1d7f2e09d21fad44e8d9dc8e212bc61219144b86\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/366b79b99287815f4d2dc1a3631900fca4dd173b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/366b79b99287815f4d2dc1a3631900fca4dd173b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}