)]}'
{"id":"openstack%2Fglance~779042","triplet_id":"openstack%2Fglance~master~Ie97b226e65af4ee995be6f539ad33e1fbd8cc375","project":"openstack/glance","branch":"master","hashtags":[],"change_id":"Ie97b226e65af4ee995be6f539ad33e1fbd8cc375","subject":"DNM: Test if fake method works in cache middleware tests","status":"ABANDONED","created":"2021-03-05 20:10:07.000000000","updated":"2021-03-06 03:58:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"816c8e02dd252e287327c4bedc1ba2aeef75702f","_number":779042,"virtual_id_number":779042,"owner":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-03-06 00:12:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-05 21:31:33.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-03-06 00:12:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"af18bd6b47addb9eaaf5c2840087a2e6c1c373f6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-05 20:10:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ca719acc7abc117dd0f32cee3b4562f499b4a9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-05 20:11:08.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"6a0b2f43f92a654f53688d2b4a70f35987002494","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2021-03-05 21:31:33.000000000","message":"Patch Set 2:\n\nBuild succeeded\n\n- dsvm-glance http://207.189.188.190/logs/779042/779042/2/check-not-vote/ext-glance-zuul/791b4d1 : SUCCESS in 38m 15s","accounts_in_message":[],"_revision_number":2},{"id":"ae4a33e89bf4003c6711727ab1e50af556c1dcb3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-06 00:12:42.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0482d34fa2ba4fb4b38f532dedcee173 : FAILURE in 6m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/baf54c23d7d048db8948784ebe8257b6 : SUCCESS in 6m 01s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5530baff6ae3498ca535711032e64b0d : FAILURE in 11m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/db57eee803744894a7f4aace35ac2aa3 : FAILURE in 5m 42s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e6ee760d28a048f0bd3b629ea49c79ee : SUCCESS in 7m 56s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2a1995cd844745ec906cf9447571db31 : SUCCESS in 7m 03s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/4aaba2e142cb4f879ac495fd477e6476 : SUCCESS in 9m 27s\n- openstack-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/dbd2b9ad488c4293a46c413858dfbd87 : SUCCESS in 9m 36s\n- glance-code-constants-check https://zuul.opendev.org/t/openstack/build/13d406a25ea4466c85d2230387ac4e62 : SUCCESS in 5m 43s","accounts_in_message":[],"_revision_number":2},{"id":"816c8e02dd252e287327c4bedc1ba2aeef75702f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-06 03:58:57.000000000","message":"Abandoned\n\nNevermind, we figured this out in https://review.opendev.org/c/openstack/glance/+/764754/32","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"289e2fa1f4a8c9ef4835f8aac7436e9aacc272b2","revisions":{"9dcecd2f86d73c7d23f8bb3fc766e1fc479223f0":{"kind":"REWORK","_number":1,"created":"2021-03-05 20:10:07.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/42/779042/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/42/779042/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/42/779042/1"}}},"commit":{"parents":[{"commit":"66281f0dbf69e597ec412e3c60b990d4fe4333dd","subject":"Merge \"Cleanup remaining tenant terminology in glance API docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/66281f0dbf69e597ec412e3c60b990d4fe4333dd"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-05 20:05:57.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-05 20:05:57.000000000","tz":0},"subject":"DNM: Test is fake method work","message":"DNM: Test is fake method work\n\nI\u0027m updating the policy code in the cache middleware to enforce proper\ntargets and the tests are failing to translate the ImageTarget to a\ndictionary.\n\nIn the process of updating the ImageStub, I became suspicious that the\nfake code was running.\n\nI attempted to break this by throwing an exception in the fake\nimplementation, but it passes for me locally.\n\nChange-Id: Ie97b226e65af4ee995be6f539ad33e1fbd8cc375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9dcecd2f86d73c7d23f8bb3fc766e1fc479223f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9dcecd2f86d73c7d23f8bb3fc766e1fc479223f0"}]},"branch":"refs/heads/master"},"289e2fa1f4a8c9ef4835f8aac7436e9aacc272b2":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-03-05 20:11:08.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/42/779042/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/42/779042/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/42/779042/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/42/779042/2"}}},"commit":{"parents":[{"commit":"66281f0dbf69e597ec412e3c60b990d4fe4333dd","subject":"Merge \"Cleanup remaining tenant terminology in glance API docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/66281f0dbf69e597ec412e3c60b990d4fe4333dd"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-05 20:05:57.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2021-03-05 20:08:51.000000000","tz":0},"subject":"DNM: Test if fake method works in cache middleware tests","message":"DNM: Test if fake method works in cache middleware tests\n\nI\u0027m updating the policy code in the cache middleware to enforce proper\ntargets and the tests are failing to translate the ImageTarget to a\ndictionary.\n\nIn the process of updating the ImageStub, I became suspicious that the\nfake code was running.\n\nI attempted to break this by throwing an exception in the fake\nimplementation, but it passes for me locally.\n\nChange-Id: Ie97b226e65af4ee995be6f539ad33e1fbd8cc375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/289e2fa1f4a8c9ef4835f8aac7436e9aacc272b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/289e2fa1f4a8c9ef4835f8aac7436e9aacc272b2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
