)]}'
{"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3ba896a1cecbaa986ac69888df0c525dff1b8a73","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                   {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                    \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ea69365_5b5bc6dc","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"updated":"2021-03-29 15:59:39.000000000","message":"Should we return prop from here?","commit_id":"17a500a01a5a280ef2187686b88db1520df1fb5e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5af71ff7d1a5aed50a236165a6a71de2d19fa364","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                   {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                    \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ce47181b_0bc3731a","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"in_reply_to":"7ea69365_5b5bc6dc","updated":"2021-03-29 16:02:05.000000000","message":"No need, we are not using it anywhere","commit_id":"17a500a01a5a280ef2187686b88db1520df1fb5e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bcb0287a7afdc85e57fb39f098b10f75081ef025","unresolved":true,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"def image_property_delete(context, prop_ref, image_ref, session\u003dNone):"},{"line_number":1184,"context_line":"    \"\"\""},{"line_number":1185,"context_line":"    Used internally by image_property_create and image_property_update."},{"line_number":1186,"context_line":"    \"\"\""},{"line_number":1187,"context_line":"    session \u003d session or get_session()"},{"line_number":1188,"context_line":"    prop \u003d session.query(models.ImageProperty).filter_by(image_id\u003dimage_ref,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9255485_3a3468d2","line":1185,"range":{"start_line":1185,"start_character":4,"end_line":1185,"end_character":71},"updated":"2021-04-01 16:08:47.000000000","message":"Not your doing, but maybe this should be corrected/removed while you\u0027re in here.","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ff604b04af2a1950c3f3d2929ee11e83dc41398d","unresolved":true,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"def image_property_delete(context, prop_ref, image_ref, session\u003dNone):"},{"line_number":1184,"context_line":"    \"\"\""},{"line_number":1185,"context_line":"    Used internally by image_property_create and image_property_update."},{"line_number":1186,"context_line":"    \"\"\""},{"line_number":1187,"context_line":"    session \u003d session or get_session()"},{"line_number":1188,"context_line":"    prop \u003d session.query(models.ImageProperty).filter_by(image_id\u003dimage_ref,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f07076d2_6f54c7f5","line":1185,"range":{"start_line":1185,"start_character":4,"end_line":1185,"end_character":71},"in_reply_to":"e9255485_3a3468d2","updated":"2021-04-01 17:04:35.000000000","message":"Sure.","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bcb0287a7afdc85e57fb39f098b10f75081ef025","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                  {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                   \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"aa138b87_bd567382","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"updated":"2021-04-01 16:08:47.000000000","message":"I wonder about returning None here ... the caller may be expecting a possible NotFound exception, but None might cause problems.  Not sure what your options are, though.","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6b54562b881b5345f05b53f6eb6f284b073ab70f","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                  {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                   \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"63ea687b_260cbf89","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"in_reply_to":"8200b267_c35f27e1","updated":"2021-04-08 14:38:57.000000000","message":"Ack","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ff604b04af2a1950c3f3d2929ee11e83dc41398d","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                  {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                   \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"d6156e8f_50cb29f3","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"in_reply_to":"aa138b87_bd567382","updated":"2021-04-01 17:04:35.000000000","message":"I think the return below is really just there for tests, right? We don\u0027t actually use it anywhere. We want to avoid raising anything here at runtime, or we need to make sure the caller ignores it. The latter seems like more work, but if you think it\u0027d be clearer, that\u0027s fine.","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf5ff94cfa44be3477bfacbdc3124d706889b93e","unresolved":true,"context_lines":[{"line_number":1195,"context_line":"                   \u0027%(err)s\u0027),"},{"line_number":1196,"context_line":"                  {\u0027prop\u0027: prop_ref, \u0027image\u0027: image_ref,"},{"line_number":1197,"context_line":"                   \u0027err\u0027: str(e)})"},{"line_number":1198,"context_line":"        return"},{"line_number":1199,"context_line":"    return prop"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8200b267_c35f27e1","line":1198,"range":{"start_line":1198,"start_character":8,"end_line":1198,"end_character":14},"in_reply_to":"d6156e8f_50cb29f3","updated":"2021-04-08 14:37:42.000000000","message":"I was just being lazy and not confirming that the returned value isn\u0027t used anywhere (which you wouldn\u0027t expect it to, it\u0027s a really weird thing to return).  I am OK with returning None at line 1198.","commit_id":"1dbb003dc9751fb29bfad1c086f8332b12c84bd4"}]}