)]}'
{"doc/source/contributor/core_reviewer_guidelines.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44c25f8c8fae25e70cadbcf80821b4dbe0136e1c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"Some guidelines around this process are provided below:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification has been addressed."},{"line_number":26,"context_line":"* The PTL reserves the rights to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1c471f41_f12412b0","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":46},"updated":"2021-03-30 18:50:13.000000000","message":"have","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bdb74b079ab2fbff5e755d52420090bf1667d4be","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Some guidelines around this process are provided below:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification has been addressed."},{"line_number":26,"context_line":"* The PTL reserves the rights to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"}],"source_content_type":"text/x-rst","patch_set":2,"id":"72aa3d2c_3eff250e","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":46},"in_reply_to":"1c471f41_f12412b0","updated":"2021-03-31 05:41:24.000000000","message":"Done","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44c25f8c8fae25e70cadbcf80821b4dbe0136e1c","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification has been addressed."},{"line_number":26,"context_line":"* The PTL reserves the rights to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"},{"line_number":29,"context_line":"  release. Specifications which are not approved by then can be discussed in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"66d0fa3e_b3179a17","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":29},"updated":"2021-03-30 18:50:13.000000000","message":"right","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bdb74b079ab2fbff5e755d52420090bf1667d4be","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification has been addressed."},{"line_number":26,"context_line":"* The PTL reserves the rights to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"},{"line_number":29,"context_line":"  release. Specifications which are not approved by then can be discussed in"}],"source_content_type":"text/x-rst","patch_set":2,"id":"395de04b_1f9a8c88","line":26,"range":{"start_line":26,"start_character":23,"end_line":26,"end_character":29},"in_reply_to":"66d0fa3e_b3179a17","updated":"2021-03-31 05:41:24.000000000","message":"Done","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44c25f8c8fae25e70cadbcf80821b4dbe0136e1c","unresolved":true,"context_lines":[{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"},{"line_number":29,"context_line":"  release. Specifications which are not approved by then can be discussed in"},{"line_number":30,"context_line":"  following weekly meeting and a decision will be made whether to grant an FFE"},{"line_number":31,"context_line":"  or move them to next cycle."},{"line_number":32,"context_line":"* The role of a core spec reviewer is to determine design fitness of the"},{"line_number":33,"context_line":"  proposed change, as well as suitability for inclusion in the project. In"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c21e1074_d6f2ccd0","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":11},"updated":"2021-03-30 18:50:13.000000000","message":"the following","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bdb74b079ab2fbff5e755d52420090bf1667d4be","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  need to be approved for given cycle."},{"line_number":28,"context_line":"* All specifications should be approved within 1 week after milestone-1"},{"line_number":29,"context_line":"  release. Specifications which are not approved by then can be discussed in"},{"line_number":30,"context_line":"  following weekly meeting and a decision will be made whether to grant an FFE"},{"line_number":31,"context_line":"  or move them to next cycle."},{"line_number":32,"context_line":"* The role of a core spec reviewer is to determine design fitness of the"},{"line_number":33,"context_line":"  proposed change, as well as suitability for inclusion in the project. In"}],"source_content_type":"text/x-rst","patch_set":2,"id":"deee4c0d_0bb88769","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":11},"in_reply_to":"c21e1074_d6f2ccd0","updated":"2021-03-31 05:41:24.000000000","message":"Done","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44c25f8c8fae25e70cadbcf80821b4dbe0136e1c","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    everything is correct"},{"line_number":50,"context_line":"  * For a patch which fixes a bug, the approver should ensure that:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    * Unit or Functional tests has been added/updated"},{"line_number":53,"context_line":"    * A release note has been added if the bug is not trivial"},{"line_number":54,"context_line":"    * The commit message is tagged with Closes-Bug: #bugid"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3dd279c9_d8ed374d","line":52,"range":{"start_line":52,"start_character":31,"end_line":52,"end_character":34},"updated":"2021-03-30 18:50:13.000000000","message":"have","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bdb74b079ab2fbff5e755d52420090bf1667d4be","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    everything is correct"},{"line_number":50,"context_line":"  * For a patch which fixes a bug, the approver should ensure that:"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    * Unit or Functional tests has been added/updated"},{"line_number":53,"context_line":"    * A release note has been added if the bug is not trivial"},{"line_number":54,"context_line":"    * The commit message is tagged with Closes-Bug: #bugid"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"e685c549_d4c1ecf2","line":52,"range":{"start_line":52,"start_character":31,"end_line":52,"end_character":34},"in_reply_to":"3dd279c9_d8ed374d","updated":"2021-03-31 05:41:24.000000000","message":"Done","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44c25f8c8fae25e70cadbcf80821b4dbe0136e1c","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    that the change does not fit with the project goals, so that the submitter"},{"line_number":74,"context_line":"    can understand the reasons and refocus their future contributions more"},{"line_number":75,"context_line":"    productively."},{"line_number":76,"context_line":"  * The core team should come to an agreement if there is difference in opinion"},{"line_number":77,"context_line":"    about the suitability of the patch."},{"line_number":78,"context_line":"  * If a majority of the team is in favor of moving forward with the patch then"},{"line_number":79,"context_line":"    the person who added these -2(s) will change it to -1 if they still don\u0027t"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8579b7f1_ffd6ee4c","line":76,"range":{"start_line":76,"start_character":58,"end_line":76,"end_character":71},"updated":"2021-03-30 18:50:13.000000000","message":"a difference of","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"bdb74b079ab2fbff5e755d52420090bf1667d4be","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    that the change does not fit with the project goals, so that the submitter"},{"line_number":74,"context_line":"    can understand the reasons and refocus their future contributions more"},{"line_number":75,"context_line":"    productively."},{"line_number":76,"context_line":"  * The core team should come to an agreement if there is difference in opinion"},{"line_number":77,"context_line":"    about the suitability of the patch."},{"line_number":78,"context_line":"  * If a majority of the team is in favor of moving forward with the patch then"},{"line_number":79,"context_line":"    the person who added these -2(s) will change it to -1 if they still don\u0027t"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9d25b1eb_acfd2d44","line":76,"range":{"start_line":76,"start_character":58,"end_line":76,"end_character":71},"in_reply_to":"8579b7f1_ffd6ee4c","updated":"2021-03-31 05:41:24.000000000","message":"Done","commit_id":"3ecc0a296d34b5bb4957161918221641bfe1c4d5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"85142dc7e61cf66511dbf21f64528db5162ad239","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition to code reviews, Glance also maintains a BP specification git"},{"line_number":15,"context_line":"repository. Detailed instructions for the use of this repository are provided"},{"line_number":16,"context_line":"`here \u003chttps://github.com/openstack/glance-specs/blob/master/README.rst\u003e`_."},{"line_number":17,"context_line":"It is expected that Glance core team members are actively reviewing"},{"line_number":18,"context_line":"specifications which are pushed out for review to the specification repository."},{"line_number":19,"context_line":"Glance specs are approved/merged by the PTL only. The PTL can approve a spec"}],"source_content_type":"text/x-rst","patch_set":3,"id":"a1d267de_be8355ca","line":16,"range":{"start_line":16,"start_character":15,"end_line":16,"end_character":25},"updated":"2021-04-01 19:35:12.000000000","message":"should probably use opendev.org instead of the mirror","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fd569012b287b6b43f838fc0c68c73f52ff1ab06","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In addition to code reviews, Glance also maintains a BP specification git"},{"line_number":15,"context_line":"repository. Detailed instructions for the use of this repository are provided"},{"line_number":16,"context_line":"`here \u003chttps://github.com/openstack/glance-specs/blob/master/README.rst\u003e`_."},{"line_number":17,"context_line":"It is expected that Glance core team members are actively reviewing"},{"line_number":18,"context_line":"specifications which are pushed out for review to the specification repository."},{"line_number":19,"context_line":"Glance specs are approved/merged by the PTL only. The PTL can approve a spec"}],"source_content_type":"text/x-rst","patch_set":3,"id":"d9a08576_74c30850","line":16,"range":{"start_line":16,"start_character":15,"end_line":16,"end_character":25},"in_reply_to":"a1d267de_be8355ca","updated":"2021-04-05 05:42:08.000000000","message":"Done","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ea14822db83ca62e5c2bcf097cad057acdac4cdb","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Some guidelines around this process are provided below:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification have been addressed."},{"line_number":26,"context_line":"* The PTL reserves the right to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."}],"source_content_type":"text/x-rst","patch_set":3,"id":"14393bb1_231c45a7","line":24,"range":{"start_line":24,"start_character":49,"end_line":24,"end_character":57},"updated":"2021-04-01 19:00:56.000000000","message":"reviewers*","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fd569012b287b6b43f838fc0c68c73f52ff1ab06","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Some guidelines around this process are provided below:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"* Before approving a spec, the PTL or other core reviwers should confirm that"},{"line_number":25,"context_line":"  all the comments about the specification have been addressed."},{"line_number":26,"context_line":"* The PTL reserves the right to decide which specifications are important and"},{"line_number":27,"context_line":"  need to be approved for given cycle."}],"source_content_type":"text/x-rst","patch_set":3,"id":"eaf828d0_ea8287c8","line":24,"range":{"start_line":24,"start_character":49,"end_line":24,"end_character":57},"in_reply_to":"14393bb1_231c45a7","updated":"2021-04-05 05:42:08.000000000","message":"Done","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"85142dc7e61cf66511dbf21f64528db5162ad239","unresolved":true,"context_lines":[{"line_number":83,"context_line":"  * The PTL reserves the right to ask a core reviewer to change their -2 vote"},{"line_number":84,"context_line":"    to a -1."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Procedural use of -2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * In some situations, a core reviewer will put a -2 vote on a patch to \"hold\""},{"line_number":89,"context_line":"    it temporarily from merging due to some procedural criteria. This may be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa94e34c_558d1365","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":22},"updated":"2021-04-01 19:35:12.000000000","message":"This is a nice section, thanks for explaining this.","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fd569012b287b6b43f838fc0c68c73f52ff1ab06","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  * The PTL reserves the right to ask a core reviewer to change their -2 vote"},{"line_number":84,"context_line":"    to a -1."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"* Procedural use of -2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  * In some situations, a core reviewer will put a -2 vote on a patch to \"hold\""},{"line_number":89,"context_line":"    it temporarily from merging due to some procedural criteria. This may be"}],"source_content_type":"text/x-rst","patch_set":3,"id":"c00b1fa1_dab7126b","line":86,"range":{"start_line":86,"start_character":2,"end_line":86,"end_character":22},"in_reply_to":"fa94e34c_558d1365","updated":"2021-04-05 05:42:08.000000000","message":"Ack","commit_id":"4862aa6e541f31e8c5b26dc78f4dae8f090eefe2"}]}