)]}'
{"glance/tests/functional/__init__.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"148baa5d2e69446289eecaf9accaa0821e4ce57d","unresolved":true,"context_lines":[{"line_number":1785,"context_line":"    def _get_latest_task(self, image_id):"},{"line_number":1786,"context_line":"        tasks \u003d self.api_get(\u0027/v2/images/%s/tasks\u0027 % image_id).json[\u0027tasks\u0027]"},{"line_number":1787,"context_line":"        tasks \u003d sorted(tasks, key\u003dlambda t: t[\u0027updated_at\u0027])"},{"line_number":1788,"context_line":"        return tasks[-1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"8c63811c_851b0aae","line":1788,"range":{"start_line":1788,"start_character":0,"end_line":1788,"end_character":24},"updated":"2021-06-03 18:58:55.000000000","message":"A bit of nitpicking, probably not worth holding back the whole patch series, but wouldn\u0027t we want to do:\n\n\n\nself.assertTrue(len(tasks) \u003e 1)\n\n\n\nrather than have an IndexError raised? I feel this would make it easier to understand, especially when going through the logs very quickly after a test failure.","commit_id":"e1139dc0f8f05ec115a5869053a1b0a8b1744401"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1d5e4973def30d105f2be7e56b7270942a0058d2","unresolved":true,"context_lines":[{"line_number":1785,"context_line":"    def _get_latest_task(self, image_id):"},{"line_number":1786,"context_line":"        tasks \u003d self.api_get(\u0027/v2/images/%s/tasks\u0027 % image_id).json[\u0027tasks\u0027]"},{"line_number":1787,"context_line":"        tasks \u003d sorted(tasks, key\u003dlambda t: t[\u0027updated_at\u0027])"},{"line_number":1788,"context_line":"        return tasks[-1]"}],"source_content_type":"text/x-python","patch_set":5,"id":"a5e917ea_6543c5a3","line":1788,"range":{"start_line":1788,"start_character":0,"end_line":1788,"end_character":24},"in_reply_to":"8c63811c_851b0aae","updated":"2021-06-03 19:19:53.000000000","message":"Sure. The places I use this are areas where we\u0027ve already determined that an import has started or finished, so it\u0027s pretty safe. But yeah, I\u0027ll add this if I respin.","commit_id":"e1139dc0f8f05ec115a5869053a1b0a8b1744401"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e7b923d0ef63653f75d0cfab5115a1e0804486c4","unresolved":true,"context_lines":[{"line_number":1785,"context_line":"    def _get_latest_task(self, image_id):"},{"line_number":1786,"context_line":"        tasks \u003d self.api_get(\u0027/v2/images/%s/tasks\u0027 % image_id).json[\u0027tasks\u0027]"},{"line_number":1787,"context_line":"        tasks \u003d sorted(tasks, key\u003dlambda t: t[\u0027updated_at\u0027])"},{"line_number":1788,"context_line":"        self.assertGreater(len(tasks), 0)"},{"line_number":1789,"context_line":"        return tasks[-1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d207897_1a66bf2b","line":1788,"range":{"start_line":1788,"start_character":13,"end_line":1788,"end_character":26},"updated":"2021-06-04 14:49:04.000000000","message":":O, I wasn\u0027t aware about this assert","commit_id":"d4730c2092f829d22c5cc4e8344bcce284602461"}]}