)]}'
{"glance/api/v2/image_data.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"6634a053a79d6226a74a7705041301dc65ad397b","unresolved":true,"context_lines":[{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                uri, size, id, store_info \u003d staging_store.add("},{"line_number":348,"context_line":"                    image_id, utils.LimitingReader("},{"line_number":349,"context_line":"                        utils.CooperativeReader(data), CONF.image_size_cap), 0)"},{"line_number":350,"context_line":"                image.size \u003d size"},{"line_number":351,"context_line":"            except glance_store.Duplicate:"},{"line_number":352,"context_line":"                msg \u003d _(\"The image %s has data on staging\") % image_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcda7e1a_625c6f61","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":79},"updated":"2021-06-04 01:47:42.000000000","message":"I might be missing something here, but isn\u0027t staging_store.add supposed to return 5 values? This works here because of the way we define the mock in test_image_data_resource.py, but wouldn\u0027t this raise a ValueError in a \"real\" use case?","commit_id":"d30772e30c992e51e7478409e9f5fd9a6aa9296a"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ff87bb726b7eb0fa89f6091830d8c0770f4b42ec","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                uri, size, id, store_info \u003d staging_store.add("},{"line_number":348,"context_line":"                    image_id, utils.LimitingReader("},{"line_number":349,"context_line":"                        utils.CooperativeReader(data), CONF.image_size_cap), 0)"},{"line_number":350,"context_line":"                image.size \u003d size"},{"line_number":351,"context_line":"            except glance_store.Duplicate:"},{"line_number":352,"context_line":"                msg \u003d _(\"The image %s has data on staging\") % image_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"d3b2b82d_e0ed6a52","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":79},"in_reply_to":"8e3b6840_72fc30dc","updated":"2021-06-04 13:44:15.000000000","message":"OK, I was indeed super confused. Thanks for the explanation!","commit_id":"d30772e30c992e51e7478409e9f5fd9a6aa9296a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ffe2183a747aef1046357568d1fac4cbe6849be1","unresolved":true,"context_lines":[{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                uri, size, id, store_info \u003d staging_store.add("},{"line_number":348,"context_line":"                    image_id, utils.LimitingReader("},{"line_number":349,"context_line":"                        utils.CooperativeReader(data), CONF.image_size_cap), 0)"},{"line_number":350,"context_line":"                image.size \u003d size"},{"line_number":351,"context_line":"            except glance_store.Duplicate:"},{"line_number":352,"context_line":"                msg \u003d _(\"The image %s has data on staging\") % image_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"8e3b6840_72fc30dc","line":349,"range":{"start_line":349,"start_character":0,"end_line":349,"end_character":79},"in_reply_to":"bcda7e1a_625c6f61","updated":"2021-06-04 13:38:55.000000000","message":"Yeah, this is super confusing. Note the comment here:\n\nhttps://github.com/openstack/glance_store/blob/master/glance_store/driver.py#L155-L158\n\nand sure enough, the filesystem store has that decoration:\n\nhttps://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py#L708\n\nNote that this _is_ getting run in several of our jobs with import enabled, so if this was wrong, we\u0027d see failures in devstack runs.","commit_id":"d30772e30c992e51e7478409e9f5fd9a6aa9296a"}]}