)]}'
{".zuul.yaml":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f986a49422a873b30e155e6f136b6555b6b0c318","unresolved":true,"context_lines":[{"line_number":298,"context_line":"      jobs:"},{"line_number":299,"context_line":"        - openstack-tox-functional-py36"},{"line_number":300,"context_line":"        - openstack-tox-functional-py38"},{"line_number":301,"context_line":"        - openstack-tox-functional-py36-fips:"},{"line_number":302,"context_line":"            voting: false"},{"line_number":303,"context_line":"        - glance-code-constants-check"},{"line_number":304,"context_line":"        - glance-ceph-thin-provisioning:"},{"line_number":305,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"373be964_639f5719","line":302,"range":{"start_line":301,"start_character":8,"end_line":302,"end_character":25},"updated":"2021-06-14 13:41:29.000000000","message":"NIT: if you need to spin a new revision, would be nice to keep the versions together.","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7fd4cc8c31faebd9449cf96e432ac314a69f227d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      jobs:"},{"line_number":299,"context_line":"        - openstack-tox-functional-py36"},{"line_number":300,"context_line":"        - openstack-tox-functional-py38"},{"line_number":301,"context_line":"        - openstack-tox-functional-py36-fips:"},{"line_number":302,"context_line":"            voting: false"},{"line_number":303,"context_line":"        - glance-code-constants-check"},{"line_number":304,"context_line":"        - glance-ceph-thin-provisioning:"},{"line_number":305,"context_line":"            voting: false"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4b4a0cab_83ac3add","line":302,"range":{"start_line":301,"start_character":8,"end_line":302,"end_character":25},"in_reply_to":"373be964_639f5719","updated":"2021-06-14 20:05:08.000000000","message":"Done","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcba4ecddefaa9ea4528bc1b783deed0c147c33f","unresolved":true,"context_lines":[{"line_number":236,"context_line":"      devstack_localrc:"},{"line_number":237,"context_line":"        GLANCE_STANDALONE: False"},{"line_number":238,"context_line":"        GLANCE_USE_IMPORT_WORKFLOW: True"},{"line_number":239,"context_line":"        ISCI_CHAP_ALGORITHMS: SHA3-256,SHA256"},{"line_number":240,"context_line":"      devstack_services:"},{"line_number":241,"context_line":"        g-api-r: true"},{"line_number":242,"context_line":"      devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"311c0609_3f4c3cff","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":28},"updated":"2021-08-19 02:46:59.000000000","message":"I left a comment on your devstack patch.  I really think you should name this \u0027ISCSI_CHAP_ALGORITHMS\u0027.","commit_id":"1936e8b394503c60c3c3ea32ddd8e3f9a5b5f9b4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"386e9314c01a05f5c64f0166c4d9b6d0696e720c","unresolved":true,"context_lines":[{"line_number":236,"context_line":"      devstack_localrc:"},{"line_number":237,"context_line":"        GLANCE_STANDALONE: False"},{"line_number":238,"context_line":"        GLANCE_USE_IMPORT_WORKFLOW: True"},{"line_number":239,"context_line":"        ISCI_CHAP_ALGORITHMS: SHA3-256,SHA256"},{"line_number":240,"context_line":"      devstack_services:"},{"line_number":241,"context_line":"        g-api-r: true"},{"line_number":242,"context_line":"      devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9902e625_dbb3d636","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":28},"updated":"2021-08-19 17:58:38.000000000","message":"I left a comment on your devstack patch.  I really think you should name this \u0027ISCSI_CHAP_ALGORITHMS\u0027.","commit_id":"cf262657a34575099019f8ed6b07bdac34ec707c"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4664c3e3a65eb113497aca645448e5b0ce1102ca","unresolved":true,"context_lines":[{"line_number":236,"context_line":"      devstack_localrc:"},{"line_number":237,"context_line":"        GLANCE_STANDALONE: False"},{"line_number":238,"context_line":"        GLANCE_USE_IMPORT_WORKFLOW: True"},{"line_number":239,"context_line":"        ISCI_CHAP_ALGORITHMS: SHA3-256,SHA256"},{"line_number":240,"context_line":"      devstack_services:"},{"line_number":241,"context_line":"        g-api-r: true"},{"line_number":242,"context_line":"      devstack_local_conf:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bbb52c9e_66825560","line":239,"range":{"start_line":239,"start_character":8,"end_line":239,"end_character":28},"in_reply_to":"9902e625_dbb3d636","updated":"2021-08-23 13:45:41.000000000","message":"agreed. will fix","commit_id":"cf262657a34575099019f8ed6b07bdac34ec707c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55f9772281b0647c4b0ba09baecbd83f0457b3af","unresolved":true,"context_lines":[{"line_number":293,"context_line":"    pre-run: playbooks/enable-fips.yaml"},{"line_number":294,"context_line":"    vars:"},{"line_number":295,"context_line":"      configure_swap_size: 4096"},{"line_number":296,"context_line":"      devstack_localrc:"},{"line_number":297,"context_line":"        USE_CINDER_FOR_GLANCE: True"},{"line_number":298,"context_line":"        GLANCE_ENABLE_MULTIPLE_STORES: True"},{"line_number":299,"context_line":"        CINDER_ENABLED_BACKENDS: lvm:lvmdriver-1,lvm:lvmdriver-2"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"6a38479e_656895a2","line":296,"updated":"2022-01-28 16:54:21.000000000","message":"Do we need this redefined in child as it is already defined in parent i.e line #280 to #284\n\nSame applies to other jobs as well","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"daed73f3bc8c07b6ea437b244ffdb7c68414cfdd","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    pre-run: playbooks/enable-fips.yaml"},{"line_number":294,"context_line":"    vars:"},{"line_number":295,"context_line":"      configure_swap_size: 4096"},{"line_number":296,"context_line":"      devstack_localrc:"},{"line_number":297,"context_line":"        USE_CINDER_FOR_GLANCE: True"},{"line_number":298,"context_line":"        GLANCE_ENABLE_MULTIPLE_STORES: True"},{"line_number":299,"context_line":"        CINDER_ENABLED_BACKENDS: lvm:lvmdriver-1,lvm:lvmdriver-2"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"cc87d28a_471e2001","line":296,"in_reply_to":"6a38479e_656895a2","updated":"2022-02-03 05:03:36.000000000","message":"Got answer that parent child does not work as we assume here.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe210e92db2ae867354a51a2c416657982c8dc0b","unresolved":true,"context_lines":[{"line_number":360,"context_line":"      jobs:"},{"line_number":361,"context_line":"        - openstack-tox-functional-py36"},{"line_number":362,"context_line":"        - openstack-tox-functional-py39"},{"line_number":363,"context_line":"        - openstack-tox-functional-py36-fips"},{"line_number":364,"context_line":"        - glance-tox-functional-py39-rbac-defaults"},{"line_number":365,"context_line":"        - glance-code-constants-check"},{"line_number":366,"context_line":"        - glance-ceph-thin-provisioning:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"0eff045f_ee6b0160","line":363,"range":{"start_line":363,"start_character":10,"end_line":363,"end_character":44},"updated":"2022-01-28 17:20:06.000000000","message":"shouldn\u0027t we have this for py39 as it is latest one?","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"af5959d630acd2d2ff63d89dbbc9057452df3077","unresolved":true,"context_lines":[{"line_number":360,"context_line":"      jobs:"},{"line_number":361,"context_line":"        - openstack-tox-functional-py36"},{"line_number":362,"context_line":"        - openstack-tox-functional-py39"},{"line_number":363,"context_line":"        - openstack-tox-functional-py36-fips"},{"line_number":364,"context_line":"        - glance-tox-functional-py39-rbac-defaults"},{"line_number":365,"context_line":"        - glance-code-constants-check"},{"line_number":366,"context_line":"        - glance-ceph-thin-provisioning:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"831b9b1d_23ad56f7","line":363,"range":{"start_line":363,"start_character":10,"end_line":363,"end_character":44},"in_reply_to":"0eff045f_ee6b0160","updated":"2022-02-02 19:48:25.000000000","message":"The fips jobs currently run on centos-8-stream - which IIRC runs py36.\n\nThe plan is to move to centos-9 and py39, but is pending the fix to a bug in python in centos-9, which should be out in centos-9-stream in the next week or two (hopefully).\n\nSo, we can either wait for that fix to merge this job, or merge the current one, with the plan to switch this to py39 and centos-9-stream, when that bug fix lands.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"daed73f3bc8c07b6ea437b244ffdb7c68414cfdd","unresolved":true,"context_lines":[{"line_number":360,"context_line":"      jobs:"},{"line_number":361,"context_line":"        - openstack-tox-functional-py36"},{"line_number":362,"context_line":"        - openstack-tox-functional-py39"},{"line_number":363,"context_line":"        - openstack-tox-functional-py36-fips"},{"line_number":364,"context_line":"        - glance-tox-functional-py39-rbac-defaults"},{"line_number":365,"context_line":"        - glance-code-constants-check"},{"line_number":366,"context_line":"        - glance-ceph-thin-provisioning:"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"9e692257_d70e6fad","line":363,"range":{"start_line":363,"start_character":10,"end_line":363,"end_character":44},"in_reply_to":"831b9b1d_23ad56f7","updated":"2022-02-03 05:03:36.000000000","message":"I think we can have it for py36 now and later add it for py39","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"54d0de001f62e765ebcba4726f87e981a5c3ced4","unresolved":true,"context_lines":[{"line_number":381,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":382,"context_line":"        - tempest-integrated-storage-import:"},{"line_number":383,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":384,"context_line":"        - tempest-integrated-storage-import-fips:"},{"line_number":385,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":386,"context_line":"        - tempest-integrated-storage-import-standalone:"},{"line_number":387,"context_line":"            irrelevant-files: *tempest-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"c2a61667_006fe6cc","line":384,"updated":"2022-01-31 14:37:10.000000000","message":"Do we need fips versions of all of these? The import, import-standalone and multistore-cinder are really just small variants that either tickle one behavior or apply to a smaller number of tests. I wouldn\u0027t think there\u0027s any reason to run all of them doubly for fips mode. I would think the larger difference is just that they\u0027re centos-based, but that likely won\u0027t matter for most of them.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"daed73f3bc8c07b6ea437b244ffdb7c68414cfdd","unresolved":true,"context_lines":[{"line_number":381,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":382,"context_line":"        - tempest-integrated-storage-import:"},{"line_number":383,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":384,"context_line":"        - tempest-integrated-storage-import-fips:"},{"line_number":385,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":386,"context_line":"        - tempest-integrated-storage-import-standalone:"},{"line_number":387,"context_line":"            irrelevant-files: *tempest-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"f3a9b82d_77b0d74e","line":384,"in_reply_to":"51eb13e1_e7a71ae8","updated":"2022-02-03 05:03:36.000000000","message":"I think we can have below jobs;\n\ntempest-integrated-storage-import-fips\nglance-multistore-cinder-import-fips","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"af5959d630acd2d2ff63d89dbbc9057452df3077","unresolved":true,"context_lines":[{"line_number":381,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":382,"context_line":"        - tempest-integrated-storage-import:"},{"line_number":383,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":384,"context_line":"        - tempest-integrated-storage-import-fips:"},{"line_number":385,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":386,"context_line":"        - tempest-integrated-storage-import-standalone:"},{"line_number":387,"context_line":"            irrelevant-files: *tempest-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"51eb13e1_e7a71ae8","line":384,"in_reply_to":"c2a61667_006fe6cc","updated":"2022-02-02 19:48:25.000000000","message":"Ack.  I created a bunch of these as an initial pass to see what would fail.\nNow that they\u0027re all passing -- I\u0027m relying on you guys (glance cores) to tell me which jobs to keep.\n\nPlease let me know - and I\u0027ll adjust accordingly.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6bb8b211af895e8f7a48aa11ab79baee5a5de6be","unresolved":true,"context_lines":[{"line_number":381,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":382,"context_line":"        - tempest-integrated-storage-import:"},{"line_number":383,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":384,"context_line":"        - tempest-integrated-storage-import-fips:"},{"line_number":385,"context_line":"            irrelevant-files: *tempest-irrelevant-files"},{"line_number":386,"context_line":"        - tempest-integrated-storage-import-standalone:"},{"line_number":387,"context_line":"            irrelevant-files: *tempest-irrelevant-files"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"458cab2b_370c93b9","line":384,"in_reply_to":"f3a9b82d_77b0d74e","updated":"2022-02-03 14:59:25.000000000","message":"\u003e I think we can have below jobs;\n\u003e \n\u003e tempest-integrated-storage-import-fips\n\u003e glance-multistore-cinder-import-fips\n\nBut to be clear, modify the existing jobs these are based on, don\u0027t add new ones.. right? That\u0027d be my vote.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"4e2cf9abcc1bc2e403e1a5d1c5fef6f033a475e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c1e695d7_ce09f40e","updated":"2021-10-12 21:00:02.000000000","message":"recheck","commit_id":"4a8f0b692dc52294b486472cecf47edc74de0e00"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"49fbceeba3895a08eaab63aba56e932a2ae541cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"a901dbe7_4cb3e8b3","updated":"2021-10-15 14:53:33.000000000","message":"recheck","commit_id":"00ced3f9dd1ef3d5f5bbd1c5ab0fcff20fcf61a7"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"b4ca03b85496ce1c6cecfb75492aebccd81990db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"b393972e_a15f4bfa","updated":"2021-10-15 12:27:39.000000000","message":"recheck","commit_id":"00ced3f9dd1ef3d5f5bbd1c5ab0fcff20fcf61a7"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"f5e21eac3d8541625de87df326dc03419c13a59e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"1f4bc8f1_909bbb4e","updated":"2021-11-16 12:23:41.000000000","message":"recheck","commit_id":"fab03d079dc81c5e278817619a1ad1ab5372ffe2"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"1dc659b680e798f7a5915736447241a0fe3dd6c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"52277d6c_e086697e","updated":"2021-11-05 15:56:02.000000000","message":"recheck","commit_id":"fab03d079dc81c5e278817619a1ad1ab5372ffe2"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"8d8cedee85d7f63000563bdf3b68fc54174be5c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"c8b86315_a2ee4020","updated":"2021-10-18 17:59:17.000000000","message":"recheck","commit_id":"fab03d079dc81c5e278817619a1ad1ab5372ffe2"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"aab539965ec241f8b6b8aa08fffbdda97a64f2f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"e1c93700_49fd88ef","updated":"2021-10-18 20:15:08.000000000","message":"recheck","commit_id":"fab03d079dc81c5e278817619a1ad1ab5372ffe2"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"e8bc63c6daa54f2d76e94722f331f159abe234b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"da12abdd_57a09886","updated":"2021-11-16 18:42:12.000000000","message":"recheck","commit_id":"13520d5d99d8804ae769a86f74cb274148ac3fd9"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"93dec94f5e3a65d097cced327576fd46b9a115fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"36e37905_0ce85e73","updated":"2022-01-20 05:42:15.000000000","message":"recheck timeout","commit_id":"13c6a96c56ce98bbe5444b81d43c48dcccf1f3aa"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"839a01284d182ebdb0ea91f0d3b068c368200170","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"77dc4859_056fb471","updated":"2022-01-20 21:41:50.000000000","message":"recheck","commit_id":"7ab5e689e437fb8e1f434f4682ebd475c143ed99"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b1202920572b8f1abe268e493f0f1525bacaffd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"331c274d_7173e2c7","updated":"2022-01-31 14:39:03.000000000","message":"Abhishek raises a good point about the python version.  Could you please enhance the commit message to say (a) which nodes this will run on (I guess centos-8-stream) and (b) which python it will use (both of which you can see in the .zuul.yaml file, but what I\u0027m looking for is an explanation of why the jobs are being set up this way).","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"79f99a392d1eb9a1a17055254da468a946f5f448","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"2c7ee5d5_86ca1d06","updated":"2022-01-31 14:42:10.000000000","message":"Falling back to +1 to replies for Dan and Brian\u0027s comment.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fe210e92db2ae867354a51a2c416657982c8dc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"e6ee30a3_48ab4e31","updated":"2022-01-28 17:20:06.000000000","message":"Looks good to me, everything is green and fungi answered to my inline question on IRC about parent child relationship in job.\n\n\u003cfungi\u003e ade_lee__: job variables are inherited but can be overridden, however it looks like what you\u0027re asking is whether the dict you\u0027re putting in the devstacl_localrc variable will be merged with the dict keys from the parent job\u0027s devstack_localrc variable? i think it overwrites the devstack_localrc dict in this case\n\u003cfungi\u003e so it gets fully replaced, not merged with the keys from that variable in the parent","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"55f9772281b0647c4b0ba09baecbd83f0457b3af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"443d2806_b892773c","updated":"2022-01-28 16:54:21.000000000","message":"Looks good,just one question to understand how it works!","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"af5959d630acd2d2ff63d89dbbc9057452df3077","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":35,"id":"ade73306_475f07ec","in_reply_to":"331c274d_7173e2c7","updated":"2022-02-02 19:48:25.000000000","message":"Yes, I can add that note about centos-8-stream and python 3.6.  See my comment about python-3.9/centos-9-stream.","commit_id":"1a31d462e0dd8061b086489dd15ff76d392ae5a4"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"97ba203c827546620882e834e795b0ea278250f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"328e6029_51fe67d7","updated":"2022-02-07 05:29:50.000000000","message":"recheck","commit_id":"0f13754f84919ce095cd6962e4b369c926738b77"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"42ec89a7c284e42230e69fe7277d53db957596ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"7bab01ae_3caad841","updated":"2022-02-03 21:07:56.000000000","message":"recheck","commit_id":"0f13754f84919ce095cd6962e4b369c926738b77"}],"tools/test-setup.sh":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f986a49422a873b30e155e6f136b6555b6b0c318","unresolved":true,"context_lines":[{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function set_conf_line { # file regex value"},{"line_number":31,"context_line":"    sudo sh -c \"grep -q -e \u0027$2\u0027 $1 \u0026\u0026 \\"},{"line_number":32,"context_line":"            sed -i \u0027s|$2|$3|g\u0027 $1 || \\"},{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"781d2ef1_7b165ed0","line":33,"range":{"start_line":31,"start_character":16,"end_line":33,"end_character":27},"updated":"2021-06-14 13:41:29.000000000","message":"This could be simplified to \"sed -i -e \u0027$a$3\u0027 -e \u0027/$2/d\u0027 $1\"?","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7fd4cc8c31faebd9449cf96e432ac314a69f227d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function set_conf_line { # file regex value"},{"line_number":31,"context_line":"    sudo sh -c \"grep -q -e \u0027$2\u0027 $1 \u0026\u0026 \\"},{"line_number":32,"context_line":"            sed -i \u0027s|$2|$3|g\u0027 $1 || \\"},{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"fb1c5005_a182d86f","line":33,"range":{"start_line":31,"start_character":16,"end_line":33,"end_character":27},"in_reply_to":"781d2ef1_7b165ed0","updated":"2021-06-14 20:05:08.000000000","message":"We might be able to - but being a little less sed savvy - this took awhile for me to parse.\nI did get it working with : sudo sh -c  \"sed -i -e \u0027\\$a$3\u0027 -e \u0027/$2/d\u0027 $1\", but that didn\u0027t add the relevant entry for an empty file.\n\nEither way, I\u0027d argue that while this is shorter - it may be a little too abstruse to be simpler and easy to maintain.","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7e73a24c770ba44c9903c247b5329f124ed39c1d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function set_conf_line { # file regex value"},{"line_number":31,"context_line":"    sudo sh -c \"grep -q -e \u0027$2\u0027 $1 \u0026\u0026 \\"},{"line_number":32,"context_line":"            sed -i \u0027s|$2|$3|g\u0027 $1 || \\"},{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"}],"source_content_type":"text/x-sh","patch_set":9,"id":"38713124_97227dc1","line":33,"range":{"start_line":31,"start_character":16,"end_line":33,"end_character":27},"in_reply_to":"fb1c5005_a182d86f","updated":"2021-06-15 12:29:17.000000000","message":"Ohh, I actually never tested it with empty file. The one thing I did not think of. I think there might not be easy way for that as I think it will respin the sed process as it\u0027s \"done\" with the file on the first -e on empty file and then will delete it on the second pass. Maybe having the two rules other way around but might not be worth of it. Initially just felt easier to figure out what\u0027s going on. Maybe just add couple of comments to the current approach what it\u0027s doing and why it actually works ;)","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f986a49422a873b30e155e6f136b6555b6b0c318","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"},{"line_number":37,"context_line":"    # mysql needs to be started on centos/rhel"},{"line_number":38,"context_line":"    sudo systemctl restart mariadb.service"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"e971bc5c_80a80c2e","line":36,"updated":"2021-06-14 13:41:29.000000000","message":"We could replace this with \u0027if { egrep -q \"^.*(centos:centos:|cloudlinux:cloudlinux:|redhat:enterprise_linux:)[78].*$\" /etc/*release }; then\u0027 and avoid those per version checking functions above. This would also make it very simple to extend the checking for version 9.x in future without needing to create specific matcher function for that too. Clearly we do not care which release it is, just that it\u0027s either one of the two (for now).","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"7e73a24c770ba44c9903c247b5329f124ed39c1d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"},{"line_number":37,"context_line":"    # mysql needs to be started on centos/rhel"},{"line_number":38,"context_line":"    sudo systemctl restart mariadb.service"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"ead6289a_e97186d1","line":36,"in_reply_to":"d63b0f50_acd36e06","updated":"2021-06-15 12:29:17.000000000","message":"Cool, I\u0027d be not agains it if we would actually care which one of the versions it is but I think the current approach is a lot of fluff we have no benefit of so might as well streamline it. Maybe swift guys will be happy to clean up the fluff too unless they actually need the version specific info somewhere. ;)","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"7fd4cc8c31faebd9449cf96e432ac314a69f227d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            echo \u0027$3\u0027 \u003e\u003e $1\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"if is_rhel7 || is_rhel8; then"},{"line_number":37,"context_line":"    # mysql needs to be started on centos/rhel"},{"line_number":38,"context_line":"    sudo systemctl restart mariadb.service"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"d63b0f50_acd36e06","line":36,"in_reply_to":"e971bc5c_80a80c2e","updated":"2021-06-14 20:05:08.000000000","message":"I was using what is currently in swift for consistency:\nhttps://opendev.org/openstack/swift/src/branch/master/tools/test-setup.sh#L18-L27\n\nBut I can do this instead to make it simpler for rhel 9","commit_id":"b2b4ab86e67b65c02ec6d96283d557a324fece21"}]}