)]}'
{"glance/api/v2/image_data.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b333c9b4fcb6392052def7927e493299bb14c65d","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                                                      request\u003dreq)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":281,"context_line":"            LOG.error(str(e))"},{"line_number":282,"context_line":"            self._restore(image_repo, image)"},{"line_number":283,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":284,"context_line":"                                                      request\u003dreq)"}],"source_content_type":"text/x-python","patch_set":3,"id":"550a6294_571d53b0","line":281,"range":{"start_line":281,"start_character":22,"end_line":281,"end_character":28},"updated":"2021-06-04 16:41:24.000000000","message":"Should be enclosed with _LE","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a9a4fb6b8bd5ce1d9a40ce5b4ca16b8d5211545","unresolved":true,"context_lines":[{"line_number":278,"context_line":"                                                      request\u003dreq)"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":281,"context_line":"            LOG.error(str(e))"},{"line_number":282,"context_line":"            self._restore(image_repo, image)"},{"line_number":283,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":284,"context_line":"                                                      request\u003dreq)"}],"source_content_type":"text/x-python","patch_set":3,"id":"561566c7_d2783181","line":281,"range":{"start_line":281,"start_character":22,"end_line":281,"end_character":28},"in_reply_to":"550a6294_571d53b0","updated":"2021-06-04 17:05:25.000000000","message":"This doesn\u0027t work on non-literal strings does it?","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b333c9b4fcb6392052def7927e493299bb14c65d","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                                                      request\u003dreq)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":415,"context_line":"            LOG.debug(str(e))"},{"line_number":416,"context_line":"            self._unstage(image_repo, image, staging_store)"},{"line_number":417,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":418,"context_line":"                                                      request\u003dreq)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2c93fcfb_27d87a85","line":415,"range":{"start_line":415,"start_character":12,"end_line":415,"end_character":29},"updated":"2021-06-04 16:41:24.000000000","message":"Why logged as debug here and error in upload case?","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a9a4fb6b8bd5ce1d9a40ce5b4ca16b8d5211545","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                                                      request\u003dreq)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":415,"context_line":"            LOG.debug(str(e))"},{"line_number":416,"context_line":"            self._unstage(image_repo, image, staging_store)"},{"line_number":417,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":418,"context_line":"                                                      request\u003dreq)"}],"source_content_type":"text/x-python","patch_set":3,"id":"79a747ae_cb84eea5","line":415,"range":{"start_line":415,"start_character":12,"end_line":415,"end_character":29},"in_reply_to":"2c93fcfb_27d87a85","updated":"2021-06-04 17:05:25.000000000","message":"Well, because I was mirroring the ImageSizeLimitExceeded above each, which do it the same inconsistent way.\n\nI would argue that they should both be LOG.debug() though as a user causing LOG.error()s in a server log is generally considered bad. People with log alarms might wake someone up because some bad user is bumping against their quota.","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"}],"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b333c9b4fcb6392052def7927e493299bb14c65d","unresolved":true,"context_lines":[{"line_number":469,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":470,"context_line":"        except exception.InvalidImageStatusTransition as e:"},{"line_number":471,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":472,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":473,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":474,"context_line":"                                                      request\u003dreq)"},{"line_number":475,"context_line":"        except ValueError as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"46d9f061_e57b1ea7","line":472,"updated":"2021-06-04 16:41:24.000000000","message":"you recorded log message in case of upload and stage, why not for import?","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2a9a4fb6b8bd5ce1d9a40ce5b4ca16b8d5211545","unresolved":true,"context_lines":[{"line_number":469,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":470,"context_line":"        except exception.InvalidImageStatusTransition as e:"},{"line_number":471,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg)"},{"line_number":472,"context_line":"        except exception.LimitExceeded as e:"},{"line_number":473,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dstr(e),"},{"line_number":474,"context_line":"                                                      request\u003dreq)"},{"line_number":475,"context_line":"        except ValueError as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"54191eca_b7f5d6b6","line":472,"in_reply_to":"46d9f061_e57b1ea7","updated":"2021-06-04 17:05:25.000000000","message":"Just consistent behavior with the two handlers above. This, along with the two above is a user behavior problem, which shouldn\u0027t be logged as error, but I can log as debug if you want. I guess we need to decide if we should refactor all the image_data.py ones before or after this, and use that to advise what to do here.\n\nBut, just tell me which you want and I\u0027ll do it :)","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"}],"glance/async_/flows/api_image_import.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b333c9b4fcb6392052def7927e493299bb14c65d","unresolved":true,"context_lines":[{"line_number":754,"context_line":"            action_wrapper.drop_lock_for_task()"},{"line_number":755,"context_line":"            task \u003d script_utils.get_task(task_repo, task_id)"},{"line_number":756,"context_line":"            if task is None:"},{"line_number":757,"context_line":"                LOG.error(\u0027Failed to find task %r to update after \u0027"},{"line_number":758,"context_line":"                          \u0027quota failure\u0027, task_id)"},{"line_number":759,"context_line":"            task.fail(str(e))"},{"line_number":760,"context_line":"            task_repo.save(task)"},{"line_number":761,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fe19d052_36654419","line":758,"range":{"start_line":757,"start_character":26,"end_line":758,"end_character":50},"updated":"2021-06-04 16:41:24.000000000","message":"Need to wrapped with _LE","commit_id":"cb90ffdf264fee8f2cd7c262ffce5a428e4b03c2"}]}