)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5fa6ffb3e9677c00fc7dbe8ffba4f40f1368ba96","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-06-29 08:58:50 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reproduce bug #1932337"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reproduces the behavior described in bug 1932337, where a post-"},{"line_number":10,"context_line":"upgrade GET by a non-owning user will return 404 for a valid image"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a5d6d64c_951f8c9f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2021-07-16 12:01:32.000000000","message":"Maybe for clarity when viewing git log \"\"\"Reproduce bug #1932337 in functional tests\"\"\"","commit_id":"ce7a3a0ddc2ebff5c51303525dbdcdd40d193b6c"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5fa6ffb3e9677c00fc7dbe8ffba4f40f1368ba96","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upgrade GET by a non-owning user will return 404 for a valid image"},{"line_number":11,"context_line":"because the cinder store migration cannot complete."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This asserts the broken behavior to reproduce the problem, and the"},{"line_number":14,"context_line":"rest of the test will be enabled when the bug is fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the test for this was duplicating code from the base class,"},{"line_number":17,"context_line":"and since some changes were needed to those methods, this removes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c7d7fdd5_08f11ef1","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":55},"updated":"2021-07-16 12:01:32.000000000","message":"Skip if rather than assert.","commit_id":"ce7a3a0ddc2ebff5c51303525dbdcdd40d193b6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c9d98793ab78123a450043a0ece671f3d075d1a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"upgrade GET by a non-owning user will return 404 for a valid image"},{"line_number":11,"context_line":"because the cinder store migration cannot complete."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This asserts the broken behavior to reproduce the problem, and the"},{"line_number":14,"context_line":"rest of the test will be enabled when the bug is fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Note that the test for this was duplicating code from the base class,"},{"line_number":17,"context_line":"and since some changes were needed to those methods, this removes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3b6865a6_7c40dd94","line":14,"range":{"start_line":13,"start_character":0,"end_line":14,"end_character":55},"in_reply_to":"c7d7fdd5_08f11ef1","updated":"2021-07-16 13:38:07.000000000","message":"I very much disagree that we should remove the assert. The whole point of this being a reproduce is to assert that the wrong behavior exists, for demonstration, before fixing it and asserting the new behavior.\n\nI know this argument doesn\u0027t hold much weight with you, but other projects do this sort of thing for big regressions before a fix to help prove that the regression exists on a given stable branch before merging a fix.","commit_id":"ce7a3a0ddc2ebff5c51303525dbdcdd40d193b6c"}],"glance/tests/functional/v2/test_legacy_update_cinder_store.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5fa6ffb3e9677c00fc7dbe8ffba4f40f1368ba96","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        resp \u003d self.api_get(\u0027/v2/images/%s\u0027 % image_id,"},{"line_number":257,"context_line":"                            headers\u003d{\u0027X-Roles\u0027: \u0027reader\u0027})"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # FIXME(danms): This is broken behavior: the first user to GET"},{"line_number":260,"context_line":"        # an image after upgrade may not be an admin or the owner. As"},{"line_number":261,"context_line":"        # such, we should not return 404 to that user for a valid image."},{"line_number":262,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":263,"context_line":"        return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # FIXME(danms): Continue the test below when bug 1932337 is"},{"line_number":266,"context_line":"        # fixed."},{"line_number":267,"context_line":"        image \u003d resp.json"},{"line_number":268,"context_line":"        # verify the image is updated to new format"},{"line_number":269,"context_line":"        self.assertEqual(\u0027cinder://store1/%s\u0027 % self.vol_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8706ccc4_48b0360f","line":266,"range":{"start_line":259,"start_character":0,"end_line":266,"end_character":16},"updated":"2021-07-16 12:01:32.000000000","message":"Rather than giving passed test for broken behaviour perhaps introduce this with\nif resp.status_code \u003d\u003d 404:\n    self.skipTest(\"Cinder store lazy update is broken. Bug #1932337\")\n\nThen it can be just removed when fixed.","commit_id":"ce7a3a0ddc2ebff5c51303525dbdcdd40d193b6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c9d98793ab78123a450043a0ece671f3d075d1a","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        resp \u003d self.api_get(\u0027/v2/images/%s\u0027 % image_id,"},{"line_number":257,"context_line":"                            headers\u003d{\u0027X-Roles\u0027: \u0027reader\u0027})"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # FIXME(danms): This is broken behavior: the first user to GET"},{"line_number":260,"context_line":"        # an image after upgrade may not be an admin or the owner. As"},{"line_number":261,"context_line":"        # such, we should not return 404 to that user for a valid image."},{"line_number":262,"context_line":"        self.assertEqual(404, resp.status_code)"},{"line_number":263,"context_line":"        return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        # FIXME(danms): Continue the test below when bug 1932337 is"},{"line_number":266,"context_line":"        # fixed."},{"line_number":267,"context_line":"        image \u003d resp.json"},{"line_number":268,"context_line":"        # verify the image is updated to new format"},{"line_number":269,"context_line":"        self.assertEqual(\u0027cinder://store1/%s\u0027 % self.vol_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe319a41_0f6d5ddd","line":266,"range":{"start_line":259,"start_character":0,"end_line":266,"end_character":16},"in_reply_to":"8706ccc4_48b0360f","updated":"2021-07-16 13:38:07.000000000","message":"Asserting the current behavior is the point of this patch and new test in general. I guess if you really prefer the skip instead of the return then I can make that change, but keeping the assert of the current behavior is important until it\u0027s fixed.","commit_id":"ce7a3a0ddc2ebff5c51303525dbdcdd40d193b6c"}]}