)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab3508bd6b03cb083ae0cfb9335667bf14d71e90","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if its configuration parameters were set. If the store fails to load and"},{"line_number":13,"context_line":"it\u0027s not in `known_stores` then no error will be reported."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The patch also wans the user when a store succeeds to load but it was"},{"line_number":16,"context_line":"not explicitly enabled in `known_stores`. Note that there may be false"},{"line_number":17,"context_line":"positives since some stores may not require any configuration parameter."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2F%2Fb4%3D","line":15,"updated":"2014-03-12 14:05:59.000000000","message":"\"wans\" typo?","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2335a3edb8c64294d6e867c6053a9562fb966992","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if its configuration parameters were set. If the store fails to load and"},{"line_number":13,"context_line":"it\u0027s not in `known_stores` then no error will be reported."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The patch also wans the user when a store succeeds to load but it was"},{"line_number":16,"context_line":"not explicitly enabled in `known_stores`. Note that there may be false"},{"line_number":17,"context_line":"positives since some stores may not require any configuration parameter."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2F%2FXk%3D","line":15,"in_reply_to":"AAAAWH%2F%2F%2Fb4%3D","updated":"2014-03-12 14:30:02.000000000","message":"Done","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"}],"glance/store/__init__.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"3ede8529b63e893667729fbffd136b8ef34f7f16","unresolved":false,"context_lines":[{"line_number":64,"context_line":"CONF.register_opts(store_opts)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"_EXTRA_STORES \u003d ["},{"line_number":67,"context_line":"    \u0027glance.store.filesystem.Store\u0027,"},{"line_number":68,"context_line":"    \u0027glance.store.s3.Store\u0027,"},{"line_number":69,"context_line":"    \u0027glance.store.swift.Store\u0027,"},{"line_number":70,"context_line":"    \u0027glance.store.sheepdog.Store\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Fp8%3D","line":67,"updated":"2014-03-12 13:57:28.000000000","message":"duplicated item, already enabled by default","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab3508bd6b03cb083ae0cfb9335667bf14d71e90","unresolved":false,"context_lines":[{"line_number":64,"context_line":"CONF.register_opts(store_opts)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"_EXTRA_STORES \u003d ["},{"line_number":67,"context_line":"    \u0027glance.store.filesystem.Store\u0027,"},{"line_number":68,"context_line":"    \u0027glance.store.s3.Store\u0027,"},{"line_number":69,"context_line":"    \u0027glance.store.swift.Store\u0027,"},{"line_number":70,"context_line":"    \u0027glance.store.sheepdog.Store\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FZM%3D","line":67,"in_reply_to":"AAAAWH%2F%2F%2Fp8%3D","updated":"2014-03-12 14:05:59.000000000","message":"+1, I think you\u0027re going to say \u0027rbd\u0027?","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"83e108c468f2e93d7a2c634f68570702f43628e7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"CONF.register_opts(store_opts)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"_EXTRA_STORES \u003d ["},{"line_number":67,"context_line":"    \u0027glance.store.filesystem.Store\u0027,"},{"line_number":68,"context_line":"    \u0027glance.store.s3.Store\u0027,"},{"line_number":69,"context_line":"    \u0027glance.store.swift.Store\u0027,"},{"line_number":70,"context_line":"    \u0027glance.store.sheepdog.Store\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FaQ%3D","line":67,"in_reply_to":"AAAAWH%2F%2F%2Fp8%3D","updated":"2014-03-12 14:06:24.000000000","message":"I thought, I had removed it!","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"3ede8529b63e893667729fbffd136b8ef34f7f16","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    \"\"\""},{"line_number":180,"context_line":"    store_count \u003d 0"},{"line_number":181,"context_line":"    store_classes \u003d set()"},{"line_number":182,"context_line":"    for store_entry in (CONF.known_stores + _EXTRA_STORES):"},{"line_number":183,"context_line":"        store_entry \u003d store_entry.strip()"},{"line_number":184,"context_line":"        if not store_entry:"},{"line_number":185,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Fo0%3D","line":182,"updated":"2014-03-12 13:57:28.000000000","message":"so \u0027glance.store.filesystem.Store\u0027 will be loaded twice.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ab3508bd6b03cb083ae0cfb9335667bf14d71e90","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    \"\"\""},{"line_number":180,"context_line":"    store_count \u003d 0"},{"line_number":181,"context_line":"    store_classes \u003d set()"},{"line_number":182,"context_line":"    for store_entry in (CONF.known_stores + _EXTRA_STORES):"},{"line_number":183,"context_line":"        store_entry \u003d store_entry.strip()"},{"line_number":184,"context_line":"        if not store_entry:"},{"line_number":185,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FZA%3D","line":182,"in_reply_to":"AAAAWH%2F%2F%2Fo0%3D","updated":"2014-03-12 14:05:59.000000000","message":"+1","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":1706,"name":"Tom Hancock","email":"tom.hancock@hp.com","username":"tom-hancock"},"change_message_id":"c82ba16f08dccb3cfe6ae21edb2f5ed751964cb7","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if store_entry not in CONF.known_stores:"},{"line_number":192,"context_line":"                LOG.warn(_(\"%s not found in `known_store`. \""},{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FzQ%3D","line":194,"updated":"2014-03-12 13:15:09.000000000","message":"If you are taking this route then I would suggest be very explicit that\nthe deployer needs to take action because the behaviour being relied\nupon will change.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"3ede8529b63e893667729fbffd136b8ef34f7f16","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            if store_entry not in CONF.known_stores:"},{"line_number":192,"context_line":"                LOG.warn(_(\"%s not found in `known_store`. \""},{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2Fd0%3D","line":194,"in_reply_to":"AAAAWH%2F%2F%2FzQ%3D","updated":"2014-03-12 13:57:28.000000000","message":"I trend to agree this.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"3ede8529b63e893667729fbffd136b8ef34f7f16","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":198,"context_line":"            continue"},{"line_number":199,"context_line":"        schemes \u003d store_instance.get_schemes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FjU%3D","line":196,"updated":"2014-03-12 13:57:28.000000000","message":"IMHO this skipping message should be logged in any case. This will help operator to know the skipping action have been applied to the store which has wrong configurations. In Glance startup path, those failed stores (known and disabled) have already logged the exceptions within their internal code, so this log will make those messages be complete, to tell the deployer truth.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2335a3edb8c64294d6e867c6053a9562fb966992","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":198,"context_line":"            continue"},{"line_number":199,"context_line":"        schemes \u003d store_instance.get_schemes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FM0%3D","line":196,"in_reply_to":"AAAAWH%2F%2F%2FUg%3D","updated":"2014-03-12 14:30:02.000000000","message":"The store doesn\u0027t log anything. AFAIK, stores raise a BadStoreConfiguration error, period. If there\u0027s a store that is logging things, then we can\u0027t do anything about it. I\u0027m opposed to print this warn regardless. Disabling the stores is the point of this whole change and I\u0027d like to see at least a step being taken towards that goal.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"f31dcffffda8e7d9179d6d291b6711d575451412","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":198,"context_line":"            continue"},{"line_number":199,"context_line":"        schemes \u003d store_instance.get_schemes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FUg%3D","line":196,"in_reply_to":"AAAAWH%2F%2F%2FaM%3D","updated":"2014-03-12 14:23:33.000000000","message":"But those stores which failed to start have already logged the error messages to the log, so without this key log line I consider the deployer will miss the truth. Probably operator doesn\u0027t care those disabled stores, but given those stores have been called at here, IMO we need to show the complete message to operator, unless we do nothing for all logging for those disabled stores.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"83e108c468f2e93d7a2c634f68570702f43628e7","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                           \"Stores need to be explicitly enabled in \""},{"line_number":194,"context_line":"                           \"the configuration file.\") % store_entry)"},{"line_number":195,"context_line":"        except exception.BadStoreConfiguration as e:"},{"line_number":196,"context_line":"            if store_entry in CONF.known_stores:"},{"line_number":197,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":198,"context_line":"            continue"},{"line_number":199,"context_line":"        schemes \u003d store_instance.get_schemes()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F%2FaM%3D","line":196,"in_reply_to":"AAAAWH%2F%2F%2FjU%3D","updated":"2014-03-12 14:06:24.000000000","message":"I disagree. The whole point is to avoid logging messages for stores that failed to start and were not explicitly enabled. The stores raise a BadConfiguration exception that is logged here. If the store was not explicitly enabled, the operator shouldn\u0027t care.\n\nThere\u0027s still a case were you\u0027ve the config set, the store is not in known_stores and it fails to start. To avoid failing without reason, I\u0027d say we should log the deprecation warning regardless.","commit_id":"79ad7b6d9769ae06953ede1d1fce06fc96184b8d"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7211f00dbea26a00babbff15ab268ad80dcc59c2","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                LOG.warn(_(\"%s Skipping store driver.\") % unicode(e))"},{"line_number":192,"context_line":"            continue"},{"line_number":193,"context_line":"        finally:"},{"line_number":194,"context_line":"            # NOTE(flaper87): To be removed in Juno"},{"line_number":195,"context_line":"            if store_entry not in CONF.known_stores:"},{"line_number":196,"context_line":"                LOG.deprecated(_(\"%s not found in `known_store`. \""},{"line_number":197,"context_line":"                                 \"Stores need to be explicitly enabled in \""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2F9Bs%3D","line":194,"updated":"2014-03-12 17:59:45.000000000","message":"I would suggest opening a bug targetted at juno-2 to track this removal.","commit_id":"b82e0b2c6fb1b34f7bf56b3cba8b7abc38022b8c"}]}