)]}'
{"doc/source/configuring.rst":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"3e77c87fbe44e7a74271949e514ae77575ffa7a8","unresolved":false,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":"Defines which version(s) of the Registry API will be enabled. If the Glance"},{"line_number":1041,"context_line":"API server parameter ``data_api`` has been set to ``glance.db.registry.api``"},{"line_number":1042,"context_line":"the registry server needs to have the same versions enabled as ``enable_vX_api``."},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"AAAAWH%2F%2FsYs%3D","line":1042,"updated":"2014-03-14 13:07:43.000000000","message":"Minor nit. If the v2 api is not enabled it doesn\u0027t matter what the value of glance.db.registry.api is. So the rules are 1) if enable_v1_api is on for the api then enable_v1_registry should be on and 2) if enable_v2_api is on for the api AND data_api is set to glance.db.registry.api enable_v2_registry should be on.","commit_id":"e8f0096d462d66cc6fa31bbc7fffe2cb0efbf8a8"}],"glance/common/config.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt(\u0027enable_v1_registry\u0027, default\u003dTrue,"},{"line_number":111,"context_line":"                help\u003d_(\"Deploy the v1 OpenStack Registry API.\")),"},{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027enable_v2_registry\u0027, default\u003dTrue,"},{"line_number":113,"context_line":"                help\u003d_(\"Deploy the v2 OpenStack Registry API.\")),"},{"line_number":114,"context_line":"    cfg.StrOpt(\u0027pydev_worker_debug_host\u0027, default\u003dNone,"},{"line_number":115,"context_line":"               help\u003d_(\u0027The hostname/IP of the pydev process listening for \u0027"},{"line_number":116,"context_line":"                      \u0027debug connections\u0027)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2Ba0%3D","line":113,"updated":"2014-03-12 16:19:55.000000000","message":"I think it would make sense in the future to split the api and registry specific params into specific \u0027api\u0027 and \u0027registry\u0027 groups -- but that\u0027s beyond the scope of this patch.","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"}],"glance/registry/api/__init__.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010-2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2BW0%3D","line":3,"updated":"2014-03-12 16:19:55.000000000","message":"*very* minor nit: I think a 2014 HP one may be best? eg see glance/openstack/common/test.py:","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2BTY%3D","line":18,"updated":"2014-03-12 16:19:55.000000000","message":"minor (and super-pedantic!): check out the import ordering guidelines here: http://docs.openstack.org/developer/hacking/","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"77c0b13e37dd46c835455b1159aa792281216a76","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F96A%3D","line":18,"in_reply_to":"AAAAWH%2F%2F%2BTY%3D","updated":"2014-03-12 16:48:37.000000000","message":"Done","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2BOo%3D","line":23,"updated":"2014-03-12 16:19:55.000000000","message":"Are images / members used?\n\nIf we wanted we could do \n\nfrom glance.registry.api.v1 import init as v1_init\n\nif we preferred each api versions to have functions called \u0027init\u0027 rather than V2init/V1init functions.","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"77c0b13e37dd46c835455b1159aa792281216a76","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F95c%3D","line":23,"in_reply_to":"AAAAWH%2F%2F%2BOo%3D","updated":"2014-03-12 16:48:37.000000000","message":"No and neither is the webob exc\n\nwell do we?","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2BPU%3D","line":24,"updated":"2014-03-12 16:19:55.000000000","message":"is rpc used?","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"77c0b13e37dd46c835455b1159aa792281216a76","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F95Q%3D","line":24,"in_reply_to":"AAAAWH%2F%2F%2BPU%3D","updated":"2014-03-12 16:48:37.000000000","message":"no","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"c72c39f2089da44fe689f46855f61497ed682725","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4Pw%3D","line":1,"updated":"2014-03-13 07:36:05.000000000","message":"Please remove this line.","commit_id":"26bcd6363b493a4fcdffc0308ee3380cd01b974d"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"307e859bcdbd3b1a1b45f4c3cbf251c81bcc02d0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3kI%3D","line":1,"in_reply_to":"AAAAWH%2F%2F4Pw%3D","updated":"2014-03-13 09:18:51.000000000","message":"Done","commit_id":"26bcd6363b493a4fcdffc0308ee3380cd01b974d"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"c72c39f2089da44fe689f46855f61497ed682725","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from glance.common import wsgi"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F4Lg%3D","line":18,"updated":"2014-03-13 07:36:05.000000000","message":"alphabetical order","commit_id":"26bcd6363b493a4fcdffc0308ee3380cd01b974d"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"307e859bcdbd3b1a1b45f4c3cbf251c81bcc02d0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from glance.common import wsgi"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAWH%2F%2F3kE%3D","line":18,"in_reply_to":"AAAAWH%2F%2F4Lg%3D","updated":"2014-03-13 09:18:51.000000000","message":"Done","commit_id":"26bcd6363b493a4fcdffc0308ee3380cd01b974d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010-2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvTk%3D","line":1,"updated":"2014-03-14 05:24:53.000000000","message":"This line should be removed as well.","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010-2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftyo%3D","line":1,"in_reply_to":"AAAAWH%2F%2FvTk%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"0524f526806529be9e693d5927ed5766d70e350c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010-2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Fx2Y%3D","line":3,"updated":"2014-03-13 21:27:00.000000000","message":"Probably this copyright line should be removed.","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2010-2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftys%3D","line":3,"in_reply_to":"AAAAWH%2F%2Fx2Y%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvTY%3D","line":19,"updated":"2014-03-14 05:24:53.000000000","message":"unused","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import routes"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftyk%3D","line":19,"in_reply_to":"AAAAWH%2F%2FvTY%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"0524f526806529be9e693d5927ed5766d70e350c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Fx28%3D","line":23,"updated":"2014-03-13 21:27:00.000000000","message":"Not sure if pep8/pylint is complaining about these imports, but in general we do not import methods or classes, only modules.\n\nSo I think it would be better to do something like\n\n  from glance.registry.api import v1\n  from glance.registry.api.v1 import images\n  from glance.registry.api.v1 import members\n\nand similarly for v2 registry imports.\n\nThen, you can do\n\n  v1.init(mapper)\n  ...\n  v2.init(mapper)\n\nand drop the \"V1\" and \"V2\" suffixes from the function names.\n\nThese are minor issues but are necessary to be consistent with our style guidelines.\n\nHowever, I\u0027m also curious why images and members are necessary to import? It seems those names are not used in this file after they are imported (same with rpc below).","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvSk%3D","line":23,"in_reply_to":"AAAAWH%2F%2Fx28%3D","updated":"2014-03-14 05:24:53.000000000","message":"+1","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from oslo.config import cfg"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from glance.common import wsgi"},{"line_number":23,"context_line":"from glance.registry.api.v1 import images, members, initV1"},{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftyg%3D","line":23,"in_reply_to":"AAAAWH%2F%2Fx28%3D","updated":"2014-03-14 09:52:51.000000000","message":"Will upload one more patch set to import the v1 \u0026 v2 instead of the inits","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class API(wsgi.Router):"},{"line_number":29,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvSs%3D","line":27,"updated":"2014-03-14 05:24:53.000000000","message":"Do you think it will be better to add these two lines at here to explicit enable options?\n\n    CONF.import_opt(\u0027enable_v1_registry\u0027, \u0027glance.common.config\u0027)\n    CONF.import_opt(\u0027enable_v2_registry\u0027, \u0027glance.common.config\u0027)","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from glance.registry.api.v2 import rpc, initV2"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d cfg.CONF"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class API(wsgi.Router):"},{"line_number":29,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftug%3D","line":27,"in_reply_to":"AAAAWH%2F%2FvSs%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, mapper):"},{"line_number":32,"context_line":"        if CONF.enable_v1_registry:"},{"line_number":33,"context_line":"            mapper \u003d routes.Mapper()"},{"line_number":34,"context_line":"            initV1(mapper)"},{"line_number":35,"context_line":"        if CONF.enable_v2_registry:"},{"line_number":36,"context_line":"            mapper \u003d mapper or routes.Mapper()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvUM%3D","line":33,"updated":"2014-03-14 05:24:53.000000000","message":"IMHO we need to use glance.common.APIMapper object here instead of create it as routes.Mapper()  all the time. Actually I think this is a bug even for original code.\n\n    mapper \u003d mapper or routes.Mapper()\n\nhttps://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L424","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def __init__(self, mapper):"},{"line_number":32,"context_line":"        if CONF.enable_v1_registry:"},{"line_number":33,"context_line":"            mapper \u003d routes.Mapper()"},{"line_number":34,"context_line":"            initV1(mapper)"},{"line_number":35,"context_line":"        if CONF.enable_v2_registry:"},{"line_number":36,"context_line":"            mapper \u003d mapper or routes.Mapper()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Ftho%3D","line":33,"in_reply_to":"AAAAWH%2F%2FvUM%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"27ff622b5fbac57f39cbdff7fdef78723a8c9b49","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class API(wsgi.Router):"},{"line_number":28,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, mapper):"},{"line_number":31,"context_line":"        if CONF.enable_v1_registry:"},{"line_number":32,"context_line":"            mapper \u003d wsgi.APIMapper()"},{"line_number":33,"context_line":"            v1.init(mapper)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtTI%3D","line":30,"updated":"2014-03-14 10:40:53.000000000","message":"mapper \u003d mapper or wsgi.APIMapper()","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"adad9441f71247ce2e030f6d1a76f4623c0b3005","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class API(wsgi.Router):"},{"line_number":28,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, mapper):"},{"line_number":31,"context_line":"        if CONF.enable_v1_registry:"},{"line_number":32,"context_line":"            mapper \u003d wsgi.APIMapper()"},{"line_number":33,"context_line":"            v1.init(mapper)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtLc%3D","line":30,"in_reply_to":"AAAAWH%2F%2FtTI%3D","updated":"2014-03-14 10:54:29.000000000","message":"Done","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"27ff622b5fbac57f39cbdff7fdef78723a8c9b49","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, mapper):"},{"line_number":31,"context_line":"        if CONF.enable_v1_registry:"},{"line_number":32,"context_line":"            mapper \u003d wsgi.APIMapper()"},{"line_number":33,"context_line":"            v1.init(mapper)"},{"line_number":34,"context_line":"        if CONF.enable_v2_registry:"},{"line_number":35,"context_line":"            mapper \u003d mapper or wsgi.APIMapper()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtUo%3D","line":32,"updated":"2014-03-14 10:40:53.000000000","message":"remove this line pls","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"27ff622b5fbac57f39cbdff7fdef78723a8c9b49","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            mapper \u003d wsgi.APIMapper()"},{"line_number":33,"context_line":"            v1.init(mapper)"},{"line_number":34,"context_line":"        if CONF.enable_v2_registry:"},{"line_number":35,"context_line":"            mapper \u003d mapper or wsgi.APIMapper()"},{"line_number":36,"context_line":"            v2.init(mapper)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        super(API, self).__init__(mapper)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtSI%3D","line":35,"updated":"2014-03-14 10:40:53.000000000","message":"remove this line pls","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"}],"glance/registry/api/v1/__init__.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c652cb21bffca68c09d0f8b55e1e8ba5f8c25e16","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from glance.common import wsgi"},{"line_number":19,"context_line":"from glance.registry.api.v1 import images"},{"line_number":20,"context_line":"from glance.registry.api.v1 import members"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def initV1(mapper):"},{"line_number":23,"context_line":"        images_resource \u003d images.create_resource()"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F%2BQ4%3D","line":21,"updated":"2014-03-12 16:19:55.000000000","message":"extra line I think","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"77c0b13e37dd46c835455b1159aa792281216a76","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from glance.common import wsgi"},{"line_number":19,"context_line":"from glance.registry.api.v1 import images"},{"line_number":20,"context_line":"from glance.registry.api.v1 import members"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def initV1(mapper):"},{"line_number":23,"context_line":"        images_resource \u003d images.create_resource()"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2F94Q%3D","line":21,"in_reply_to":"AAAAWH%2F%2F%2BQ4%3D","updated":"2014-03-12 16:48:37.000000000","message":"Done","commit_id":"807f04c9035a6cfc553b7607e4543a6603695c06"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"419ada8e8815f9487b278ef2dd6f408f11af9889","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, mapper):"},{"line_number":87,"context_line":"        mapper \u003d routes.Mapper()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        initV1(mapper)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2FvSY%3D","line":87,"updated":"2014-03-14 05:24:53.000000000","message":"same question at here.","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"9053a612e98ed3285fd0b99b6dbe48dd03195f54","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, mapper):"},{"line_number":87,"context_line":"        mapper \u003d routes.Mapper()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        initV1(mapper)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Fthg%3D","line":87,"in_reply_to":"AAAAWH%2F%2FvSY%3D","updated":"2014-03-14 09:52:51.000000000","message":"Done","commit_id":"2fcb0a900f47fca9f33cfa9793d6b8d6be885a7f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"27ff622b5fbac57f39cbdff7fdef78723a8c9b49","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, mapper):"},{"line_number":87,"context_line":"        mapper \u003d wsgi.APIapper()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        init(mapper)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtUA%3D","line":87,"updated":"2014-03-14 10:40:53.000000000","message":"mapper \u003d mapper or wsgi.APIMapper()","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"adad9441f71247ce2e030f6d1a76f4623c0b3005","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \"\"\"WSGI entry point for all Registry requests.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __init__(self, mapper):"},{"line_number":87,"context_line":"        mapper \u003d wsgi.APIapper()"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        init(mapper)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2FtLU%3D","line":87,"in_reply_to":"AAAAWH%2F%2FtUA%3D","updated":"2014-03-14 10:54:29.000000000","message":"Done","commit_id":"d54f2765703b1e8b98b9bb614962b1a74925c461"}]}